| Message ID | 8d0663ed-123e-1428-8aef-17d82c1b5f17@suse.com |
|---|---|
| State | Accepted |
| Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp989886vqx;
Thu, 3 Aug 2023 01:15:36 -0700 (PDT)
X-Google-Smtp-Source:
APBJJlE00mXqvgdw/t0/dHnF9ThxiNlUnADbUaYU+lfeOwaRNdXkHXUtrjM5WqEExzzEv9dkgugp
X-Received: by 2002:a05:6512:ad3:b0:4fe:3a57:7c98 with SMTP id
n19-20020a0565120ad300b004fe3a577c98mr7735231lfu.32.1691050535648;
Thu, 03 Aug 2023 01:15:35 -0700 (PDT)
Received: from server2.sourceware.org (server2.sourceware.org.
[2620:52:3:1:0:246e:9693:128c])
by mx.google.com with ESMTPS id
d26-20020aa7d69a000000b005222a0cd29dsi842241edr.339.2023.08.03.01.15.35
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 03 Aug 2023 01:15:35 -0700 (PDT)
Received-SPF: pass (google.com: domain of
gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates
2620:52:3:1:0:246e:9693:128c as permitted sender)
client-ip=2620:52:3:1:0:246e:9693:128c;
Authentication-Results: mx.google.com;
dkim=pass header.i=@gcc.gnu.org header.s=default header.b=lQne0HsM;
arc=fail (signature failed);
spf=pass (google.com: domain of
gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates
2620:52:3:1:0:246e:9693:128c as permitted sender)
smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org
Received: from server2.sourceware.org (localhost [IPv6:::1])
by sourceware.org (Postfix) with ESMTP id 344913857C5A
for <ouuuleilei@gmail.com>; Thu, 3 Aug 2023 08:14:42 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 344913857C5A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
s=default; t=1691050482;
bh=YsZQHjarKFkg4khN/O3RQXMvB+XTPGqlzvJlB2HxaPs=;
h=Date:Subject:To:Cc:References:In-Reply-To:List-Id:
List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:
From:Reply-To:From;
b=lQne0HsMcxAfv0/nJ9AL6hy1PQcRxs/KBZBXr4WiuUl0jORoM8l1Km+9bR24vzAZB
SbY0IDslw6KCXu6De1WjVkM5ox+ymEAxh2V6iIvdlJjmUBWgRLt+677iDW6WURvwnE
+qSPrBC7BO6QjZhXRcrJFhfwykI/AxsBOloDTHQ8=
X-Original-To: gcc-patches@gcc.gnu.org
Delivered-To: gcc-patches@gcc.gnu.org
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
(mail-db3eur04on2055.outbound.protection.outlook.com [40.107.6.55])
by sourceware.org (Postfix) with ESMTPS id EE759385703C
for <gcc-patches@gcc.gnu.org>; Thu, 3 Aug 2023 08:13:47 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE759385703C
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=Fx0smkZFeuQ9+1pmQ6QeOld9Ba7KgJHCRuikRhKYqqKrHgw43ul5tXLJLOinQXCK+NWjFCV6b2FSg/9CMvqM27G1xxulqQB9TZzNGHPxzZMzJxtATtJEqZji4jXxbWC0Xzj1SpOW7QRKYcwqo7xtSpiBZY2K08ceHrEce8UAOfL00W7kBdYFmGC0txUdfuhatmV061i0VEphiZ9Jp4leiekAvi/jCtFr9YO38Bcy+RBOicwon5bZt9o7AMUwpQyiZHxRsF211ioEByVMZ6+quQh+luqeuXdltFOaClk1w6dh6+ZPcYTB7Sw4SfBPyzHn4GxWlfvJZ1EMSS7/tTXMLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=YsZQHjarKFkg4khN/O3RQXMvB+XTPGqlzvJlB2HxaPs=;
b=eqU1G+OS+ytBTc45PyouT/tDuw+DURUTQJ3p9wGTghMs0NMzbgw1Yl3gOSSZTpK56n6uuXWG1v2yyaCsK3fbwPk6/OtvPrBFqTUz0fwN2stBWjxXb/llJoK4KkRUSMKP52GPP7Xu98oEKZclFa9oQu4aAWIwen00qorBiPKDubqw0x+FUBgd1eTm8ILnI69e4voMn3ifX1lIAeXogGLxs8r6sRRECoZWDlmerHEMagHd5T3znlmV59Z7gPWzwSBV2kAzPpgV+Ruhw7iXAZrsVMxKoTnpArw8ZWUDZqseq5ACPCr3ovReQPNk0XhKUJ7VK2aFMfA6+s+pAstn4lwszw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
dkim=pass header.d=suse.com; arc=none
Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23)
by VE1PR04MB7359.eurprd04.prod.outlook.com (2603:10a6:800:1a0::15)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug
2023 08:13:46 +0000
Received: from DU2PR04MB8790.eurprd04.prod.outlook.com
([fe80::e5cf:5743:ab60:b14e]) by DU2PR04MB8790.eurprd04.prod.outlook.com
([fe80::e5cf:5743:ab60:b14e%5]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023
08:13:46 +0000
Message-ID: <8d0663ed-123e-1428-8aef-17d82c1b5f17@suse.com>
Date: Thu, 3 Aug 2023 10:13:44 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
Thunderbird/102.13.1
Subject: [PATCH 09/10] x86: correct "length_immediate" in a few cases
Content-Language: en-US
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Uros Bizjak <ubizjak@gmail.com>, Hongtao Liu <hongtao.liu@intel.com>,
Jan Hubicka <hubicka@ucw.cz>, Kirill Yukhin <kirill.yukhin@gmail.com>
References: <9bef986f-7441-c4a9-5bfd-7bbed0a3d950@suse.com>
In-Reply-To: <9bef986f-7441-c4a9-5bfd-7bbed0a3d950@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0151.DEUP281.PROD.OUTLOOK.COM
(2603:10a6:d10:a2::12) To DU2PR04MB8790.eurprd04.prod.outlook.com
(2603:10a6:10:2e1::23)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VE1PR04MB7359:EE_
X-MS-Office365-Filtering-Correlation-Id: 3fe00833-c83b-4549-4259-08db93f98f21
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
cxxs2A81P8jfVhW6C8zK1UJhnm1WdlbYFsZgp7bIjiLw/6DphhU9fhxnCQlvT2ylyXF6HE2ibwQOGsN74pZbV6sT8guJno9ydyQJMpFvCsYwNu2u322vmQaEZgyuytTgZV5oC+7FOYXbd5MEEXjaM9EeR92gSvOlkgEJdnoKh0kEtjk7jntTQQkRL5BlF/DobZXf2jyzNVoPcu2rhu5ONDACHDB/9RRjngEiFGTQ6LbTgT8Z7MN15qtVSNP0eDAPmAkQz9xNMOnAZracGfT2yt/D3zrAKQl6xKkftONSZL6e/QyO0LpIbCxSh9zwQ2sLXBcun84BMcLlf0zxRLcAo9hT/2LZDQpR71gCGTbYYg0evnz2I/Xx4zeEyxyWovvwogDWZhIJanrVXLZl1P5+Zrl3ULtZBU8lISaJEwIJD0ML2cq3eYPToNTxOlqaPzPUG46HdBhy60vAfKERWaU4zJL7DHXi1ZE1DPS/abahpTGFEFSpFIlPX3P7hmf9Lsqzo5pQ3Fo22nIfUeP6VJxrc4SjnVQP7EZaiWuzfYjxAukGb+yqJOOFAw00bcXVctWg+dtUMV/TnB/vTDFvczrMRl4vMxgryO8HyGi1D5/qCnHG0dXjdcoZFgzYAaJM7FSPUD0tIDl4GCcwAJ/wme8O5TEIIJP9E9qfsBgkU8670fE=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:DU2PR04MB8790.eurprd04.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230028)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199021)(41300700001)(66556008)(316002)(2906002)(4326008)(6916009)(66946007)(66476007)(8936002)(8676002)(5660300002)(38100700002)(26005)(36756003)(186003)(6506007)(86362001)(83380400001)(2616005)(31696002)(6512007)(478600001)(54906003)(6486002)(31686004)(14773001)(43740500002)(45980500001);
DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?FtyiO0iUsSL3Nw1Y5xavNTBWjhzS?=
=?utf-8?q?MGRn9DibtDLj+gmCUJBqwlHOrcaLPnzxNdHxfJhRexC2SSVEcH36XTvRTWTRwJvNc?=
=?utf-8?q?6xq34v1gL2TKWdy+93srwt5lQr6UUT+dgnpccXML+yKnXYOOZi9uHqlLGhc8DktDU?=
=?utf-8?q?5AStAbu7s/Tr+MvtmYszYrPZKnnkvEEquPPQaOV/zg1zZ266P6K5bghGbuoRXyIkq?=
=?utf-8?q?SdKpCWS/MKu/O5C1mkxyZRzN+diZkyyEkGynudl/ygpEHb6Za0oJ48wt6pSod4Owb?=
=?utf-8?q?II+9KhhrqbGZzXyZ9cehsFKC4DJCGoAtOAtkYZJjuBC8X8ev2xN2SuOgNgz5qyFAo?=
=?utf-8?q?5Euv7qIFLB6YmygZ89sy05NvPox5oJ7Qde2Y1jRJnaIFembdli6m+EyjypVDsspbu?=
=?utf-8?q?zYVgN50Y/Z93hU0Jgf+pDcs3xO6QQWkNecJ3AbvVo4X56gvCrDdLFCZAFa5W0oMvU?=
=?utf-8?q?ZPDKDIHxcldxOtrjfJjTi6bM10XRx4ETqot/BSGczUn9mA8mNu+1ZHyq08y/X6D/c?=
=?utf-8?q?sTmr/0Wgu1cSRiDV9NEX+Zrro/Nc7Vtuxyw6XzOWcnjprvZ9Eg22UIK8x1pB8hvr2?=
=?utf-8?q?PXp10rWOr0jR9TOolSZR3uTj5vIlpbxE2cTS5lKtWVnD5FHeRnJh3xul1Og/lHH1m?=
=?utf-8?q?d8rOMkz09lD1TJNpAYzYO+duQNgD5Rku32zY3iwsPYnJgGyR0Frfwy3hAjU+8peVz?=
=?utf-8?q?G05fc0YBGaE/JbLB5zYJRbvh3PhET7o37ZMmRyLqs0SW+vwPaTYThj2KNH91yVjE7?=
=?utf-8?q?ouJ0PiXB7qukJl6Fy6E/pKWDzCp868tFOrgo+PIUrGnPOYhRG38ZLUgHSmdaXSG9C?=
=?utf-8?q?cTCQ/d4+2vaJwe3+tPbI3dp1rIcgT+868vX8avq5OOsanJS5a1v1xSYzzSnYw69Rz?=
=?utf-8?q?44UsL1b8aF9wFVGpk1sXb4OagEvJ4WbFCWEniOROu78ALCYKKwaXLyYFIpChxh/1+?=
=?utf-8?q?P5vfIpNMUb92i7Fl8Kr1zE0V+9jzJpGhuT0In8y+Bh1ipWUE9+n9jeDC8Gdhx6HyD?=
=?utf-8?q?fvIxITIjOIIiFMhPWy2tmWIzWbH2p8K4TfqMS/T9HIyc/dB7/Js4Uf4V2D992R4GJ?=
=?utf-8?q?ND/BE7RklP/BX+nh5+UdN+HGh2idN5xSrdrKIT1vxPXG1eP0ZM9zVTFUTxrw7kYpR?=
=?utf-8?q?RkwiJx/DEgtgec20bK3S0y1xS7T8y4fdbhrArOVzKE7tCqPovbGUR4esSL995NLae?=
=?utf-8?q?PURDemVazKQqMH+sTo5NnWaBGzTOLLQ/SnXzBiO4u3nPY7RpJVNiS7GvjCuQrFMnT?=
=?utf-8?q?3m4kEfZmjWgI8wsCqulEAtxKgEQmmRD8x0k9/GmpzzkeUiDX9u1luAxw55HsIfLid?=
=?utf-8?q?1HUXPg7R6nmB3jsrTcSR1PtE2QxMsMefmlyBQZ2OUS+lXkJ7mJkPvifgTDxiznQFA?=
=?utf-8?q?wQeoLBhi7OVnr4ajxvCmzFII+HWNRfS8+nraf7us3u8Ok9wPLgtw0Ud+Nw0s0QAyM?=
=?utf-8?q?zkyAHkl3Biuza22L9A0CIkTq5pwp/Ae3jhMvnE+Eu17oYFEDt5KkE9967mTX+TiUA?=
=?utf-8?q?PQ6A9k5jp2z5?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id:
3fe00833-c83b-4549-4259-08db93f98f21
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 08:13:46.1872 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName:
h2eXVvN3C9PMYY7D89y6GdxEqdb/RNwOiPvHl/foprnpQ1tr/wqt0z+RuCPQdSycRGEYYEcyf3DnN9TvteTBAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7359
X-Spam-Status: No, score=-3027.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE,
RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP,
T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
<mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
<mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
From: Jan Beulich via Gcc-patches <gcc-patches@gcc.gnu.org>
Reply-To: Jan Beulich <jbeulich@suse.com>
Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org
Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org>
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1773195006764070020
X-GMAIL-MSGID: 1773195006764070020
|
| Series |
x86: (mainly) "prefix_extra" adjustments
|
|
Checks
| Context | Check | Description |
|---|---|---|
| snail/gcc-patch-check | success | Github commit url |
Commit Message
Jan Beulich
Aug. 3, 2023, 8:13 a.m. UTC
When first added explicitly in 3ddffba914b2 ("i386.md
(sse4_1_round<mode>2): Add avx512f alternative"), "*" should not have
been used for the pre-existing alternative. The attribute was plain
missing. Subsequent changes adding more alternatives then generously
extended the bogus pattern.
Apparently something similar happened to the two mmx_pblendvb_* insns.
gcc/
* config/i386/i386.md (sse4_1_round<mode>2): Make
"length_immediate" uniformly 1.
* config/i386/mmx.md (mmx_pblendvb_v8qi): Likewise.
(mmx_pblendvb_<mode>): Likewise.
Comments
On Thu, Aug 3, 2023 at 4:14 PM Jan Beulich via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > When first added explicitly in 3ddffba914b2 ("i386.md > (sse4_1_round<mode>2): Add avx512f alternative"), "*" should not have > been used for the pre-existing alternative. The attribute was plain > missing. Subsequent changes adding more alternatives then generously > extended the bogus pattern. > > Apparently something similar happened to the two mmx_pblendvb_* insns. Ok. > > gcc/ > > * config/i386/i386.md (sse4_1_round<mode>2): Make > "length_immediate" uniformly 1. > * config/i386/mmx.md (mmx_pblendvb_v8qi): Likewise. > (mmx_pblendvb_<mode>): Likewise. > > --- a/gcc/config/i386/i386.md > +++ b/gcc/config/i386/i386.md > @@ -21594,7 +21594,7 @@ > vrndscale<ssemodesuffix>\t{%2, %1, %d0|%d0, %1, %2}" > [(set_attr "type" "ssecvt") > (set_attr "prefix_extra" "1,1,1,*,*") > - (set_attr "length_immediate" "*,*,*,1,1") > + (set_attr "length_immediate" "1") > (set_attr "prefix" "maybe_vex,maybe_vex,maybe_vex,evex,evex") > (set_attr "isa" "noavx512f,noavx512f,noavx512f,avx512f,avx512f") > (set_attr "avx_partial_xmm_update" "false,false,true,false,true") > --- a/gcc/config/i386/mmx.md > +++ b/gcc/config/i386/mmx.md > @@ -3094,7 +3094,7 @@ > [(set_attr "isa" "noavx,noavx,avx") > (set_attr "type" "ssemov") > (set_attr "prefix_extra" "1") > - (set_attr "length_immediate" "*,*,1") > + (set_attr "length_immediate" "1") > (set_attr "prefix" "orig,orig,vex") > (set_attr "btver2_decode" "vector") > (set_attr "mode" "TI")]) > @@ -3114,7 +3114,7 @@ > [(set_attr "isa" "noavx,noavx,avx") > (set_attr "type" "ssemov") > (set_attr "prefix_extra" "1") > - (set_attr "length_immediate" "*,*,1") > + (set_attr "length_immediate" "1") > (set_attr "prefix" "orig,orig,vex") > (set_attr "btver2_decode" "vector") > (set_attr "mode" "TI")]) >
--- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -21594,7 +21594,7 @@ vrndscale<ssemodesuffix>\t{%2, %1, %d0|%d0, %1, %2}" [(set_attr "type" "ssecvt") (set_attr "prefix_extra" "1,1,1,*,*") - (set_attr "length_immediate" "*,*,*,1,1") + (set_attr "length_immediate" "1") (set_attr "prefix" "maybe_vex,maybe_vex,maybe_vex,evex,evex") (set_attr "isa" "noavx512f,noavx512f,noavx512f,avx512f,avx512f") (set_attr "avx_partial_xmm_update" "false,false,true,false,true") --- a/gcc/config/i386/mmx.md +++ b/gcc/config/i386/mmx.md @@ -3094,7 +3094,7 @@ [(set_attr "isa" "noavx,noavx,avx") (set_attr "type" "ssemov") (set_attr "prefix_extra" "1") - (set_attr "length_immediate" "*,*,1") + (set_attr "length_immediate" "1") (set_attr "prefix" "orig,orig,vex") (set_attr "btver2_decode" "vector") (set_attr "mode" "TI")]) @@ -3114,7 +3114,7 @@ [(set_attr "isa" "noavx,noavx,avx") (set_attr "type" "ssemov") (set_attr "prefix_extra" "1") - (set_attr "length_immediate" "*,*,1") + (set_attr "length_immediate" "1") (set_attr "prefix" "orig,orig,vex") (set_attr "btver2_decode" "vector") (set_attr "mode" "TI")])