Message ID | 20221102141014.1025893-5-Frank.Li@nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp3646729wru; Wed, 2 Nov 2022 07:16:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5frPIo9aU/qNw3lcLpbz9WegRWSvw8bAuHIVtjHeAwdJEthgIPHOCbykICbeo3B46b+Hcc X-Received: by 2002:a63:1f53:0:b0:46f:ea8b:d746 with SMTP id q19-20020a631f53000000b0046fea8bd746mr8375713pgm.144.1667398618884; Wed, 02 Nov 2022 07:16:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1667398618; cv=pass; d=google.com; s=arc-20160816; b=KSvpoYdhwt3B5nsEN9kqeZxO240qX0BRmLHEcb/1kabAIkwclvXfWIza3TPm7u2JsP UDgTI1uDEXb4VQ3KVYNjIU+RoD+EovlIR8Pgm6nIYfPTtN8RrnL90M6KdvIkZ8/HFfxY lIT8yacMMBW8aphT+QDlalykOE8Etiv1Z3TAh9WUlwFTnbta1HmCUL01JIZU7vDuPAJp vH+hrinLnKVy018bilHhxRscrsKND+Kz4GUAjxcH1VnHOdWVjAleEce5Tix70GUMjexr wgnixmux2bUzWF8s8wxHz3STNbl+Taf9edudBPfKwFxUZfKz63bVJGIPPuVzYTrTYDGS 7IbQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Cg9Cz+TfGC5o2RUupkOOm59g23D635oht16Vk34QK4Y=; b=g6mZ65M1hkiPIQVpOn5NOQRt83KJWaLZ2tuXIiWEY2BrmwBgOslLPYeO8syYurfnrK rzbTY1TQ8VxEY5/comW2N4l01oqUTTDHDVcUpU0DjIeRbazsVlz46BAqyIbdyB/ySakW ++cYNmqr/GEvPEffiK2WjgdYL22ABrzMweNkJEyMotqyBsejLEt5479NJfgAh0RSFuzN HCrAJ2G5uRJQlU425XYDDOn1Gni9d1zV0UVcsJ6S1zODYEf+HElyS1sTZ0Fe6vqMZK9S SbOngiZE7jwH3Lm6Y3XdVHd1g+hPa1HP1U4TLODJdq/c/c/RvQaue3D6HRgInMajdynm LWGw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=UBlBrbtz; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w10-20020a63160a000000b00439c1e186c8si9770109pgl.281.2022.11.02.07.16.44; Wed, 02 Nov 2022 07:16:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=UBlBrbtz; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231185AbiKBOLI (ORCPT <rfc822;yves.mi.zy@gmail.com> + 99 others); Wed, 2 Nov 2022 10:11:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231411AbiKBOLC (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 2 Nov 2022 10:11:02 -0400 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2085.outbound.protection.outlook.com [40.107.21.85]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA0372612C; Wed, 2 Nov 2022 07:10:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mGnNcw/Xi/BGXG7PCoYve9h9/T6lpA2bqcyBfqh8lpyhg+OxJ8VBnuygHXbVXbolEMZVZN3xfVbr8/HK0Qs7QRZZv4hoYbEVGfE4/aETFQ4pPm7rT3Du79sXyGEysG0PQJIL2uL5FJRWyON77HX4TQJj7A/qAumPQr0DD0zCZqFt98r9y3EBQ3BVXpyvE5pZ+qwiftH988HNJq704cQKoh0A0KuYbpYmS9dRQfPTT4aTfYP16bTlPWOXIy91i/gUqWuqcQgpeRxiozLLOquvBAvj7BPTGSMcoSVzVnFTroahi+LX/MoGj0ved8ICaUFDyZM2n1hUAkoLIgzigXNpWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cg9Cz+TfGC5o2RUupkOOm59g23D635oht16Vk34QK4Y=; b=eGorMdLoWbHZYIH3wYHxts/LUtkIyNG+pSj10WndJRn1O2z3FyCGFx9hxBsJTC5vdX9MNfj6/9iIhfsk83pDfLiXLnWY2XzTUxrdWWmCLL8P/ZMp14mTyznBMIFw92vWr+IfVVdf3/7TlLf9ts9be+redyoFezWYucM1GP/WSy6U1wDHWTlukrLhbj9xIOrRvtxK32FhDPwn+cE8uvrYWiFFNWFI15OICphcTatvKs4ACfLLgjvaAYTbUccMrRC4VGg/p+cEhXmJY4Gu/DQmF558XkXhi/UY8sftmOFFSMSfNgGGZdwXyufbb6UU9/gdGuoJYDJQkXAWZ7rYzvTdBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cg9Cz+TfGC5o2RUupkOOm59g23D635oht16Vk34QK4Y=; b=UBlBrbtzMnTviAhWLZO3l7L5otv9NIeXWowO51Aze7CgWYu5TVKoCMWrjwlg19mvBR3Dmy9kU7czseNThvBSgvuTPR0S9Nqq+tE/vtLFfon5NGY1ylm0ZyDkc04uOqAsynnZsYihInm9mdfyvpFid7qgpOsrt8+xa06HpwDMGMo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) by DB9PR04MB8234.eurprd04.prod.outlook.com (2603:10a6:10:25d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 14:10:48 +0000 Received: from HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28]) by HE1PR0401MB2331.eurprd04.prod.outlook.com ([fe80::44bb:8387:8f4b:6a28%11]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 14:10:48 +0000 From: Frank Li <Frank.Li@nxp.com> To: mani@kernel.org Cc: Frank.Li@nxp.com, allenbh@gmail.com, bhelgaas@google.com, dave.jiang@intel.com, helgaas@kernel.org, imx@lists.linux.dev, jdmason@kudzu.us, kw@linux.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, ntb@lists.linux.dev Subject: [PATCH v16 4/7] PCI: endpoint: pci-epf-vntb: remove unused field epf_db_phy Date: Wed, 2 Nov 2022 10:10:11 -0400 Message-Id: <20221102141014.1025893-5-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221102141014.1025893-1-Frank.Li@nxp.com> References: <20221102141014.1025893-1-Frank.Li@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SJ0PR05CA0210.namprd05.prod.outlook.com (2603:10b6:a03:330::35) To HE1PR0401MB2331.eurprd04.prod.outlook.com (2603:10a6:3:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR0401MB2331:EE_|DB9PR04MB8234:EE_ X-MS-Office365-Filtering-Correlation-Id: 3abff87d-dcbc-4cfd-229b-08dabcdc0aa8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4uZDE39GaWqLBAxxC1H944ryTkzA7gmnd7YuNExTOMPrxaYZQYJztiXgan2GVyPRoD+ngZuILsnq/ZSvOf6U/EvErdv/gj1FoQAD72rPS7ZG+yqpzgn3OscbJYqRLbh2+UvYfxSnjnGlnF1jOahoZxH5OC0VRFB4u2mDVv7ibGP38C5DQVDl04ySGN8blxqx/HTTSjLFXjo4gQAkDfEWZuBnLms0QUT0TRp1uF2X64YIYUMoqqkoc42+IioaYWrRsWI9cVeiNmOIDSdLJ2Kk8/9kGqvNiJEyb/dl06xpZf07Q58r8Df41xL4p7WO/0Y8aaZmQqCcs9wLL8wp1+s9aakFxbDOm9BzCgak8+HW16jQeM9BoQQWX3C8UEeUzxAPSAyGlcZCgAJENgqgZLGmIP29KUTcLEVMFPlNw4+WWyEQJJVKyJYNrlw+Py5xy9zWdzm5hOQKllNwc9ObpeeoOYx5cn7ifHACbA7AbcXIjf1LxjYwB8lfD8WFzGxOj/9XiKXdkAP8d3OKu0Mfry/fH/2pycOp+d8Lp5JthfrZNKZhZA/lO870gZU5bm0odANDDNS+Bn4120xJJBub1qk57aMGYhx0NkZuJVAEb2PFw9L4nMbCWhOrrtu+bYy7x4o6DP9946e57F7dROIPE8FY9PI1HhfGG3eRh2GWCTqwkE/NCw/EhUoPA0uMZxtq1PAFcm7/VZ2Q959V7WwP5NTanqBcjW6DAkQvnLcYLdYFbGT18NEUPbKY6xGkA4nyEgXfbq8NNanyVYBgEx1Wf/3cxw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(396003)(376002)(366004)(451199015)(36756003)(6916009)(6486002)(5660300002)(7416002)(83380400001)(478600001)(2906002)(41300700001)(66556008)(316002)(8676002)(66476007)(4326008)(66946007)(8936002)(26005)(6512007)(186003)(4744005)(38100700002)(2616005)(1076003)(38350700002)(86362001)(6666004)(52116002)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 00zaARr5x/zZ9PNCdvJ+vVJA9xQEuEGqQ50EHeE2KXxTE+hYM4oRknO84j59D9k7uaA9zJxCQU8ayZb681ycUcZdV0qNmYQtnWoYB97cy/dyU2zyfwZAJzwLQ3yr+bakUcCvq+QkvbFn1mRGaQZvt4UcN/Bci5TTVABPyxcxaUQNmL2UNQZnZSpsy4w38xVz1v9mUopCrQ6+hA6ZAbnKjmj8t5diDK3oCRXuw8JsEKwXXsmjsxGi+ZqDVecXJoqyPgAnDZqSfQ/gr8bcyAhYZFk47a/fUB1kWiXNq3nGNjPn8+2EgaKwuUG4FwGRzV8Gw3P/tpJNy1clEBm6Gf0TC3EPw3xL6ciAx+CZKG7BOptrHGqrTr5HVRFCe83k3WN/9Ec5QyncQ00qSA4hnFKAdwnQQS8Yg7mmIqVZ9U0gnpGkYTJ9PAKIdkQ8T08trqoZzmC14tRCL/dw5f5MV4seI8Efl9uOrOYujbS4sHaQ/R2Eb3Vu1lxez676SkCrDRyoiyMRKppQ2N2y15q6XlG+x4ZaOawAlPtz70ykGotiJvpu5eNDj6B2rResTpFLyTcHwwgkcP20IkuPgQUY8WYskq3rcY4il1ZeIwLRuyaHgSwpOSYBunhiLHc7+avtWyLx2yAa89JxtuCPu9wiCF56i1s3cWX1SD4TwdE5taTMdHAOKve8VTDlz1BGQkemC0DyWQYW8k9TLqW4R52W6Zm9OKEunVTrGDMD6NSuxkaniQwn6w+1RS+LI/jKdUOXsVFiTiG9cVqxyTFs50TJbBTlW5bj9WSQE+5VzZEnqEXtm6UyyfdIemXphE4ivv4+q2TzsdYlcCHUGcwf3b85SjCFrUkWX1VvixU3XwvKmNWVFDR8mslBxaBoMjSJf2LfvLn2DPecEJBd5IJ2qnbO3d4GLr3bVHFrzjbQu7IaCiUWCH4wCs9HlmI/OGlW33Mex+6DCiktWkxjEBcBJRCrAqH5gl/Kg/RbJfBHVZo8tLEX0EhaFWdTXGucOxxPJHaY/U756UuiALprGCE/V1K/kj4czqVdlSpH2TsEQaWeflWIy8y44mQKq2/1PL4hpuEiuzMMWtuH1Ebeoog9CumF9YdEnY7zgAuWU1dzDhOErhO+xneDFkrr1SE/3p2gRCCLAVr1b6Dfe5+aYvTNLjMsBZioWb/mWCM2HS29DidEbgTgLmFSaqL7chCusfZ3D7MfVwi/PXO+GboI5QgdQFZxFsfHI+PCu/FC8kZrD/KaA+tMpvuOe6+6Gz9Vfuo9cRlaybxtUz8yWZUTL48fWfAHvPXiVfgVOFlNP+0ba4T9olgoJMGz+kbKnex1gx6oeqvZmznAm5+EmJi5Gf/d06l5K7DCcfglb9W+TInqRLsB1muN45uHbw4Yi/ZxMP92V80G4NgWMoAwpDt818y2w4Nrq73u0FjOgrithFh3KQBTRMjQw3HqKUPZJLgnwH3Y0BeUn70L11PkaNXPmmTxww+NujQFJc1WVp+9s6U7Oq1gE1O2wLx012Baw6ngD28JIZ0ww9fIzqZcegRIasBh+zEzDb114T2Hsnfcz7cUX+mYMFtPA7ink6UuEjcodlhL+NuzRwPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3abff87d-dcbc-4cfd-229b-08dabcdc0aa8 X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 14:10:48.7089 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aLEAFoOtM3s3X1IjQMXTIIoD5qGbZ5xjw0ZdoGkh2fMsVBY+ze9AdSUjFnvJJP9mX59AFx0WjxX0OSHT1ZQsBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8234 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748394173952399716?= X-GMAIL-MSGID: =?utf-8?q?1748394173952399716?= |
Series |
pci-epf-vntb clean up
|
|
Commit Message
Frank Li
Nov. 2, 2022, 2:10 p.m. UTC
From: Frank Li <frank.li@nxp.com> epf_db_phy is not used, so remove it Signed-off-by: Frank Li <frank.li@nxp.com> Acked-by: Manivannan Sadhasivam <mani@kernel.org> --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 1 - 1 file changed, 1 deletion(-)
Comments
On Wed, Nov 02, 2022 at 10:10:11AM -0400, Frank Li wrote: > From: Frank Li <frank.li@nxp.com> > > epf_db_phy is not used, so remove it Sentences end with a period (.). I can fix these things but we can't spend our lives telling you how to write a commit log, check how they are written in the PCI subsystem and follow the pattern. https://lore.kernel.org/all/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com > > Signed-off-by: Frank Li <frank.li@nxp.com> > Acked-by: Manivannan Sadhasivam <mani@kernel.org> > --- > drivers/pci/endpoint/functions/pci-epf-vntb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c > index 191924a83454..ee66101cb5c4 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c > @@ -136,7 +136,6 @@ struct epf_ntb { > > struct epf_ntb_ctrl *reg; > > - phys_addr_t epf_db_phy; > void __iomem *epf_db; > > phys_addr_t vpci_mw_phy[MAX_MW]; > -- > 2.34.1 >
> -----Original Message----- > From: Lorenzo Pieralisi <lpieralisi@kernel.org> > Sent: Thursday, November 10, 2022 9:29 AM > To: Frank Li <frank.li@nxp.com> > Cc: mani@kernel.org; allenbh@gmail.com; bhelgaas@google.com; > dave.jiang@intel.com; helgaas@kernel.org; imx@lists.linux.dev; > jdmason@kudzu.us; kw@linux.com; linux-kernel@vger.kernel.org; linux- > pci@vger.kernel.org; ntb@lists.linux.dev > Subject: [EXT] Re: [PATCH v16 4/7] PCI: endpoint: pci-epf-vntb: remove > unused field epf_db_phy > > Caution: EXT Email > > On Wed, Nov 02, 2022 at 10:10:11AM -0400, Frank Li wrote: > > From: Frank Li <frank.li@nxp.com> > > > > epf_db_phy is not used, so remove it > > Sentences end with a period (.). I can fix these things but > we can't spend our lives telling you how to write a commit log, > check how they are written in the PCI subsystem and follow the > pattern. [Frank Li] Do you need me send new version to fix "."? Or you will plan queue these patches? My means: Mani's below feedback will make both live easy. > > None use epf_db_phy and remove it. "epf_db_phy is not used, so remove it" > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.k > ernel.org%2Fall%2F20171026223701.GA25649%40bhelgaas- > glaptop.roam.corp.google.com&data=05%7C01%7CFrank.Li%40nxp.co > m%7Ca0924bed538a494cbfd508dac3304e8e%7C686ea1d3bc2b4c6fa92cd99c > 5c301635%7C0%7C0%7C638036909484154968%7CUnknown%7CTWFpbGZsb > 3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > %3D%7C3000%7C%7C%7C&sdata=B3G7sfaSVdLDC8BG95WzpBPFO5lPJ > QpThKDcEexOHfU%3D&reserved=0 [Frank Li] Thank you for your documents. > > > > > Signed-off-by: Frank Li <frank.li@nxp.com> > > Acked-by: Manivannan Sadhasivam <mani@kernel.org> > > --- > > drivers/pci/endpoint/functions/pci-epf-vntb.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c > b/drivers/pci/endpoint/functions/pci-epf-vntb.c > > index 191924a83454..ee66101cb5c4 100644 > > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c > > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c > > @@ -136,7 +136,6 @@ struct epf_ntb { > > > > struct epf_ntb_ctrl *reg; > > > > - phys_addr_t epf_db_phy; > > void __iomem *epf_db; > > > > phys_addr_t vpci_mw_phy[MAX_MW]; > > -- > > 2.34.1 > >
On Fri, Nov 11, 2022 at 02:39:12AM +0000, Frank Li wrote: > > -----Original Message----- > > From: Lorenzo Pieralisi <lpieralisi@kernel.org> > > Sent: Thursday, November 10, 2022 9:29 AM > > To: Frank Li <frank.li@nxp.com> > > Cc: mani@kernel.org; allenbh@gmail.com; bhelgaas@google.com; > > dave.jiang@intel.com; helgaas@kernel.org; imx@lists.linux.dev; > > jdmason@kudzu.us; kw@linux.com; linux-kernel@vger.kernel.org; linux- > > pci@vger.kernel.org; ntb@lists.linux.dev > > Subject: [EXT] Re: [PATCH v16 4/7] PCI: endpoint: pci-epf-vntb: remove > > unused field epf_db_phy > > > > Caution: EXT Email > > > > On Wed, Nov 02, 2022 at 10:10:11AM -0400, Frank Li wrote: > > > From: Frank Li <frank.li@nxp.com> > > > > > > epf_db_phy is not used, so remove it > > > > Sentences end with a period (.). I can fix these things but > > we can't spend our lives telling you how to write a commit log, > > check how they are written in the PCI subsystem and follow the > > pattern. > > [Frank Li] Do you need me send new version to fix "."? Or you will plan You don't have to write your name in brackets all the time in replies, it is clear from the indentation what I am replying to and to whom. > queue these patches? I will queue them but next time I won't fix the commit log myself. > My means: > Mani's below feedback will make both live easy. What feedback ? I am sorry I don't understand. Thank you, Lorenzo > > > > None use epf_db_phy and remove it. > > "epf_db_phy is not used, so remove it" > > > > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.k > > ernel.org%2Fall%2F20171026223701.GA25649%40bhelgaas- > > glaptop.roam.corp.google.com&data=05%7C01%7CFrank.Li%40nxp.co > > m%7Ca0924bed538a494cbfd508dac3304e8e%7C686ea1d3bc2b4c6fa92cd99c > > 5c301635%7C0%7C0%7C638036909484154968%7CUnknown%7CTWFpbGZsb > > 3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > > %3D%7C3000%7C%7C%7C&sdata=B3G7sfaSVdLDC8BG95WzpBPFO5lPJ > > QpThKDcEexOHfU%3D&reserved=0 > > [Frank Li] Thank you for your documents. > > > > > > > > > Signed-off-by: Frank Li <frank.li@nxp.com> > > > Acked-by: Manivannan Sadhasivam <mani@kernel.org> > > > --- > > > drivers/pci/endpoint/functions/pci-epf-vntb.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c > > b/drivers/pci/endpoint/functions/pci-epf-vntb.c > > > index 191924a83454..ee66101cb5c4 100644 > > > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c > > > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c > > > @@ -136,7 +136,6 @@ struct epf_ntb { > > > > > > struct epf_ntb_ctrl *reg; > > > > > > - phys_addr_t epf_db_phy; > > > void __iomem *epf_db; > > > > > > phys_addr_t vpci_mw_phy[MAX_MW]; > > > -- > > > 2.34.1 > > >
> -----Original Message----- > From: Lorenzo Pieralisi <lpieralisi@kernel.org> > Sent: Friday, November 11, 2022 4:56 AM > To: Frank Li <frank.li@nxp.com> > Cc: mani@kernel.org; allenbh@gmail.com; bhelgaas@google.com; > dave.jiang@intel.com; helgaas@kernel.org; imx@lists.linux.dev; > jdmason@kudzu.us; kw@linux.com; linux-kernel@vger.kernel.org; linux- > pci@vger.kernel.org; ntb@lists.linux.dev > Subject: Re: [EXT] Re: [PATCH v16 4/7] PCI: endpoint: pci-epf-vntb: remove > unused field epf_db_phy > > Caution: EXT Email > > On Fri, Nov 11, 2022 at 02:39:12AM +0000, Frank Li wrote: > > > -----Original Message----- > > > From: Lorenzo Pieralisi <lpieralisi@kernel.org> > > > Sent: Thursday, November 10, 2022 9:29 AM > > > To: Frank Li <frank.li@nxp.com> > > > Cc: mani@kernel.org; allenbh@gmail.com; bhelgaas@google.com; > > > dave.jiang@intel.com; helgaas@kernel.org; imx@lists.linux.dev; > > > jdmason@kudzu.us; kw@linux.com; linux-kernel@vger.kernel.org; linux- > > > pci@vger.kernel.org; ntb@lists.linux.dev > > > Subject: [EXT] Re: [PATCH v16 4/7] PCI: endpoint: pci-epf-vntb: remove > > > unused field epf_db_phy > > > > > > Caution: EXT Email > > > > > > On Wed, Nov 02, 2022 at 10:10:11AM -0400, Frank Li wrote: > > > > From: Frank Li <frank.li@nxp.com> > > > > > > > > epf_db_phy is not used, so remove it > > > > > > Sentences end with a period (.). I can fix these things but > > > we can't spend our lives telling you how to write a commit log, > > > check how they are written in the PCI subsystem and follow the > > > pattern. > > > > [Frank Li] Do you need me send new version to fix "."? Or you will plan > > You don't have to write your name in brackets all the time in replies, > it is clear from the indentation what I am replying to and to whom. > > > queue these patches? > > I will queue them but next time I won't fix the commit log myself. Do you have chance to queue it? I still have one patch (enable MSI) depend on these patch series. > > > My means: > > Mani's below feedback will make both live easy. > > What feedback ? I am sorry I don't understand. > > Thank you, > Lorenzo > > > > > > > None use epf_db_phy and remove it. > > > > "epf_db_phy is not used, so remove it" > > > > > > > > > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.k > %2F&data=05%7C01%7Cfrank.li%40nxp.com%7C200a354ecae54e7b1af > 408dac3d34892%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638 > 037609466107831%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi > LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&a > mp;sdata=3ngvYAIP0oTTF1uwAAHFAFmBVi1FvKtgTTw1u3tDXUg%3D&re > served=0 > > > ernel.org%2Fall%2F20171026223701.GA25649%40bhelgaas- > > > > glaptop.roam.corp.google.com&data=05%7C01%7CFrank.Li%40nxp.co > > > > m%7Ca0924bed538a494cbfd508dac3304e8e%7C686ea1d3bc2b4c6fa92cd99c > > > > 5c301635%7C0%7C0%7C638036909484154968%7CUnknown%7CTWFpbGZsb > > > > 3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > > > %3D%7C3000%7C%7C%7C&sdata=B3G7sfaSVdLDC8BG95WzpBPFO5l > PJ > > > QpThKDcEexOHfU%3D&reserved=0 > > > > [Frank Li] Thank you for your documents. > > > > > > > > > > > > > Signed-off-by: Frank Li <frank.li@nxp.com> > > > > Acked-by: Manivannan Sadhasivam <mani@kernel.org> > > > > --- > > > > drivers/pci/endpoint/functions/pci-epf-vntb.c | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c > > > b/drivers/pci/endpoint/functions/pci-epf-vntb.c > > > > index 191924a83454..ee66101cb5c4 100644 > > > > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c > > > > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c > > > > @@ -136,7 +136,6 @@ struct epf_ntb { > > > > > > > > struct epf_ntb_ctrl *reg; > > > > > > > > - phys_addr_t epf_db_phy; > > > > void __iomem *epf_db; > > > > > > > > phys_addr_t vpci_mw_phy[MAX_MW]; > > > > -- > > > > 2.34.1 > > > >
diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c index 191924a83454..ee66101cb5c4 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -136,7 +136,6 @@ struct epf_ntb { struct epf_ntb_ctrl *reg; - phys_addr_t epf_db_phy; void __iomem *epf_db; phys_addr_t vpci_mw_phy[MAX_MW];