Message ID | 20221109163426.76164-12-nbd@nbd.name |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp450435wru; Wed, 9 Nov 2022 09:02:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf4fa5JwFOYF47vm859tXXP7/A06MaGoN93Xp0Fh6FbXUM52JMUYUKxqKDu0JFoyoXBINI1g X-Received: by 2002:a63:c118:0:b0:470:84b1:6f12 with SMTP id w24-20020a63c118000000b0047084b16f12mr10231187pgf.241.1668013363122; Wed, 09 Nov 2022 09:02:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668013363; cv=none; d=google.com; s=arc-20160816; b=MWciPfCAZDqF1DqIaNP3Y+Uk/JmCVRoTY7P4Bm1Uc2do3+xVCea6hUlU7JXm8Uoweo OH6A5bF00ObKv8FWNSehe+Ck2EE99f6CG/32Z0D0qHU9c60LPEewtvM4KwxjFwlEvzeg IeLs1xaUK/zNxOUSFvs2cmobolnr/K61xtvSRfKQqg2t6TdK2lKJ3DFWMtvxyUyHIZzS rQcqgFfLJ4bYxC8ZMMtrNybYdeE/PQVY9P3Tp30JO7OwrujQls23GOtIj8OF1rbuSe0t 5KIfCz2OJOvlKngVJBSSom8H+mblsSLApstcLBRzkdd0N3FGtU2yCLd2QQyvTrF7pf+a snlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=810KJYvQua3Tgj0eTQnOjCyIwfPHWRslPBRk0KhS8r0=; b=ER4C8tWLSs4pbnlcMK7gEiyJi7EdSQSCXmlL/H0jr1FLr5TFQvhMInxJ2MtYC1mVg1 N5Dt88IGAwl1GnVSaThIOv/XtteTa2xDY4StH/DzharlVYOXT4Q9taD5VzwhyxCgaGaK 4Z36DI2lPnzgRnHoQTkjOvuROms9+PFCQZo5OqJPMU1KPMqNxwqWOKPnVuQkmiwyJ9pI UEx0mADukrTf8GvNW0NreGxCxJftuk6hrZQrb/PE/pjnF61gSTBGzT5B/+/g7ENqxEMy UNu4jJthWQizxEPXMK1ZBwtPpR6ZTKZvN/RdAsqX1f6GtKq9jg/aEQAPvddTVQmFRcJQ 6kZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=NfgRes3F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nbd.name Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q20-20020aa78434000000b0052b75c32fd2si16244514pfn.48.2022.11.09.09.02.28; Wed, 09 Nov 2022 09:02:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=NfgRes3F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nbd.name Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231630AbiKIRBT (ORCPT <rfc822;dexuan.linux@gmail.com> + 99 others); Wed, 9 Nov 2022 12:01:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231343AbiKIRAm (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 9 Nov 2022 12:00:42 -0500 Received: from nbd.name (nbd.name [46.4.11.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D658DF35; Wed, 9 Nov 2022 08:57:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=810KJYvQua3Tgj0eTQnOjCyIwfPHWRslPBRk0KhS8r0=; b=NfgRes3FlgLZOAi5KPhr9WSYdb rrBOtRbDLSQNvOvLOh6GDIC6Y8+5WVCLr8KEzM46i2phVihE73iMK3m3knPfug2NL4xmYMdgRQjGY KslSg1b2y1q1dfWQMjh40HhMGbWbK3pRT4Da2eR4NAaPIDW4Yu/BGunFKikhGOOJHcGg=; Received: from p200300daa72ee100054f3c61b16ef6e7.dip0.t-ipconnect.de ([2003:da:a72e:e100:54f:3c61:b16e:f6e7] helo=localhost.localdomain) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (Exim 4.94.2) (envelope-from <nbd@nbd.name>) id 1oso2B-000l4N-M4; Wed, 09 Nov 2022 17:34:39 +0100 From: Felix Fietkau <nbd@nbd.name> To: netdev@vger.kernel.org, John Crispin <john@phrozen.org>, Sean Wang <sean.wang@mediatek.com>, Mark Lee <Mark-MC.Lee@mediatek.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Matthias Brugger <matthias.bgg@gmail.com> Cc: Vladimir Oltean <olteanv@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 11/12] net: ethernet: mtk_eth_soc: set NETIF_F_ALL_TSO Date: Wed, 9 Nov 2022 17:34:25 +0100 Message-Id: <20221109163426.76164-12-nbd@nbd.name> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221109163426.76164-1-nbd@nbd.name> References: <20221109163426.76164-1-nbd@nbd.name> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749038779922333835?= X-GMAIL-MSGID: =?utf-8?q?1749038779922333835?= |
Series |
[net-next,v2,01/12] net: ethernet: mtk_eth_soc: account for vlan in rx header length
|
|
Commit Message
Felix Fietkau
Nov. 9, 2022, 4:34 p.m. UTC
Significantly improves performance by avoiding unnecessary segmentation
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
On Wed, 9 Nov 2022 17:34:25 +0100 Felix Fietkau wrote:
> Significantly improves performance by avoiding unnecessary segmentation
NETIF_F_TSO_ECN is the bit that matters here, right?
It'd be reassuring if the commit message mentioned it and confirmed
it works correctly :S
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h index 1c85fbad5bc1..60da6936559a 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.h +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.h @@ -49,8 +49,7 @@ NETIF_F_RXCSUM | \ NETIF_F_HW_VLAN_CTAG_TX | \ NETIF_F_HW_VLAN_CTAG_RX | \ - NETIF_F_SG | NETIF_F_TSO | \ - NETIF_F_TSO6 | \ + NETIF_F_SG | NETIF_F_ALL_TSO | \ NETIF_F_IPV6_CSUM |\ NETIF_F_HW_TC) #define MTK_HW_FEATURES_MT7628 (NETIF_F_SG | NETIF_F_RXCSUM)