Message ID | 20230726174226.2480552-1-ruanjinjie@huawei.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp316033vqo; Wed, 26 Jul 2023 03:58:08 -0700 (PDT) X-Google-Smtp-Source: APBJJlETaNeJRjRPAeP6Fb5W01djywwTvqo4pr+Fkm0APeQr06Ig+mXCfjH+6MfNyFJ7Zc/xVBTF X-Received: by 2002:a17:902:d2cf:b0:1b8:a54c:61a5 with SMTP id n15-20020a170902d2cf00b001b8a54c61a5mr1688176plc.37.1690369088044; Wed, 26 Jul 2023 03:58:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690369088; cv=none; d=google.com; s=arc-20160816; b=L+/xlVx23MM2tHRKHAO5IAJWGySRUB7t0u9dV5VYUyLpp+/Wk0VKR2j4D7iBWxm/1z r8fiSsKEYQ2ilKSsmN7+W1OhBEJwBx/MkOqW5QV/cVWTUoF5o5rSHZEvG4hr79MFBmK8 r7rHFvqFBXLmVWsleMBB2zp2BPrK1zgI1c3Vvy4HsrWNwF7Qx7CCEsN5hbj3cxS+nsEi SONKFM291nEXgTXDRFznGqta4UW9/78NSHvMjOv8aQL+TgNj/Sq7FFktejUNlmoquR3z RrkIEFqtPi/pQiuBKqPiZIRBt5PYyr0o3UAknD4YUvRR1NHCIG+htf5zLX9uvor1zVF7 0JDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=FqOjlGUh1C5dh75jl8BGy0UQhVsSyaHg6wFXz1FwE7E=; fh=FqzsA6riRZGIkGyljgDinxZs3HfpUBOvPASae+Tiprw=; b=Q1A0cW5EvPBnerxeCDT628SNWzhuJyPzYX3NBELYq8PT1NpqXH7U7tTwPtStisfVDp V3ad/4lCE9vwm+8gqV0IYapLV+/oFeE02eQR+TXrQe459u0YHgTrDGTxN4SDQ9LPEkuw l6ZDnv3cCknw4uWG7NCB7g7n9HJc7u8Hf6JFxyblqRFKY/nrz5URi6Z75Kjsj+EshoBg 9rWnOHE4KaF1nqqXUcsGdEXT3QtYA/cOh1H5C1lSnbeLEx6JEriht8r6aHzWjb97200C ZVYxdbrk4OcqDqetg3dD/zCpFP9GQhHNPogCnPoT3QG73F7F8QIK5i8/3Yn3VJPi/8Vc N1UQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t5-20020a170902e84500b001b6680bc871si13862948plg.445.2023.07.26.03.57.54; Wed, 26 Jul 2023 03:58:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233727AbjGZJl6 (ORCPT <rfc822;hanasaki@gmail.com> + 99 others); Wed, 26 Jul 2023 05:41:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233663AbjGZJls (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 26 Jul 2023 05:41:48 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04164DB; Wed, 26 Jul 2023 02:41:46 -0700 (PDT) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4R9pjn4CMhzNmZk; Wed, 26 Jul 2023 17:38:21 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 26 Jul 2023 17:41:43 +0800 From: Ruan Jinjie <ruanjinjie@huawei.com> To: <krzysztof.kozlowski@linaro.org>, <alim.akhtar@samsung.com>, <andi.shyti@kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-samsung-soc@vger.kernel.org>, <linux-i2c@vger.kernel.org> CC: <ruanjinjie@huawei.com> Subject: [PATCH -next] i2c: s3c2410: Remove redundant dev_err() Date: Wed, 26 Jul 2023 17:42:26 +0000 Message-ID: <20230726174226.2480552-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772480456890820262 X-GMAIL-MSGID: 1772480456890820262 |
Series |
[-next] i2c: s3c2410: Remove redundant dev_err()
|
|
Commit Message
Jinjie Ruan
July 26, 2023, 5:42 p.m. UTC
There is no need to call the dev_err() function directly to print a custom
message when handling an error from platform_get_irq() function as
it is going to display an appropriate error message in case of a failure.
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
drivers/i2c/busses/i2c-s3c2410.c | 1 -
1 file changed, 1 deletion(-)
Comments
Hi Ruan, On Wed, Jul 26, 2023 at 05:42:26PM +0000, Ruan Jinjie wrote: > There is no need to call the dev_err() function directly to print a custom > message when handling an error from platform_get_irq() function as > it is going to display an appropriate error message in case of a failure. > > Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> Correct! Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Andi
Hi On Wed, 26 Jul 2023 17:42:26 +0000, Ruan Jinjie wrote: > There is no need to call the dev_err() function directly to print a custom > message when handling an error from platform_get_irq() function as > it is going to display an appropriate error message in case of a failure. > > Applied to i2c/andi-for-next on https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git Please note that this patch may still undergo further evaluation and the final decision will be made in collaboration with Wolfram. Thank you, Andi Patches applied =============== [1/1] i2c: s3c2410: Remove redundant dev_err() commit: c0e109161aad5d543145d79921d1a577c8fa2eee
On Wed, Aug 02, 2023 at 10:10:35PM +0200, Andi Shyti wrote: > Hi > > On Wed, 26 Jul 2023 17:42:26 +0000, Ruan Jinjie wrote: > > There is no need to call the dev_err() function directly to print a custom > > message when handling an error from platform_get_irq() function as > > it is going to display an appropriate error message in case of a failure. > > > > Applied to for-next (via Andi's branch), thanks!
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index 28f0e5c64f32..703a43446eaa 100644 --- a/drivers/i2c/busses/i2c-s3c2410.c +++ b/drivers/i2c/busses/i2c-s3c2410.c @@ -1076,7 +1076,6 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) if (!(i2c->quirks & QUIRK_POLL)) { i2c->irq = ret = platform_get_irq(pdev, 0); if (ret < 0) { - dev_err(&pdev->dev, "cannot find IRQ\n"); clk_unprepare(i2c->clk); return ret; }