Message ID | 20230802-revert-do-not-generate-hfp-hbp-hsa-eot-packet-v1-1-f8a20084e15a@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp328132vqx; Wed, 2 Aug 2023 02:33:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlEKno1O8wnR/YWuJCXRg2YJKwdSHhrbrjde5ha30VAFgMj8Vn1bRf5rJboGkhpJFQ81kexJ X-Received: by 2002:a05:6a20:a11d:b0:132:7fb3:3325 with SMTP id q29-20020a056a20a11d00b001327fb33325mr15441496pzk.59.1690968823939; Wed, 02 Aug 2023 02:33:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690968823; cv=none; d=google.com; s=arc-20160816; b=fSg5Aa/pbxuJ8g73e9ZQKREJBNvPZwEBd+2u0Wi2wm0cWSfrzyAXO38RMjClQpAELc +2u/0wvT2m/p/6mtDZ8wVWXBAtzanIyq54VkSyR7tUBj1Y1O6yUmM2YVopdNCRPAOyCS HVL2XjQwej5/XAWGM/0cVvFP0zDUNqT2qGtWD+k+QlmvunmmjxeUdbl+0SWXhcnOu6Pv J8qHL17AvgTQ1aaTg4/s+7Vjmy/MsG/WE7HdYsABocbFagvjokMRrPTFdZoHn/pMSJ2M EPJ7bYt5ZCxz5E4duwF4PNVPchACfZXmPL6RPKpWfwTuUO+7zVKTmHHoCxY/S4fJGaUW zi8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=6wsrvVf1Tq2vaUhYtAT2JkjgDSEB22fZNeeTE0a5xSU=; fh=HmcKrZHfFoPUbnN/uKNu5bM0NJmJtB0nqFWCbe2MoUE=; b=vl8fSbupbgTMZWOXKq13msDjxt1OqWrxu70i/gwvymqAW0fntA5+NCGuLqhaAIhzW0 l3R62QcyVxyohs0WDMEMaaanDsmjzaRV6JOOSpR9NHB42HEYD7UF1Kf4MIffH19jS16K D6PMi7MdjQNpdR6ISKotMoAmJU1Cgf1bilxZagX3ooLcWQ7l509TX/8dTCozug63ZhZS 36XYEfR2cRTWh5y3Vgkay9nuHpbXLM1m4cdv1A5+gxybi+7FMsBaKQQaschMdjDApovl Pl7RyYWOCgGvOAJbphDCE8mCco5V5COTcrRvoPV1ZuJ/34KhTF0pG3xoKJXc0mvGCNt0 6AIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IVOBTjzg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s18-20020a056a00179200b0068035bb7a40si8570956pfg.366.2023.08.02.02.33.30; Wed, 02 Aug 2023 02:33:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IVOBTjzg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232564AbjHBIwh (ORCPT <rfc822;maxi.paulin@gmail.com> + 99 others); Wed, 2 Aug 2023 04:52:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229589AbjHBIwf (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 2 Aug 2023 04:52:35 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85E4A101 for <linux-kernel@vger.kernel.org>; Wed, 2 Aug 2023 01:52:33 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-3fbea14706eso60797005e9.2 for <linux-kernel@vger.kernel.org>; Wed, 02 Aug 2023 01:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690966352; x=1691571152; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=6wsrvVf1Tq2vaUhYtAT2JkjgDSEB22fZNeeTE0a5xSU=; b=IVOBTjzguAcA8nzoBa7REcOzJwvUR/3BndO0bPmLQRkwUFH4N3RsPRbfz6wGzY8mX/ vT11GLqVCGmMrD4TewyaQm6InaYrjTG+NV7nnFiPgetuYQYqmKDafmNfd5Kyt7S+N9RY ym8em805p4ceawjLf1PRU1ox5Za/b7VP5iemiHUYFC9m+GHCV9YBFZzL3NiwVD9/ulbQ +XzmqlwlmOHi8eDo8BLneVJ6VVwOOdmR5ksuIvntNfEgaWQoc6A3fQcv4asPbn5wJGl0 xFoTZ3ivECi9+kPDKKftXzkzX+BCKFLmJH0HymQZanARtu4ItLCgutNnh/us46DDWhde JGbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690966352; x=1691571152; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6wsrvVf1Tq2vaUhYtAT2JkjgDSEB22fZNeeTE0a5xSU=; b=hUv0UdMolMW9LzMjZIbLo9iGVcs/fAFaV5NnaFNCUQwSVZeqDcXobcPHKS+m1w4Lp4 L6Q97VMQQ8TEavRbdYMyn5b5uG9rJ/xSYWJBB5go/LbpDK4LSRKgIjp9Qep5RXq6q1Y2 3uKMKKI4rjxq6k58J/cBHodSp6TBDJEJJIB+oym/heXSvmMMwbC9vcXNHcYFINLSrkyd ++1eAadk1LmaCM3tNUWHpdGGy7+RrvO9z7e47gDewsg0C4J4Lz2UCgUVrsM7Dx8FDQDp tn8N1OapU3ajqVfp0OqlXFRB4x8HoF0rECp6KCnv8o3PTDX0F73lq+276nI7MMY/0Hk7 RK5A== X-Gm-Message-State: ABy/qLbTFQA24viE/h8el3lFrdBbR4UZi57r+94nvNMY3zw9enZhy7Mf UlwJyDtomczYMMAlKw+cC7+piA== X-Received: by 2002:a05:600c:2159:b0:3fe:1f93:8cf4 with SMTP id v25-20020a05600c215900b003fe1f938cf4mr4223087wml.8.1690966351956; Wed, 02 Aug 2023 01:52:31 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id x4-20020a1c7c04000000b003fa973e6612sm1094035wmc.44.2023.08.02.01.52.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 01:52:31 -0700 (PDT) From: Neil Armstrong <neil.armstrong@linaro.org> Date: Wed, 02 Aug 2023 10:52:22 +0200 Subject: [PATCH] Revert "drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet" MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230802-revert-do-not-generate-hfp-hbp-hsa-eot-packet-v1-1-f8a20084e15a@linaro.org> X-B4-Tracking: v=1; b=H4sIAEUZymQC/x2NwQrDIBBEfyXsuQtqSgn9ldKDJmOUgsoqJRDy7 116mMNjHjMndUhGp+d0kuCbe65Fwd4mWpMvOzhvyuSMm81iHKsEGbxVLnXwjgLxA5xi4xQ03TO 0aH79YPAjmrsLNvjFzqSbTRDz8f97va/rBwbXaYZ/AAAA To: Andrzej Hajda <andrzej.hajda@intel.com>, Robert Foss <rfoss@kernel.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Marek Vasut <marex@denx.de> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jagan Teki <jagan@amarulasolutions.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Amit Pundir <amit.pundir@linaro.org>, Neil Armstrong <neil.armstrong@linaro.org> X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1936; i=neil.armstrong@linaro.org; h=from:subject:message-id; bh=e9tUV/g8uW3iJGQla2yximmXQmIZ4VqzDUhHU5HlWnQ=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBkyhlOPAxfJvCKRFgFs7eo6UzvGsJ/l1XX6BklteG9 88m6BGyJAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCZMoZTgAKCRB33NvayMhJ0cmAD/ 4xEICh1qTqtu2jreftXCG4HpmJWmOW9vxu5esdTN960Zi4rZDQnO3dTtJn/JQz88MItdN1NsICzWiq oUBBHD/ZYREyV1+oGOCmRxkkJ7n4SgB+GW1euwJeLsnxUXOWOPwiton1GHVm0vLZ80wmMMdHtdaBXf t3fqPdaaLD0XumzBQnXOSnU6IJ31TemVwkFbZIUJ2v9rXtNfnu5Oyd8n6wOVS54cag4Ffi61T9KmVp ktX+ET+Ysu87MD1PohBj5ccuANrVpcbLcH7zhStTmMkIX4ml4ipkEIU+mVuQirjjitt6ALXay+CoIz CsBvo/P5Neb8f3AlzSFMUxCRli4b51geO36qb2P3ETWLElTTwsTAljJ6Mhr4ToDb4xohxc2TphiA1K pClXYCQdb0F4cS6ce141ZRL/parRNNGUJnZAS2xlHEzRWNwYKm6YxMkZxO7QUa6JVF7Elr9s5ephD4 9gx8q1bDXV3V9a7bosSOtyvxAtWXAIxaYliGDYJlFBUYy0SVqnR+uebZtppw9K6G5tMG5XtqntZ0lS 8FTQxKb8TwC66ZvQJccqFTiv3Lx2HIFFXCiT33CDxwyeoKmEfU9G5RGuOW79tjMX9dYA0UAuzOXi6a oQdFtZ8Gth6/03IUD97/e/nC9v6oIQQmjceqDQDv1bu6nndW76cUj3mFhZoA== X-Developer-Key: i=neil.armstrong@linaro.org; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773109325755230629 X-GMAIL-MSGID: 1773109325755230629 |
Series |
Revert "drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet"
|
|
Commit Message
Neil Armstrong
Aug. 2, 2023, 8:52 a.m. UTC
This reverts commit [1] to fix display regression on the Dragonboard 845c
(SDM845) devboard.
There's a mismatch on the real action of the following flags:
- MIPI_DSI_MODE_VIDEO_NO_HSA
- MIPI_DSI_MODE_VIDEO_NO_HFP
- MIPI_DSI_MODE_VIDEO_NO_HBP
which leads to a non-working display on qcom platforms.
[1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet")
Cc: Marek Vasut <marex@denx.de>
Cc: Robert Foss <rfoss@kernel.org>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet")
Reported-by: Amit Pundir <amit.pundir@linaro.org>
Link: https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
---
base-commit: f590814603bf2dd8620584b7d59ae94d7c186c69
change-id: 20230802-revert-do-not-generate-hfp-hbp-hsa-eot-packet-6f042b1ba813
Best regards,
Comments
On Wed, 2 Aug 2023 at 11:52, Neil Armstrong <neil.armstrong@linaro.org> wrote: > > This reverts commit [1] to fix display regression on the Dragonboard 845c > (SDM845) devboard. > > There's a mismatch on the real action of the following flags: > - MIPI_DSI_MODE_VIDEO_NO_HSA > - MIPI_DSI_MODE_VIDEO_NO_HFP > - MIPI_DSI_MODE_VIDEO_NO_HBP > which leads to a non-working display on qcom platforms. > > [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") Nit: I think the preferred form is to write `... reverts commit abcdef ("foo and bar")', but I might be wrong. Other than that: Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Cc: Marek Vasut <marex@denx.de> > Cc: Robert Foss <rfoss@kernel.org> > Cc: Jagan Teki <jagan@amarulasolutions.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") > Reported-by: Amit Pundir <amit.pundir@linaro.org> > Link: https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c > index 5163e5224aad..9663601ce098 100644 > --- a/drivers/gpu/drm/bridge/lontium-lt9611.c > +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c > @@ -774,9 +774,7 @@ static struct mipi_dsi_device *lt9611_attach_dsi(struct lt9611 *lt9611, > dsi->lanes = 4; > dsi->format = MIPI_DSI_FMT_RGB888; > dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > - MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO_NO_HSA | > - MIPI_DSI_MODE_VIDEO_NO_HFP | MIPI_DSI_MODE_VIDEO_NO_HBP | > - MIPI_DSI_MODE_NO_EOT_PACKET; > + MIPI_DSI_MODE_VIDEO_HSE; > > ret = devm_mipi_dsi_attach(dev, dsi); > if (ret < 0) { > > --- > base-commit: f590814603bf2dd8620584b7d59ae94d7c186c69 > change-id: 20230802-revert-do-not-generate-hfp-hbp-hsa-eot-packet-6f042b1ba813 > > Best regards, > -- > Neil Armstrong <neil.armstrong@linaro.org> >
On Wed, 2 Aug 2023 at 14:22, Neil Armstrong <neil.armstrong@linaro.org> wrote: > > This reverts commit [1] to fix display regression on the Dragonboard 845c > (SDM845) devboard. Tested-by: Amit Pundir <amit.pundir@linaro.org> Regards, Amit Pundir > > There's a mismatch on the real action of the following flags: > - MIPI_DSI_MODE_VIDEO_NO_HSA > - MIPI_DSI_MODE_VIDEO_NO_HFP > - MIPI_DSI_MODE_VIDEO_NO_HBP > which leads to a non-working display on qcom platforms. > > [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") > > Cc: Marek Vasut <marex@denx.de> > Cc: Robert Foss <rfoss@kernel.org> > Cc: Jagan Teki <jagan@amarulasolutions.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") > Reported-by: Amit Pundir <amit.pundir@linaro.org> > Link: https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c > index 5163e5224aad..9663601ce098 100644 > --- a/drivers/gpu/drm/bridge/lontium-lt9611.c > +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c > @@ -774,9 +774,7 @@ static struct mipi_dsi_device *lt9611_attach_dsi(struct lt9611 *lt9611, > dsi->lanes = 4; > dsi->format = MIPI_DSI_FMT_RGB888; > dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > - MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO_NO_HSA | > - MIPI_DSI_MODE_VIDEO_NO_HFP | MIPI_DSI_MODE_VIDEO_NO_HBP | > - MIPI_DSI_MODE_NO_EOT_PACKET; > + MIPI_DSI_MODE_VIDEO_HSE; > > ret = devm_mipi_dsi_attach(dev, dsi); > if (ret < 0) { > > --- > base-commit: f590814603bf2dd8620584b7d59ae94d7c186c69 > change-id: 20230802-revert-do-not-generate-hfp-hbp-hsa-eot-packet-6f042b1ba813 > > Best regards, > -- > Neil Armstrong <neil.armstrong@linaro.org> >
On 8/2/23 10:52, Neil Armstrong wrote: > This reverts commit [1] to fix display regression on the Dragonboard 845c > (SDM845) devboard. > > There's a mismatch on the real action of the following flags: > - MIPI_DSI_MODE_VIDEO_NO_HSA > - MIPI_DSI_MODE_VIDEO_NO_HFP > - MIPI_DSI_MODE_VIDEO_NO_HBP > which leads to a non-working display on qcom platforms. > > [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") > > Cc: Marek Vasut <marex@denx.de> > Cc: Robert Foss <rfoss@kernel.org> > Cc: Jagan Teki <jagan@amarulasolutions.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") > Reported-by: Amit Pundir <amit.pundir@linaro.org> > Link: https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> This breaks LT9611 operation on i.MX8M Mini/Nano/Plus, so, NAK. I am currently using this LT9611 with Linux 6.1.y in production and this is not acceptable. I also believe the correct fix is on the MSM side, not on the LT9611 driver side, since MSM incorrectly implements these flags.
On 8/2/23 14:07, Marek Vasut wrote: > On 8/2/23 10:52, Neil Armstrong wrote: >> This reverts commit [1] to fix display regression on the Dragonboard 845c >> (SDM845) devboard. >> >> There's a mismatch on the real action of the following flags: >> - MIPI_DSI_MODE_VIDEO_NO_HSA >> - MIPI_DSI_MODE_VIDEO_NO_HFP >> - MIPI_DSI_MODE_VIDEO_NO_HBP >> which leads to a non-working display on qcom platforms. >> >> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and >> EOT packet") >> >> Cc: Marek Vasut <marex@denx.de> >> Cc: Robert Foss <rfoss@kernel.org> >> Cc: Jagan Teki <jagan@amarulasolutions.com> >> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA >> and EOT packet") >> Reported-by: Amit Pundir <amit.pundir@linaro.org> >> Link: >> https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > > This breaks LT9611 operation on i.MX8M Mini/Nano/Plus, so, NAK. > > I am currently using this LT9611 with Linux 6.1.y Correction, 6.1.y only with the DSIM patches backported. > in production and this > is not acceptable. I also believe the correct fix is on the MSM side, > not on the LT9611 driver side, since MSM incorrectly implements these > flags.
On 02/08/2023 14:28, Marek Vasut wrote: > On 8/2/23 14:07, Marek Vasut wrote: >> On 8/2/23 10:52, Neil Armstrong wrote: >>> This reverts commit [1] to fix display regression on the Dragonboard 845c >>> (SDM845) devboard. >>> >>> There's a mismatch on the real action of the following flags: >>> - MIPI_DSI_MODE_VIDEO_NO_HSA >>> - MIPI_DSI_MODE_VIDEO_NO_HFP >>> - MIPI_DSI_MODE_VIDEO_NO_HBP >>> which leads to a non-working display on qcom platforms. >>> >>> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") >>> >>> Cc: Marek Vasut <marex@denx.de> >>> Cc: Robert Foss <rfoss@kernel.org> >>> Cc: Jagan Teki <jagan@amarulasolutions.com> >>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >>> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") >>> Reported-by: Amit Pundir <amit.pundir@linaro.org> >>> Link: https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ >>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> >> This breaks LT9611 operation on i.MX8M Mini/Nano/Plus, so, NAK. >> >> I am currently using this LT9611 with Linux 6.1.y > > Correction, 6.1.y only with the DSIM patches backported. Well you'll need to keep [1] backported on your downstream branch, this revert won't propagate to v6.1 stable anyway. > >> in production and this is not acceptable. I also believe the correct fix is on the MSM side, not on the LT9611 driver side, since MSM incorrectly implements these flags. > Since [1] breaks Qcom boards on v6.5, and [1] was added for v6.5 to make the bridge work on i.MX8M Mini/Nano/Plus, it's not acceptable either to keep it for the v6.5 release. Neil
On 02/08/2023 15:07, Marek Vasut wrote: > On 8/2/23 10:52, Neil Armstrong wrote: >> This reverts commit [1] to fix display regression on the Dragonboard 845c >> (SDM845) devboard. >> >> There's a mismatch on the real action of the following flags: >> - MIPI_DSI_MODE_VIDEO_NO_HSA >> - MIPI_DSI_MODE_VIDEO_NO_HFP >> - MIPI_DSI_MODE_VIDEO_NO_HBP >> which leads to a non-working display on qcom platforms. >> >> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and >> EOT packet") >> >> Cc: Marek Vasut <marex@denx.de> >> Cc: Robert Foss <rfoss@kernel.org> >> Cc: Jagan Teki <jagan@amarulasolutions.com> >> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA >> and EOT packet") >> Reported-by: Amit Pundir <amit.pundir@linaro.org> >> Link: >> https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > > This breaks LT9611 operation on i.MX8M Mini/Nano/Plus, so, NAK. > > I am currently using this LT9611 with Linux 6.1.y in production and this > is not acceptable. I also believe the correct fix is on the MSM side, > not on the LT9611 driver side, since MSM incorrectly implements these > flags. Up to now we saw no proof that MSM incorrectly implements the flags.
On 02/08/2023 15:07, Marek Vasut wrote: > On 8/2/23 10:52, Neil Armstrong wrote: >> This reverts commit [1] to fix display regression on the Dragonboard 845c >> (SDM845) devboard. >> >> There's a mismatch on the real action of the following flags: >> - MIPI_DSI_MODE_VIDEO_NO_HSA >> - MIPI_DSI_MODE_VIDEO_NO_HFP >> - MIPI_DSI_MODE_VIDEO_NO_HBP >> which leads to a non-working display on qcom platforms. >> >> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and >> EOT packet") >> >> Cc: Marek Vasut <marex@denx.de> >> Cc: Robert Foss <rfoss@kernel.org> >> Cc: Jagan Teki <jagan@amarulasolutions.com> >> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA >> and EOT packet") >> Reported-by: Amit Pundir <amit.pundir@linaro.org> >> Link: >> https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > > This breaks LT9611 operation on i.MX8M Mini/Nano/Plus, so, NAK. > > I am currently using this LT9611 with Linux 6.1.y in production and this > is not acceptable. I also believe the correct fix is on the MSM side, > not on the LT9611 driver side, since MSM incorrectly implements these > flags. There is no indication that MSM gets these flags wrong. Let me quote the DSI 1.3 (I think Abhinav already quoted DSI 1.2). Chapter 8.11.1 Transmission Packet Sequences: ======== If a peripheral timing specification for HBP or HFP minimum period is zero, the corresponding Blanking Packet may be omitted. If the HBP or HFP maximum period is zero, the corresponding blanking packet shall be omitted. ======== Next, chapter 8.11.2 Non-Burst Mode with Sync Pulses ====== Normally, periods shown as HSA (Horizontal Sync Active), HBP (Horizontal Back Porch) and HFP (Horizontal Front Porch) are filled by Blanking Packets, with lengths (including packet overhead) calculated to match the period specified by the peripheral’s data sheet. Alternatively, if there is sufficient time to transition from HS to LP mode and back again, a timed interval in LP mode may substitute for a Blanking Packet, thus saving power. During HSA, HBP and HFP periods, the bus should stay in the LP-11 state. ======== So, by the spec, sending the HSA / HBP / HFP as blanking packets should always be accepted (and it is the default mode). Switching to LP-11 should be permitted if there is a sufficient time to switch to LP-11 and back. Not sending the packets is only possible if the peripheral (lt9611) says so. We already know that lt9611 breaks if we try switching to LP-11 during this period. We know that the there is a requirement time for the HSA / HBP / HFP, because the HDMI monitor needs them. Thus, I can only emphasise that the behaviour before the offending patch was correct. Last, but not least, breaking the in-kernel platform for the out-of-tree peripheral doesn't sound correct. I can only propose the following steps: 1. land the revert to unbreak existing users. 2. Marek to propose and land the DT bindings & driver change that will enable the workaround for the particular platform (i.MX8m).
On 02/08/2023 11:52, Neil Armstrong wrote: > This reverts commit [1] to fix display regression on the Dragonboard 845c > (SDM845) devboard. > > There's a mismatch on the real action of the following flags: > - MIPI_DSI_MODE_VIDEO_NO_HSA > - MIPI_DSI_MODE_VIDEO_NO_HFP > - MIPI_DSI_MODE_VIDEO_NO_HBP > which leads to a non-working display on qcom platforms. > > [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") > > Cc: Marek Vasut <marex@denx.de> > Cc: Robert Foss <rfoss@kernel.org> > Cc: Jagan Teki <jagan@amarulasolutions.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") > Reported-by: Amit Pundir <amit.pundir@linaro.org> > Link: https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> #fix db845c The boards broken by [1] are used in production by different parties since 5.10, breaking them doesn't seem more acceptable than breaking the new out-of-tree iMX8m hardware.
On 8/2/23 14:38, Dmitry Baryshkov wrote: > On 02/08/2023 15:07, Marek Vasut wrote: >> On 8/2/23 10:52, Neil Armstrong wrote: >>> This reverts commit [1] to fix display regression on the Dragonboard >>> 845c >>> (SDM845) devboard. >>> >>> There's a mismatch on the real action of the following flags: >>> - MIPI_DSI_MODE_VIDEO_NO_HSA >>> - MIPI_DSI_MODE_VIDEO_NO_HFP >>> - MIPI_DSI_MODE_VIDEO_NO_HBP >>> which leads to a non-working display on qcom platforms. >>> >>> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA >>> and EOT packet") >>> >>> Cc: Marek Vasut <marex@denx.de> >>> Cc: Robert Foss <rfoss@kernel.org> >>> Cc: Jagan Teki <jagan@amarulasolutions.com> >>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >>> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA >>> and EOT packet") >>> Reported-by: Amit Pundir <amit.pundir@linaro.org> >>> Link: >>> https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ >>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> >> This breaks LT9611 operation on i.MX8M Mini/Nano/Plus, so, NAK. >> >> I am currently using this LT9611 with Linux 6.1.y in production and >> this is not acceptable. I also believe the correct fix is on the MSM >> side, not on the LT9611 driver side, since MSM incorrectly implements >> these flags. > > Up to now we saw no proof that MSM incorrectly implements the flags. Please read the whole "[PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet" discussion for context.
On 8/2/23 15:16, Dmitry Baryshkov wrote: > On 02/08/2023 15:07, Marek Vasut wrote: >> On 8/2/23 10:52, Neil Armstrong wrote: >>> This reverts commit [1] to fix display regression on the Dragonboard >>> 845c >>> (SDM845) devboard. >>> >>> There's a mismatch on the real action of the following flags: >>> - MIPI_DSI_MODE_VIDEO_NO_HSA >>> - MIPI_DSI_MODE_VIDEO_NO_HFP >>> - MIPI_DSI_MODE_VIDEO_NO_HBP >>> which leads to a non-working display on qcom platforms. >>> >>> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA >>> and EOT packet") >>> >>> Cc: Marek Vasut <marex@denx.de> >>> Cc: Robert Foss <rfoss@kernel.org> >>> Cc: Jagan Teki <jagan@amarulasolutions.com> >>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >>> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA >>> and EOT packet") >>> Reported-by: Amit Pundir <amit.pundir@linaro.org> >>> Link: >>> https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ >>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> >> This breaks LT9611 operation on i.MX8M Mini/Nano/Plus, so, NAK. >> >> I am currently using this LT9611 with Linux 6.1.y in production and >> this is not acceptable. I also believe the correct fix is on the MSM >> side, not on the LT9611 driver side, since MSM incorrectly implements >> these flags. > > There is no indication that MSM gets these flags wrong. > > Let me quote the DSI 1.3 (I think Abhinav already quoted DSI 1.2). > > Chapter 8.11.1 Transmission Packet Sequences: > > ======== > If a peripheral timing specification for HBP or HFP minimum period is > zero, the corresponding Blanking > Packet may be omitted. If the HBP or HFP maximum period is zero, the > corresponding blanking packet > shall be omitted. > ======== > > Next, chapter 8.11.2 Non-Burst Mode with Sync Pulses > > ====== > Normally, periods shown as HSA (Horizontal Sync Active), HBP (Horizontal > Back Porch) and HFP > (Horizontal Front Porch) are filled by Blanking Packets, with lengths > (including packet overhead) > calculated to match the period specified by the peripheral’s data sheet. > Alternatively, if there is sufficient > time to transition from HS to LP mode and back again, a timed interval > in LP mode may substitute for a > Blanking Packet, thus saving power. During HSA, HBP and HFP periods, the > bus should stay in the LP-11 > state. > ======== > > So, by the spec, sending the HSA / HBP / HFP as blanking packets should > always be accepted (and it is the default mode). Switching to LP-11 > should be permitted if there is a sufficient time to switch to LP-11 and > back. Not sending the packets is only possible if the peripheral > (lt9611) says so. > > We already know that lt9611 breaks if we try switching to LP-11 during > this period. We know that the there is a requirement time for the HSA / > HBP / HFP, because the HDMI monitor needs them. Thus, I can only > emphasise that the behaviour before the offending patch was correct. > > Last, but not least, breaking the in-kernel platform for the out-of-tree > peripheral doesn't sound correct. Except the MX8M support is all in-tree now, so please drop the "out-of-tree" argument. That I am using 6.1.y on those platforms in production makes no difference. > I can only propose the following steps: > > 1. land the revert to unbreak existing users. That's just trading breaking one set of users for breaking another set of users. > 2. Marek to propose and land the DT bindings & driver change that will > enable the workaround for the particular platform (i.MX8m). Since I have no access to the QCOM hardware or datasheet, can you have a look at the NXP.com MX8M M/N/P datasheets (those are available) and compare their behavior with the QCOM behavior ? I assume you do have the QCOM datasheets available.
On 8/2/23 15:38, Dmitry Baryshkov wrote: > On 02/08/2023 11:52, Neil Armstrong wrote: >> This reverts commit [1] to fix display regression on the Dragonboard 845c >> (SDM845) devboard. >> >> There's a mismatch on the real action of the following flags: >> - MIPI_DSI_MODE_VIDEO_NO_HSA >> - MIPI_DSI_MODE_VIDEO_NO_HFP >> - MIPI_DSI_MODE_VIDEO_NO_HBP >> which leads to a non-working display on qcom platforms. >> >> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and >> EOT packet") >> >> Cc: Marek Vasut <marex@denx.de> >> Cc: Robert Foss <rfoss@kernel.org> >> Cc: Jagan Teki <jagan@amarulasolutions.com> >> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA >> and EOT packet") >> Reported-by: Amit Pundir <amit.pundir@linaro.org> >> Link: >> https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> > Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> #fix db845c > > The boards broken by [1] are used in production by different parties > since 5.10, breaking them doesn't seem more acceptable than breaking the > new out-of-tree iMX8m hardware. The MX8M is also in-tree, so this does not apply.
On 8/2/23 14:37, Neil Armstrong wrote: > On 02/08/2023 14:28, Marek Vasut wrote: >> On 8/2/23 14:07, Marek Vasut wrote: >>> On 8/2/23 10:52, Neil Armstrong wrote: >>>> This reverts commit [1] to fix display regression on the Dragonboard >>>> 845c >>>> (SDM845) devboard. >>>> >>>> There's a mismatch on the real action of the following flags: >>>> - MIPI_DSI_MODE_VIDEO_NO_HSA >>>> - MIPI_DSI_MODE_VIDEO_NO_HFP >>>> - MIPI_DSI_MODE_VIDEO_NO_HBP >>>> which leads to a non-working display on qcom platforms. >>>> >>>> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA >>>> and EOT packet") >>>> >>>> Cc: Marek Vasut <marex@denx.de> >>>> Cc: Robert Foss <rfoss@kernel.org> >>>> Cc: Jagan Teki <jagan@amarulasolutions.com> >>>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>>> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >>>> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA >>>> and EOT packet") >>>> Reported-by: Amit Pundir <amit.pundir@linaro.org> >>>> Link: >>>> https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ >>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >>> >>> This breaks LT9611 operation on i.MX8M Mini/Nano/Plus, so, NAK. >>> >>> I am currently using this LT9611 with Linux 6.1.y >> >> Correction, 6.1.y only with the DSIM patches backported. > > Well you'll need to keep [1] backported on your downstream branch, > this revert won't propagate to v6.1 stable anyway. I will still have a problem with those MX8M boards during my development on linux-next, so that isn't helping. >>> in production and this is not acceptable. I also believe the correct >>> fix is on the MSM side, not on the LT9611 driver side, since MSM >>> incorrectly implements these flags. >> > > Since [1] breaks Qcom boards on v6.5, and [1] was added for v6.5 to make > the bridge work > on i.MX8M Mini/Nano/Plus, it's not acceptable either to keep it for the > v6.5 release. So, we need to find a solution which works for both, I proposed one already.
On Wed, 2 Aug 2023 at 20:34, Marek Vasut <marex@denx.de> wrote: > > On 8/2/23 14:37, Neil Armstrong wrote: > > On 02/08/2023 14:28, Marek Vasut wrote: > >> On 8/2/23 14:07, Marek Vasut wrote: > >>> On 8/2/23 10:52, Neil Armstrong wrote: > >>>> This reverts commit [1] to fix display regression on the Dragonboard > >>>> 845c > >>>> (SDM845) devboard. > >>>> > >>>> There's a mismatch on the real action of the following flags: > >>>> - MIPI_DSI_MODE_VIDEO_NO_HSA > >>>> - MIPI_DSI_MODE_VIDEO_NO_HFP > >>>> - MIPI_DSI_MODE_VIDEO_NO_HBP > >>>> which leads to a non-working display on qcom platforms. > >>>> > >>>> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA > >>>> and EOT packet") > >>>> > >>>> Cc: Marek Vasut <marex@denx.de> > >>>> Cc: Robert Foss <rfoss@kernel.org> > >>>> Cc: Jagan Teki <jagan@amarulasolutions.com> > >>>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > >>>> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > >>>> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA > >>>> and EOT packet") > >>>> Reported-by: Amit Pundir <amit.pundir@linaro.org> > >>>> Link: > >>>> https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ > >>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > >>> > >>> This breaks LT9611 operation on i.MX8M Mini/Nano/Plus, so, NAK. > >>> > >>> I am currently using this LT9611 with Linux 6.1.y > >> > >> Correction, 6.1.y only with the DSIM patches backported. > > > > Well you'll need to keep [1] backported on your downstream branch, > > this revert won't propagate to v6.1 stable anyway. > > I will still have a problem with those MX8M boards during my development > on linux-next, so that isn't helping. > > >>> in production and this is not acceptable. I also believe the correct > >>> fix is on the MSM side, not on the LT9611 driver side, since MSM > >>> incorrectly implements these flags. > >> > > > > Since [1] breaks Qcom boards on v6.5, and [1] was added for v6.5 to make > > the bridge work > > on i.MX8M Mini/Nano/Plus, it's not acceptable either to keep it for the > > v6.5 release. > > So, we need to find a solution which works for both, I proposed one already. We proposed another one.
On Wed, 2 Aug 2023 at 20:34, Marek Vasut <marex@denx.de> wrote: > > On 8/2/23 15:38, Dmitry Baryshkov wrote: > > On 02/08/2023 11:52, Neil Armstrong wrote: > >> This reverts commit [1] to fix display regression on the Dragonboard 845c > >> (SDM845) devboard. > >> > >> There's a mismatch on the real action of the following flags: > >> - MIPI_DSI_MODE_VIDEO_NO_HSA > >> - MIPI_DSI_MODE_VIDEO_NO_HFP > >> - MIPI_DSI_MODE_VIDEO_NO_HBP > >> which leads to a non-working display on qcom platforms. > >> > >> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and > >> EOT packet") > >> > >> Cc: Marek Vasut <marex@denx.de> > >> Cc: Robert Foss <rfoss@kernel.org> > >> Cc: Jagan Teki <jagan@amarulasolutions.com> > >> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > >> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > >> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA > >> and EOT packet") > >> Reported-by: Amit Pundir <amit.pundir@linaro.org> > >> Link: > >> https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ > >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > >> --- > >> drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +--- > >> 1 file changed, 1 insertion(+), 3 deletions(-) > >> > > Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> #fix db845c > > > > The boards broken by [1] are used in production by different parties > > since 5.10, breaking them doesn't seem more acceptable than breaking the > > new out-of-tree iMX8m hardware. > > The MX8M is also in-tree, so this does not apply. v6.5-rc4: $ git grep lontium,lt9611 | grep -v 9611uxc Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml:$id: http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: - lontium,lt9611 Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: compatible = "lontium,lt9611"; arch/arm64/boot/dts/qcom/sdm845-db845c.dts: compatible = "lontium,lt9611"; drivers/gpu/drm/bridge/lontium-lt9611.c: { "lontium,lt9611", 0 }, drivers/gpu/drm/bridge/lontium-lt9611.c: { .compatible = "lontium,lt9611" }, next-20230802: $ git grep lontium,lt9611 | grep -v 9611uxc Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml:$id: http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: - lontium,lt9611 Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: compatible = "lontium,lt9611"; arch/arm64/boot/dts/qcom/sdm845-db845c.dts: compatible = "lontium,lt9611"; drivers/gpu/drm/bridge/lontium-lt9611.c: { "lontium,lt9611", 0 }, drivers/gpu/drm/bridge/lontium-lt9611.c: { .compatible = "lontium,lt9611" }, Your device is not in the tree. Your commit broke existing users. Can we please end the argument, land the fix (this revert) for 6.5 and work on the solution for 6.6 or 6.7?
On 8/2/23 20:16, Dmitry Baryshkov wrote: > On Wed, 2 Aug 2023 at 20:34, Marek Vasut <marex@denx.de> wrote: >> >> On 8/2/23 15:38, Dmitry Baryshkov wrote: >>> On 02/08/2023 11:52, Neil Armstrong wrote: >>>> This reverts commit [1] to fix display regression on the Dragonboard 845c >>>> (SDM845) devboard. >>>> >>>> There's a mismatch on the real action of the following flags: >>>> - MIPI_DSI_MODE_VIDEO_NO_HSA >>>> - MIPI_DSI_MODE_VIDEO_NO_HFP >>>> - MIPI_DSI_MODE_VIDEO_NO_HBP >>>> which leads to a non-working display on qcom platforms. >>>> >>>> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and >>>> EOT packet") >>>> >>>> Cc: Marek Vasut <marex@denx.de> >>>> Cc: Robert Foss <rfoss@kernel.org> >>>> Cc: Jagan Teki <jagan@amarulasolutions.com> >>>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>>> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >>>> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA >>>> and EOT packet") >>>> Reported-by: Amit Pundir <amit.pundir@linaro.org> >>>> Link: >>>> https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ >>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >>>> --- >>>> drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +--- >>>> 1 file changed, 1 insertion(+), 3 deletions(-) >>>> >>> Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> #fix db845c >>> >>> The boards broken by [1] are used in production by different parties >>> since 5.10, breaking them doesn't seem more acceptable than breaking the >>> new out-of-tree iMX8m hardware. >> >> The MX8M is also in-tree, so this does not apply. > > v6.5-rc4: > > $ git grep lontium,lt9611 | grep -v 9611uxc > Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml:$id: > http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# > Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: > - lontium,lt9611 > Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: > compatible = "lontium,lt9611"; > arch/arm64/boot/dts/qcom/sdm845-db845c.dts: compatible = "lontium,lt9611"; > drivers/gpu/drm/bridge/lontium-lt9611.c: { "lontium,lt9611", 0 }, > drivers/gpu/drm/bridge/lontium-lt9611.c: { .compatible = "lontium,lt9611" }, > > next-20230802: > > $ git grep lontium,lt9611 | grep -v 9611uxc > Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml:$id: > http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# > Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: > - lontium,lt9611 > Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: > compatible = "lontium,lt9611"; > arch/arm64/boot/dts/qcom/sdm845-db845c.dts: compatible = "lontium,lt9611"; > drivers/gpu/drm/bridge/lontium-lt9611.c: { "lontium,lt9611", 0 }, > drivers/gpu/drm/bridge/lontium-lt9611.c: { .compatible = "lontium,lt9611" }, > > Your device is not in the tree. Your commit broke existing users. These devices are in tree: arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts The LT9211 and LT9611 are both expansion modules handled by DTOs and bound to the DSIM (which is also in tree). > Can we please end the argument, land the fix (this revert) for 6.5 and > work on the solution for 6.6 or 6.7? I would much prefer a solution which does not break my existing use case. It is still not even clear whether the problem really is on MX8M side at all, or whether it is QCOM misinterpreting flags. I cannot debug the later, since I have no access to that platform, nor its documentation.
On Wed, Aug 2, 2023 at 11:16 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Wed, 2 Aug 2023 at 20:34, Marek Vasut <marex@denx.de> wrote: > > > > On 8/2/23 15:38, Dmitry Baryshkov wrote: > > > On 02/08/2023 11:52, Neil Armstrong wrote: > > >> This reverts commit [1] to fix display regression on the Dragonboard 845c > > >> (SDM845) devboard. > > >> > > >> There's a mismatch on the real action of the following flags: > > >> - MIPI_DSI_MODE_VIDEO_NO_HSA > > >> - MIPI_DSI_MODE_VIDEO_NO_HFP > > >> - MIPI_DSI_MODE_VIDEO_NO_HBP > > >> which leads to a non-working display on qcom platforms. > > >> > > >> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and > > >> EOT packet") > > >> > > >> Cc: Marek Vasut <marex@denx.de> > > >> Cc: Robert Foss <rfoss@kernel.org> > > >> Cc: Jagan Teki <jagan@amarulasolutions.com> > > >> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > >> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > > >> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA > > >> and EOT packet") > > >> Reported-by: Amit Pundir <amit.pundir@linaro.org> > > >> Link: > > >> https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ > > >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > > >> --- > > >> drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +--- > > >> 1 file changed, 1 insertion(+), 3 deletions(-) > > >> > > > Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> #fix db845c > > > > > > The boards broken by [1] are used in production by different parties > > > since 5.10, breaking them doesn't seem more acceptable than breaking the > > > new out-of-tree iMX8m hardware. > > > > The MX8M is also in-tree, so this does not apply. > > v6.5-rc4: > > $ git grep lontium,lt9611 | grep -v 9611uxc > Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml:$id: > http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# > Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: > - lontium,lt9611 > Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: > compatible = "lontium,lt9611"; > arch/arm64/boot/dts/qcom/sdm845-db845c.dts: compatible = "lontium,lt9611"; > drivers/gpu/drm/bridge/lontium-lt9611.c: { "lontium,lt9611", 0 }, > drivers/gpu/drm/bridge/lontium-lt9611.c: { .compatible = "lontium,lt9611" }, > > next-20230802: > > $ git grep lontium,lt9611 | grep -v 9611uxc > Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml:$id: > http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# > Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: > - lontium,lt9611 > Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: > compatible = "lontium,lt9611"; > arch/arm64/boot/dts/qcom/sdm845-db845c.dts: compatible = "lontium,lt9611"; > drivers/gpu/drm/bridge/lontium-lt9611.c: { "lontium,lt9611", 0 }, > drivers/gpu/drm/bridge/lontium-lt9611.c: { .compatible = "lontium,lt9611" }, > > Your device is not in the tree. Your commit broke existing users. > > Can we please end the argument, land the fix (this revert) for 6.5 and > work on the solution for 6.6 or 6.7? > Even if they were in-tree, breaking existing hw means revert and try-again. Especially as we get into later -rc's BR, -R > -- > With best wishes > Dmitry
On 02/08/2023 21:45, Marek Vasut wrote: > On 8/2/23 20:16, Dmitry Baryshkov wrote: >> On Wed, 2 Aug 2023 at 20:34, Marek Vasut <marex@denx.de> wrote: >>> >>> On 8/2/23 15:38, Dmitry Baryshkov wrote: >>>> On 02/08/2023 11:52, Neil Armstrong wrote: >>>>> This reverts commit [1] to fix display regression on the >>>>> Dragonboard 845c >>>>> (SDM845) devboard. >>>>> >>>>> There's a mismatch on the real action of the following flags: >>>>> - MIPI_DSI_MODE_VIDEO_NO_HSA >>>>> - MIPI_DSI_MODE_VIDEO_NO_HFP >>>>> - MIPI_DSI_MODE_VIDEO_NO_HBP >>>>> which leads to a non-working display on qcom platforms. >>>>> >>>>> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and >>>>> EOT packet") >>>>> >>>>> Cc: Marek Vasut <marex@denx.de> >>>>> Cc: Robert Foss <rfoss@kernel.org> >>>>> Cc: Jagan Teki <jagan@amarulasolutions.com> >>>>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>>>> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >>>>> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA >>>>> and EOT packet") >>>>> Reported-by: Amit Pundir <amit.pundir@linaro.org> >>>>> Link: >>>>> https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ >>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >>>>> --- >>>>> drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +--- >>>>> 1 file changed, 1 insertion(+), 3 deletions(-) >>>>> >>>> Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> #fix db845c >>>> >>>> The boards broken by [1] are used in production by different parties >>>> since 5.10, breaking them doesn't seem more acceptable than breaking >>>> the >>>> new out-of-tree iMX8m hardware. >>> >>> The MX8M is also in-tree, so this does not apply. >> >> v6.5-rc4: >> >> $ git grep lontium,lt9611 | grep -v 9611uxc >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml:$id: >> http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: >> - lontium,lt9611 >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: >> compatible = "lontium,lt9611"; >> arch/arm64/boot/dts/qcom/sdm845-db845c.dts: compatible = >> "lontium,lt9611"; >> drivers/gpu/drm/bridge/lontium-lt9611.c: { "lontium,lt9611", 0 }, >> drivers/gpu/drm/bridge/lontium-lt9611.c: { .compatible = >> "lontium,lt9611" }, >> >> next-20230802: >> >> $ git grep lontium,lt9611 | grep -v 9611uxc >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml:$id: >> http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: >> - lontium,lt9611 >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: >> compatible = "lontium,lt9611"; >> arch/arm64/boot/dts/qcom/sdm845-db845c.dts: compatible = >> "lontium,lt9611"; >> drivers/gpu/drm/bridge/lontium-lt9611.c: { "lontium,lt9611", 0 }, >> drivers/gpu/drm/bridge/lontium-lt9611.c: { .compatible = >> "lontium,lt9611" }, >> >> Your device is not in the tree. Your commit broke existing users. > > These devices are in tree: > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts > arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts > > The LT9211 and LT9611 are both expansion modules handled by DTOs and > bound to the DSIM (which is also in tree). And they DT for them is not in the tree, that was my point. You have broken the existing user for the DTBO that is not present even in linux-next. > >> Can we please end the argument, land the fix (this revert) for 6.5 and >> work on the solution for 6.6 or 6.7? > > I would much prefer a solution which does not break my existing use > case. It is still not even clear whether the problem really is on MX8M > side at all, or whether it is QCOM misinterpreting flags. I cannot debug > the later, since I have no access to that platform, nor its documentation. You can get the RB1 for $199 and check the DSI behaviour on that platform. It has newer bridge, but the DSI controller is (mostly) the same.
On Wed, Aug 02, 2023 at 09:49:42PM +0300, Dmitry Baryshkov wrote: > On 02/08/2023 21:45, Marek Vasut wrote: > > On 8/2/23 20:16, Dmitry Baryshkov wrote: > >> On Wed, 2 Aug 2023 at 20:34, Marek Vasut wrote: > >>> On 8/2/23 15:38, Dmitry Baryshkov wrote: > >>>> On 02/08/2023 11:52, Neil Armstrong wrote: > >>>>> This reverts commit [1] to fix display regression on the > >>>>> Dragonboard 845c > >>>>> (SDM845) devboard. > >>>>> > >>>>> There's a mismatch on the real action of the following flags: > >>>>> - MIPI_DSI_MODE_VIDEO_NO_HSA > >>>>> - MIPI_DSI_MODE_VIDEO_NO_HFP > >>>>> - MIPI_DSI_MODE_VIDEO_NO_HBP > >>>>> which leads to a non-working display on qcom platforms. > >>>>> > >>>>> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and > >>>>> EOT packet") > >>>>> > >>>>> Cc: Marek Vasut <marex@denx.de> > >>>>> Cc: Robert Foss <rfoss@kernel.org> > >>>>> Cc: Jagan Teki <jagan@amarulasolutions.com> > >>>>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > >>>>> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > >>>>> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA > >>>>> and EOT packet") > >>>>> Reported-by: Amit Pundir <amit.pundir@linaro.org> > >>>>> Link: > >>>>> https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ > >>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > >>>>> --- > >>>>> drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +--- > >>>>> 1 file changed, 1 insertion(+), 3 deletions(-) > >>>>> > >>>> Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> #fix db845c > >>>> > >>>> The boards broken by [1] are used in production by different parties > >>>> since 5.10, breaking them doesn't seem more acceptable than breaking the > >>>> new out-of-tree iMX8m hardware. > >>> > >>> The MX8M is also in-tree, so this does not apply. > >> > >> v6.5-rc4: > >> > >> $ git grep lontium,lt9611 | grep -v 9611uxc > >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml:$id: > >> http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# > >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: > >> - lontium,lt9611 > >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: > >> compatible = "lontium,lt9611"; > >> arch/arm64/boot/dts/qcom/sdm845-db845c.dts: compatible = "lontium,lt9611"; > >> drivers/gpu/drm/bridge/lontium-lt9611.c: { "lontium,lt9611", 0 }, > >> drivers/gpu/drm/bridge/lontium-lt9611.c: { .compatible = "lontium,lt9611" }, > >> > >> next-20230802: > >> > >> $ git grep lontium,lt9611 | grep -v 9611uxc > >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml:$id: > >> http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# > >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: > >> - lontium,lt9611 > >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: > >> compatible = "lontium,lt9611"; > >> arch/arm64/boot/dts/qcom/sdm845-db845c.dts: compatible = "lontium,lt9611"; > >> drivers/gpu/drm/bridge/lontium-lt9611.c: { "lontium,lt9611", 0 }, > >> drivers/gpu/drm/bridge/lontium-lt9611.c: { .compatible = "lontium,lt9611" }, > >> > >> Your device is not in the tree. Your commit broke existing users. > > > > These devices are in tree: > > arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts > > arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts > > > > The LT9211 and LT9611 are both expansion modules handled by DTOs and > > bound to the DSIM (which is also in tree). > > And they DT for them is not in the tree, that was my point. You have > broken the existing user for the DTBO that is not present even in > linux-next. > > >> Can we please end the argument, land the fix (this revert) for 6.5 and > >> work on the solution for 6.6 or 6.7? > > > > I would much prefer a solution which does not break my existing use > > case. It is still not even clear whether the problem really is on MX8M > > side at all, or whether it is QCOM misinterpreting flags. I cannot debug > > the later, since I have no access to that platform, nor its documentation. > > You can get the RB1 for $199 and check the DSI behaviour on that > platform. It has newer bridge, but the DSI controller is (mostly) the same. Could everybody please get away from the keyboard for a few hours, take a deep breath, and resume the discussion in a less aggressive and more constructive way ? Without judging the technical merits of the arguments, and which platform gets it wrong, the commit being reverted landed in v6.5-rc1, and breaks in-tree users. Reverting and retrying thus seems the usual practice to me, as we are getting too close to the v6.5 release to ensure a correct fix can be developed and merged in time. This will not cause a regression on i.MX8M, as the commit has never appeared in a release kernel. This is however an unfortunate event. It is not a nice feeling to work on enabling features for a platform and see the work being reverted at the last minute. Neil, Dmitry, could you please help Marek figuring out a good solution for v6.6 ? I don't think it's reasonable to ask him to buy an RB1 and investigate the MSM side, when Linaro has access to hardware and support.
On 8/2/23 20:49, Rob Clark wrote: > On Wed, Aug 2, 2023 at 11:16 AM Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: >> >> On Wed, 2 Aug 2023 at 20:34, Marek Vasut <marex@denx.de> wrote: >>> >>> On 8/2/23 15:38, Dmitry Baryshkov wrote: >>>> On 02/08/2023 11:52, Neil Armstrong wrote: >>>>> This reverts commit [1] to fix display regression on the Dragonboard 845c >>>>> (SDM845) devboard. >>>>> >>>>> There's a mismatch on the real action of the following flags: >>>>> - MIPI_DSI_MODE_VIDEO_NO_HSA >>>>> - MIPI_DSI_MODE_VIDEO_NO_HFP >>>>> - MIPI_DSI_MODE_VIDEO_NO_HBP >>>>> which leads to a non-working display on qcom platforms. >>>>> >>>>> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and >>>>> EOT packet") >>>>> >>>>> Cc: Marek Vasut <marex@denx.de> >>>>> Cc: Robert Foss <rfoss@kernel.org> >>>>> Cc: Jagan Teki <jagan@amarulasolutions.com> >>>>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>>>> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >>>>> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA >>>>> and EOT packet") >>>>> Reported-by: Amit Pundir <amit.pundir@linaro.org> >>>>> Link: >>>>> https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ >>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >>>>> --- >>>>> drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +--- >>>>> 1 file changed, 1 insertion(+), 3 deletions(-) >>>>> >>>> Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> #fix db845c >>>> >>>> The boards broken by [1] are used in production by different parties >>>> since 5.10, breaking them doesn't seem more acceptable than breaking the >>>> new out-of-tree iMX8m hardware. >>> >>> The MX8M is also in-tree, so this does not apply. >> >> v6.5-rc4: >> >> $ git grep lontium,lt9611 | grep -v 9611uxc >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml:$id: >> http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: >> - lontium,lt9611 >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: >> compatible = "lontium,lt9611"; >> arch/arm64/boot/dts/qcom/sdm845-db845c.dts: compatible = "lontium,lt9611"; >> drivers/gpu/drm/bridge/lontium-lt9611.c: { "lontium,lt9611", 0 }, >> drivers/gpu/drm/bridge/lontium-lt9611.c: { .compatible = "lontium,lt9611" }, >> >> next-20230802: >> >> $ git grep lontium,lt9611 | grep -v 9611uxc >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml:$id: >> http://devicetree.org/schemas/display/bridge/lontium,lt9611.yaml# >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: >> - lontium,lt9611 >> Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml: >> compatible = "lontium,lt9611"; >> arch/arm64/boot/dts/qcom/sdm845-db845c.dts: compatible = "lontium,lt9611"; >> drivers/gpu/drm/bridge/lontium-lt9611.c: { "lontium,lt9611", 0 }, >> drivers/gpu/drm/bridge/lontium-lt9611.c: { .compatible = "lontium,lt9611" }, >> >> Your device is not in the tree. Your commit broke existing users. >> >> Can we please end the argument, land the fix (this revert) for 6.5 and >> work on the solution for 6.6 or 6.7? >> > > Even if they were in-tree, breaking existing hw means revert and > try-again. Especially as we get into later -rc's Then just apply the revert, I don't have time to debug this right this moment, and it is anyway meaningless until I can look at the bus with DSI bus analyzer.
On 02/08/2023 11:08, Dmitry Baryshkov wrote: > On Wed, 2 Aug 2023 at 11:52, Neil Armstrong <neil.armstrong@linaro.org> wrote: >> >> This reverts commit [1] to fix display regression on the Dragonboard 845c >> (SDM845) devboard. >> >> There's a mismatch on the real action of the following flags: >> - MIPI_DSI_MODE_VIDEO_NO_HSA >> - MIPI_DSI_MODE_VIDEO_NO_HFP >> - MIPI_DSI_MODE_VIDEO_NO_HBP >> which leads to a non-working display on qcom platforms. >> >> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") > > Nit: I think the preferred form is to write `... reverts commit abcdef > ("foo and bar")', but I might be wrong. Yep, I'll fix all that while applying. Thanks, Neil > > Other than that: > > Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > >> >> Cc: Marek Vasut <marex@denx.de> >> Cc: Robert Foss <rfoss@kernel.org> >> Cc: Jagan Teki <jagan@amarulasolutions.com> >> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet") >> Reported-by: Amit Pundir <amit.pundir@linaro.org> >> Link: https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/ >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c >> index 5163e5224aad..9663601ce098 100644 >> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c >> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c >> @@ -774,9 +774,7 @@ static struct mipi_dsi_device *lt9611_attach_dsi(struct lt9611 *lt9611, >> dsi->lanes = 4; >> dsi->format = MIPI_DSI_FMT_RGB888; >> dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | >> - MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO_NO_HSA | >> - MIPI_DSI_MODE_VIDEO_NO_HFP | MIPI_DSI_MODE_VIDEO_NO_HBP | >> - MIPI_DSI_MODE_NO_EOT_PACKET; >> + MIPI_DSI_MODE_VIDEO_HSE; >> >> ret = devm_mipi_dsi_attach(dev, dsi); >> if (ret < 0) { >> >> --- >> base-commit: f590814603bf2dd8620584b7d59ae94d7c186c69 >> change-id: 20230802-revert-do-not-generate-hfp-hbp-hsa-eot-packet-6f042b1ba813 >> >> Best regards, >> -- >> Neil Armstrong <neil.armstrong@linaro.org> >> > >
Hi Marek, On 03/08/2023 20:10, Marek Vasut wrote: > On 8/2/23 20:49, Rob Clark wrote: >> On Wed, Aug 2, 2023 at 11:16 AM Dmitry Baryshkov >> <dmitry.baryshkov@linaro.org> wrote: >>> <snip> >>> >>> Can we please end the argument, land the fix (this revert) for 6.5 and >>> work on the solution for 6.6 or 6.7? >>> >> >> Even if they were in-tree, breaking existing hw means revert and >> try-again. Especially as we get into later -rc's > > Then just apply the revert, I don't have time to debug this right this moment, and it is anyway meaningless until I can look at the bus with DSI bus analyzer. I'm applying it, then I'll like to find an explanation when you'll be able to run the DSI bus analyzer. I'll be able to test for regressions on the db845c board if you require, just ping me on irc. We should clearly define those flags actions and probably add new flags to reflect the way the qcom dsi controller acts. Thanks, Neil
Hi, On Wed, 02 Aug 2023 10:52:22 +0200, Neil Armstrong wrote: > This reverts commit [1] to fix display regression on the Dragonboard 845c > (SDM845) devboard. > > There's a mismatch on the real action of the following flags: > - MIPI_DSI_MODE_VIDEO_NO_HSA > - MIPI_DSI_MODE_VIDEO_NO_HFP > - MIPI_DSI_MODE_VIDEO_NO_HBP > which leads to a non-working display on qcom platforms. > > [...] Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes) [1/1] Revert "drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet" https://cgit.freedesktop.org/drm/drm-misc/commit/?id=3c6bd1b7e2043fb00ce6b622709d176609431406
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c index 5163e5224aad..9663601ce098 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c @@ -774,9 +774,7 @@ static struct mipi_dsi_device *lt9611_attach_dsi(struct lt9611 *lt9611, dsi->lanes = 4; dsi->format = MIPI_DSI_FMT_RGB888; dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | - MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO_NO_HSA | - MIPI_DSI_MODE_VIDEO_NO_HFP | MIPI_DSI_MODE_VIDEO_NO_HBP | - MIPI_DSI_MODE_NO_EOT_PACKET; + MIPI_DSI_MODE_VIDEO_HSE; ret = devm_mipi_dsi_attach(dev, dsi); if (ret < 0) {