Message ID | 20230801143204.2284343-11-shikemeng@huaweicloud.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp2481220vqg; Mon, 31 Jul 2023 23:40:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlHKg1pA+JNCU4UJlHAsgu8L4fAjHX9Q99M1fm3/ZOgSTraqQmN8CTX7ExZnMgUu5zadRQFJ X-Received: by 2002:a05:6a00:1304:b0:682:3186:55e0 with SMTP id j4-20020a056a00130400b00682318655e0mr10913437pfu.12.1690872023514; Mon, 31 Jul 2023 23:40:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690872023; cv=none; d=google.com; s=arc-20160816; b=FaO8/MX1yyEIW+HdeXESRyHvvrqEpE1XjL9nbSzognuriDNTk383Ywqr3I94w7fisp g2pnEIGzTIv3FW0I3GvkhhOZ9fO5ToLZwb0O7w9yVE4nHa4rKGJ/2+kDrsJa1O0+fCqR RlziKw+p73guJvTZJvl4nw2sqGUbIncMTszMzfupfY/dfwq2EnlC/qf9o9pNthYpB0md 4foYCb4vdr700dJz4cnPjEokWk+YqTwc43offcyd9uQ1NGz0LPfQRNY9hCkSyCnbi5s3 nuQRRhUYHOzFJSzwTYhDb68iRjcJ7HTvknlxrvhH9pS5Tmp6LLr0/EcY13zPaEz9kzr0 QLTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=tpaHwQY83vYOzlmovxROlP+8b6IYsKALppd2NSSihcs=; fh=MlGqaUnvBjpXmiP990bdf+mzv9VjPrVaE5OVdv29XYE=; b=jm/neHzRqDPH8eoqpQbS2qOXYB63ghx044pdRUHvRtqFt67//meBkIM2XYUEUtkZ9u QlzI5lnQUoR7uOrV1lcV6uFA9T5S4OWGl7guBL1X28N96/z1ZRp+ACaQdoEqoPDNsp0E BF9JkfwE/0+Fb8DUXLh1J0LoVunCcDNo8xi+/y7cyRoLIzDMXN/TJUYuszTNUwxcgddV 4jU+nhfOIFfbGYDsPZOj/1uPU2yObr76xkx8SPmaHYvHm0XOpB/X5RB0ZlO8trLEyucC 5pQLdrN+mc0/1QOUkKpFiXvqFh3u8qJc3MAoBEXqcxnDZRTHDQTtbtNtrykZk4ega6l0 Ah6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x63-20020a638642000000b005636ef310adsi8180573pgd.597.2023.07.31.23.40.10; Mon, 31 Jul 2023 23:40:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231786AbjHAGca (ORCPT <rfc822;maxi.paulin@gmail.com> + 99 others); Tue, 1 Aug 2023 02:32:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231510AbjHAGbz (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 1 Aug 2023 02:31:55 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D95B114; Mon, 31 Jul 2023 23:31:53 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RFQHp5Ds2z4f3m7p; Tue, 1 Aug 2023 14:31:50 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP2 (Coremail) with SMTP id Syh0CgDnjOrQpshkMcvqPA--.21719S12; Tue, 01 Aug 2023 14:31:51 +0800 (CST) From: Kemeng Shi <shikemeng@huaweicloud.com> To: tytso@mit.edu, adilger.kernel@dilger.ca, ritesh.list@gmail.com, ojaswin@linux.ibm.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Cc: shikemeng@huaweicloud.com Subject: [PATCH v3 10/10] ext4: correct some stale comment of criteria Date: Tue, 1 Aug 2023 22:32:04 +0800 Message-Id: <20230801143204.2284343-11-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230801143204.2284343-1-shikemeng@huaweicloud.com> References: <20230801143204.2284343-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: Syh0CgDnjOrQpshkMcvqPA--.21719S12 X-Coremail-Antispam: 1UD129KBjvJXoWrury8Xr1rGrW5tF1DXr15XFb_yoW8JF17pr 1aka4xGF1fXr15ua1Du3WkWw4DGa1fWFyUur9Yvr4FvFy7JFyfuFWDt3Z5ZFy8Zrs3X3WY yrZ8ZFWUGa1Uu37anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUPF14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2jI8I6cxK62vIxIIY0VWUZVW8XwA2048vs2IY02 0E87I2jVAFwI0_JF0E3s1l82xGYIkIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0 rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6x IIjxv20xvEc7CjxVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK 6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4 xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8 JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20V AGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r4j6ryUMIIF0xvE2Ix0cI8IcVCY1x0267AK xVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJbIYCTnIWIevJa73UjIFyTuYvjTRKfOw UUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773007822804590426 X-GMAIL-MSGID: 1773007822804590426 |
Series |
A few fixes and cleanups to mballoc
|
|
Commit Message
Kemeng Shi
Aug. 1, 2023, 2:32 p.m. UTC
We named criteria with CR_XXX, correct stale comment to criteria with
raw number.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
fs/ext4/mballoc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Comments
Kemeng Shi <shikemeng@huaweicloud.com> writes: > We named criteria with CR_XXX, correct stale comment to criteria with > raw number. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> > --- > fs/ext4/mballoc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index bfaab173a3f4..1e8ce0ece47a 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -2782,8 +2782,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac) > > /* > * ac->ac_2order is set only if the fe_len is a power of 2 > - * if ac->ac_2order is set we also set criteria to 0 so that we > - * try exact allocation using buddy. > + * if ac->ac_2order is set we also set criteria to CR_POWER2_ALIGNED > + * so that we try exact allocation using buddy. > */ > i = fls(ac->ac_g_ex.fe_len); > ac->ac_2order = 0; > @@ -2840,8 +2840,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac) > /* > * Batch reads of the block allocation bitmaps > * to get multiple READs in flight; limit > - * prefetching at cr=0/1, otherwise mballoc can > - * spend a lot of time loading imperfect groups > + * prefetching at inexpensive CR, otherwise mballoc > + * can spend a lot of time loading imperfect groups > */ > if ((prefetch_grp == group) && > (ext4_mb_cr_expensive(cr) || Is this function defined at any place ^^^ -ritesh
Ritesh Harjani (IBM) <ritesh.list@gmail.com> writes: > Kemeng Shi <shikemeng@huaweicloud.com> writes: > >> We named criteria with CR_XXX, correct stale comment to criteria with >> raw number. >> >> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> >> --- >> fs/ext4/mballoc.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c >> index bfaab173a3f4..1e8ce0ece47a 100644 >> --- a/fs/ext4/mballoc.c >> +++ b/fs/ext4/mballoc.c >> @@ -2782,8 +2782,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac) >> >> /* >> * ac->ac_2order is set only if the fe_len is a power of 2 >> - * if ac->ac_2order is set we also set criteria to 0 so that we >> - * try exact allocation using buddy. >> + * if ac->ac_2order is set we also set criteria to CR_POWER2_ALIGNED >> + * so that we try exact allocation using buddy. >> */ >> i = fls(ac->ac_g_ex.fe_len); >> ac->ac_2order = 0; >> @@ -2840,8 +2840,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac) >> /* >> * Batch reads of the block allocation bitmaps >> * to get multiple READs in flight; limit >> - * prefetching at cr=0/1, otherwise mballoc can >> - * spend a lot of time loading imperfect groups >> + * prefetching at inexpensive CR, otherwise mballoc >> + * can spend a lot of time loading imperfect groups >> */ >> if ((prefetch_grp == group) && >> (ext4_mb_cr_expensive(cr) || > Is this function defined at any place ^^^ aah ok got it. Here [1] ...which you have also mentioned in your cover letetr. So your patch series currently is depenedent of above patch [1] [1]: https://lore.kernel.org/linux-ext4/20230630085927.140137-1-ojaswin@linux.ibm.com/ Feel free to add - Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com> > > -ritesh
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index bfaab173a3f4..1e8ce0ece47a 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -2782,8 +2782,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac) /* * ac->ac_2order is set only if the fe_len is a power of 2 - * if ac->ac_2order is set we also set criteria to 0 so that we - * try exact allocation using buddy. + * if ac->ac_2order is set we also set criteria to CR_POWER2_ALIGNED + * so that we try exact allocation using buddy. */ i = fls(ac->ac_g_ex.fe_len); ac->ac_2order = 0; @@ -2840,8 +2840,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac) /* * Batch reads of the block allocation bitmaps * to get multiple READs in flight; limit - * prefetching at cr=0/1, otherwise mballoc can - * spend a lot of time loading imperfect groups + * prefetching at inexpensive CR, otherwise mballoc + * can spend a lot of time loading imperfect groups */ if ((prefetch_grp == group) && (ext4_mb_cr_expensive(cr) ||