Message ID | 20230207114456.2304801-1-usama.arif@bytedance.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2801304wrn; Tue, 7 Feb 2023 03:47:16 -0800 (PST) X-Google-Smtp-Source: AK7set+Ac6W9g3XdK4KonHyxpw0EM8IR4IqJKyMG8QzGL3CjS/OSumTLW8Hfc3F0BpXbY/VOxnnw X-Received: by 2002:a17:90a:1a10:b0:230:bb46:787d with SMTP id 16-20020a17090a1a1000b00230bb46787dmr3642408pjk.37.1675770436600; Tue, 07 Feb 2023 03:47:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675770436; cv=none; d=google.com; s=arc-20160816; b=Hox4sXqp7DCauZ7y2C1Vacikk80UmsXnaxmOIyipUZLIRImTHQfGEOoQY0a0k+MAPD RMCZGU/yQ4y/FRkhbXL5KjOBi0ZDapH0mrNBHUlNtVA1NxMMF4ekteiq+w3a1KB71RHY FW4N0ByIsrEmEZq9i7zxuJCVDfpGdMlToSby7RnIbclRpN4iBZxWk6ksGKCPzI8GekQh LYszL+twNpM4E8j5y6TRzKCGo+KD/oAp9IKI8upENO10G33U2YJkAjFRq3hwnY69m9fA V9iht1V/8q3kuJNNRTG+KgvyS4q9qYtm4i2gFeb5XbmHU4dFQBfdk/vwFpFaYCAS29P3 mybA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=mVX+TpCcMgKWMfF13P/1xSiJxqs3IaOghijzEHBL02Q=; b=hSCFa/vYlZWFjgnrztLkz2vhZ0UNNKM8LWlERZPa3p94U2kAgoKBet77KXKewSnI2S ZOs9u+Ksp82eB9XsYqjM+jGovYrz6xqzLGBceHCnZmAwKyXaKsvRlo6YAEeIBtuv+jD8 uCrYuhOQjFRCKRCntU2eWl7fxpyQC0xp6geuAJYChHoO1bl+VyO/Wpp73v5dQJbvuCtF 9cAacVzAJC0K2mA6CiuqBSCmRoYz970LcwSkIBwufMiZT2xQFS3I4Gk/On+ivfeJyWMw 9yfj833enf8YkMHOeeM/NpINOIExE+cQzEUDYsL/Hv+eq7tJ/j2gFMXRbXSVjQ+W56Ho Z5Fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=fYH4Tu1P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lr18-20020a17090b4b9200b00228e974632csi16016333pjb.180.2023.02.07.03.47.04; Tue, 07 Feb 2023 03:47:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=fYH4Tu1P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231202AbjBGLpF (ORCPT <rfc822;kmanaouilinux@gmail.com> + 99 others); Tue, 7 Feb 2023 06:45:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230361AbjBGLpC (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 7 Feb 2023 06:45:02 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C2FB30F1 for <linux-kernel@vger.kernel.org>; Tue, 7 Feb 2023 03:45:01 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id d14so13252820wrr.9 for <linux-kernel@vger.kernel.org>; Tue, 07 Feb 2023 03:45:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mVX+TpCcMgKWMfF13P/1xSiJxqs3IaOghijzEHBL02Q=; b=fYH4Tu1PRIpBrT723Ad22c6A/AvDvTrQ4qKhcvZB4vpnDMvYvOQC4xqK+a/6WCT167 B8G93OOLfOH1XHpy/fII60QMD5Z052LjibbHbFHZxBsZ2AslzyBfZKaj1Sbg3NptXb1A MDy4ECTuUHzbpTnOOYkno6p4U0wB6I6gMjCpkyXW9MPL3nFxBPJ9l1McIpE0PgKmrAYA qXYRjQXvUBA87LrOu1+vI0ePubeSDvjBgXYW6dTUoSYtb4a7qJLdCc1EYKHiMhCcOFXI kah8nXhEMPS2vw0A5t07Cyo5NbCSGD0tgYgwZhSCZTw/ldha2ENB1pW3N5ARKrL7AkX1 da+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mVX+TpCcMgKWMfF13P/1xSiJxqs3IaOghijzEHBL02Q=; b=ErfkVoOkWLaWdDEyGm0EOetw+cLm02sz7LZVXKwHhZ21e7lZJvY6lWAptr32h5bLkG NMYSteMxDXNhGaqHqTBIdQ/6NeLlKLfBhg9bMrG8Av4Mkl/M2FmdbsfyVkVMFhNfWL60 pin1FuBjfRh1Qfyv0N3vIH9c4a+Uop5DbqIlX3F4ihBkiO0gheapxWvArmSD7hoovNwX HW5VZBNJj/XtKtWIFeyJT7x1M7id+aGLZHbuK4R2hG7ONBn1kYWneoe0IOa2LF3Dbru+ /wf0yrbJYyTroi64LaFUhqF26PKbtn9TpLHEta9v0vsw+bxoPmc77CN2/1trQbQJ3b6z tabw== X-Gm-Message-State: AO0yUKW7X3u5oq+2QzP6Xtk70aBgW4Omq1VXgQWr+pmZJQiVgzX7mt0g RrCIhPL4pZm3qZY0cQwbjcR7Iw== X-Received: by 2002:a05:6000:4d:b0:2bf:b506:e0eb with SMTP id k13-20020a056000004d00b002bfb506e0ebmr2026077wrx.51.1675770299988; Tue, 07 Feb 2023 03:44:59 -0800 (PST) Received: from usaari01.cust.communityfibre.co.uk ([2a02:6b6a:b566:0:c04f:2463:c151:8b87]) by smtp.gmail.com with ESMTPSA id i14-20020a0560001ace00b002bfb8f829eesm11726612wry.71.2023.02.07.03.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 03:44:59 -0800 (PST) From: Usama Arif <usama.arif@bytedance.com> To: songmuchun@bytedance.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, fam.zheng@bytedance.com, liangma@liangbit.com, Usama Arif <usama.arif@bytedance.com> Subject: [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB Date: Tue, 7 Feb 2023 11:44:56 +0000 Message-Id: <20230207114456.2304801-1-usama.arif@bytedance.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757172661206304313?= X-GMAIL-MSGID: =?utf-8?q?1757172661206304313?= |
Series |
docs: mm: Fix number of base pages for 1GB HugeTLB
|
|
Commit Message
Usama Arif
Feb. 7, 2023, 11:44 a.m. UTC
1GB HugeTLB page consists of 262144 base pages.
Signed-off-by: Usama Arif <usama.arif@bytedance.com>
---
Documentation/mm/vmemmap_dedup.rst | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Tue, Feb 7, 2023 at 7:45 PM Usama Arif <usama.arif@bytedance.com> wrote: > > 1GB HugeTLB page consists of 262144 base pages. > > Signed-off-by: Usama Arif <usama.arif@bytedance.com> Thanks for your fix. Acked-by: Muchun Song <songmuchun@bytedance.com>
On Tue, Feb 07, 2023 at 11:44:56AM +0000, Usama Arif wrote: > 1GB HugeTLB page consists of 262144 base pages. > > Signed-off-by: Usama Arif <usama.arif@bytedance.com> Acked-by: Mike Rapoport (IBM) <rppt@kernel.org> > --- > Documentation/mm/vmemmap_dedup.rst | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst > index a4b12ff906c4..689a6907c70b 100644 > --- a/Documentation/mm/vmemmap_dedup.rst > +++ b/Documentation/mm/vmemmap_dedup.rst > @@ -1,3 +1,4 @@ > + > .. SPDX-License-Identifier: GPL-2.0 > > ========================================= > @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many > architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more > details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are > currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page > -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages. > +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages. > For each base page, there is a corresponding ``struct page``. > > Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to > -- > 2.25.1 >
On 08/02/2023 09:51, Mike Rapoport wrote: > On Tue, Feb 07, 2023 at 11:44:56AM +0000, Usama Arif wrote: >> 1GB HugeTLB page consists of 262144 base pages. >> >> Signed-off-by: Usama Arif <usama.arif@bytedance.com> > > Acked-by: Mike Rapoport (IBM) <rppt@kernel.org> > >> --- >> Documentation/mm/vmemmap_dedup.rst | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst >> index a4b12ff906c4..689a6907c70b 100644 >> --- a/Documentation/mm/vmemmap_dedup.rst >> +++ b/Documentation/mm/vmemmap_dedup.rst >> @@ -1,3 +1,4 @@ >> + >> .. SPDX-License-Identifier: GPL-2.0 >> >> ========================================= >> @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many >> architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more >> details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are >> currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page >> -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages. >> +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages. >> For each base page, there is a corresponding ``struct page``. >> >> Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to >> -- >> 2.25.1 >> > Hi, Was just reading vmemmap_dedup.rst for something and realized that its still 4096 pages for 1G, maybe this patch got missed? Thanks, Usama
(adding Jon) On Mon, Jul 24, 2023 at 03:05:29PM +0100, Usama Arif wrote: > > > On 08/02/2023 09:51, Mike Rapoport wrote: > > On Tue, Feb 07, 2023 at 11:44:56AM +0000, Usama Arif wrote: > > > 1GB HugeTLB page consists of 262144 base pages. > > > > > > Signed-off-by: Usama Arif <usama.arif@bytedance.com> > > > > Acked-by: Mike Rapoport (IBM) <rppt@kernel.org> > > > > > --- > > > Documentation/mm/vmemmap_dedup.rst | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst > > > index a4b12ff906c4..689a6907c70b 100644 > > > --- a/Documentation/mm/vmemmap_dedup.rst > > > +++ b/Documentation/mm/vmemmap_dedup.rst > > > @@ -1,3 +1,4 @@ > > > + > > > .. SPDX-License-Identifier: GPL-2.0 > > > ========================================= > > > @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many > > > architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more > > > details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are > > > currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page > > > -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages. > > > +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages. > > > For each base page, there is a corresponding ``struct page``. > > > Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to > > > -- > > > 2.25.1 > > > > > > > Hi, > > Was just reading vmemmap_dedup.rst for something and realized that its still > 4096 pages for 1G, maybe this patch got missed? > > Thanks, > Usama
On 07.02.23 12:44, Usama Arif wrote: > 1GB HugeTLB page consists of 262144 base pages. > > Signed-off-by: Usama Arif <usama.arif@bytedance.com> > --- > Documentation/mm/vmemmap_dedup.rst | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst > index a4b12ff906c4..689a6907c70b 100644 > --- a/Documentation/mm/vmemmap_dedup.rst > +++ b/Documentation/mm/vmemmap_dedup.rst > @@ -1,3 +1,4 @@ > + > .. SPDX-License-Identifier: GPL-2.0 > > ========================================= > @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many > architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more > details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are > currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page > -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages. > +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages. > For each base page, there is a corresponding ``struct page``. > > Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to Reviewed-by: David Hildenbrand <david@redhat.com>
Mike Rapoport <rppt@kernel.org> writes: > (adding Jon) > > On Mon, Jul 24, 2023 at 03:05:29PM +0100, Usama Arif wrote: >> >> >> On 08/02/2023 09:51, Mike Rapoport wrote: >> > On Tue, Feb 07, 2023 at 11:44:56AM +0000, Usama Arif wrote: >> > > 1GB HugeTLB page consists of 262144 base pages. >> > > >> > > Signed-off-by: Usama Arif <usama.arif@bytedance.com> >> > >> > Acked-by: Mike Rapoport (IBM) <rppt@kernel.org> >> > >> > > --- >> > > Documentation/mm/vmemmap_dedup.rst | 3 ++- >> > > 1 file changed, 2 insertions(+), 1 deletion(-) >> > > >> > > diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst >> > > index a4b12ff906c4..689a6907c70b 100644 >> > > --- a/Documentation/mm/vmemmap_dedup.rst >> > > +++ b/Documentation/mm/vmemmap_dedup.rst >> > > @@ -1,3 +1,4 @@ >> > > + >> > > .. SPDX-License-Identifier: GPL-2.0 >> > > ========================================= >> > > @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many >> > > architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more >> > > details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are >> > > currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page >> > > -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages. >> > > +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages. >> > > For each base page, there is a corresponding ``struct page``. >> > > Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to >> > > -- >> > > 2.25.1 >> > > >> > >> >> Hi, >> >> Was just reading vmemmap_dedup.rst for something and realized that its still >> 4096 pages for 1G, maybe this patch got missed? Dug out of the archives and applied, thanks. jon
diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst index a4b12ff906c4..689a6907c70b 100644 --- a/Documentation/mm/vmemmap_dedup.rst +++ b/Documentation/mm/vmemmap_dedup.rst @@ -1,3 +1,4 @@ + .. SPDX-License-Identifier: GPL-2.0 ========================================= @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages. +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages. For each base page, there is a corresponding ``struct page``. Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to