Message ID | 20230730121047.43115-1-david@ixit.cz |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp1502545vqg; Sun, 30 Jul 2023 06:30:37 -0700 (PDT) X-Google-Smtp-Source: APBJJlGHyY6nUk5I32J2INpNLb7kY+d+u9NhMIZwjUQbhL+7iyEmX2IuZ4JSAY6yuPZvxJh6oqTq X-Received: by 2002:a17:907:2be0:b0:99b:bc52:8d2 with SMTP id gv32-20020a1709072be000b0099bbc5208d2mr3922067ejc.6.1690723836880; Sun, 30 Jul 2023 06:30:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690723836; cv=none; d=google.com; s=arc-20160816; b=ceSXkHvLS8E3vHJl4yqTl/0Yb3E7UYjLqLVav5i+mJFvKZvzzUC9vAwnXm3BuNk7aK K54VcVcBscIrsZ6ppv+PjeHCVFMm4+S1yak+UTo6LvQk4jTE2jFw2n/8maRwocU7VOzv 8ovNeOYmR7ZNuULwSpkIt5NoeO+HpZs05RH0pi6RZEDE+tGimpeNeWwcLVNrKe74uqmh G26Axou6x/nArI3+JSEAyJelmA3qVquQ3iTj2/01JodjcQkBKxilyCmpwNR90hLSPBpr qTDjUZcl/opFA3sCK8wsBU2hdV+TD7r1sJyJZHOaocqeIsFmWJR+59vxHD1MaY5SQQW2 KcMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=8xPO/h+VRMWWUdnfCzdT2GNLOOjMm+3WDZzPS6rqiDY=; fh=o3gMvfqLYIGSoLKaiL+c9njDu8QmVHTNTSf0J4pVrLA=; b=urmDtuzrBX+uRpl/bcIuo7UzRIUu5JofEIUONetGGD/jvzY9ig5hxa7l26m4/hsHAx 5II7YqPPKoj1hOhaSgOeu+UzDzkL22X9wopU92Q2uAsDe1OOB4gwycj2GVvUxTEbFZ/j 6AbLuPptXT3LDyfo0N5uOPbFuI2ltSpe9PWoKBke1pRGSs4Vba9MVe4rerXDbJsVN9Pt YkJkNwbPn36V70CbLJMKbf7HFzbm0EQj6lkeh/kQs6767JeH+CFtmU1zQjjYuMkdQ331 /eqxPXJS1BYNeNs7nZwjL0lozofezfQuqseifLEa59valALclUfTcdL9FkTRiivmCysb /RsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ixit.cz header.s=dkim header.b=yuke68O4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=ixit.cz Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u27-20020a1709063b9b00b0096633b5c0aesi1805774ejf.809.2023.07.30.06.30.09; Sun, 30 Jul 2023 06:30:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ixit.cz header.s=dkim header.b=yuke68O4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=ixit.cz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230043AbjG3MK5 (ORCPT <rfc822;dengxinlin2429@gmail.com> + 99 others); Sun, 30 Jul 2023 08:10:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjG3MK4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 30 Jul 2023 08:10:56 -0400 Received: from ixit.cz (ip-89-177-23-149.bb.vodafone.cz [89.177.23.149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE63510E3; Sun, 30 Jul 2023 05:10:54 -0700 (PDT) Received: from localhost.localdomain (fhswifi.lu.lv [5.179.19.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ixit.cz (Postfix) with ESMTPSA id C992F160057; Sun, 30 Jul 2023 14:10:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ixit.cz; s=dkim; t=1690719052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8xPO/h+VRMWWUdnfCzdT2GNLOOjMm+3WDZzPS6rqiDY=; b=yuke68O41Sz0uTySgOzG6labzf7hb8vdOhRXavKZ9941dYwAArzT/N8YyWZp++evnscZFA lRKUGnCj1WeZJbuQDpyBvaHuCvr7whQEIREPXP7dvmVMXS2mPyMoacVJFoewiQfJiE6GO/ 2xVjB0ieiJ+sEH74dvwhZiFOx+NHc9Q= From: David Heidelberg <david@ixit.cz> To: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, =?utf-8?q?Guido_G=C3=BCnther?= <agx@sigxcpu.org>, David Heidelberg <david@ixit.cz>, Peng Fan <peng.fan@nxp.com> Cc: kernel@puri.sm, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply Date: Sun, 30 Jul 2023 15:10:46 +0300 Message-Id: <20230730121047.43115-1-david@ixit.cz> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772852437810609353 X-GMAIL-MSGID: 1772852437810609353 |
Series |
arm64: dts: imx8mq-librem5-devkit: switch to vqmmc-supply
|
|
Commit Message
David Heidelberg
July 30, 2023, 12:10 p.m. UTC
Resolves following warning:
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected)
from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml#
Cc: kernel@puri.sm
Cc: Guido Günther <agx@sigxcpu.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi, On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote: > Resolves following warning: > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected) > from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml# > > Cc: kernel@puri.sm > Cc: Guido Günther <agx@sigxcpu.org> > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > index b3549eae6278..a8b5da3ca08f 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > @@ -1031,7 +1031,7 @@ &usdhc2 { > pinctrl-2 = <&pinctrl_usdhc2_200mhz>; > bus-width = <4>; > vmmc-supply = <®_usdhc2_vmmc>; > - power-supply = <&wifi_pwr_en>; > + vqmmc-supply = <&wifi_pwr_en>; From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE` so I don't think vqmmc is correct here. I wonder if there's a better way to model that in DT? Any suggestions would be welcome. Cheers, -- Guido > broken-cd; > disable-wp; > cap-sdio-irq; > -- > 2.40.1 >
Hello David, Hello Guido, On 31.07.23 13:32, Guido Günther wrote: > Hi, > On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote: >> Resolves following warning: >> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected) >> from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml# >> >> Cc: kernel@puri.sm >> Cc: Guido Günther <agx@sigxcpu.org> >> Signed-off-by: David Heidelberg <david@ixit.cz> >> --- >> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >> index b3549eae6278..a8b5da3ca08f 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >> @@ -1031,7 +1031,7 @@ &usdhc2 { >> pinctrl-2 = <&pinctrl_usdhc2_200mhz>; >> bus-width = <4>; >> vmmc-supply = <®_usdhc2_vmmc>; >> - power-supply = <&wifi_pwr_en>; >> + vqmmc-supply = <&wifi_pwr_en>; > > From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE` > so I don't think vqmmc is correct here. I wonder if there's a better way > to model that in DT? Any suggestions would be welcome. I think mmc-pwrseq is what you are after. Cheers, Ahmad > > Cheers, > -- Guido > >> broken-cd; >> disable-wp; >> cap-sdio-irq; >> -- >> 2.40.1 >> > >
On 31/07/2023 14:42, Ahmad Fatoum wrote: > Hello David, > Hello Guido, > > On 31.07.23 13:32, Guido Günther wrote: >> Hi, >> On Sun, Jul 30, 2023 at 03:10:46PM +0300, David Heidelberg wrote: >>> Resolves following warning: >>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected) >>> from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml# >>> >>> Cc: kernel@puri.sm >>> Cc: Guido Günther <agx@sigxcpu.org> >>> Signed-off-by: David Heidelberg <david@ixit.cz> >>> --- >>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >>> index b3549eae6278..a8b5da3ca08f 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >>> @@ -1031,7 +1031,7 @@ &usdhc2 { >>> pinctrl-2 = <&pinctrl_usdhc2_200mhz>; >>> bus-width = <4>; >>> vmmc-supply = <®_usdhc2_vmmc>; >>> - power-supply = <&wifi_pwr_en>; >>> + vqmmc-supply = <&wifi_pwr_en>; >> From the schematics WIFI_PWR_EN connects to the Wifi card's `W_DISABLE` >> so I don't think vqmmc is correct here. I wonder if there's a better way >> to model that in DT? Any suggestions would be welcome. > I think mmc-pwrseq is what you are after. Guido sent patch to replace it with `mmc-pwrseq` in https://www.spinics.net/lists/kernel/msg4894084.html
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts index b3549eae6278..a8b5da3ca08f 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts @@ -1031,7 +1031,7 @@ &usdhc2 { pinctrl-2 = <&pinctrl_usdhc2_200mhz>; bus-width = <4>; vmmc-supply = <®_usdhc2_vmmc>; - power-supply = <&wifi_pwr_en>; + vqmmc-supply = <&wifi_pwr_en>; broken-cd; disable-wp; cap-sdio-irq;