diff mbox series

[net-next] vsock: Remove unused function declarations

Message ID 20230729122036.32988-1-yuehaibing@huawei.com
State New
Headers
Series [net-next] vsock: Remove unused function declarations |

Commit Message

Yue Haibing July 29, 2023, 12:20 p.m. UTC 
  These are never implemented since introduction in
commit d021c344051a ("VSOCK: Introduce VM Sockets")

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 net/vmw_vsock/vmci_transport.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Simon Horman July 30, 2023, 5:27 p.m. UTC | #1 
On Sat, Jul 29, 2023 at 08:20:36PM +0800, Yue Haibing wrote:
> These are never implemented since introduction in
> commit d021c344051a ("VSOCK: Introduce VM Sockets")
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Reviewed-by: Simon Horman <horms@kernel.org>
Stefano Garzarella July 31, 2023, 9:55 a.m. UTC | #2 
On Sat, Jul 29, 2023 at 08:20:36PM +0800, Yue Haibing wrote:
>These are never implemented since introduction in
>commit d021c344051a ("VSOCK: Introduce VM Sockets")
>
>Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>---
> net/vmw_vsock/vmci_transport.h | 3 ---
> 1 file changed, 3 deletions(-)

Good catch ;-)

I'd used "vsock/vmci:" as a prefix in the title.

With or without:

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

>
>diff --git a/net/vmw_vsock/vmci_transport.h b/net/vmw_vsock/vmci_transport.h
>index b7b072194282..dbda3ababa14 100644
>--- a/net/vmw_vsock/vmci_transport.h
>+++ b/net/vmw_vsock/vmci_transport.h
>@@ -116,9 +116,6 @@ struct vmci_transport {
> 	spinlock_t lock; /* protects sk. */
> };
>
>-int vmci_transport_register(void);
>-void vmci_transport_unregister(void);
>-
> int vmci_transport_send_wrote_bh(struct sockaddr_vm *dst,
> 				 struct sockaddr_vm *src);
> int vmci_transport_send_read_bh(struct sockaddr_vm *dst,
>-- 
>2.34.1
>
>
patchwork-bot+netdevbpf@kernel.org July 31, 2023, 9:50 p.m. UTC | #3 
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 29 Jul 2023 20:20:36 +0800 you wrote:
> These are never implemented since introduction in
> commit d021c344051a ("VSOCK: Introduce VM Sockets")
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  net/vmw_vsock/vmci_transport.h | 3 ---
>  1 file changed, 3 deletions(-)

Here is the summary with links:
  - [net-next] vsock: Remove unused function declarations
    https://git.kernel.org/netdev/net-next/c/634e44971981

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/vmw_vsock/vmci_transport.h b/net/vmw_vsock/vmci_transport.h
index b7b072194282..dbda3ababa14 100644
--- a/net/vmw_vsock/vmci_transport.h
+++ b/net/vmw_vsock/vmci_transport.h
@@ -116,9 +116,6 @@  struct vmci_transport {
 	spinlock_t lock; /* protects sk. */
 };
 
-int vmci_transport_register(void);
-void vmci_transport_unregister(void);
-
 int vmci_transport_send_wrote_bh(struct sockaddr_vm *dst,
 				 struct sockaddr_vm *src);
 int vmci_transport_send_read_bh(struct sockaddr_vm *dst,