| Message ID | 20221110144448.wexu6neb67krqhla@device |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp200605wru;
Thu, 10 Nov 2022 07:08:04 -0800 (PST)
X-Google-Smtp-Source:
AMsMyM7SOZQ4QdfKDqeIb8tMPK5YQtkS0IExeJz4FYLed6Aze8XPDs00WAoQNwDLWPJbE60ZXyka
X-Received: by 2002:a17:906:c45:b0:7ae:21bc:3256 with SMTP id
t5-20020a1709060c4500b007ae21bc3256mr2705542ejf.313.1668092884098;
Thu, 10 Nov 2022 07:08:04 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1668092884; cv=none;
d=google.com; s=arc-20160816;
b=cBxe8sovCLL2QQ1bWBxO4d2nJatABtXVjO/d0/OjMPM+QhJn1oZIX7j57992eDGVrC
7N847V/v0pfbelS2j6p/M+hzmssa9vMk902KVZZOGM9nUzQQDZgOnOKVLRebIg1xSr3T
JU84OM+SWwP0MWmuoJ9uWWE9BJvnhwvsf9FyEhzkpKxw0Ljk9nf+hT1jKjvTEZeffQxH
/zaESr5piEhbumB+yvTbMZhjV30BG8sfoFjafPxHeiODsZbJKI3w8PC3mwkJAUbQN/JC
U0fcnB1HXS6eEIEu/gm3a0pZNCSdt4CvkUuw+fuDejeBiHcJ1Ljba8fUTwATM9Yib21P
uwXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-disposition:mime-version:message-id
:subject:cc:to:from:date:dkim-signature;
bh=wQ9CRqRZOgn0JyTwO/ZP8X+FHVdLdYVJ+um7AReCvBI=;
b=fYCjKHBev9AijKCQ4aqyc64E/jckIe+JLw+SzVX3BUzrEBjSgSSPQr6dEZrXzuU+We
1OlYzrO6ur0k5o6/N6DKRjR152c/UvxvBn7cUfyW48QtKFVBk5z+M6fyyw1sNaVfKo3V
/zNB9b0ywovBWc8wUuoW5ojGB+9NCiQDTmfuWXhqMk6i4yw8de2UG0R2Nxa4ncp5VFvM
7mVEbTSN10sUy0aOwZ2KAT2bK91rzyscN6BGMW1RPCjrdABPasErczjccgV14hMHmP6p
9hfrk6cpnVTdEgwpARVX+GVYcgyGOyujxcpTCF53O/H8dwFpmoyeSgSL6YKBfBFHyqGo
n3zQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@pgazz.com header.s=mail header.b=RpGtRxzs;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pgazz.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
i6-20020a05640242c600b004599fc7f310si20664745edc.140.2022.11.10.07.07.37;
Thu, 10 Nov 2022 07:08:04 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@pgazz.com header.s=mail header.b=RpGtRxzs;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pgazz.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230387AbiKJOul (ORCPT <rfc822;winker.wchi@gmail.com>
+ 99 others); Thu, 10 Nov 2022 09:50:41 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40454 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230081AbiKJOuj (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 10 Nov 2022 09:50:39 -0500
X-Greylist: delayed 347 seconds by postgrey-1.37 at lindbergh.monkeyblade.net;
Thu, 10 Nov 2022 06:50:38 PST
Received: from box.opentheblackbox.net (box.opentheblackbox.net
[IPv6:2600:3c02::f03c:92ff:fee2:82bc])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2522FFAD7;
Thu, 10 Nov 2022 06:50:38 -0800 (PST)
Received: from authenticated-user (box.opentheblackbox.net [172.105.151.37])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
(No client certificate requested)
by box.opentheblackbox.net (Postfix) with ESMTPSA id DC99C3FA28;
Thu, 10 Nov 2022 09:44:49 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pgazz.com; s=mail;
t=1668091490; bh=fQdau5QS7mf10RLv3bPTZ0/QHvF1wJc9X2hCGYwzcvk=;
h=Date:From:To:Cc:Subject:From;
b=RpGtRxzsgkYxic0iBon465gLp0z5Gr9xa/hUV9flV8XuK07ERNxQca6JHimvNoz6L
4VbkSEQYqy3+39PofPqzZ970+HgxGuAMdTrWQO38eg1Qieil+FOKIQR3BovmX550N8
1OTQFzVxp4CXFnJof3wJYto88F7QnM/ZnMFZrAcodRaMAl+aW6sTPtzATc9EKGQ/jJ
orADq1NOv07VrnvRqwBWdxCZmLSnWlGoLsLqxWbe2D+uEjsy37tRrAkeKPcPAhf9Dk
iG/r8Zfk1K2F22iwBsfsQNdVliM0snQLGq5neSI+VvJzRej/8c3xVhstqBL9kXoeWk
i/CXA7tfquv4g==
Date: Thu, 10 Nov 2022 09:44:48 -0500
From: Paul Gazzillo <paul@pgazz.com>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Shreeya Patel <shreeya.patel@collabora.com>,
Zhigang Shi <Zhigang.Shi@liteon.com>,
Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 1/1]: iio: light: rpr0521: add missing Kconfig dependencies
Message-ID: <20221110144448.wexu6neb67krqhla@device>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_SBL_CSS,RCVD_IN_XBL,
SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1749122164183680419?=
X-GMAIL-MSGID: =?utf-8?q?1749122164183680419?=
|
| Series |
[v1,1/1] : iio: light: rpr0521: add missing Kconfig dependencies
|
|
Commit Message
Paul Gazzillo
Nov. 10, 2022, 2:44 p.m. UTC
Steps to reproduce (v6.1-rc2, x86_64):
1. make defconfig menuconfig
2. Enable the driver:
-> Device Drivers
-> Industrial I/O support (IIO [=y])
-> Light sensors
-> ROHM RPR0521 ALS and proximity sensor driver
3. make drivers/iio/light/rpr0521.o
Causes "implicit declaration of function" errors, e.g.,
CC drivers/iio/light/rpr0521.o
drivers/iio/light/rpr0521.c: In function 'rpr0521_drdy_irq_thread':
drivers/iio/light/rpr0521.c:434:3: error: implicit declaration of function
'iio_trigger_poll_chained' [-Werror=implicit-function-declaration]
434 | iio_trigger_poll_chained(data->drdy_trigger0);
| ^~~~~~~~~~~~~~~~~~~~~~~~
(This bug was found with the help of a tool, krepair, that generates
configuration files for commits: https://github.com/paulgazz/kmax)
The following patch ensures that the code controlled by IIO_BUFFER and
IIO_TRIGGERED_BUFFER is available:
Reported-by: Paul Gazzillo <paul@pgazz.com>
---
drivers/iio/light/Kconfig | 2 ++
1 file changed, 2 insertions(+)
Comments
On Thu, Nov 10, 2022 at 09:44:48AM -0500, Paul Gazzillo wrote: > Steps to reproduce (v6.1-rc2, x86_64): > > 1. make defconfig menuconfig > 2. Enable the driver: > -> Device Drivers > -> Industrial I/O support (IIO [=y]) > -> Light sensors > -> ROHM RPR0521 ALS and proximity sensor driver > 3. make drivers/iio/light/rpr0521.o > > Causes "implicit declaration of function" errors, e.g., > CC drivers/iio/light/rpr0521.o > drivers/iio/light/rpr0521.c: In function 'rpr0521_drdy_irq_thread': These two lines can be removed. > drivers/iio/light/rpr0521.c:434:3: error: implicit declaration of function > 'iio_trigger_poll_chained' [-Werror=implicit-function-declaration] > 434 | iio_trigger_poll_chained(data->drdy_trigger0); > | ^~~~~~~~~~~~~~~~~~~~~~~~ > (This bug was found with the help of a tool, krepair, that generates > configuration files for commits: https://github.com/paulgazz/kmax) I'm not sure we need this in the commit message. Do we have a tag for the static analyzers? > The following patch ensures that the code controlled by IIO_BUFFER and > IIO_TRIGGERED_BUFFER is available: > Reported-by: Paul Gazzillo <paul@pgazz.com> Without SoB this may not be anyhow proceeded. Please, read Submitting Patches documentation and try again. (Btw, Reported-by above contradicts the commit message that refers to the tool, and not human)
On 11/10/2022, Andy Shevchenko wrote: > On Thu, Nov 10, 2022 at 09:44:48AM -0500, Paul Gazzillo wrote: > > > CC drivers/iio/light/rpr0521.o > > drivers/iio/light/rpr0521.c: In function 'rpr0521_drdy_irq_thread': > > These two lines can be removed. Will do. > > (This bug was found with the help of a tool, krepair, that generates > > configuration files for commits: https://github.com/paulgazz/kmax) > > I'm not sure we need this in the commit message. Do we have a tag for > the static analyzers? I'll also remove this. > > The following patch ensures that the code controlled by IIO_BUFFER and > > IIO_TRIGGERED_BUFFER is available: > > > Reported-by: Paul Gazzillo <paul@pgazz.com> > > Without SoB this may not be anyhow proceeded. Please, read Submitting Patches > documentation and try again. > > (Btw, Reported-by above contradicts the commit message that refers to the tool, > and not human) Apologies, I was confused about whether I or the maintainer fills that out. Will submit a new version with SoB. Thanks! Paul > > -- > With Best Regards, > Andy Shevchenko
diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig index 7cf6e8490123..0d4447df7200 100644 --- a/drivers/iio/light/Kconfig +++ b/drivers/iio/light/Kconfig @@ -293,6 +293,8 @@ config RPR0521 tristate "ROHM RPR0521 ALS and proximity sensor driver" depends on I2C select REGMAP_I2C + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say Y here if you want to build support for ROHM's RPR0521 ambient light and proximity sensor device.