regulator: qcom_smd: Fix PMR735a S3 regulator spec

Message ID 20221110121225.9216-1-konrad.dybcio@linaro.org
State New
Headers
Series regulator: qcom_smd: Fix PMR735a S3 regulator spec |

Commit Message

Konrad Dybcio Nov. 10, 2022, 12:12 p.m. UTC
  PMR735a has a wider range than previously defined. Fix it.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
No Fixes tag, as the patch is only in -next, so the hash will change.

 drivers/regulator/qcom_smd-regulator.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
  

Comments

Mark Brown Nov. 10, 2022, 12:31 p.m. UTC | #1
On Thu, Nov 10, 2022 at 01:12:25PM +0100, Konrad Dybcio wrote:
> PMR735a has a wider range than previously defined. Fix it.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> No Fixes tag, as the patch is only in -next, so the hash will change.

No, it won't.
  
Konrad Dybcio Nov. 10, 2022, 12:48 p.m. UTC | #2
On 10/11/2022 13:31, Mark Brown wrote:
> On Thu, Nov 10, 2022 at 01:12:25PM +0100, Konrad Dybcio wrote:
>> PMR735a has a wider range than previously defined. Fix it.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> No Fixes tag, as the patch is only in -next, so the hash will change.
> 
> No, it won't

Fixes: 0cda8c43aa24 ("regulator: qcom_smd: Add PMR735a regulators")

Konrad
  
Mark Brown Nov. 10, 2022, 3:18 p.m. UTC | #3
On Thu, 10 Nov 2022 13:12:25 +0100, Konrad Dybcio wrote:
> PMR735a has a wider range than previously defined. Fix it.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: qcom_smd: Fix PMR735a S3 regulator spec
      commit: 91016037216b3aaa0fa1b616d388053fb4202835

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
  

Patch

diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
index 9eaae13fd385..9f2b58458841 100644
--- a/drivers/regulator/qcom_smd-regulator.c
+++ b/drivers/regulator/qcom_smd-regulator.c
@@ -686,6 +686,15 @@  static const struct regulator_desc pmic5_ftsmps520 = {
 	.ops = &rpm_smps_ldo_ops,
 };
 
+static const struct regulator_desc pmic5_hfsmps515 = {
+	.linear_ranges = (struct linear_range[]) {
+		REGULATOR_LINEAR_RANGE(320000, 0, 235, 16000),
+	},
+	.n_linear_ranges = 1,
+	.n_voltages = 236,
+	.ops = &rpm_smps_ldo_ops,
+};
+
 static const struct regulator_desc pms405_hfsmps3 = {
 	.linear_ranges = (struct linear_range[]) {
 		REGULATOR_LINEAR_RANGE(320000, 0, 215, 8000),
@@ -1277,7 +1286,7 @@  static const struct rpm_regulator_data rpm_pmi8998_regulators[] = {
 static const struct rpm_regulator_data rpm_pmr735a_regulators[] = {
 	{ "s1", QCOM_SMD_RPM_SMPE, 1, &pmic5_ftsmps520, "vdd_s1"},
 	{ "s2", QCOM_SMD_RPM_SMPE, 2, &pmic5_ftsmps520, "vdd_s2"},
-	{ "s3", QCOM_SMD_RPM_SMPE, 3, &pms405_hfsmps3, "vdd_s3"},
+	{ "s3", QCOM_SMD_RPM_SMPE, 3, &pmic5_hfsmps515, "vdd_s3"},
 	{ "l1", QCOM_SMD_RPM_LDOE, 1, &pm660_nldo660, "vdd_l1_l2"},
 	{ "l2", QCOM_SMD_RPM_LDOE, 2, &pm660_nldo660, "vdd_l1_l2"},
 	{ "l3", QCOM_SMD_RPM_LDOE, 3, &pm660_nldo660, "vdd_l3"},