diff mbox series

[v3,33/50] dt-bindings: usb: add sam9x7

Message ID 20230728102843.266967-1-varshini.rajendran@microchip.com
State New
Headers
Series [v3,01/50] dt-bindings: microchip: atmel,at91rm9200-tcb: add sam9x60, sam9x7 compatible |

Commit Message

Varshini Rajendran July 28, 2023, 10:28 a.m. UTC 
  Document sam9x7 compatible for usb ohci.

Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
---
 Documentation/devicetree/bindings/usb/generic-ohci.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Krzysztof Kozlowski July 28, 2023, 11:48 a.m. UTC | #1 
On 28/07/2023 12:28, Varshini Rajendran wrote:
> Document sam9x7 compatible for usb ohci.
> 
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> ---
>  Documentation/devicetree/bindings/usb/generic-ohci.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> index be268e23ca79..a2490759f694 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> @@ -57,6 +57,12 @@ properties:
>                - nxp,ohci-nxp
>                - st,spear600-ohci
>            - const: usb-ohci
> +      - items:
> +          - enum:
> +              - microchip,sam9x7-ohci
> +          - enum:

That's not an enum. You cannot have here different compatibles.

> +              - atmel,at91rm9200-ohci
> +          - const: usb-ohci
>  
>    reg:
>      maxItems: 1

Best regards,
Krzysztof
Rob Herring July 28, 2023, 7:22 p.m. UTC | #2 
On Fri, Jul 28, 2023 at 01:48:01PM +0200, Krzysztof Kozlowski wrote:
> On 28/07/2023 12:28, Varshini Rajendran wrote:
> > Document sam9x7 compatible for usb ohci.
> > 
> > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> > ---
> >  Documentation/devicetree/bindings/usb/generic-ohci.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > index be268e23ca79..a2490759f694 100644
> > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > @@ -57,6 +57,12 @@ properties:
> >                - nxp,ohci-nxp
> >                - st,spear600-ohci
> >            - const: usb-ohci
> > +      - items:
> > +          - enum:
> > +              - microchip,sam9x7-ohci
> > +          - enum:
> 
> That's not an enum. You cannot have here different compatibles.
> 
> > +              - atmel,at91rm9200-ohci
> > +          - const: usb-ohci

As mentioned elsewhere, you aren't really compatible having custom 
properties. If you are adding this here, then stuff should be removed 
from the .txt binding. You need to sort out this mess and the existing 
warnings with 'usb-ohci' in Atmel dts files before adding on to it.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
index be268e23ca79..a2490759f694 100644
--- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
@@ -57,6 +57,12 @@  properties:
               - nxp,ohci-nxp
               - st,spear600-ohci
           - const: usb-ohci
+      - items:
+          - enum:
+              - microchip,sam9x7-ohci
+          - enum:
+              - atmel,at91rm9200-ohci
+          - const: usb-ohci
 
   reg:
     maxItems: 1