Message ID | b8c9c1a8a05dbf0be8e8be98cfdeafa9cecd8cef.1690535002.git.geert+renesas@glider.be |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp317609vqg; Fri, 28 Jul 2023 02:53:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlHyqvChkvJT07r0tILvA+/UqA9lUue4XiGowRxsfRToBcPmxe0Jqyj89p/pLDSzjJIzbYDi X-Received: by 2002:ac8:5e13:0:b0:400:9896:b0fa with SMTP id h19-20020ac85e13000000b004009896b0famr2244484qtx.64.1690538011823; Fri, 28 Jul 2023 02:53:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690538011; cv=none; d=google.com; s=arc-20160816; b=HsCTkYfILfck8pesEbjXINDJeIJz/iq0NYEjW1qtCQMoc7NZVtwDgeDdQU1n9ZHtcX 2pif2l53xVaIILPbIHeJCO+Osg9ft8wOwj+qcnCp0OzP8IPIZaI7H9T9/xbIMh7SUmXP Ervfj8Pqel+heXQUEQeKkho38jut3mCowv8GrKEcmmxIghC0D5ZJ3UcIc6/35z1pHBDW v6nrmDGKWVk37KdUm142MHlmqrXHe3IkZeYQ7TUJCq2ajE8+fO2o7jrBaOd+OYQAxMiK 4sygUuhsENYFhuvy8ASxqh9f4PwosrMMg36TeV1TG6XIxy7g9plhgWA1YPrtWPApe9Pl P1GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=wywyJ9Grxe6Z4BCjR6Bgv8ZY6dNL8U+8i4Lsjx9jSiA=; fh=y51ZHCQ7uTxWMZ4YMnVYKBK1UreBjQeXfhEiLS+OU+Q=; b=VwZfM0GSjCaeQA4gBkzzOalHgIzwQXJNGTHGdnXoV/QRoetW7AWDrwxN0jn2QgMNwQ rOFFPvVpKalAWmWjdyQSbyitK9AUvfsV6v/19aJbMKVDcShWQSLuPiImMaVt/3x+D2P6 LASrrjPdzrxhxYg+xQp0Ztm2HIdCKZoFnJRRPhqVANjqNe4LRwOfgiT+U3Gc4ABe2+0C v00Z+JitCRHGEotuiX1bfMMDX3lUThfcmOfHXlWgnreqUbJV4oK9q6LJV/yOKlidcpn8 KQ6weiVGuGsDGvy5lkxDKTe9Fv6h5V65ps2c6CKUo2JoGhmgEjxP53GBhtrg1wRGuetj U7zw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b75-20020a63344e000000b0055793097dbdsi2770586pga.453.2023.07.28.02.53.19; Fri, 28 Jul 2023 02:53:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234270AbjG1JEC (ORCPT <rfc822;hanasaki@gmail.com> + 99 others); Fri, 28 Jul 2023 05:04:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230128AbjG1JD7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 28 Jul 2023 05:03:59 -0400 Received: from michel.telenet-ops.be (michel.telenet-ops.be [IPv6:2a02:1800:110:4::f00:18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB77197 for <linux-kernel@vger.kernel.org>; Fri, 28 Jul 2023 02:03:58 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:12b0:7b7e:d1ff:7873]) by michel.telenet-ops.be with bizsmtp id SZ3v2A0070d1nm806Z3voj; Fri, 28 Jul 2023 11:03:57 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qPJNt-002lhW-Uw; Fri, 28 Jul 2023 11:03:55 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qPJO7-00AnzN-2F; Fri, 28 Jul 2023 11:03:55 +0200 From: Geert Uytterhoeven <geert+renesas@glider.be> To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Sean Paul <sean@poorly.run>, Alex Deucher <alexander.deucher@amd.com> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be>, Sui Jingfeng <suijingfeng@loongson.cn> Subject: [PATCH v2] drm/atomic-helper: Update reference to drm_crtc_force_disable_all() Date: Fri, 28 Jul 2023 11:03:53 +0200 Message-Id: <b8c9c1a8a05dbf0be8e8be98cfdeafa9cecd8cef.1690535002.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772657586427846721 X-GMAIL-MSGID: 1772657586427846721 |
Series |
[v2] drm/atomic-helper: Update reference to drm_crtc_force_disable_all()
|
|
Commit Message
Geert Uytterhoeven
July 28, 2023, 9:03 a.m. UTC
drm_crtc_force_disable_all() was renamed to drm_helper_force_disable_all(), but one reference was not updated. Fixes: c2d88e06bcb98540 ("drm: Move the legacy kms disable_all helper to crtc helpers") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn> --- v2: - Add Reviewed-by. --- drivers/gpu/drm/drm_atomic_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Geert Uytterhoeven <geert+renesas@glider.be> writes: Hello Geert, > drm_crtc_force_disable_all() was renamed to > drm_helper_force_disable_all(), but one reference was not updated. > > Fixes: c2d88e06bcb98540 ("drm: Move the legacy kms disable_all helper to crtc helpers") The dim tool complains that: -:10: WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' So I've fixed it locally to only use the first 12 chars of the sha1. > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn> > --- Pushed to drm-misc (drm-misc-next). Thanks!
Hi Javier, On Fri, Jul 28, 2023 at 11:53 AM Javier Martinez Canillas <javierm@redhat.com> wrote: > Geert Uytterhoeven <geert+renesas@glider.be> writes: > > drm_crtc_force_disable_all() was renamed to > > drm_helper_force_disable_all(), but one reference was not updated. > > > > Fixes: c2d88e06bcb98540 ("drm: Move the legacy kms disable_all helper to crtc helpers") > > The dim tool complains that: > > -:10: WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' > > So I've fixed it locally to only use the first 12 chars of the sha1. Good luck restoring them in the future (you do care about Y2038, do you? ;-) > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn> > > --- > > Pushed to drm-misc (drm-misc-next). Thanks! Thanks! Gr{oetje,eeting}s, Geert
Geert Uytterhoeven <geert@linux-m68k.org> writes: > Hi Javier, > > On Fri, Jul 28, 2023 at 11:53 AM Javier Martinez Canillas > <javierm@redhat.com> wrote: >> Geert Uytterhoeven <geert+renesas@glider.be> writes: >> > drm_crtc_force_disable_all() was renamed to >> > drm_helper_force_disable_all(), but one reference was not updated. >> > >> > Fixes: c2d88e06bcb98540 ("drm: Move the legacy kms disable_all helper to crtc helpers") >> >> The dim tool complains that: >> >> -:10: WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' >> >> So I've fixed it locally to only use the first 12 chars of the sha1. > > Good luck restoring them in the future (you do care about Y2038, > do you? ;-) > Fair. I fixed it not only because checkpatch complained but also to make it consistent with the rest of the Fixes: tag in the tree, in case that people have automation in place having the assumption of the 12 chars...
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 41b8066f61fff4be..292e38eb621806a0 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -3332,7 +3332,7 @@ EXPORT_SYMBOL(drm_atomic_helper_disable_all); * that also takes a snapshot of the modeset state to be restored on resume. * * This is just a convenience wrapper around drm_atomic_helper_disable_all(), - * and it is the atomic version of drm_crtc_force_disable_all(). + * and it is the atomic version of drm_helper_force_disable_all(). */ void drm_atomic_helper_shutdown(struct drm_device *dev) {