[v2] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults/range in schema
Commit Message
The range and the defaults are specified in the description instead of
being specified in the schema.
Fix it by adding the default value in the `default` field and specifying
the range as `minimum` and `maximum`.
Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema")
Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
---
changes in v2:
- also move the range as minimum/maximum in the schema
.../devicetree/bindings/net/rockchip-dwmac.yaml | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
Comments
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Wed, 26 Jul 2023 10:06:15 +0300 you wrote:
> The range and the defaults are specified in the description instead of
> being specified in the schema.
> Fix it by adding the default value in the `default` field and specifying
> the range as `minimum` and `maximum`.
>
> Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema")
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
>
> [...]
Here is the summary with links:
- [v2] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults/range in schema
https://git.kernel.org/netdev/net/c/5416d7925e6e
You are awesome, thank you!
@@ -92,12 +92,18 @@ properties:
$ref: /schemas/types.yaml#/definitions/phandle
tx_delay:
- description: Delay value for TXD timing. Range value is 0~0x7F, 0x30 as default.
+ description: Delay value for TXD timing.
$ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0
+ maximum: 0x7F
+ default: 0x30
rx_delay:
- description: Delay value for RXD timing. Range value is 0~0x7F, 0x10 as default.
+ description: Delay value for RXD timing.
$ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0
+ maximum: 0x7F
+ default: 0x10
phy-supply:
description: PHY regulator