diff mbox series

[v2] rtc: bq4802: add sparc dependency

Message ID 20230719192835.1025406-1-arnd@kernel.org
State New
Headers
Series [v2] rtc: bq4802: add sparc dependency |

Commit Message

Arnd Bergmann July 19, 2023, 7:28 p.m. UTC 
  From: Arnd Bergmann <arnd@arndb.de>

The added HAS_IOPORT dependency might not actually be necessary as Geert
points out, but the driver is also only used on one architecture. Sparc
is also a special case here since it converts port numbers into virtual
addresses rather than having them mapped into a particular part of the
__iomem address space, so the difference is actually not important here.

Add a dependency on sparc, but allow compile-testing otherwise, to
make this clearer without anyone having to spend much time modernizing
the driver beyond that.

Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: David S. Miller <davem@davemloft.net>
Link: https://lore.kernel.org/all/CAMuHMdWEx0F=fNei4Bz_JPkuvoaN-+zk08h0i8KnSi_VjO615g@mail.gmail.com/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2: split dependency into two lines, as suggested by Geert
---
 drivers/rtc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Geert Uytterhoeven July 27, 2023, 1:32 p.m. UTC | #1 
On Wed, Jul 19, 2023 at 9:28 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The added HAS_IOPORT dependency might not actually be necessary as Geert
> points out, but the driver is also only used on one architecture. Sparc
> is also a special case here since it converts port numbers into virtual
> addresses rather than having them mapped into a particular part of the
> __iomem address space, so the difference is actually not important here.
>
> Add a dependency on sparc, but allow compile-testing otherwise, to
> make this clearer without anyone having to spend much time modernizing
> the driver beyond that.
>
> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: David S. Miller <davem@davemloft.net>
> Link: https://lore.kernel.org/all/CAMuHMdWEx0F=fNei4Bz_JPkuvoaN-+zk08h0i8KnSi_VjO615g@mail.gmail.com/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: split dependency into two lines, as suggested by Geert

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Alexandre Belloni July 27, 2023, 9:10 p.m. UTC | #2 
On Wed, 19 Jul 2023 21:28:18 +0200, Arnd Bergmann wrote:
> The added HAS_IOPORT dependency might not actually be necessary as Geert
> points out, but the driver is also only used on one architecture. Sparc
> is also a special case here since it converts port numbers into virtual
> addresses rather than having them mapped into a particular part of the
> __iomem address space, so the difference is actually not important here.
> 
> Add a dependency on sparc, but allow compile-testing otherwise, to
> make this clearer without anyone having to spend much time modernizing
> the driver beyond that.
> 
> [...]

Applied, thanks!

[1/1] rtc: bq4802: add sparc dependency
      commit: 766c3f8a092b4d42abd68ee0338349838430a5ee

Best regards,
diff mbox series

Patch

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 05f4b2d66290d..19c3eac474f7c 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1196,6 +1196,7 @@  config RTC_DRV_MSM6242
 config RTC_DRV_BQ4802
 	tristate "TI BQ4802"
 	depends on HAS_IOMEM && HAS_IOPORT
+	depends on SPARC || COMPILE_TEST
 	help
 	  If you say Y here you will get support for the TI
 	  BQ4802 RTC chip.