Message ID | 20230719075056.72178-2-angelogioacchino.delregno@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2281563vqt; Wed, 19 Jul 2023 01:17:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlFbCfJIuBNSf6fvwWeLf1Ni+PIxvpQpn8epbqd6Cj7uTmCVz761QvtRJ5LPUjF5mQ4c3QFT X-Received: by 2002:a17:907:7746:b0:993:d617:bdc2 with SMTP id kx6-20020a170907774600b00993d617bdc2mr1500261ejc.75.1689754647763; Wed, 19 Jul 2023 01:17:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689754647; cv=none; d=google.com; s=arc-20160816; b=JHvYvmP5M8Ded46J0jd5PjH3p0Urljci0v/8IetJwxanBrtA9FPkm2RjEIVZis3Ar/ vZ6kC1eL7AfgjDGs5cuVuzvus7FIsLwbwO/8puxR5qZjnl02VkJvPNaS6bxppRT6kWwz 1zDmWgCDCOvlG7JfpFF+Xj2GUUCK4PerfNBQQqelt8YNCmzgt2vdxYdUHvszBziKVweH gkgv3RCF1yC1DGRshs6oyfebovTsNM3dj8dplg8eYNO1LpXen5pbjZeXsCK3Qg64Ng4c EvPQfVHNLCE1GQhvv2YrGkZyZ2hYqrHrwR9sMP6jkl+BvlUwFEkpYnksz6XYDWT4DF61 liPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=36nLmUkMoaPNfFqc2lZwJu0SPk871bx2ndAXsjrjZM4=; fh=NKnLsaTUs6DGQa/OThi18WPpEgJ637Y16FMWW8s0AeQ=; b=PmwFOnesSAFNjeRQq/TKh2VRT2yxDCZMuqLr+L/5qgzKHo+4ZNlkIdEfeHL8Mq7HxQ YIdficrojymtt0PWPssQgUA/SJr+U943Cbne8t0cmH59TeKDQpYBomDj9ZsPoofkERyE 5q/sro+NdfAuDDLB2i5EBUMPQpTJUV15nIBsqaHn07AKbDCIl0cZcmFerxTWN3s6ALb/ DAQx4kS+CMzYPbt6Z/dS6DDS4fB+DXRf7Do0kp7YrZ4mdOfh2wR0hfzOb76gqUiigfQU mBZIvCTHuzvWHNalnW9av2N+zJMnL1g6RzNoORuMk4mqeDGOKfLmRnPrD4nDAQ7p2HRm FXsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=YVm9nlsm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c23-20020a170906341700b0098843bd4387si2441163ejb.320.2023.07.19.01.17.03; Wed, 19 Jul 2023 01:17:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=YVm9nlsm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230027AbjGSHvN (ORCPT <rfc822;assdfgzxcv4@gmail.com> + 99 others); Wed, 19 Jul 2023 03:51:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229757AbjGSHvJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 19 Jul 2023 03:51:09 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF6BC134 for <linux-kernel@vger.kernel.org>; Wed, 19 Jul 2023 00:51:08 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id D5D6A6607070; Wed, 19 Jul 2023 08:51:06 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1689753067; bh=n4bzSjz/8ToatLkUrHwwNZNY341UFIC11J8xZSFamQk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YVm9nlsm7Q93D67X1+1cSOFc6xkeULgbJzUdCUPhr5LLjVwqs6hPTFnkancL7h/IH e38JSizfJc9RmGiUIb3+LsqCAwc/M0GhFCQZ9cM5oYhe4Zrl1vV2Dk2hdsiM8DEKd2 lajRt6cmWVXGyLUc1jDVhFr8Ba8pw0XAxc1ZOdTQHCB81W8OW4MW9G2bvp+3DNrTNF Tw1hvo2MlLdOl89ZJj4gkdkfQVdAFx2QL7a/D+XpRz4nuDeqLO7R/xoK7KWQLgnzzX kGsW1hc7nLyQ1RGMbuOJ45HuSPW1+/6gmkcCVhmS3GvCrJy10ef+1fACwOzD3Rmy2P WIIP7xHk3LW+Q== From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: chunkuang.hu@kernel.org Cc: p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, fshao@chromium.org Subject: [PATCH v2 1/6] drm/mediatek: mtk_dpi: Simplify with devm_drm_bridge_add() Date: Wed, 19 Jul 2023 09:50:51 +0200 Message-Id: <20230719075056.72178-2-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230719075056.72178-1-angelogioacchino.delregno@collabora.com> References: <20230719075056.72178-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771836169746603177 X-GMAIL-MSGID: 1771836169746603177 |
Series |
drm/mediatek: Small mtk-dpi cleanups
|
|
Commit Message
AngeloGioacchino Del Regno
July 19, 2023, 7:50 a.m. UTC
Change drm_bridge_add() to its devm variant to slightly simplify the
probe function.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
On Wed, Jul 19, 2023 at 3:51 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Change drm_bridge_add() to its devm variant to slightly simplify the > probe function. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Fei Shao <fshao@chromium.org>
Hi, Angelo: On Wed, 2023-07-19 at 09:50 +0200, AngeloGioacchino Del Regno wrote: > Change drm_bridge_add() to its devm variant to slightly simplify the > probe function. Reviewed-by: CK Hu <ck.hu@mediatek.com> > > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > b/drivers/gpu/drm/mediatek/mtk_dpi.c > index 948a53f1f4b3..74068aa70e0c 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -1090,11 +1090,12 @@ static int mtk_dpi_probe(struct > platform_device *pdev) > dpi->bridge.of_node = dev->of_node; > dpi->bridge.type = DRM_MODE_CONNECTOR_DPI; > > - drm_bridge_add(&dpi->bridge); > + ret = devm_drm_bridge_add(dev, &dpi->bridge); > + if (ret) > + return ret; > > ret = component_add(dev, &mtk_dpi_component_ops); > if (ret) { > - drm_bridge_remove(&dpi->bridge); > dev_err(dev, "Failed to add component: %d\n", ret); > return ret; > } > @@ -1107,7 +1108,6 @@ static int mtk_dpi_remove(struct > platform_device *pdev) > struct mtk_dpi *dpi = platform_get_drvdata(pdev); > > component_del(&pdev->dev, &mtk_dpi_component_ops); > - drm_bridge_remove(&dpi->bridge); > > return 0; > }
Hi, Angelo: On Wed, 2023-07-26 at 13:21 +0800, CK Hu wrote: > Hi, Angelo: > > On Wed, 2023-07-19 at 09:50 +0200, AngeloGioacchino Del Regno wrote: > > Change drm_bridge_add() to its devm variant to slightly simplify > > the > > probe function. > > Reviewed-by: CK Hu <ck.hu@mediatek.com> > > > > > Signed-off-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > drivers/gpu/drm/mediatek/mtk_dpi.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > > b/drivers/gpu/drm/mediatek/mtk_dpi.c > > index 948a53f1f4b3..74068aa70e0c 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > > @@ -1090,11 +1090,12 @@ static int mtk_dpi_probe(struct > > platform_device *pdev) > > dpi->bridge.of_node = dev->of_node; > > dpi->bridge.type = DRM_MODE_CONNECTOR_DPI; > > > > - drm_bridge_add(&dpi->bridge); > > + ret = devm_drm_bridge_add(dev, &dpi->bridge); > > + if (ret) > > + return ret; > > > > ret = component_add(dev, &mtk_dpi_component_ops); > > if (ret) { > > - drm_bridge_remove(&dpi->bridge); > > dev_err(dev, "Failed to add component: %d\n", ret); > > return ret; > > } > > @@ -1107,7 +1108,6 @@ static int mtk_dpi_remove(struct > > platform_device *pdev) > > struct mtk_dpi *dpi = platform_get_drvdata(pdev); Remove this also. So drop my Reviewed-by tag. Regards, CK > > > > component_del(&pdev->dev, &mtk_dpi_component_ops); > > - drm_bridge_remove(&dpi->bridge); > > > > return 0; > > }
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 948a53f1f4b3..74068aa70e0c 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -1090,11 +1090,12 @@ static int mtk_dpi_probe(struct platform_device *pdev) dpi->bridge.of_node = dev->of_node; dpi->bridge.type = DRM_MODE_CONNECTOR_DPI; - drm_bridge_add(&dpi->bridge); + ret = devm_drm_bridge_add(dev, &dpi->bridge); + if (ret) + return ret; ret = component_add(dev, &mtk_dpi_component_ops); if (ret) { - drm_bridge_remove(&dpi->bridge); dev_err(dev, "Failed to add component: %d\n", ret); return ret; } @@ -1107,7 +1108,6 @@ static int mtk_dpi_remove(struct platform_device *pdev) struct mtk_dpi *dpi = platform_get_drvdata(pdev); component_del(&pdev->dev, &mtk_dpi_component_ops); - drm_bridge_remove(&dpi->bridge); return 0; }