[1/2] regulator: dt-bindings: add missing unevaluatedProperties for each regulator
Commit Message
Each regulator node, which references common regulator.yaml schema,
should disallow additional or unevaluated properties. Otherwise
mistakes in properties will go unnoticed.
Reported-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Closes: https://git.codelinaro.org/linaro/qcomlt/kernel/-/commit/1c8aeef8a6e84520b77f0c270d99c8bf692c5933
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Documentation/devicetree/bindings/regulator/mps,mp5416.yaml | 2 ++
Documentation/devicetree/bindings/regulator/mps,mpq7920.yaml | 2 ++
Documentation/devicetree/bindings/regulator/pfuze100.yaml | 4 ++++
.../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 2 ++
.../devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml | 1 +
.../bindings/regulator/richtek,rt4831-regulator.yaml | 1 +
.../bindings/regulator/richtek,rtmv20-regulator.yaml | 1 +
.../bindings/regulator/richtek,rtq6752-regulator.yaml | 1 +
.../devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml | 2 +-
Documentation/devicetree/bindings/regulator/ti,tps65090.yaml | 1 +
Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml | 1 +
Documentation/devicetree/bindings/regulator/wlf,arizona.yaml | 2 ++
12 files changed, 19 insertions(+), 1 deletion(-)
Comments
On Tue, 25 Jul 2023 12:54:20 +0200, Krzysztof Kozlowski wrote:
> Each regulator node, which references common regulator.yaml schema,
> should disallow additional or unevaluated properties. Otherwise
> mistakes in properties will go unnoticed.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/2] regulator: dt-bindings: add missing unevaluatedProperties for each regulator
(no commit info)
[2/2] regulator: dt-bindings: mps,mpq7920: drop incorrect ref to regulator.yaml
commit: 55c8b8ddc0d95912c7b0d066aaa4bbac146e3c42
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
On 25/07/2023 13:14, Mark Brown wrote:
> On Tue, Jul 25, 2023 at 12:54:20PM +0200, Krzysztof Kozlowski wrote:
>> Each regulator node, which references common regulator.yaml schema,
>> should disallow additional or unevaluated properties. Otherwise
>> mistakes in properties will go unnoticed.
>
> This doesn't apply against current code, please check and resend.
>
>> Documentation/devicetree/bindings/regulator/ti,tps65090.yaml | 1 +
>
> This doesn't seem to be upstream.
Indeed, I should exclude any work-in-progress. Apologies. I'll fix and
send v2 of this patch.
Best regards,
Krzysztof
@@ -29,10 +29,12 @@ properties:
patternProperties:
"^buck[1-4]$":
$ref: regulator.yaml#
+ unevaluatedProperties: false
type: object
"^ldo[1-4]$":
$ref: regulator.yaml#
+ unevaluatedProperties: false
type: object
additionalProperties: false
@@ -39,11 +39,13 @@ properties:
ldortc:
type: object
$ref: regulator.yaml#
+ unevaluatedProperties: false
patternProperties:
"^ldo[1-4]$":
type: object
$ref: regulator.yaml#
+ unevaluatedProperties: false
"^buck[1-4]$":
type: object
@@ -68,18 +68,22 @@ properties:
"^sw([1-4]|[1-4][a-c]|[1-4][a-c][a-c])$":
$ref: regulator.yaml#
type: object
+ unevaluatedProperties: false
"^vgen[1-6]$":
$ref: regulator.yaml#
type: object
+ unevaluatedProperties: false
"^vldo[1-4]$":
$ref: regulator.yaml#
type: object
+ unevaluatedProperties: false
"^(vsnvs|vref|vrefddr|swbst|coin|v33|vccsd)$":
$ref: regulator.yaml#
type: object
+ unevaluatedProperties: false
additionalProperties: false
@@ -111,6 +111,7 @@ properties:
bob:
type: object
$ref: regulator.yaml#
+ unevaluatedProperties: false
description: BOB regulator node.
dependencies:
regulator-allow-set-load: [ regulator-allowed-modes ]
@@ -119,6 +120,7 @@ patternProperties:
"^(smps|ldo|lvs|bob)[0-9]+$":
type: object
$ref: regulator.yaml#
+ unevaluatedProperties: false
description: smps/ldo regulator nodes(s).
dependencies:
regulator-allow-set-load: [ regulator-allowed-modes ]
@@ -110,6 +110,7 @@ patternProperties:
"^((s|l|lvs|5vs)[0-9]*)|(boost-bypass)|(bob)$":
description: List of regulators and its properties
$ref: regulator.yaml#
+ unevaluatedProperties: false
additionalProperties: false
@@ -29,6 +29,7 @@ patternProperties:
"^DSV(LCM|P|N)$":
type: object
$ref: regulator.yaml#
+ unevaluatedProperties: false
description:
Properties for single Display Bias Voltage regulator.
@@ -121,6 +121,7 @@ properties:
description: load switch current regulator description.
type: object
$ref: regulator.yaml#
+ unevaluatedProperties: false
required:
- compatible
@@ -35,6 +35,7 @@ properties:
"^(p|n)avdd$":
type: object
$ref: regulator.yaml#
+ unevaluatedProperties: false
description: |
regulator description for pavdd and navdd.
@@ -25,8 +25,8 @@ properties:
patternProperties:
"^(reg11|reg18|usb33)$":
type: object
-
$ref: regulator.yaml#
+ unevaluatedProperties: false
required:
- compatible
@@ -67,6 +67,7 @@ properties:
patternProperties:
"^dcdc[1-3]|fet[1-7]|ldo[1-2]$":
$ref: regulator.yaml
+ unevaluatedProperties: false
properties:
ti,enable-ext-control:
$ref: /schemas/types.yaml#/definitions/flag
@@ -64,6 +64,7 @@ properties:
patternProperties:
"^sys|sm[0-2]|ldo[0-9]|ldo_rtc$":
$ref: regulator.yaml
+ unevaluatedProperties: false
allOf:
- $ref: /schemas/gpio/gpio.yaml
@@ -29,11 +29,13 @@ properties:
Initial data for the LDO1 regulator.
$ref: regulator.yaml#
type: object
+ unevaluatedProperties: false
micvdd:
description:
Initial data for the MICVDD regulator.
$ref: regulator.yaml#
type: object
+ unevaluatedProperties: false
additionalProperties: true