dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults in schema
Commit Message
The defaults are specified in the description instead of being specified
in the schema.
Fix it by adding the default value in the `default` field.
Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema")
Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
---
Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
Comments
On Tue, Jul 25, 2023 at 06:11:56PM +0200, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Jul 25, 2023 at 06:52:54PM +0300, Eugen Hristev wrote:
> > The defaults are specified in the description instead of being specified
> > in the schema.
> > Fix it by adding the default value in the `default` field.
> >
> > Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema")
> > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
> > ---
>
> Maybe also fix the allowed range while at it? I.e.
>
> minimum: 0x00
> maximum: 0x7F
Beat me to it! Please do.
@@ -92,12 +92,14 @@ properties:
$ref: /schemas/types.yaml#/definitions/phandle
tx_delay:
- description: Delay value for TXD timing. Range value is 0~0x7F, 0x30 as default.
+ description: Delay value for TXD timing. Range value is 0~0x7F.
$ref: /schemas/types.yaml#/definitions/uint32
+ default: 0x30
rx_delay:
- description: Delay value for RXD timing. Range value is 0~0x7F, 0x10 as default.
+ description: Delay value for RXD timing. Range value is 0~0x7F.
$ref: /schemas/types.yaml#/definitions/uint32
+ default: 0x10
phy-supply:
description: PHY regulator