Message ID | 20230723160827.22660-7-a39.skl@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp1334755vqg; Sun, 23 Jul 2023 09:23:52 -0700 (PDT) X-Google-Smtp-Source: APBJJlEai5EUH7OlD1Y5T0O/p+BMb5cYLTeePpCDrrshwA1/RT7qcl1UPb5PBEMWGYSa0Y7vBNAJ X-Received: by 2002:a05:6358:7f08:b0:132:d3b1:c34a with SMTP id p8-20020a0563587f0800b00132d3b1c34amr2995471rwn.7.1690129431735; Sun, 23 Jul 2023 09:23:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690129431; cv=none; d=google.com; s=arc-20160816; b=LI9kVTackmIgPN9zTjdAffml4L7J/tbKJ9duamKksBPDc0BXCK6hb8kVpTA0mFhoNt DUgzBkRfUZyHRtq5p3snJr5h+HJH2WQOdvi4ejO2oOesNvfy0mYWYT5oPkvmfFMEYSYu da+mQfi6BbXWzPS+QD9UmxEFfA+VF8KZlaba7/U6Roa6mEPotxizw/AbxtAhHR9S7d0f TC2XxZf17PwVZf7DbEfMp/uwxRXMjKNBlhpe/oW9miyuOFkYjIR9JqGnCBVkbBf+WDlw 7C+2X7VL0xcw+fKaY5i1jdGI90oFVAOuhbEVaZF8RnDt+mIqW8dqKgA3XjDDVq58tlGb AdHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=JAGDbj4w5cqYpPhjbv0lV9BCY/wz/Fddf4zaiPiVK1k=; fh=yvapBpxRRF+mjwML+sZg6pJkW9kIP6kouIjVxp7tgTI=; b=ZDxxjrAsDPoOB5iCPflltkUaO/IKnbDmi55bVN4a0n1+FXOnXxStFUace18Fp72Njy D63EqkDGGMkjlfSFDRxSP2YXecDfYmH73sd3hN7+30E3yU0WpyNTJPq5zEv8GVrsEpYi +KcDXjYPfIZsORqHOMwFvIrsC3ed7b6NhFqlC6dyloVL+lFgzpB+q5bzushAKtKBdX1S qJOq/YYin1ru5JtOEKYlQ+T9uLVZ8GfGrWohpx3EcMj7l68VW9vLXafI0rdPc3uu/hAl apDRSa3IGNrgaVyNQuUjJzU8D6RizhqeFQfltaqD1KyyefF4csd8cGX7fBSxKiHBeQLq WjGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20221208 header.b=B23twYJY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bu30-20020a63295e000000b00543c84bf588si7341549pgb.473.2023.07.23.09.23.38; Sun, 23 Jul 2023 09:23:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20221208 header.b=B23twYJY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229477AbjGWQLY (ORCPT <rfc822;chrisben.tianve@gmail.com> + 99 others); Sun, 23 Jul 2023 12:11:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230218AbjGWQLF (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 23 Jul 2023 12:11:05 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0EBE1722; Sun, 23 Jul 2023 09:10:29 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-98377c5d53eso576594266b.0; Sun, 23 Jul 2023 09:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690128573; x=1690733373; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JAGDbj4w5cqYpPhjbv0lV9BCY/wz/Fddf4zaiPiVK1k=; b=B23twYJYp6zKU1881M5PgC/7EWYMBfYki3iHA9pDNh3HOsf9qlPI1gel24VxrlFUHr zcqzl5li0RMxmoKtFoRQYXqBgCiEpSIdDrzCxBRv6nbw6VoqJ6N5cSKR+a1hiy+PCnkG uG1HiS7pBlAZg6wwK4MnhSWmcVCBy6TI0oMyIRLxjkpHsNoImh+KjRvKEygBE1h6Wsv0 z3bO+NN26kGR3L/RymPJaCY7/eILDRYBlrW64XaZP5RmnPVcxIZK4HwhevXQbcFzqS5T jx5jPel15Bd1GukFjH2zAWytdhcZW07093WW/ve+14KfwNL62JhjLxnFqTewJ9aFQb3D QtLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690128573; x=1690733373; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JAGDbj4w5cqYpPhjbv0lV9BCY/wz/Fddf4zaiPiVK1k=; b=lM+U3A6NHHXfbz01I65/HEc3SEHdgkfqRwxwSMxBPte6JsEI5o5NODcvQ0LkHoSs2l NCfDph3uXRy7I7HMJ0A2kZ3vLvgZ7oX3iftl+XEA4VnhSiguh9aP+Mz/9mPFlyYb7yLV p8msCXLgGm/LtPwRpbgMpfKFDZrdb/B+N5LwQp2et1MhvNxFsfNJg6gBddoHgqXMTW++ rWRaw6aMCqxlRX7wRro6yczSJdofz5prrVJVfJj8jV2zagFpYkfR8NHknVYMeAUfXDiU BtLjXPkXLhm4gyXGaZu9SALKmME3pexKgDy44nPNhMYVJkd5s0bsUmfpmVDYW2bfSebY IHHA== X-Gm-Message-State: ABy/qLa8n/qO9IQw3b3OBNZ9CqPO5NkMb9hzFHv0lE7V8a1Ux+wUS2XQ kPBYKyUHagzzztjuzwnpODiXqDoDLzE= X-Received: by 2002:a17:906:535b:b0:99b:658e:3941 with SMTP id j27-20020a170906535b00b0099b658e3941mr7191830ejo.70.1690128573018; Sun, 23 Jul 2023 09:09:33 -0700 (PDT) Received: from localhost.localdomain (ccx116.neoplus.adsl.tpnet.pl. [83.30.147.116]) by smtp.gmail.com with ESMTPSA id u16-20020a170906951000b0099b4d86fbccsm5425039ejx.141.2023.07.23.09.09.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jul 2023 09:09:32 -0700 (PDT) From: Adam Skladowski <a39.skl@gmail.com> Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Adam Skladowski <a39.skl@gmail.com>, Bjorn Andersson <andersson@kernel.org>, Andy Gross <agross@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, AngeloGioacchino Del Regno <kholk11@gmail.com>, Marijn Suijten <marijn.suijten@somainline.org>, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/7] arm64: dts: qcom: msm8976: Split lpass region Date: Sun, 23 Jul 2023 18:08:25 +0200 Message-Id: <20230723160827.22660-7-a39.skl@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230723160827.22660-1-a39.skl@gmail.com> References: <20230723160827.22660-1-a39.skl@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772229159268934562 X-GMAIL-MSGID: 1772229159268934562 |
Series |
MSM8976 PLL,RPMPD and DTS changes
|
|
Commit Message
Adam Skladowski
July 23, 2023, 4:08 p.m. UTC
Some devices like Sony Loire uses Broadcom module over sdc3 however others
utilize qcom WCNSS, split shared region based on downstream pil-tz loader.
Signed-off-by: Adam Skladowski <a39.skl@gmail.com>
---
arch/arm64/boot/dts/qcom/msm8976.dtsi | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
Comments
On 23.07.2023 18:08, Adam Skladowski wrote: > Some devices like Sony Loire uses Broadcom module over sdc3 however others > utilize qcom WCNSS, split shared region based on downstream pil-tz loader. > > Signed-off-by: Adam Skladowski <a39.skl@gmail.com> > --- Looks like 0x1800000 is the generic configuration: https://git.codelinaro.org/clo/la/kernel/msm-3.10/-/blob/LA.BR.1.3.7.c26-05300-8976.0/arch/arm/boot/dts/qcom/msm8976.dtsi#L93-98 Konrad
On 25.07.2023 10:44, Konrad Dybcio wrote: > On 23.07.2023 18:08, Adam Skladowski wrote: >> Some devices like Sony Loire uses Broadcom module over sdc3 however others >> utilize qcom WCNSS, split shared region based on downstream pil-tz loader. >> >> Signed-off-by: Adam Skladowski <a39.skl@gmail.com> >> --- > Looks like 0x1800000 is the generic configuration: > > https://git.codelinaro.org/clo/la/kernel/msm-3.10/-/blob/LA.BR.1.3.7.c26-05300-8976.0/arch/arm/boot/dts/qcom/msm8976.dtsi#L93-98 > > Konrad Yes, indeed however as you probably noticed this region isn't called lpass rather reloc. Downstream sometimes tends to define pools of memory where loader will do its own job. If you read later wcnss/lpass both point to same shared memory which im not sure without reworks will work with mainline. On top it's not really that it will even hurt Loire at the end, if you browse around internet you can easily find gists from Pavel which have logs of pil-tz loading of lpass: https://gist.github.com/bartcubbins/c2ff215f39fe2b3ed5d3f8444bcec83b#file-gistfile1-txt-L1289 As you can see even on loire where region is bigger it only loads first 0x1000000. Do we really need to complicate things just for everyone else for sake of not ending with one platform having to adjust or even not(it probably wouldn't even make a difference for loader as it will fit anyway) On the ending note i apologize if this msg gets broken formatting first time using thunderbird and after redesign im unable to find most options mentioned in guide. .
diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi b/arch/arm64/boot/dts/qcom/msm8976.dtsi index ab76806317a7..7385d5edec04 100644 --- a/arch/arm64/boot/dts/qcom/msm8976.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8976.dtsi @@ -338,7 +338,12 @@ mpss_mem: mpss@86c00000 { }; lpass_mem: lpass@8c200000 { - reg = <0x0 0x8c200000 0x0 0x1800000>; + reg = <0x0 0x8c200000 0x0 0x1000000>; + no-map; + }; + + wcnss_fw_mem: wcnss@8d200000 { + reg = <0x0 0x8d200000 0x0 0x800000>; no-map; };