diff mbox series

C-SKY: Fix unsigned comparison warning

Message ID 20220912121923.fazqolix7neh77uz@lug-owl.de
State New, archived
Headers
Series C-SKY: Fix unsigned comparison warning |

Commit Message

Jan-Benedict Glaw Sept. 12, 2022, 12:19 p.m. UTC 
  Hi!

When -mfloat-abi=hard support was added, a cast went missing that
used to silence a warning in common code:

/usr/lib/gcc-snapshot/bin/g++  -fno-PIE -c   -g -O2   -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE   -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include -I../../gcc/gcc/../libcody  -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace   -o builtins.o -MT builtins.o -MMD -MP -MF ./.deps/builtins.TPo ../../gcc/gcc/builtins.cc
In file included from ./tm.h:21,
                 from ../../gcc/gcc/backend.h:28,
                 from ../../gcc/gcc/builtins.cc:27:
../../gcc/gcc/builtins.cc: In function 'int apply_args_size()':
../../gcc/gcc/config/csky/csky.h:421:13: error: comparison of unsigned expression in '>= 0' is always true [-Werror=type-limits]
  421 |   (((REGNO) >= CSKY_FIRST_PARM_REGNUM                        \
../../gcc/gcc/builtins.cc:1444:13: note: in expansion of macro 'FUNCTION_ARG_REGNO_P'
 1444 |         if (FUNCTION_ARG_REGNO_P (regno))
      |             ^~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[1]: *** [Makefile:1146: builtins.o] Error 1

The needed (int) cast is even mentioned in the comment above, so reinstate
it here.



2022-09-06  Jan-Benedict Glaw  <jbglaw@lug-owl.de>

gcc/ChangeLog:
	* config/csky/csky.h (FUNCTION_ARG_REGNO_P): Cast REGNO to (int)
	to prevent warning.


Ok for HEAD?

Thanks,
  Jan-Benedict

--

Comments

Jan-Benedict Glaw Sept. 16, 2022, 10:09 p.m. UTC | #1 
On Mon, 2022-09-12 14:19:23 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> 2022-09-06  Jan-Benedict Glaw  <jbglaw@lug-owl.de>
> 
> gcc/ChangeLog:
> 	* config/csky/csky.h (FUNCTION_ARG_REGNO_P): Cast REGNO to (int)
> 	to prevent warning.
> 
> diff --git a/gcc/config/csky/csky.h b/gcc/config/csky/csky.h
> index 37410f0cda4..730d1b44ef1 100644
> --- a/gcc/config/csky/csky.h
> +++ b/gcc/config/csky/csky.h
> @@ -418,7 +418,7 @@ typedef struct
>     The int cast is to prevent a complaint about unsigned comparison to
>     zero, since CSKY_FIRST_PARM_REGNUM is zero.  */
>  #define FUNCTION_ARG_REGNO_P(REGNO)                          \
> -  (((REGNO) >= CSKY_FIRST_PARM_REGNUM                        \
> +  (((int)(REGNO) >= CSKY_FIRST_PARM_REGNUM                   \
>      && (REGNO) < (CSKY_NPARM_REGS + CSKY_FIRST_PARM_REGNUM)) \
>     || FUNCTION_VARG_REGNO_P(REGNO))
>  
> 
> Ok for HEAD?

Just wanted to give this a ping.

MfG, JBG

--
Jeff Law Sept. 17, 2022, 12:22 a.m. UTC | #2 
On 9/12/22 06:19, Jan-Benedict Glaw wrote:
> Hi!
>
> When -mfloat-abi=hard support was added, a cast went missing that
> used to silence a warning in common code:
>
> /usr/lib/gcc-snapshot/bin/g++  -fno-PIE -c   -g -O2   -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE   -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include -I../../gcc/gcc/../libcody  -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace   -o builtins.o -MT builtins.o -MMD -MP -MF ./.deps/builtins.TPo ../../gcc/gcc/builtins.cc
> In file included from ./tm.h:21,
>                   from ../../gcc/gcc/backend.h:28,
>                   from ../../gcc/gcc/builtins.cc:27:
> ../../gcc/gcc/builtins.cc: In function 'int apply_args_size()':
> ../../gcc/gcc/config/csky/csky.h:421:13: error: comparison of unsigned expression in '>= 0' is always true [-Werror=type-limits]
>    421 |   (((REGNO) >= CSKY_FIRST_PARM_REGNUM                        \
> ../../gcc/gcc/builtins.cc:1444:13: note: in expansion of macro 'FUNCTION_ARG_REGNO_P'
>   1444 |         if (FUNCTION_ARG_REGNO_P (regno))
>        |             ^~~~~~~~~~~~~~~~~~~~
> cc1plus: all warnings being treated as errors
> make[1]: *** [Makefile:1146: builtins.o] Error 1
>
> The needed (int) cast is even mentioned in the comment above, so reinstate
> it here.
>
>
>
> 2022-09-06  Jan-Benedict Glaw  <jbglaw@lug-owl.de>
>
> gcc/ChangeLog:
> 	* config/csky/csky.h (FUNCTION_ARG_REGNO_P): Cast REGNO to (int)
> 	to prevent warning.

OK

jeff
diff mbox series

Patch

diff --git a/gcc/config/csky/csky.h b/gcc/config/csky/csky.h
index 37410f0cda4..730d1b44ef1 100644
--- a/gcc/config/csky/csky.h
+++ b/gcc/config/csky/csky.h
@@ -418,7 +418,7 @@  typedef struct
    The int cast is to prevent a complaint about unsigned comparison to
    zero, since CSKY_FIRST_PARM_REGNUM is zero.  */
 #define FUNCTION_ARG_REGNO_P(REGNO)                          \
-  (((REGNO) >= CSKY_FIRST_PARM_REGNUM                        \
+  (((int)(REGNO) >= CSKY_FIRST_PARM_REGNUM                   \
     && (REGNO) < (CSKY_NPARM_REGS + CSKY_FIRST_PARM_REGNUM)) \
    || FUNCTION_VARG_REGNO_P(REGNO))