Message ID | 20230721133932.12679-1-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp230040vqg; Fri, 21 Jul 2023 07:07:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlE/kijoujPfONwnnTd0QKadDLErvncly7RA54gMVkigeX7SiC+dB8SJFAP0Wns6BvaW9yY8 X-Received: by 2002:a17:902:d4d2:b0:1b8:e41:f43f with SMTP id o18-20020a170902d4d200b001b80e41f43fmr2392868plg.27.1689948453699; Fri, 21 Jul 2023 07:07:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689948453; cv=none; d=google.com; s=arc-20160816; b=EX8N6TzhUAy25Lly5BCLM8ROmPUvfZtqVDcDDkEuJOKmo2xvxfddssfSejuhVgYn/T caBhM1XjOYzD24Tn06oZdGDsLjZOm8weec+Ji1R45sIcHJhh5Y6ZNj37yTTIWBbcPcUF P4F5UXzXMi4QhyZuGfdzfeu6HmKnoz7gsS2gQ8RMSt8XiECKX8K2npt5/lQTyUtD3LPJ e9vtkikj91CwYwmgEjmKP/AVoMbYgbqjuwKZEkazEubdCB5kdQs9EqXiUMbzCxUvvf0+ x5Synjl8iwnSyi53XzvhhEQvI/gJZfE3s5bZXpUZ3tgUQIQ5G5LmtKb1XychihyB5/69 zgXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=SSbM0pbZwlk36MbUKXW2e3/PNWjKAMnlm5+1OYqMUxU=; fh=VnPMTe8C/Rzm+FcGY3/U4zfK5EMSLxCDuvnIV1kM6FU=; b=Vvn51OdjAbaJUXXoBXceuC8/tHwLvUU/e6wrIwjWnsFEa6uHIpO4Zf14OUfPk9yBxn u6xJwlu159va0eKnrJh/Uz+8laN2+hr6ycQqJ0SNCgYy0CGc5TxLyJOiyUgTkUr3xKtL Gv0u2WMUeTe2JxkaJLdopHWTYY3bWAT0FaEuA+kIhc3E9c2Brp/Uu4y6puuFekcn9JOU UCE9rkNT0Rv2a2oRljPBI1FojdqDls82UNAK6+stT7VvmiGzBDg+sKRu1r6qGchF87qr oLXbTOJej5R8/Q85wWsIZcWzyA0V3jOS4qRA6r9nzJVftLYCiaeQRj5fZjhpNitMm6BB EVYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dx+HoGA5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u11-20020a170902e5cb00b001b8c4021be9si3344744plf.397.2023.07.21.07.07.18; Fri, 21 Jul 2023 07:07:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dx+HoGA5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231398AbjGUNjg (ORCPT <rfc822;chrisben.tianve@gmail.com> + 99 others); Fri, 21 Jul 2023 09:39:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231365AbjGUNjd (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 21 Jul 2023 09:39:33 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD9FD1BDC for <linux-kernel@vger.kernel.org>; Fri, 21 Jul 2023 06:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689946771; x=1721482771; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=NkUrPuisbIFulQyMWqUtCvT40Kfi6q+a3Q6zjh8r0po=; b=dx+HoGA5urIbfoBvEOG7q+RX3QvrM94/r9bABHNudN1ZHwMnjWlkZeN9 DtCo3PPBm2DiKTSU0iDTWT958tLB42FJTpUEdKfUBtIhf0y9l/8GEqvMH TBkxk4AGeoykOSR+vrnSVh0QUflZDLrq2JPTbWye1QspcGLaGJ7nP2L8S fFIYEyO5IdsX2t/y/d0/gNF8f10BonT1FDuoN8jk4RvzMNoQ93uKpQuZE Q0YiKnXkPODs1vMkNzEw0HZ14yNWwHfAAvFYU3nFxxafWv9vFGHElbDEQ Kld/LwJf9swyxcYzTea040tUFi1qiW+do9QF+93dLxz8yifnuV5pUus0p w==; X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="453399308" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="453399308" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 06:39:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="754461242" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="754461242" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 21 Jul 2023 06:39:29 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id AC796370; Fri, 21 Jul 2023 16:39:36 +0300 (EEST) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Herve Codina <herve.codina@bootlin.com>, "Jason A. Donenfeld" <Jason@zx2c4.com>, linux-kernel@vger.kernel.org Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>, Andrew Morton <akpm@linux-foundation.org> Subject: [PATCH v1 1/1] minmax: Fix header inclusions Date: Fri, 21 Jul 2023 16:39:32 +0300 Message-Id: <20230721133932.12679-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772039389475508846 X-GMAIL-MSGID: 1772039389475508846 |
Series |
[v1,1/1] minmax: Fix header inclusions
|
|
Commit Message
Andy Shevchenko
July 21, 2023, 1:39 p.m. UTC
BUILD_BUG_ON*() are defined in build_bug.h.
It also provides __UNIQUE_ID() that is defined
in the compiler.h.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/minmax.h | 1 +
1 file changed, 1 insertion(+)
Comments
Hi Andy, On Fri, 21 Jul 2023 16:39:32 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > BUILD_BUG_ON*() are defined in build_bug.h. > It also provides __UNIQUE_ID() that is defined > in the compiler.h. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > include/linux/minmax.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/minmax.h b/include/linux/minmax.h > index 798c6963909f..049480235e53 100644 > --- a/include/linux/minmax.h > +++ b/include/linux/minmax.h > @@ -2,6 +2,7 @@ > #ifndef _LINUX_MINMAX_H > #define _LINUX_MINMAX_H > > +#include <linux/build_bug.h> > #include <linux/const.h> > > /* Reviewed-by: Herve Codina <herve.codina@bootlin.com> Best regards, Hervé
Hi Andy,
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on crng-random/master v6.5-rc2 next-20230721]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/minmax-Fix-header-inclusions/20230721-214152
base: linus/master
patch link: https://lore.kernel.org/r/20230721133932.12679-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/1] minmax: Fix header inclusions
config: um-allnoconfig (https://download.01.org/0day-ci/archive/20230721/202307212350.YQFKs9v6-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230721/202307212350.YQFKs9v6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307212350.YQFKs9v6-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from arch/um/os-Linux/sigio.c:6:
In file included from include/linux/minmax.h:5:
In file included from include/linux/build_bug.h:5:
>> include/linux/compiler.h:246:10: fatal error: 'asm/rwonce.h' file not found
246 | #include <asm/rwonce.h>
| ^~~~~~~~~~~~~~
1 error generated.
vim +246 include/linux/compiler.h
a9a3ed1eff3601 Borislav Petkov 2020-04-22 245
e506ea451254ab Will Deacon 2019-10-15 @246 #include <asm/rwonce.h>
e506ea451254ab Will Deacon 2019-10-15 247
On Fri, Jul 21, 2023 at 11:52:46PM +0800, kernel test robot wrote: > Hi Andy, > > kernel test robot noticed the following build errors: Oh my... UM without this header or even a stub?! Hmm... Which one else? Let's wait a few days to see. > In file included from arch/um/os-Linux/sigio.c:6: > In file included from include/linux/minmax.h:5: > In file included from include/linux/build_bug.h:5: > >> include/linux/compiler.h:246:10: fatal error: 'asm/rwonce.h' file not found > 246 | #include <asm/rwonce.h> > | ^~~~~~~~~~~~~~
Hi Andy,
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on crng-random/master v6.5-rc2 next-20230721]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/minmax-Fix-header-inclusions/20230721-214152
base: linus/master
patch link: https://lore.kernel.org/r/20230721133932.12679-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/1] minmax: Fix header inclusions
config: um-randconfig-r021-20230720 (https://download.01.org/0day-ci/archive/20230721/202307212304.cH79zJp1-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230721/202307212304.cH79zJp1-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307212304.cH79zJp1-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/build_bug.h:5,
from include/linux/minmax.h:5,
from arch/um/os-Linux/sigio.c:6:
>> include/linux/compiler.h:246:10: fatal error: asm/rwonce.h: No such file or directory
246 | #include <asm/rwonce.h>
| ^~~~~~~~~~~~~~
compilation terminated.
vim +246 include/linux/compiler.h
a9a3ed1eff3601 Borislav Petkov 2020-04-22 245
e506ea451254ab Will Deacon 2019-10-15 @246 #include <asm/rwonce.h>
e506ea451254ab Will Deacon 2019-10-15 247
On Fri, Jul 21, 2023 at 04:10:33PM +0200, Herve Codina wrote: > On Fri, 21 Jul 2023 16:39:32 +0300 > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Reviewed-by: Herve Codina <herve.codina@bootlin.com> Thank you! Note, the https://lore.kernel.org/all/20230724142307.28411-1-andriy.shevchenko@linux.intel.com/ has a fix to the broken builds the LKP reported about.
On Mon, Jul 24, 2023 at 05:29:25PM +0300, Andy Shevchenko wrote: > On Fri, Jul 21, 2023 at 04:10:33PM +0200, Herve Codina wrote: > > On Fri, 21 Jul 2023 16:39:32 +0300 > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > > Reviewed-by: Herve Codina <herve.codina@bootlin.com> > > Thank you! > > Note, the https://lore.kernel.org/all/20230724142307.28411-1-andriy.shevchenko@linux.intel.com/ > has a fix to the broken builds the LKP reported about. Andrew, since the build fix is in your tree, can you apply this one on top of that, please?
diff --git a/include/linux/minmax.h b/include/linux/minmax.h index 798c6963909f..049480235e53 100644 --- a/include/linux/minmax.h +++ b/include/linux/minmax.h @@ -2,6 +2,7 @@ #ifndef _LINUX_MINMAX_H #define _LINUX_MINMAX_H +#include <linux/build_bug.h> #include <linux/const.h> /*