[03/10] gpio: pxa: make pxa_gpio_has_pinctrl return false for MMP_GPIO

Message ID 20230721210042.21535-4-duje.mihanovic@skole.hr
State New
Headers
Series Initial Marvell PXA1908 support |

Commit Message

Duje Mihanović July 21, 2023, 8:37 p.m. UTC
  Fixes the incorrect assumption that mmp-gpio needs a pinctrl handle,
causing devices consuming GPIO to be indefinitely deferred.

Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
---
 drivers/gpio/gpio-pxa.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

andy@kernel.org July 24, 2023, 9:01 a.m. UTC | #1
On Fri, Jul 21, 2023 at 10:37:45PM +0200, Duje Mihanović wrote:
> Fixes the incorrect assumption that mmp-gpio needs a pinctrl handle,
> causing devices consuming GPIO to be indefinitely deferred.

If this is a fix, add the Fixes tag and locate it closer to the beginning of
the series, so it may be backported with an ease.
  

Patch

diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index 076ee6dff4d5..b48d142b736d 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -238,6 +238,7 @@  static bool pxa_gpio_has_pinctrl(void)
 	switch (gpio_type) {
 	case PXA3XX_GPIO:
 	case MMP2_GPIO:
+	case MMP_GPIO:
 		return false;
 
 	default: