[v1,1/1] driver core: Move dev_err_probe() to where it belogs
Commit Message
dev_err_probe() belongs to the printing API, hence
move the definition from device.h to dev_printk.h.
There is no change to the callers at all, since:
1) implementation is located in the same core.c;
2) dev_printk.h is guaranteed to be included by device.h.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/dev_printk.h | 2 ++
include/linux/device.h | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
Comments
Hi Andi,
On Fri, Jul 21, 2023 at 04:13:09PM +0300, Andy Shevchenko wrote:
> dev_err_probe() belongs to the printing API, hence
> move the definition from device.h to dev_printk.h.
>
> There is no change to the callers at all, since:
> 1) implementation is located in the same core.c;
> 2) dev_printk.h is guaranteed to be included by device.h.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
yes! I think that's right!
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Andi
@@ -274,4 +274,6 @@ do { \
WARN_ONCE(condition, "%s %s: " format, \
dev_driver_string(dev), dev_name(dev), ## arg)
+__printf(3, 4) int dev_err_probe(const struct device *dev, int err, const char *fmt, ...);
+
#endif /* _DEVICE_PRINTK_H_ */
@@ -1241,8 +1241,6 @@ void device_link_remove(void *consumer, struct device *supplier);
void device_links_supplier_sync_state_pause(void);
void device_links_supplier_sync_state_resume(void);
-__printf(3, 4) int dev_err_probe(const struct device *dev, int err, const char *fmt, ...);
-
/* Create alias, so I can be autoloaded. */
#define MODULE_ALIAS_CHARDEV(major,minor) \
MODULE_ALIAS("char-major-" __stringify(major) "-" __stringify(minor))