Message ID | CAH2r5msCqEDv1mUMMVTg8t7K+CO82Ha_xQoYJ-FkQ9h83By5wA@mail.gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp869034vqg; Sat, 22 Jul 2023 08:51:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlGjETQBP9vJrogNULIHReVSsUwuqRjMolsLF+yENqZX5CBhux2vV9ipb96qDDA6r0ZIPqBy X-Received: by 2002:a17:903:2445:b0:1b8:a7ec:38c5 with SMTP id l5-20020a170903244500b001b8a7ec38c5mr4207219pls.57.1690041110028; Sat, 22 Jul 2023 08:51:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690041110; cv=none; d=google.com; s=arc-20160816; b=hquLPz1Fdb7LM0XllkNEbIipCO8iovEQPouBgyr4MIxVfP9ikNf6bIbVjHixU5AcX3 juX+E3DhYSek4hioJMc70moGE8ma+oVkAk1ZIwlM2706ZjSOA12dwWiI3YSnqSLF98uN BJ+oRJJg/+nQb7t51nTMpyQ1+R/O77K7zzlJLA+X9sqLs8NmRimiu956+W3fS+7+sdxp WWyot924i7EwvnTstz4sUwflmcfkxVoygjWq/oZsjVNuJJx+z0cbP+4tier6QUGfhm0F NkZPKeF4eqh7MERrLQchyVozKKGyICl1pK77vlgLz9jY3UrH3gQ0igBgGMhVYtaz6rKn i5ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:mime-version :dkim-signature; bh=cj7Am9y7Ub1W147cRpCDox5jRFGPz/3xm9Zj5ypIhV4=; fh=GzNndcRkZw0PZcufD1fkGGpmHGKjMumUul1IkxTTQ3k=; b=N7FEcZ1M9GtDpShscuw5DDTSaTf1JqcSGM+cEIJ/euAzVh/SOR5M9AUVbOoEjSdKZW L55h1BZu3kYFAvKd1olET/pkaXHRCEuyU+aKhoaXwxbVWLGWQMLOAAb4u5g7zlrDOiPk 1KRFzwMa1mZ0PGmtzAdW4LuwmQuWR5m/y2wFlZjdGgmBgaQC2AGkapp/zXM5bQSD1l0r zm1D4gQHCx/kP0cF8Zjk7eF9JuaF/dl8qT/z4naS6vURFTaYZibIU2CCFLOQRmwR/MqP 3KujCYGW9rdFRoitLMojLnd4TINWE4EQ4af+8jiiI/YqHDF0++md5BcrcXP/MO37gOC6 hhsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=FgbBkhrb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h6-20020a170902680600b001b8abd7038fsi5310447plk.20.2023.07.22.08.51.37; Sat, 22 Jul 2023 08:51:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=FgbBkhrb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229703AbjGVOTj (ORCPT <rfc822;assdfgzxcv4@gmail.com> + 99 others); Sat, 22 Jul 2023 10:19:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbjGVOTi (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 22 Jul 2023 10:19:38 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A69482709; Sat, 22 Jul 2023 07:19:37 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2b703cbfaf5so41883231fa.1; Sat, 22 Jul 2023 07:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690035576; x=1690640376; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=cj7Am9y7Ub1W147cRpCDox5jRFGPz/3xm9Zj5ypIhV4=; b=FgbBkhrbb6/jRw2JfVhRhA6ZHxpJ00oIhBqj8Uizt7l1/HZk1+tLekUphlt97EHvmE PoQKWBhXXPzjrQ1/hJ9040j/tgo6pbRstMynfpJFHSvDU8HcmCI06w7iN4zpMyV0L/8G LIJteBlgAwQwCzpN36DVOMenx2AhExqe2lxVNPI0/XC67/feKivLfKRwHo7wT3NsYSHs oKgNVfijaeCuSZqdsTe5t6ZgRGQDknvmzguaz58H4Wmc4Sc8OO0yBiZoV2eZBxm/X7FS YdY/wjjYg6GUEhzojiPmtGKm8vMK5uVo0J3plISXSm169bHizaHMthIJ73hVNm7oG8F3 GORQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690035576; x=1690640376; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=cj7Am9y7Ub1W147cRpCDox5jRFGPz/3xm9Zj5ypIhV4=; b=DpAWi6pMP5CDRdGzfXEAGk2MgxKagP0LkycmZMvqcBJjy5lHm0R5wWjlNhqQGWCGJ8 L+FWQieuEedPRDTQQBRAVx0Nt/boNPg/DXRRpSg1Cd4EdJe16BHJEcjrKH/N6XisH1Ih ZqgmNFtnlHTCkP8xvZGKUKoIU28z15/bD47eO+xrQSlxiFpiWYgqlosge8pdCK15IZKc 2ai8P0AFtG929nF99q13yDAgXv4FRFqEIGX0zVm7y0RBMRjYKQDihiYfT2TD1AALVKtI iAmwponHeVQjk5BdhAcw5mzy9VuqqkM9Is321E4BGVJD+sDuX3tGsANP2lgnAX44L8Fq 5fVg== X-Gm-Message-State: ABy/qLbq3y3VK7s7mpyugV5zhVXa6O2I7M05+uFVPdheM6LaacGwbWdT fHTbI23czmbTmUP4lhyIvnJRXqDyhSaaNeKznhZ6C8gJ X-Received: by 2002:a2e:7205:0:b0:2b9:383b:89fc with SMTP id n5-20020a2e7205000000b002b9383b89fcmr3211936ljc.0.1690035575499; Sat, 22 Jul 2023 07:19:35 -0700 (PDT) MIME-Version: 1.0 From: Steve French <smfrench@gmail.com> Date: Sat, 22 Jul 2023 09:19:24 -0500 Message-ID: <CAH2r5msCqEDv1mUMMVTg8t7K+CO82Ha_xQoYJ-FkQ9h83By5wA@mail.gmail.com> Subject: [GIT PULL] smb3 client minor debugging fix To: Linus Torvalds <torvalds@linux-foundation.org> Cc: LKML <linux-kernel@vger.kernel.org>, CIFS <linux-cifs@vger.kernel.org> Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772136546459328266 X-GMAIL-MSGID: 1772136546459328266 |
Series |
[GIT,PULL] smb3 client minor debugging fix
|
|
Pull-request
git://git.samba.org/sfrench/cifs-2.6.git tags/6.5-rc2-smb3-client-fixesMessage
Steve French
July 22, 2023, 2:19 p.m. UTC
The following changes since commit fdf0eaf11452d72945af31804e2a1048ee1b574c: Linux 6.5-rc2 (2023-07-16 15:10:37 -0700) are available in the Git repository at: git://git.samba.org/sfrench/cifs-2.6.git tags/6.5-rc2-smb3-client-fixes for you to fetch changes up to ac0ce20fd8eaa9f5e193d138fbf1749c780928d0: cifs: update internal module version number for cifs.ko (2023-07-20 08:30:32 -0500) ---------------------------------------------------------------- add small debugging improvement - it is helpful for network debugging of smb3 problems to be able to use directory not just file (e.g. access to empty share) ---------------------------------------------------------------- Shyam Prasad N (1): cifs: allow dumping keys for directories too Steve French (1): cifs: update internal module version number for cifs.ko fs/smb/client/cifsfs.h | 2 +- fs/smb/client/ioctl.c | 17 +++++++++++++---- 2 files changed, 14 insertions(+), 5 deletions(-) -- Thanks, Steve
Comments
On Sat, 22 Jul 2023 at 07:19, Steve French <smfrench@gmail.com> wrote: > > add small debugging improvement > - it is helpful for network debugging of smb3 problems to be able to > use directory not just file (e.g. access to empty share) > ---------------------------------------------------------------- > Shyam Prasad N (1): > cifs: allow dumping keys for directories too > > Steve French (1): > cifs: update internal module version number for cifs.ko Bah. I pulled, and then unpulled, because that module version number change was obviously garbage. That versioning has been problematic before too, and honestly seems to be just completely broken and pointless random numbers that mostly - but not always - are in sync. This pull wasn't really a "fix" anyway, but then when I see nonsense like that I just decide it's entirely bogus. Linus
On Sat, Jul 22, 2023 at 1:24 PM Linus Torvalds <torvalds@linux-foundation.org> wrote: > > On Sat, 22 Jul 2023 at 07:19, Steve French <smfrench@gmail.com> wrote: > > > > add small debugging improvement > > - it is helpful for network debugging of smb3 problems to be able to > > use directory not just file (e.g. access to empty share) > > ---------------------------------------------------------------- > > Shyam Prasad N (1): > > cifs: allow dumping keys for directories too > > > > Steve French (1): > > cifs: update internal module version number for cifs.ko > > Bah. I pulled, and then unpulled, because that module version number > change was obviously garbage. I had missed a line in the version update. Have now fixed that typo. The module version number is used e.g. to tell when someone has backported fixes for cifs.ko to an earlier kernel release (so e.g. we can see from "modinfo cifs" or "cat /proc/fs/cifs/DebugData | grep Version" whether they are running an updated version of cifs.ko or the default version for that kernel). I try to update the module version at the end of the merge window but have sometimes delayed updating it until after an important fix. > This pull wasn't really a "fix" anyway, but then when I see nonsense > like that I just decide it's entirely bogus. For some context on the debug improvement: - the keys change improves ability to read a network trace to debug problems on encrypted connections which are very common (e.g. using wireshark or tcpdump). That works today with tools like "smbinfo keys /mnt/file" but requires passing in a filename on the mount (see e.g. https://wiki.samba.org/index.php/Wireshark_Decryption), but it often makes more sense to just pass in the mount point path (ie a directory not a filename). And this fix was needed to debug some types of problems (an obvious example is on an encrypted connection failing operations on an empty share or with no files in the root of the directory) - so you can simply pass in the "smbinfo keys <mntpoint>" and get the information that wireshark needs. I have updated to correct the version missing line at git://git.samba.org/sfrench/cifs-2.6.git tags/6.5-rc2-smb3-client-fixes-ver2
The pull request you sent on Sat, 22 Jul 2023 14:56:46 -0500:
> git://git.samba.org/sfrench/cifs-2.6.git tags/6.5-rc2-smb3-client-fixes-ver2
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/8266f53b39087c195f0d011dc5696cb2e6155242
Thank you!