Message ID | 20230721073303.112597-1-u.kleine-koenig@pengutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp38609vqg; Fri, 21 Jul 2023 00:54:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlHqOsTnoqHNBPjuj0HsKzHrwAJ1tIhJhDunmDM2gBOOcpSNlcUeK99yyho71nh3lgCtVRTG X-Received: by 2002:a05:6a21:9996:b0:131:47f7:e808 with SMTP id ve22-20020a056a21999600b0013147f7e808mr1122589pzb.26.1689926049237; Fri, 21 Jul 2023 00:54:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689926049; cv=none; d=google.com; s=arc-20160816; b=KxH6z0EULgiFJLq+dqpbSTCa9nw5ItC0wj2nP0+rEJt5QSnyPdxvDQDl5vAIcWFQW8 57IEVyz1tGwRk3NBmp/5wWrLzYPX1TTyT+6iY/EDhbqbTsvw/x3VAchFoC4mhSCF9ggA AFc44hs5UKYmS/98+JBMMMOStLsZWFXxFK2RbT/QJts6wkIa64LgzBBp2pkPntKkVggG OJYVyeTfLnpO3/t89WdzO03bx0E3xuu0volcnKw4lF3pKBuWMMYkYl5MBR4C1aCn6Ity ZBwejafMcAUeUe7zmOdjIAEah8MUmdW4/s0st2bBd3oHJfRlStDIpLL+8S0/8ljRtxNe lnsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=N1yjzaBDLVD64TpZlxn6ZOsJa555Y6x0ag57ZPK1Q4Q=; fh=hT9Xo87xuWSt6/cZxXacquYgYaj+VBAIkjLnVx78G4g=; b=n2HZTivpoul0skmHy2YdRbF1J/oPBBIGPtRD2lEufdHJbLar+Eqkg0l8gYdL/qxcz2 mewDVDNgTyTnGCO+BpB0b3lq6jZc+fY3DDdne1ryennj5bqGGwPL2GEIoCOLiopp+WH4 VNu9L3ZCkjFf923UN7/CcrLQLsSRoCNRaHXxq4kFISlk20qihcFhqBXIdJ30xU4LEpkE HTWA8prY8N5vQUdOAmEeBS5rgEHWFu5gfgjptrxfCpFpzhh06zK+Qf2NAfjZBEuO8PAJ HZRyFPmRMJp4rkzhwBiHEROatrKefd9X2i4k7tn/jqjWQOjmoAFOJsttucrjgjHxfCpx GAkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q123-20020a632a81000000b005636ef310adsi2376003pgq.597.2023.07.21.00.53.56; Fri, 21 Jul 2023 00:54:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229835AbjGUHdN (ORCPT <rfc822;chrisben.tianve@gmail.com> + 99 others); Fri, 21 Jul 2023 03:33:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbjGUHdL (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 21 Jul 2023 03:33:11 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3B5819A1 for <linux-kernel@vger.kernel.org>; Fri, 21 Jul 2023 00:33:10 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1qMkdQ-0004QZ-Rt; Fri, 21 Jul 2023 09:33:08 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1qMkdP-0010y3-Mq; Fri, 21 Jul 2023 09:33:07 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1qMkdP-006Z3w-2d; Fri, 21 Jul 2023 09:33:07 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com> Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH] regulator: max8893: Drop "_new" from probe callback Date: Fri, 21 Jul 2023 09:33:03 +0200 Message-Id: <20230721073303.112597-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1394; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=gNNwWgecuG8lSYDEqAZEIrha6k/75RXWaaE9779yXcs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkujSu+FOkhn8759g0ijWboNQ7cfiIwvX6Mdpd0 l1B8m6RxPSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZLo0rgAKCRCPgPtYfRL+ TnD5B/0VxawHr003klht5sQo0bzEZy2Zy7ZqiONEBrOryxXLJo5toRcq9IttIhttJe8sM8XGwgJ Cr7sOCpvkeDsx497R1lFwhH1y1BEcnMgwPXo5eWqdLuz10Uy6Gm0MijW+Ws63kj2dRkDjIIV2hH RrJmWlVWKMhCynuReRGx2CTdT2ivAqhqIm+/xd2Chz5UbQHfDuIr4Ty48qIAm3m5YAT02bU/MD4 cYevcsPUviH6Ki7XoPsnPuW0N2GZb+lIXRCV/OqY3IMJfGHr/fmAboPIJWgQdJjvBVQe1+OmJvp gM5zJI6l7i8OYB88OAxNw6PXnGBnwScX9RcYr+94RpIKBJno X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772015896970593479 X-GMAIL-MSGID: 1772015896970593479 |
Series |
regulator: max8893: Drop "_new" from probe callback
|
|
Commit Message
Uwe Kleine-König
July 21, 2023, 7:33 a.m. UTC
The driver was introduced when .probe_new was the right probe callback
to use for i2c drivers. Today .probe is the right one (again) and the
driver was already switched in commit 964e186547b2 ("regulator: Switch
i2c drivers back to use .probe()") but the name continued to include
"_new". To prevent code readers wondering about what might be new here,
drop that part of the name.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/regulator/max8893.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
base-commit: 964e186547b22b9c3b23fee49eb993391aa73ea8
Comments
On Fri, 21 Jul 2023 09:33:03 +0200, Uwe Kleine-König wrote: > The driver was introduced when .probe_new was the right probe callback > to use for i2c drivers. Today .probe is the right one (again) and the > driver was already switched in commit 964e186547b2 ("regulator: Switch > i2c drivers back to use .probe()") but the name continued to include > "_new". To prevent code readers wondering about what might be new here, > drop that part of the name. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/1] regulator: max8893: Drop "_new" from probe callback commit: 813ebba3b100997a24984040673d35cb2dc9f418 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/regulator/max8893.c b/drivers/regulator/max8893.c index cb0e72948dd4..30592425e193 100644 --- a/drivers/regulator/max8893.c +++ b/drivers/regulator/max8893.c @@ -125,7 +125,7 @@ static const struct regmap_config max8893_regmap = { .val_bits = 8, }; -static int max8893_probe_new(struct i2c_client *i2c) +static int max8893_probe(struct i2c_client *i2c) { int id, ret; struct regulator_config config = {.dev = &i2c->dev}; @@ -168,7 +168,7 @@ static const struct i2c_device_id max8893_ids[] = { MODULE_DEVICE_TABLE(i2c, max8893_ids); static struct i2c_driver max8893_driver = { - .probe = max8893_probe_new, + .probe = max8893_probe, .driver = { .name = "max8893", .probe_type = PROBE_PREFER_ASYNCHRONOUS,