Message ID | 20230717225446.3211738-1-robh@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1398050vqt; Mon, 17 Jul 2023 16:15:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlH/s8uYaoS1pp6JXGdZ0mL9OB2nbgpHlRZHq0U1xiCihgQTbvM9gba5rsPiqX5wFdD/Vb+S X-Received: by 2002:a5d:4a42:0:b0:315:9362:3c70 with SMTP id v2-20020a5d4a42000000b0031593623c70mr10409753wrs.60.1689635731969; Mon, 17 Jul 2023 16:15:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689635731; cv=none; d=google.com; s=arc-20160816; b=URK1XwoKHRGa19KG0FTc3uOD338yvaYRP0j09ZFogXJ8zhd+OIri3wqAc+VYQGymOc zBrHTlmqJfjCKFfdv96xG82CW88kaSjzBX5ynLSSJBc9V43DQphAAxZiSSGMpI7+0580 JP9SZVeHNF4jZdPAMorRgSG9N4cqDkQ6YLv5lUz2B0hUKDynFS6X7rh/ZAQqwn8VSbIc sXcJwKJZTZw0QtTpjkFzGA5ovcrsF5ZtLnkiwf4G/1nhCF9hKqfRi2ruNe73VGzi9O/5 T+AkruCFo2/i89wnndZZhTDgW0J0OVXoHDZMKydR/2QSeH+m5hah2x/KxxT39c/ShoDL Sg6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=RLNV7YaF9ibetEUeTbBG2m/q8pp6j+V8FlDPy76JCds=; fh=bov9u2FEpU/AtCA8PHtf/mVRXgmpfpdrfrEtdqirY7E=; b=XJObENOkooefCsiOa7WgnHd3VxNfwm62GbPKy1rB280DnC3wko3immsJBsfyQfikha s4c30hc36CQHVwuaAm8aj98q4lLO9ropGGaaqcCfBGitZSkLwvU8AZpee9PyHZO1xyeZ OoULsJDOc0pTes7k8BPyiwUr7SEKlH0t9DiRR+M1gO46AOEnAzk9jQEuJVW0dHxL3GLm CETMTgkLJYSkiBRlpbLIkvMZ9l/AmmtDD50cplfFunMKjrtvSZQOLkBew/9gBadm39If Ww/8hV5SrIxhrCzQHRJFKz/7GYQ/gWewWV/VwzaWn8cki/0N/r3iYtBCQQgHJS8Leb0i yfOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=d+xnaUrz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r19-20020a1709067fd300b00991e694a0a2si330387ejs.240.2023.07.17.16.15.07; Mon, 17 Jul 2023 16:15:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=d+xnaUrz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230391AbjGQW6s (ORCPT <rfc822;hadasmailinglist@gmail.com> + 99 others); Mon, 17 Jul 2023 18:58:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229919AbjGQW6q (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 17 Jul 2023 18:58:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABE2210EF; Mon, 17 Jul 2023 15:58:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4017C612B4; Mon, 17 Jul 2023 22:58:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1F80C433C7; Mon, 17 Jul 2023 22:58:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689634724; bh=rM26BLazDBsUWhbicT5Xil9vOWS3Rtw9EQvF4oPqBU4=; h=From:To:Cc:Subject:Date:From; b=d+xnaUrzFHksDRaRYvhXNRgDZX1mSPr8+8T2JlAVzjfLb5Ydem2RGjv/HG/6XV4q7 yndeBtrZtuOOy3WeWki60J1w7TicdtV2hdl9UHfxGS70DlD9BDkXLeyGGG5INGvs7J KHWMBTmDTWRNpRF4Sx3urZKpXpy4WBXb8Ngvw6NcACdYu7gCDxtSOY0fwDRszrjorB rHe/qr1/3cYHG+HwtW1iQOc3LuoOjhofWJvBgxCGYk0SPbUyw8rwnsU1INhXZRcp8k pgwjn3wBS96h2SJhv9juWlGzzwN+agtw9ScLFQM51oIoN+792a0PdyVE3oLKLzdjE4 V7t1LsOU3SNpA== Received: (nullmailer pid 3211848 invoked by uid 1000); Mon, 17 Jul 2023 22:54:49 -0000 From: Rob Herring <robh@kernel.org> To: Russell King <linux@armlinux.org.uk>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Alim Akhtar <alim.akhtar@samsung.com> Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: s5pv210: Explicitly include correct DT includes Date: Mon, 17 Jul 2023 16:54:46 -0600 Message-Id: <20230717225446.3211738-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771711477172201860 X-GMAIL-MSGID: 1771711477172201860 |
Series |
ARM: s5pv210: Explicitly include correct DT includes
|
|
Commit Message
Rob Herring
July 17, 2023, 10:54 p.m. UTC
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it was merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. --- arch/arm/mach-s5pv210/s5pv210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 18/07/2023 00:54, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it was merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. Your SoB is missing. Best regards, Krzysztof
diff --git a/arch/arm/mach-s5pv210/s5pv210.c b/arch/arm/mach-s5pv210/s5pv210.c index a21ed3bb992a..7d4a10184160 100644 --- a/arch/arm/mach-s5pv210/s5pv210.c +++ b/arch/arm/mach-s5pv210/s5pv210.c @@ -7,7 +7,7 @@ // Tomasz Figa <t.figa@samsung.com> #include <linux/of_fdt.h> -#include <linux/of_platform.h> +#include <linux/platform_device.h> #include <asm/mach/arch.h> #include <asm/mach/map.h>