| Message ID | 20230718090914.282293-1-eugen.hristev@collabora.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1610664vqt;
Tue, 18 Jul 2023 02:20:10 -0700 (PDT)
X-Google-Smtp-Source:
APBJJlH2+nnvVSqpizYvhbKxkI6KhtqSP+/7lPJW5g9MeHZ/xo3qBdXC3VoKK51WoGi+wh4tvJhP
X-Received: by 2002:a05:6a00:24d3:b0:666:ecf4:ed6d with SMTP id
d19-20020a056a0024d300b00666ecf4ed6dmr16073235pfv.18.1689672009767;
Tue, 18 Jul 2023 02:20:09 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1689672009; cv=none;
d=google.com; s=arc-20160816;
b=Qyn35awof9SeURPlXL25s2DfG78PGawVN5cwa7cRbdnt0QLFd2+59in+HZBod1GT+Z
BiibkPtBG3FWVWdPnMiETsWh2AbLZuVOIXkc2GzSjAFbNQ62fBPJn8r4/cs0a+iMC8qd
yzYTIStNUEsE9jcyjjBggYLKuxZMEagCy8IF8VFZXq7nQFPAZsQSVjLDIiMAtDVduAJz
aEmFjbTyne+H8j26aftzEW2kZ8wAacIhLNYVQ4TfwV6vzUOhMExSGg7lxt3lRGWtkCvu
LPc5mkMT5aoXS/Xsav/kIUttx7lVei67Lk1N5hzP5uAyPPwUEC4Jr7Om1gALB5loSPVS
A1ZQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=/6a+tXFxl3r/5auV72BobxwkqzuxuuRZS1JxLDwxIno=;
fh=DdVF+jg12jnBgVudidVwb6oEz29KBOXllE7XAsd4/Yc=;
b=jiAd7PK6C/C1qd7PTMgB/Urpu9g5hZxQrH8Frl4eYK5kjPzIwm6YgfUVml8zDXHRb5
/hXJhvuv5Fvfd3bpaNhKHm6uSyM8dVD9ek85ZHghw85L2nX4M3qOAAKz3bZQ9sH+3X60
QCTsklNisU6V95n39xeDnLbpZQrdR3ShaKIUI8Zu2PwfwMRRphQoVZyM0cQdjg6dJj37
JPOrQztRmuMdBikqTafhiwtaE8zZe6iVaBbOJX9qGXgISXy9DYV0SKcePPX5VqeLoNx5
yQ5OksmdRuWT43xfBhPN94C/u5a/w1/xObM8cVnfLfMC+K4kLmNaE9r7M8ljr6NgLG68
gLsg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=LA3ZsJ3+;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=collabora.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
h20-20020a056a00219400b0068224c12950si1281646pfi.64.2023.07.18.02.19.56;
Tue, 18 Jul 2023 02:20:09 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=LA3ZsJ3+;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=collabora.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231879AbjGRJJh (ORCPT <rfc822;assdfgzxcv4@gmail.com>
+ 99 others); Tue, 18 Jul 2023 05:09:37 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50002 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229471AbjGRJJf (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 18 Jul 2023 05:09:35 -0400
Received: from madras.collabora.co.uk (madras.collabora.co.uk
[IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0B02E4C;
Tue, 18 Jul 2023 02:09:31 -0700 (PDT)
Received: from eugen-station.. (unknown [82.76.24.202])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits)
server-digest SHA256)
(No client certificate requested)
(Authenticated sender: ehristev)
by madras.collabora.co.uk (Postfix) with ESMTPSA id 02201660702C;
Tue, 18 Jul 2023 10:09:29 +0100 (BST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
s=mail; t=1689671370;
bh=LRgumKXnd6HM84mjqPVewOO4GAbvkbnnAGnSqH3ASMI=;
h=From:To:Cc:Subject:Date:From;
b=LA3ZsJ3+9vkedXXQOHUVhKKF9X4DaU/+cqVSkYFPUm3vYxLoFvr2h7SIFCwNPxCs8
BslBR6YzrSsk5soWRFYnoozpj49DLm5bY6IolMENAqGg4o5QOgrThCL8XjDVIrZ8HI
rC05vfQ55eYePb4uM3gSwhywP8gYY83c9/hGiGFfgp3I1mxWsKEaogCAtVqZSDXhMt
WTFhrm3tmVTR2eqvY1gOhlbmfpbMFQ+wFSfrYzst7sM79t6MaD8p2hs7fyOdX+2Kxx
2CvqLHepOq43ZHmJlaAJk5sS2pk23bkKSyOi7W7q2zAw3dCNpf0lD6p2kqu4kxuUpc
i49kF5T8bgD/g==
From: Eugen Hristev <eugen.hristev@collabora.com>
To: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org
Cc: david.wu@rock-chips.com, heiko@sntech.de,
krzysztof.kozlowski+dt@linaro.org, kernel@collabora.com,
Eugen Hristev <eugen.hristev@collabora.com>
Subject: [PATCH] dt-bindings: net: rockchip-dwmac: add default 'input' for
clock_in_out
Date: Tue, 18 Jul 2023 12:09:14 +0300
Message-Id: <20230718090914.282293-1-eugen.hristev@collabora.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1771749517393071417
X-GMAIL-MSGID: 1771749517393071417
|
| Series |
dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out
|
|
Commit Message
Eugen Hristev
July 18, 2023, 9:09 a.m. UTC
'clock_in_out' property is optional, and it can be one of two enums.
The binding does not specify what is the behavior when the property is
missing altogether.
Hence, add a default value that the driver can use.
Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
---
Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 +
1 file changed, 1 insertion(+)
Comments
Hi, On Tue, Jul 18, 2023 at 12:09:14PM +0300, Eugen Hristev wrote: > 'clock_in_out' property is optional, and it can be one of two enums. > The binding does not specify what is the behavior when the property is > missing altogether. > Hence, add a default value that the driver can use. > > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> > --- Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> -- Sebastian > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > index 176ea5f90251..bb943c96c196 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > @@ -80,6 +80,7 @@ properties: > "output" means GMAC provides the reference clock. > $ref: /schemas/types.yaml#/definitions/string > enum: [input, output] > + default: input > > rockchip,grf: > description: The phandle of the syscon node for the general register file. > -- > 2.34.1 > > > -- > To unsubscribe, send mail to kernel-unsubscribe@lists.collabora.co.uk.
On Tue, 18 Jul 2023 12:09:14 +0300, Eugen Hristev wrote: > 'clock_in_out' property is optional, and it can be one of two enums. > The binding does not specify what is the behavior when the property is > missing altogether. > Hence, add a default value that the driver can use. > > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> > --- > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 18 Jul 2023 12:09:14 +0300 you wrote: > 'clock_in_out' property is optional, and it can be one of two enums. > The binding does not specify what is the behavior when the property is > missing altogether. > Hence, add a default value that the driver can use. > > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> > > [...] Here is the summary with links: - dt-bindings: net: rockchip-dwmac: add default 'input' for clock_in_out https://git.kernel.org/netdev/net-next/c/51318bf44395 You are awesome, thank you!
diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml index 176ea5f90251..bb943c96c196 100644 --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml @@ -80,6 +80,7 @@ properties: "output" means GMAC provides the reference clock. $ref: /schemas/types.yaml#/definitions/string enum: [input, output] + default: input rockchip,grf: description: The phandle of the syscon node for the general register file.