| Message ID | 20230607170724.2016988-2-tharvey@gateworks.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp361846vqr;
Wed, 7 Jun 2023 10:24:34 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ7r092rc4RZEVhKCjoGgQMtK5/6lubAWHHUgdNaZSzkA6vlWTnChwmAQZ+qNBsxRqX8j/lR
X-Received: by 2002:a05:6a20:5485:b0:118:a68f:8035 with SMTP id
i5-20020a056a20548500b00118a68f8035mr79667pzk.45.1686158674404;
Wed, 07 Jun 2023 10:24:34 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1686158674; cv=none;
d=google.com; s=arc-20160816;
b=mDft3QZbE0cOWn+cnAzzwbVQIdsSouaMEc4krRZ6b7v5NrHbP5YIlIJ4srE4PaFL3g
fMBYQN9kbPz5YHIgTGImY4oDylqTn1KiCkin41tSSNXWyUuZqSNWwpPR3g8HAPSGadXe
iIievMMvhobllnEifVDYSxtuNj4RvZ/z51fQuh8ixQcmEHnPmWf9yGq8hu+rDnlDppnj
4nLl0PUABJTNe+3QGb2dP5g8gnKjBnErHU7txxUDKqoEgnCvoqx42IVkGfcEKWP1h18n
CJLrZrLeWMfa/wG+oX04O/BFqlSvXGm85gZVU+OWrBu6tzrq0mMojpjwmI7FvJUYbcFK
sf7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=U2rQNT/uwfpWuZRSMHuPg8F8q+l9EpFJmcGaA3GWsP4=;
b=S4kMN2+IoXaso9E4PrMWENzGIMDtDZ1pKdNkr3oTxqOMoJUy4X321MIhxXH3Um/1K1
qst6rurQTp3XzHgNgdsOvmMMq7fHSsSL4yKeQImFR+knFfyHzl411ci0kjO5TsObcUFy
AmvtvdjrbgDxbvcUXAbfg5oIKvS9SMZOXroJkQEL9wAvW5akBxrlEOdtmq3MU3qVhsK5
bec1W5TAfWn3wHt38vr/SiExmXJ4yin8v1RgglPb7lMQFDq70GHj/6XR/uYtX3zGYHDv
ZNvPXwkIs8R+QK033jDjYHBn+KtmE21o8ysAMNslSokq2XpziqdtEvhxlGUssyL/SAxV
5gdQ==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
v29-20020a63b95d000000b005347fcb785bsi9097617pgo.204.2023.06.07.10.24.20;
Wed, 07 Jun 2023 10:24:34 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231420AbjFGRHn (ORCPT <rfc822;literming00@gmail.com>
+ 99 others); Wed, 7 Jun 2023 13:07:43 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45336 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231384AbjFGRHl (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 7 Jun 2023 13:07:41 -0400
Received: from finn.localdomain (finn.gateworks.com [108.161.129.64])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4C251BEA;
Wed, 7 Jun 2023 10:07:39 -0700 (PDT)
Received: from 068-189-091-139.biz.spectrum.com ([68.189.91.139]
helo=tharvey.pdc.gateworks.com)
by finn.localdomain with esmtp (Exim 4.93)
(envelope-from <tharvey@gateworks.com>)
id 1q6wd5-0069bl-IN; Wed, 07 Jun 2023 17:07:27 +0000
From: Tim Harvey <tharvey@gateworks.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Tim Harvey <tharvey@gateworks.com>
Subject: [PATCH 2/2] arm64: dts: freescale: Add imx8mp-venice-gw71xx-2x
Date: Wed, 7 Jun 2023 10:07:24 -0700
Message-Id: <20230607170724.2016988-2-tharvey@gateworks.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20230607170724.2016988-1-tharvey@gateworks.com>
References: <20230607170724.2016988-1-tharvey@gateworks.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1768065517701383275?=
X-GMAIL-MSGID: =?utf-8?q?1768065517701383275?=
|
| Series |
[1/2] dt-bindings: arm: Add Gateworks i.MX8M Mini gw71xx-2x board
|
|
Commit Message
Tim Harvey
June 7, 2023, 5:07 p.m. UTC
The Gateworks imx8mp-venice-gw71xx-2x consists of a SOM + baseboard.
The GW702x SOM contains the following:
- i.MX8M Plus SoC
- LPDDR4 memory
- eMMC Boot device
- Gateworks System Controller (GSC) with integrated EEPROM, button
controller, and ADC's
- PMIC
- SOM connector providing:
- eQoS GbE MII
- 1x SPI
- 2x I2C
- 4x UART
- 2x USB 3.0
- 1x PCI
- 1x SDIO (4-bit 3.3V)
- 1x SDIO (4-bit 3.3V/1.8V)
- GPIO
The GW71xx Baseboard contains the following:
- GPS
- RJ45 GbE (eQoS)
- off-board I/O connector with UART, I2C, SPI, GPIO
- EERPOM
- PCIe clock generator
- full-length miniPCIe socket with PCI/USB3 (via mux) and USB2.0
- USB Type-C with USB 2.0 host and peripheral support
- Wide range DC input supply
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
arch/arm64/boot/dts/freescale/Makefile | 1 +
.../dts/freescale/imx8mp-venice-gw71xx-2x.dts | 19 ++
.../dts/freescale/imx8mp-venice-gw71xx.dtsi | 236 ++++++++++++++++++
3 files changed, 256 insertions(+)
create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts
create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi
Comments
On Wed, Jun 07, 2023 at 10:07:24AM -0700, Tim Harvey wrote: > The Gateworks imx8mp-venice-gw71xx-2x consists of a SOM + baseboard. > > The GW702x SOM contains the following: > - i.MX8M Plus SoC > - LPDDR4 memory > - eMMC Boot device > - Gateworks System Controller (GSC) with integrated EEPROM, button > controller, and ADC's > - PMIC > - SOM connector providing: > - eQoS GbE MII > - 1x SPI > - 2x I2C > - 4x UART > - 2x USB 3.0 > - 1x PCI > - 1x SDIO (4-bit 3.3V) > - 1x SDIO (4-bit 3.3V/1.8V) > - GPIO > > The GW71xx Baseboard contains the following: > - GPS > - RJ45 GbE (eQoS) > - off-board I/O connector with UART, I2C, SPI, GPIO > - EERPOM > - PCIe clock generator > - full-length miniPCIe socket with PCI/USB3 (via mux) and USB2.0 > - USB Type-C with USB 2.0 host and peripheral support > - Wide range DC input supply > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > --- > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../dts/freescale/imx8mp-venice-gw71xx-2x.dts | 19 ++ > .../dts/freescale/imx8mp-venice-gw71xx.dtsi | 236 ++++++++++++++++++ > 3 files changed, 256 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 62f22b77b38b..b3bb823d0168 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -101,6 +101,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw71xx-2x.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw74xx.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw7905-2x.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mp-verdin-nonwifi-dahlia.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts > new file mode 100644 > index 000000000000..53120fc9cd7f > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts > @@ -0,0 +1,19 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2023 Gateworks Corporation > + */ > + > +/dts-v1/; > + > +#include "imx8mp.dtsi" > +#include "imx8mp-venice-gw702x.dtsi" > +#include "imx8mp-venice-gw71xx.dtsi" > + > +/ { > + model = "Gateworks Venice GW71xx-2x i.MX8MP Development Kit"; > + compatible = "gateworks,imx8mp-gw71xx-2x", "fsl,imx8mp"; > + > + chosen { > + stdout-path = &uart2; > + }; > +}; > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi > new file mode 100644 > index 000000000000..86999f52d4b2 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi > @@ -0,0 +1,236 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2023 Gateworks Corporation > + */ > + > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/leds/common.h> > +#include <dt-bindings/phy/phy-imx8-pcie.h> > + > +/ { > + led-controller { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_gpio_leds>; > + > + led-0 { > + function = LED_FUNCTION_STATUS; > + color = <LED_COLOR_ID_GREEN>; > + gpios = <&gpio4 1 GPIO_ACTIVE_HIGH>; > + default-state = "on"; > + linux,default-trigger = "heartbeat"; > + }; > + > + led-1 { > + function = LED_FUNCTION_STATUS; > + color = <LED_COLOR_ID_RED>; > + gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>; > + default-state = "off"; > + }; > + }; > + > + pcie0_refclk: pcie0-refclk { Can we name the node clock-xxx? > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <100000000>; > + }; > + > + pps { > + compatible = "pps-gpio"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pps>; > + gpios = <&gpio4 3 GPIO_ACTIVE_HIGH>; > + status = "okay"; > + }; > +}; > + > +/* off-board header */ > +&ecspi2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_spi2>; > + cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>; > + status = "okay"; > +}; > + > +&gpio4 { > + gpio-line-names = > + "", "", "", "", > + "", "", "", "", > + "dio1", "", "", "dio0", > + "", "", "pci_usb_sel", "", > + "", "", "", "", > + "", "", "", "", > + "dio3", "", "dio2", "", > + "pci_wdis#", "", "", ""; > +}; > + > +&i2c2 { > + clock-frequency = <400000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c2>; > + status = "okay"; > + > + accelerometer@19 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_accel>; > + compatible = "st,lis2de12"; > + reg = <0x19>; Can we start the property list from these two? > + st,drdy-int-pin = <1>; > + interrupt-parent = <&gpio4>; > + interrupts = <21 IRQ_TYPE_LEVEL_LOW>; > + interrupt-names = "INT1"; > + }; > +}; > + > +&pcie_phy { > + fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>; > + fsl,clkreq-unsupported; > + clocks = <&pcie0_refclk>; > + clock-names = "ref"; > + status = "okay"; > +}; > + > +&pcie { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pcie0>; > + reset-gpio = <&gpio4 29 GPIO_ACTIVE_LOW>; > + status = "okay"; > +}; > + > +/* GPS */ > +&uart1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart1>; > + status = "okay"; > +}; > + > +/* off-board header */ > +&uart3 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart3>; > + status = "okay"; > +}; > + > +/* USB1 Type-C front panel */ > +&usb3_0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb1>; > + fsl,over-current-active-low; > + status = "okay"; > +}; > + > +&usb3_phy0 { > + status = "okay"; > +}; > + > +&usb_dwc3_0 { > + /* dual role is implemented but not a full featured OTG */ > + adp-disable; > + hnp-disable; > + srp-disable; > + dr_mode = "otg"; > + usb-role-switch; > + role-switch-default-mode = "peripheral"; > + status = "okay"; > + > + connector { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usbcon1>; > + compatible = "gpio-usb-b-connector", "usb-b-connector"; Start the properties from 'compatible'? Shawn > + type = "micro"; > + label = "Type-C"; > + id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; > + }; > +}; > + > +/* USB2 - MiniPCIe socket */ > +&usb3_1 { > + fsl,permanently-attached; > + fsl,disable-port-power-control; > + status = "okay"; > +}; > + > +&usb3_phy1 { > + status = "okay"; > +}; > + > +&usb_dwc3_1 { > + dr_mode = "host"; > + status = "okay"; > +}; > + > +&iomuxc { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_hog>; > + > + pinctrl_hog: hoggrp { > + fsl,pins = < > + MX8MP_IOMUXC_SAI1_RXD6__GPIO4_IO08 0x40000146 /* DIO1 */ > + MX8MP_IOMUXC_SAI1_TXC__GPIO4_IO11 0x40000146 /* DIO0 */ > + MX8MP_IOMUXC_SAI1_TXD2__GPIO4_IO14 0x40000106 /* PCIE_USBSEL */ > + MX8MP_IOMUXC_SAI2_TXD0__GPIO4_IO26 0x40000146 /* DIO2 */ > + MX8MP_IOMUXC_SAI2_TXFS__GPIO4_IO24 0x40000146 /* DIO3 */ > + MX8MP_IOMUXC_SAI3_RXFS__GPIO4_IO28 0x40000106 /* PCIE_WDIS# */ > + >; > + }; > + > + pinctrl_accel: accelgrp { > + fsl,pins = < > + MX8MP_IOMUXC_SAI2_RXFS__GPIO4_IO21 0x150 /* IRQ */ > + >; > + }; > + > + pinctrl_gpio_leds: gpioledgrp { > + fsl,pins = < > + MX8MP_IOMUXC_SAI1_RXC__GPIO4_IO01 0x6 /* LEDG */ > + MX8MP_IOMUXC_SAI1_RXD3__GPIO4_IO05 0x6 /* LEDR */ > + >; > + }; > + > + pinctrl_pcie0: pcie0grp { > + fsl,pins = < > + MX8MP_IOMUXC_SAI3_RXC__GPIO4_IO29 0x106 > + >; > + }; > + > + pinctrl_pps: ppsgrp { > + fsl,pins = < > + MX8MP_IOMUXC_SAI1_RXD1__GPIO4_IO03 0x146 > + >; > + }; > + > + pinctrl_usb1: usb1grp { > + fsl,pins = < > + MX8MP_IOMUXC_GPIO1_IO13__USB1_OTG_OC 0x140 /* USB1_FLT# */ > + >; > + }; > + > + pinctrl_usbcon1: usbcon1grp { > + fsl,pins = < > + MX8MP_IOMUXC_SAI5_RXD0__GPIO3_IO21 0x140 /* USB1_ID */ > + >; > + }; > + > + pinctrl_spi2: spi2grp { > + fsl,pins = < > + MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK 0x140 > + MX8MP_IOMUXC_ECSPI2_MOSI__ECSPI2_MOSI 0x140 > + MX8MP_IOMUXC_ECSPI2_MISO__ECSPI2_MISO 0x140 > + MX8MP_IOMUXC_ECSPI2_SS0__GPIO5_IO13 0x140 > + >; > + }; > + > + pinctrl_uart1: uart1grp { > + fsl,pins = < > + MX8MP_IOMUXC_UART1_RXD__UART1_DCE_RX 0x140 > + MX8MP_IOMUXC_UART1_TXD__UART1_DCE_TX 0x140 > + >; > + }; > + > + pinctrl_uart3: uart3grp { > + fsl,pins = < > + MX8MP_IOMUXC_UART3_RXD__UART3_DCE_RX 0x140 > + MX8MP_IOMUXC_UART3_TXD__UART3_DCE_TX 0x140 > + >; > + }; > +}; > -- > 2.25.1 >
On Sun, Jul 16, 2023 at 5:27 PM Shawn Guo <shawnguo@kernel.org> wrote: > > On Wed, Jun 07, 2023 at 10:07:24AM -0700, Tim Harvey wrote: > > The Gateworks imx8mp-venice-gw71xx-2x consists of a SOM + baseboard. > > > > The GW702x SOM contains the following: > > - i.MX8M Plus SoC > > - LPDDR4 memory > > - eMMC Boot device > > - Gateworks System Controller (GSC) with integrated EEPROM, button > > controller, and ADC's > > - PMIC > > - SOM connector providing: > > - eQoS GbE MII > > - 1x SPI > > - 2x I2C > > - 4x UART > > - 2x USB 3.0 > > - 1x PCI > > - 1x SDIO (4-bit 3.3V) > > - 1x SDIO (4-bit 3.3V/1.8V) > > - GPIO > > > > The GW71xx Baseboard contains the following: > > - GPS > > - RJ45 GbE (eQoS) > > - off-board I/O connector with UART, I2C, SPI, GPIO > > - EERPOM > > - PCIe clock generator > > - full-length miniPCIe socket with PCI/USB3 (via mux) and USB2.0 > > - USB Type-C with USB 2.0 host and peripheral support > > - Wide range DC input supply > > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > > --- > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > .../dts/freescale/imx8mp-venice-gw71xx-2x.dts | 19 ++ > > .../dts/freescale/imx8mp-venice-gw71xx.dtsi | 236 ++++++++++++++++++ > > 3 files changed, 256 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > index 62f22b77b38b..b3bb823d0168 100644 > > --- a/arch/arm64/boot/dts/freescale/Makefile > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > @@ -101,6 +101,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw71xx-2x.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw74xx.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw7905-2x.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-verdin-nonwifi-dahlia.dtb > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts > > new file mode 100644 > > index 000000000000..53120fc9cd7f > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts > > @@ -0,0 +1,19 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright 2023 Gateworks Corporation > > + */ > > + > > +/dts-v1/; > > + > > +#include "imx8mp.dtsi" > > +#include "imx8mp-venice-gw702x.dtsi" > > +#include "imx8mp-venice-gw71xx.dtsi" > > + > > +/ { > > + model = "Gateworks Venice GW71xx-2x i.MX8MP Development Kit"; > > + compatible = "gateworks,imx8mp-gw71xx-2x", "fsl,imx8mp"; > > + > > + chosen { > > + stdout-path = &uart2; > > + }; > > +}; > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi > > new file mode 100644 > > index 000000000000..86999f52d4b2 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi > > @@ -0,0 +1,236 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright 2023 Gateworks Corporation > > + */ > > + > > +#include <dt-bindings/gpio/gpio.h> > > +#include <dt-bindings/leds/common.h> > > +#include <dt-bindings/phy/phy-imx8-pcie.h> > > + > > +/ { > > + led-controller { > > + compatible = "gpio-leds"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_gpio_leds>; > > + > > + led-0 { > > + function = LED_FUNCTION_STATUS; > > + color = <LED_COLOR_ID_GREEN>; > > + gpios = <&gpio4 1 GPIO_ACTIVE_HIGH>; > > + default-state = "on"; > > + linux,default-trigger = "heartbeat"; > > + }; > > + > > + led-1 { > > + function = LED_FUNCTION_STATUS; > > + color = <LED_COLOR_ID_RED>; > > + gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>; > > + default-state = "off"; > > + }; > > + }; > > + > > + pcie0_refclk: pcie0-refclk { > > Can we name the node clock-xxx? > > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <100000000>; > > + }; > > + > > + pps { > > + compatible = "pps-gpio"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_pps>; > > + gpios = <&gpio4 3 GPIO_ACTIVE_HIGH>; > > + status = "okay"; > > + }; > > +}; > > + > > +/* off-board header */ > > +&ecspi2 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_spi2>; > > + cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>; > > + status = "okay"; > > +}; > > + > > +&gpio4 { > > + gpio-line-names = > > + "", "", "", "", > > + "", "", "", "", > > + "dio1", "", "", "dio0", > > + "", "", "pci_usb_sel", "", > > + "", "", "", "", > > + "", "", "", "", > > + "dio3", "", "dio2", "", > > + "pci_wdis#", "", "", ""; > > +}; > > + > > +&i2c2 { > > + clock-frequency = <400000>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_i2c2>; > > + status = "okay"; > > + > > + accelerometer@19 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_accel>; > > + compatible = "st,lis2de12"; > > + reg = <0x19>; > > Can we start the property list from these two? > > > + st,drdy-int-pin = <1>; > > + interrupt-parent = <&gpio4>; > > + interrupts = <21 IRQ_TYPE_LEVEL_LOW>; > > + interrupt-names = "INT1"; > > + }; > > +}; > > + > > +&pcie_phy { > > + fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>; > > + fsl,clkreq-unsupported; > > + clocks = <&pcie0_refclk>; > > + clock-names = "ref"; > > + status = "okay"; > > +}; > > + > > +&pcie { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_pcie0>; > > + reset-gpio = <&gpio4 29 GPIO_ACTIVE_LOW>; > > + status = "okay"; > > +}; > > + > > +/* GPS */ > > +&uart1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_uart1>; > > + status = "okay"; > > +}; > > + > > +/* off-board header */ > > +&uart3 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_uart3>; > > + status = "okay"; > > +}; > > + > > +/* USB1 Type-C front panel */ > > +&usb3_0 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_usb1>; > > + fsl,over-current-active-low; > > + status = "okay"; > > +}; > > + > > +&usb3_phy0 { > > + status = "okay"; > > +}; > > + > > +&usb_dwc3_0 { > > + /* dual role is implemented but not a full featured OTG */ > > + adp-disable; > > + hnp-disable; > > + srp-disable; > > + dr_mode = "otg"; > > + usb-role-switch; > > + role-switch-default-mode = "peripheral"; > > + status = "okay"; > > + > > + connector { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_usbcon1>; > > + compatible = "gpio-usb-b-connector", "usb-b-connector"; > > Start the properties from 'compatible'? > > Shawn > Hi Shawn, My notes say that pinctrl should come first (if needed) followed by compatible, reg, other props, and finally status (if needed). Assuming I'm wrong about that where in the list should pinctrl be and is this documented anywhere for future reference? Best regards, Tim > > + type = "micro"; > > + label = "Type-C"; > > + id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; > > + }; > > +}; > > + > > +/* USB2 - MiniPCIe socket */ > > +&usb3_1 { > > + fsl,permanently-attached; > > + fsl,disable-port-power-control; > > + status = "okay"; > > +}; > > + > > +&usb3_phy1 { > > + status = "okay"; > > +}; > > + > > +&usb_dwc3_1 { > > + dr_mode = "host"; > > + status = "okay"; > > +}; > > + > > +&iomuxc { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_hog>; > > + > > + pinctrl_hog: hoggrp { > > + fsl,pins = < > > + MX8MP_IOMUXC_SAI1_RXD6__GPIO4_IO08 0x40000146 /* DIO1 */ > > + MX8MP_IOMUXC_SAI1_TXC__GPIO4_IO11 0x40000146 /* DIO0 */ > > + MX8MP_IOMUXC_SAI1_TXD2__GPIO4_IO14 0x40000106 /* PCIE_USBSEL */ > > + MX8MP_IOMUXC_SAI2_TXD0__GPIO4_IO26 0x40000146 /* DIO2 */ > > + MX8MP_IOMUXC_SAI2_TXFS__GPIO4_IO24 0x40000146 /* DIO3 */ > > + MX8MP_IOMUXC_SAI3_RXFS__GPIO4_IO28 0x40000106 /* PCIE_WDIS# */ > > + >; > > + }; > > + > > + pinctrl_accel: accelgrp { > > + fsl,pins = < > > + MX8MP_IOMUXC_SAI2_RXFS__GPIO4_IO21 0x150 /* IRQ */ > > + >; > > + }; > > + > > + pinctrl_gpio_leds: gpioledgrp { > > + fsl,pins = < > > + MX8MP_IOMUXC_SAI1_RXC__GPIO4_IO01 0x6 /* LEDG */ > > + MX8MP_IOMUXC_SAI1_RXD3__GPIO4_IO05 0x6 /* LEDR */ > > + >; > > + }; > > + > > + pinctrl_pcie0: pcie0grp { > > + fsl,pins = < > > + MX8MP_IOMUXC_SAI3_RXC__GPIO4_IO29 0x106 > > + >; > > + }; > > + > > + pinctrl_pps: ppsgrp { > > + fsl,pins = < > > + MX8MP_IOMUXC_SAI1_RXD1__GPIO4_IO03 0x146 > > + >; > > + }; > > + > > + pinctrl_usb1: usb1grp { > > + fsl,pins = < > > + MX8MP_IOMUXC_GPIO1_IO13__USB1_OTG_OC 0x140 /* USB1_FLT# */ > > + >; > > + }; > > + > > + pinctrl_usbcon1: usbcon1grp { > > + fsl,pins = < > > + MX8MP_IOMUXC_SAI5_RXD0__GPIO3_IO21 0x140 /* USB1_ID */ > > + >; > > + }; > > + > > + pinctrl_spi2: spi2grp { > > + fsl,pins = < > > + MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK 0x140 > > + MX8MP_IOMUXC_ECSPI2_MOSI__ECSPI2_MOSI 0x140 > > + MX8MP_IOMUXC_ECSPI2_MISO__ECSPI2_MISO 0x140 > > + MX8MP_IOMUXC_ECSPI2_SS0__GPIO5_IO13 0x140 > > + >; > > + }; > > + > > + pinctrl_uart1: uart1grp { > > + fsl,pins = < > > + MX8MP_IOMUXC_UART1_RXD__UART1_DCE_RX 0x140 > > + MX8MP_IOMUXC_UART1_TXD__UART1_DCE_TX 0x140 > > + >; > > + }; > > + > > + pinctrl_uart3: uart3grp { > > + fsl,pins = < > > + MX8MP_IOMUXC_UART3_RXD__UART3_DCE_RX 0x140 > > + MX8MP_IOMUXC_UART3_TXD__UART3_DCE_TX 0x140 > > + >; > > + }; > > +}; > > -- > > 2.25.1 > >
On Tue, Jul 18, 2023 at 02:16:22PM -0700, Tim Harvey wrote: > On Sun, Jul 16, 2023 at 5:27 PM Shawn Guo <shawnguo@kernel.org> wrote: > > > > On Wed, Jun 07, 2023 at 10:07:24AM -0700, Tim Harvey wrote: > > > The Gateworks imx8mp-venice-gw71xx-2x consists of a SOM + baseboard. > > > > > > The GW702x SOM contains the following: > > > - i.MX8M Plus SoC > > > - LPDDR4 memory > > > - eMMC Boot device > > > - Gateworks System Controller (GSC) with integrated EEPROM, button > > > controller, and ADC's > > > - PMIC > > > - SOM connector providing: > > > - eQoS GbE MII > > > - 1x SPI > > > - 2x I2C > > > - 4x UART > > > - 2x USB 3.0 > > > - 1x PCI > > > - 1x SDIO (4-bit 3.3V) > > > - 1x SDIO (4-bit 3.3V/1.8V) > > > - GPIO > > > > > > The GW71xx Baseboard contains the following: > > > - GPS > > > - RJ45 GbE (eQoS) > > > - off-board I/O connector with UART, I2C, SPI, GPIO > > > - EERPOM > > > - PCIe clock generator > > > - full-length miniPCIe socket with PCI/USB3 (via mux) and USB2.0 > > > - USB Type-C with USB 2.0 host and peripheral support > > > - Wide range DC input supply > > > > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > > > --- > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > .../dts/freescale/imx8mp-venice-gw71xx-2x.dts | 19 ++ > > > .../dts/freescale/imx8mp-venice-gw71xx.dtsi | 236 ++++++++++++++++++ > > > 3 files changed, 256 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > > index 62f22b77b38b..b3bb823d0168 100644 > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > @@ -101,6 +101,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw71xx-2x.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw74xx.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw7905-2x.dtb > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-verdin-nonwifi-dahlia.dtb > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts > > > new file mode 100644 > > > index 000000000000..53120fc9cd7f > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts > > > @@ -0,0 +1,19 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright 2023 Gateworks Corporation > > > + */ > > > + > > > +/dts-v1/; > > > + > > > +#include "imx8mp.dtsi" > > > +#include "imx8mp-venice-gw702x.dtsi" > > > +#include "imx8mp-venice-gw71xx.dtsi" > > > + > > > +/ { > > > + model = "Gateworks Venice GW71xx-2x i.MX8MP Development Kit"; > > > + compatible = "gateworks,imx8mp-gw71xx-2x", "fsl,imx8mp"; > > > + > > > + chosen { > > > + stdout-path = &uart2; > > > + }; > > > +}; > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi > > > new file mode 100644 > > > index 000000000000..86999f52d4b2 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi > > > @@ -0,0 +1,236 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright 2023 Gateworks Corporation > > > + */ > > > + > > > +#include <dt-bindings/gpio/gpio.h> > > > +#include <dt-bindings/leds/common.h> > > > +#include <dt-bindings/phy/phy-imx8-pcie.h> > > > + > > > +/ { > > > + led-controller { > > > + compatible = "gpio-leds"; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_gpio_leds>; > > > + > > > + led-0 { > > > + function = LED_FUNCTION_STATUS; > > > + color = <LED_COLOR_ID_GREEN>; > > > + gpios = <&gpio4 1 GPIO_ACTIVE_HIGH>; > > > + default-state = "on"; > > > + linux,default-trigger = "heartbeat"; > > > + }; > > > + > > > + led-1 { > > > + function = LED_FUNCTION_STATUS; > > > + color = <LED_COLOR_ID_RED>; > > > + gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>; > > > + default-state = "off"; > > > + }; > > > + }; > > > + > > > + pcie0_refclk: pcie0-refclk { > > > > Can we name the node clock-xxx? > > > > > + compatible = "fixed-clock"; > > > + #clock-cells = <0>; > > > + clock-frequency = <100000000>; > > > + }; > > > + > > > + pps { > > > + compatible = "pps-gpio"; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_pps>; > > > + gpios = <&gpio4 3 GPIO_ACTIVE_HIGH>; > > > + status = "okay"; > > > + }; > > > +}; > > > + > > > +/* off-board header */ > > > +&ecspi2 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_spi2>; > > > + cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>; > > > + status = "okay"; > > > +}; > > > + > > > +&gpio4 { > > > + gpio-line-names = > > > + "", "", "", "", > > > + "", "", "", "", > > > + "dio1", "", "", "dio0", > > > + "", "", "pci_usb_sel", "", > > > + "", "", "", "", > > > + "", "", "", "", > > > + "dio3", "", "dio2", "", > > > + "pci_wdis#", "", "", ""; > > > +}; > > > + > > > +&i2c2 { > > > + clock-frequency = <400000>; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_i2c2>; > > > + status = "okay"; > > > + > > > + accelerometer@19 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_accel>; > > > + compatible = "st,lis2de12"; > > > + reg = <0x19>; > > > > Can we start the property list from these two? > > > > > + st,drdy-int-pin = <1>; > > > + interrupt-parent = <&gpio4>; > > > + interrupts = <21 IRQ_TYPE_LEVEL_LOW>; > > > + interrupt-names = "INT1"; > > > + }; > > > +}; > > > + > > > +&pcie_phy { > > > + fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>; > > > + fsl,clkreq-unsupported; > > > + clocks = <&pcie0_refclk>; > > > + clock-names = "ref"; > > > + status = "okay"; > > > +}; > > > + > > > +&pcie { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_pcie0>; > > > + reset-gpio = <&gpio4 29 GPIO_ACTIVE_LOW>; > > > + status = "okay"; > > > +}; > > > + > > > +/* GPS */ > > > +&uart1 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_uart1>; > > > + status = "okay"; > > > +}; > > > + > > > +/* off-board header */ > > > +&uart3 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_uart3>; > > > + status = "okay"; > > > +}; > > > + > > > +/* USB1 Type-C front panel */ > > > +&usb3_0 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_usb1>; > > > + fsl,over-current-active-low; > > > + status = "okay"; > > > +}; > > > + > > > +&usb3_phy0 { > > > + status = "okay"; > > > +}; > > > + > > > +&usb_dwc3_0 { > > > + /* dual role is implemented but not a full featured OTG */ > > > + adp-disable; > > > + hnp-disable; > > > + srp-disable; > > > + dr_mode = "otg"; > > > + usb-role-switch; > > > + role-switch-default-mode = "peripheral"; > > > + status = "okay"; > > > + > > > + connector { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_usbcon1>; > > > + compatible = "gpio-usb-b-connector", "usb-b-connector"; > > > > Start the properties from 'compatible'? > > > > Shawn > > > > Hi Shawn, > > My notes say that pinctrl should come first (if needed) followed by > compatible, reg, other props, and finally status (if needed). Assuming > I'm wrong about that where in the list should pinctrl be and is this > documented anywhere for future reference? It's more a recommended idiom than documented/hard rule. - compatible - reg - general properties - vendor specific properties - status Shawn
On Tue, Jul 18, 2023 at 6:58 PM Shawn Guo <shawnguo@kernel.org> wrote: > > On Tue, Jul 18, 2023 at 02:16:22PM -0700, Tim Harvey wrote: > > On Sun, Jul 16, 2023 at 5:27 PM Shawn Guo <shawnguo@kernel.org> wrote: > > > > > > On Wed, Jun 07, 2023 at 10:07:24AM -0700, Tim Harvey wrote: > > > > The Gateworks imx8mp-venice-gw71xx-2x consists of a SOM + baseboard. > > > > > > > > The GW702x SOM contains the following: > > > > - i.MX8M Plus SoC > > > > - LPDDR4 memory > > > > - eMMC Boot device > > > > - Gateworks System Controller (GSC) with integrated EEPROM, button > > > > controller, and ADC's > > > > - PMIC > > > > - SOM connector providing: > > > > - eQoS GbE MII > > > > - 1x SPI > > > > - 2x I2C > > > > - 4x UART > > > > - 2x USB 3.0 > > > > - 1x PCI > > > > - 1x SDIO (4-bit 3.3V) > > > > - 1x SDIO (4-bit 3.3V/1.8V) > > > > - GPIO > > > > > > > > The GW71xx Baseboard contains the following: > > > > - GPS > > > > - RJ45 GbE (eQoS) > > > > - off-board I/O connector with UART, I2C, SPI, GPIO > > > > - EERPOM > > > > - PCIe clock generator > > > > - full-length miniPCIe socket with PCI/USB3 (via mux) and USB2.0 > > > > - USB Type-C with USB 2.0 host and peripheral support > > > > - Wide range DC input supply > > > > > > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > > > > --- > > > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > > > .../dts/freescale/imx8mp-venice-gw71xx-2x.dts | 19 ++ > > > > .../dts/freescale/imx8mp-venice-gw71xx.dtsi | 236 ++++++++++++++++++ > > > > 3 files changed, 256 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > > > > index 62f22b77b38b..b3bb823d0168 100644 > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > @@ -101,6 +101,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw71xx-2x.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw74xx.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw7905-2x.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-verdin-nonwifi-dahlia.dtb > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts > > > > new file mode 100644 > > > > index 000000000000..53120fc9cd7f > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts > > > > @@ -0,0 +1,19 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > +/* > > > > + * Copyright 2023 Gateworks Corporation > > > > + */ > > > > + > > > > +/dts-v1/; > > > > + > > > > +#include "imx8mp.dtsi" > > > > +#include "imx8mp-venice-gw702x.dtsi" > > > > +#include "imx8mp-venice-gw71xx.dtsi" > > > > + > > > > +/ { > > > > + model = "Gateworks Venice GW71xx-2x i.MX8MP Development Kit"; > > > > + compatible = "gateworks,imx8mp-gw71xx-2x", "fsl,imx8mp"; > > > > + > > > > + chosen { > > > > + stdout-path = &uart2; > > > > + }; > > > > +}; > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi > > > > new file mode 100644 > > > > index 000000000000..86999f52d4b2 > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi > > > > @@ -0,0 +1,236 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > +/* > > > > + * Copyright 2023 Gateworks Corporation > > > > + */ > > > > + > > > > +#include <dt-bindings/gpio/gpio.h> > > > > +#include <dt-bindings/leds/common.h> > > > > +#include <dt-bindings/phy/phy-imx8-pcie.h> > > > > + > > > > +/ { > > > > + led-controller { > > > > + compatible = "gpio-leds"; > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_gpio_leds>; > > > > + > > > > + led-0 { > > > > + function = LED_FUNCTION_STATUS; > > > > + color = <LED_COLOR_ID_GREEN>; > > > > + gpios = <&gpio4 1 GPIO_ACTIVE_HIGH>; > > > > + default-state = "on"; > > > > + linux,default-trigger = "heartbeat"; > > > > + }; > > > > + > > > > + led-1 { > > > > + function = LED_FUNCTION_STATUS; > > > > + color = <LED_COLOR_ID_RED>; > > > > + gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>; > > > > + default-state = "off"; > > > > + }; > > > > + }; > > > > + > > > > + pcie0_refclk: pcie0-refclk { > > > > > > Can we name the node clock-xxx? > > > > > > > + compatible = "fixed-clock"; > > > > + #clock-cells = <0>; > > > > + clock-frequency = <100000000>; > > > > + }; > > > > + > > > > + pps { > > > > + compatible = "pps-gpio"; > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_pps>; > > > > + gpios = <&gpio4 3 GPIO_ACTIVE_HIGH>; > > > > + status = "okay"; > > > > + }; > > > > +}; > > > > + > > > > +/* off-board header */ > > > > +&ecspi2 { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_spi2>; > > > > + cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>; > > > > + status = "okay"; > > > > +}; > > > > + > > > > +&gpio4 { > > > > + gpio-line-names = > > > > + "", "", "", "", > > > > + "", "", "", "", > > > > + "dio1", "", "", "dio0", > > > > + "", "", "pci_usb_sel", "", > > > > + "", "", "", "", > > > > + "", "", "", "", > > > > + "dio3", "", "dio2", "", > > > > + "pci_wdis#", "", "", ""; > > > > +}; > > > > + > > > > +&i2c2 { > > > > + clock-frequency = <400000>; > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_i2c2>; > > > > + status = "okay"; > > > > + > > > > + accelerometer@19 { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_accel>; > > > > + compatible = "st,lis2de12"; > > > > + reg = <0x19>; > > > > > > Can we start the property list from these two? > > > > > > > + st,drdy-int-pin = <1>; > > > > + interrupt-parent = <&gpio4>; > > > > + interrupts = <21 IRQ_TYPE_LEVEL_LOW>; > > > > + interrupt-names = "INT1"; > > > > + }; > > > > +}; > > > > + > > > > +&pcie_phy { > > > > + fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>; > > > > + fsl,clkreq-unsupported; > > > > + clocks = <&pcie0_refclk>; > > > > + clock-names = "ref"; > > > > + status = "okay"; > > > > +}; > > > > + > > > > +&pcie { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_pcie0>; > > > > + reset-gpio = <&gpio4 29 GPIO_ACTIVE_LOW>; > > > > + status = "okay"; > > > > +}; > > > > + > > > > +/* GPS */ > > > > +&uart1 { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_uart1>; > > > > + status = "okay"; > > > > +}; > > > > + > > > > +/* off-board header */ > > > > +&uart3 { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_uart3>; > > > > + status = "okay"; > > > > +}; > > > > + > > > > +/* USB1 Type-C front panel */ > > > > +&usb3_0 { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_usb1>; > > > > + fsl,over-current-active-low; > > > > + status = "okay"; > > > > +}; > > > > + > > > > +&usb3_phy0 { > > > > + status = "okay"; > > > > +}; > > > > + > > > > +&usb_dwc3_0 { > > > > + /* dual role is implemented but not a full featured OTG */ > > > > + adp-disable; > > > > + hnp-disable; > > > > + srp-disable; > > > > + dr_mode = "otg"; > > > > + usb-role-switch; > > > > + role-switch-default-mode = "peripheral"; > > > > + status = "okay"; > > > > + > > > > + connector { > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&pinctrl_usbcon1>; > > > > + compatible = "gpio-usb-b-connector", "usb-b-connector"; > > > > > > Start the properties from 'compatible'? > > > > > > Shawn > > > > > > > Hi Shawn, > > > > My notes say that pinctrl should come first (if needed) followed by > > compatible, reg, other props, and finally status (if needed). Assuming > > I'm wrong about that where in the list should pinctrl be and is this > > documented anywhere for future reference? > > It's more a recommended idiom than documented/hard rule. > > - compatible > - reg > - general properties > - vendor specific properties > - status > ok, thank you for the clarification. I will submit a new version of: arm64: dts: freescale: Add imx8mp-venice-gw73xx-2x arm64: dts: freescale: Add imx8mp-venice-gw72xx-2x arm64: dts: freescale: Add imx8mp-venice-gw71xx-2x arm64: dts: freescale: Add imx8mm-venice-gw7905-0x best regards, Tim
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile index 62f22b77b38b..b3bb823d0168 100644 --- a/arch/arm64/boot/dts/freescale/Makefile +++ b/arch/arm64/boot/dts/freescale/Makefile @@ -101,6 +101,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb +dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw71xx-2x.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw74xx.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-venice-gw7905-2x.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mp-verdin-nonwifi-dahlia.dtb diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts new file mode 100644 index 000000000000..53120fc9cd7f --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dts @@ -0,0 +1,19 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2023 Gateworks Corporation + */ + +/dts-v1/; + +#include "imx8mp.dtsi" +#include "imx8mp-venice-gw702x.dtsi" +#include "imx8mp-venice-gw71xx.dtsi" + +/ { + model = "Gateworks Venice GW71xx-2x i.MX8MP Development Kit"; + compatible = "gateworks,imx8mp-gw71xx-2x", "fsl,imx8mp"; + + chosen { + stdout-path = &uart2; + }; +}; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi new file mode 100644 index 000000000000..86999f52d4b2 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi @@ -0,0 +1,236 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright 2023 Gateworks Corporation + */ + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/leds/common.h> +#include <dt-bindings/phy/phy-imx8-pcie.h> + +/ { + led-controller { + compatible = "gpio-leds"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_gpio_leds>; + + led-0 { + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_GREEN>; + gpios = <&gpio4 1 GPIO_ACTIVE_HIGH>; + default-state = "on"; + linux,default-trigger = "heartbeat"; + }; + + led-1 { + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_RED>; + gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>; + default-state = "off"; + }; + }; + + pcie0_refclk: pcie0-refclk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <100000000>; + }; + + pps { + compatible = "pps-gpio"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pps>; + gpios = <&gpio4 3 GPIO_ACTIVE_HIGH>; + status = "okay"; + }; +}; + +/* off-board header */ +&ecspi2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_spi2>; + cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>; + status = "okay"; +}; + +&gpio4 { + gpio-line-names = + "", "", "", "", + "", "", "", "", + "dio1", "", "", "dio0", + "", "", "pci_usb_sel", "", + "", "", "", "", + "", "", "", "", + "dio3", "", "dio2", "", + "pci_wdis#", "", "", ""; +}; + +&i2c2 { + clock-frequency = <400000>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c2>; + status = "okay"; + + accelerometer@19 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_accel>; + compatible = "st,lis2de12"; + reg = <0x19>; + st,drdy-int-pin = <1>; + interrupt-parent = <&gpio4>; + interrupts = <21 IRQ_TYPE_LEVEL_LOW>; + interrupt-names = "INT1"; + }; +}; + +&pcie_phy { + fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>; + fsl,clkreq-unsupported; + clocks = <&pcie0_refclk>; + clock-names = "ref"; + status = "okay"; +}; + +&pcie { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pcie0>; + reset-gpio = <&gpio4 29 GPIO_ACTIVE_LOW>; + status = "okay"; +}; + +/* GPS */ +&uart1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_uart1>; + status = "okay"; +}; + +/* off-board header */ +&uart3 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_uart3>; + status = "okay"; +}; + +/* USB1 Type-C front panel */ +&usb3_0 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usb1>; + fsl,over-current-active-low; + status = "okay"; +}; + +&usb3_phy0 { + status = "okay"; +}; + +&usb_dwc3_0 { + /* dual role is implemented but not a full featured OTG */ + adp-disable; + hnp-disable; + srp-disable; + dr_mode = "otg"; + usb-role-switch; + role-switch-default-mode = "peripheral"; + status = "okay"; + + connector { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + compatible = "gpio-usb-b-connector", "usb-b-connector"; + type = "micro"; + label = "Type-C"; + id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + }; +}; + +/* USB2 - MiniPCIe socket */ +&usb3_1 { + fsl,permanently-attached; + fsl,disable-port-power-control; + status = "okay"; +}; + +&usb3_phy1 { + status = "okay"; +}; + +&usb_dwc3_1 { + dr_mode = "host"; + status = "okay"; +}; + +&iomuxc { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_hog>; + + pinctrl_hog: hoggrp { + fsl,pins = < + MX8MP_IOMUXC_SAI1_RXD6__GPIO4_IO08 0x40000146 /* DIO1 */ + MX8MP_IOMUXC_SAI1_TXC__GPIO4_IO11 0x40000146 /* DIO0 */ + MX8MP_IOMUXC_SAI1_TXD2__GPIO4_IO14 0x40000106 /* PCIE_USBSEL */ + MX8MP_IOMUXC_SAI2_TXD0__GPIO4_IO26 0x40000146 /* DIO2 */ + MX8MP_IOMUXC_SAI2_TXFS__GPIO4_IO24 0x40000146 /* DIO3 */ + MX8MP_IOMUXC_SAI3_RXFS__GPIO4_IO28 0x40000106 /* PCIE_WDIS# */ + >; + }; + + pinctrl_accel: accelgrp { + fsl,pins = < + MX8MP_IOMUXC_SAI2_RXFS__GPIO4_IO21 0x150 /* IRQ */ + >; + }; + + pinctrl_gpio_leds: gpioledgrp { + fsl,pins = < + MX8MP_IOMUXC_SAI1_RXC__GPIO4_IO01 0x6 /* LEDG */ + MX8MP_IOMUXC_SAI1_RXD3__GPIO4_IO05 0x6 /* LEDR */ + >; + }; + + pinctrl_pcie0: pcie0grp { + fsl,pins = < + MX8MP_IOMUXC_SAI3_RXC__GPIO4_IO29 0x106 + >; + }; + + pinctrl_pps: ppsgrp { + fsl,pins = < + MX8MP_IOMUXC_SAI1_RXD1__GPIO4_IO03 0x146 + >; + }; + + pinctrl_usb1: usb1grp { + fsl,pins = < + MX8MP_IOMUXC_GPIO1_IO13__USB1_OTG_OC 0x140 /* USB1_FLT# */ + >; + }; + + pinctrl_usbcon1: usbcon1grp { + fsl,pins = < + MX8MP_IOMUXC_SAI5_RXD0__GPIO3_IO21 0x140 /* USB1_ID */ + >; + }; + + pinctrl_spi2: spi2grp { + fsl,pins = < + MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK 0x140 + MX8MP_IOMUXC_ECSPI2_MOSI__ECSPI2_MOSI 0x140 + MX8MP_IOMUXC_ECSPI2_MISO__ECSPI2_MISO 0x140 + MX8MP_IOMUXC_ECSPI2_SS0__GPIO5_IO13 0x140 + >; + }; + + pinctrl_uart1: uart1grp { + fsl,pins = < + MX8MP_IOMUXC_UART1_RXD__UART1_DCE_RX 0x140 + MX8MP_IOMUXC_UART1_TXD__UART1_DCE_TX 0x140 + >; + }; + + pinctrl_uart3: uart3grp { + fsl,pins = < + MX8MP_IOMUXC_UART3_RXD__UART3_DCE_RX 0x140 + MX8MP_IOMUXC_UART3_TXD__UART3_DCE_TX 0x140 + >; + }; +};