Message ID | 20230719041450.737929-2-quic_imrashai@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2186554vqt; Tue, 18 Jul 2023 21:26:26 -0700 (PDT) X-Google-Smtp-Source: APBJJlF17uGHcEsddyzFUfGValgWagIHnewPRnaJ1wR0IozdA2xI0BTMgo6mAnuypZlbvs8WdS2o X-Received: by 2002:a05:6e02:1543:b0:348:8da1:891c with SMTP id j3-20020a056e02154300b003488da1891cmr4961531ilu.24.1689740786276; Tue, 18 Jul 2023 21:26:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689740786; cv=none; d=google.com; s=arc-20160816; b=RyERAe4O39UrJXTZS+r1IJoEkIpbno9m/01p+B+eY7RVkGPI/+wGoAhCmtoLAvWzDz rakpSqUlb6GLlb6VmXL6GC7UAf2pCygeJI9qayfBflFjMqHaynM3sDcmOikpgjC4BZc+ Hj85Xf4YSdsPkUSSk1XxITgvsCGtWfSqyVZZSUBnNFhVUvEkzrcd52Ci4QvC6NYrYBDY 6SjRwfFSPbQvadnrrgC+kfQyfxm2/WdClDKfoYK6y0L11nWyEZ+QXwZzjVXH9c1YqBFz 0bH5FxnBlxRD2kMJHjxVRcDIVwzplJ6Ftd0JpYUu9WvhGdnSckVZB9fh372wLE+2epKf Q38A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8c54pkJuLyOtalt5OJu+8YRtbJFhEIgOq+ydoGQ9TH4=; fh=eTM5AMgA8WvDOtBfPt3Izhy34yBTmUdrPz7RKnSgpf0=; b=tOK0vrKjUYJI/TJX4G5CcKwdt1OVKeMGWMfbO2VgwoAt69m5hU/D+mVQXHhAH3/o/8 TT43S+VkNDiKNcNJFHT/ZuxqkjwN5/wtvM+zbFYoMQsefikl5wd1ZGWd6jros9gooRFV NCKFcUfzdvWyeV5ZTLmG9CuRhJGlT+tp3hdPn4RbioWsv8W+yNRmBuHhMHeYZPLnjSTy SdcLHT1slx/vpMBbe0PcLSpdYkcCFkl/bjeiFKZCVizIdWJNDCq45EGdCbpSePaSsGJf 8HlrWNi9Pfaw+0v62G9fogmPzeakaeXyYTvEjz7Of884NGumwCQjl4ws29wNDVXGlrhJ 2E3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=EG+d8qbV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e12-20020a170902b78c00b001b55229ea8csi2739769pls.399.2023.07.18.21.26.11; Tue, 18 Jul 2023 21:26:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=EG+d8qbV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230024AbjGSEPh (ORCPT <rfc822;chrisben.tianve@gmail.com> + 99 others); Wed, 19 Jul 2023 00:15:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjGSEPb (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 19 Jul 2023 00:15:31 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C340118E; Tue, 18 Jul 2023 21:15:30 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36J3FGaF000899; Wed, 19 Jul 2023 04:15:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=qcppdkim1; bh=8c54pkJuLyOtalt5OJu+8YRtbJFhEIgOq+ydoGQ9TH4=; b=EG+d8qbVvQM1d8owqIxVaFCOQyk8BWV6NVWF3WgNNGlToNqcMtOf87H3A8GjomvC2Ylj WL8wg03k9GWwxEuTP1gpaefGpamHVcrVxSlWKx+pJwJhxqieQJhCQhS632L8AaX3Tw32 l0+7OIWsqzueUw97J7SdRNbMsB4BrMfNLS5c+Xs9UAYu3EAnkJldSd2wsvj27OTsOiOY KY3BNTJ8O0EWLEpNa+RjxIPLb4M8zgeB7Kd6kCdzrhK2UNNHG8Nv2urYsFpREInBg8mU QHndw0HSUwzeqoIbHDOhLOcMjz0pSegL94i4x9pmZwuoPm1D4fqsTKEkjy884fiSAOAN sw== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rx7rng4ff-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jul 2023 04:15:26 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 36J4FPfg032382 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jul 2023 04:15:25 GMT Received: from hu-imrashai-hyd.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Tue, 18 Jul 2023 21:15:20 -0700 From: Imran Shaik <quic_imrashai@quicinc.com> To: Andy Gross <agross@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> CC: Bjorn Andersson <andersson@kernel.org>, Taniya Das <quic_tdas@quicinc.com>, Imran Shaik <quic_imrashai@quicinc.com>, "Melody Olvera" <quic_molvera@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Jagadeesh Kona <quic_jkona@quicinc.com>, Satya Priya Kakitapalli <quic_skakitap@quicinc.com>, Ajit Pandey <quic_ajipan@quicinc.com>, Rob Herring <robh@kernel.org> Subject: [PATCH V4 1/7] dt-bindings: clock: Update GCC clocks for QDU1000 and QRU1000 SoCs Date: Wed, 19 Jul 2023 09:44:44 +0530 Message-ID: <20230719041450.737929-2-quic_imrashai@quicinc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230719041450.737929-1-quic_imrashai@quicinc.com> References: <20230719041450.737929-1-quic_imrashai@quicinc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: osMQg6DVs_-b9e5EyQZEq8e4dQAVfg7H X-Proofpoint-ORIG-GUID: osMQg6DVs_-b9e5EyQZEq8e4dQAVfg7H X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-19_01,2023-07-18_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 priorityscore=1501 mlxscore=0 clxscore=1015 suspectscore=0 mlxlogscore=999 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307190038 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771821634937935728 X-GMAIL-MSGID: 1771821634937935728 |
Series |
Update GCC clocks for QDU1000 and QRU1000 SoCs
|
|
Commit Message
Imran Shaik
July 19, 2023, 4:14 a.m. UTC
Update the qcom GCC clock bindings for QDU1000 and QRU1000 SoCs. Co-developed-by: Taniya Das <quic_tdas@quicinc.com> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> Signed-off-by: Imran Shaik <quic_imrashai@quicinc.com> Acked-by: Rob Herring <robh@kernel.org> --- Changes since v3: - None Changes since v2: - None Changes since v1: - Removed the v2 variant compatible string changes - Updated the maintainers list Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml | 3 ++- include/dt-bindings/clock/qcom,qdu1000-gcc.h | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-)
Comments
On Wed, Jul 19, 2023 at 09:44:44AM +0530, Imran Shaik wrote: > Update the qcom GCC clock bindings for QDU1000 and QRU1000 SoCs. > Please read [1], and as it says "Describe your problem.". This goes for the most of the series. There are changes in this series which could be applicable to existing or future platforms. Your description of the problems you're solving will help others solve the same problem, not make the same mistake, and anyone fixing adjacent issues in the future can rely on your documentation of why things looks the way they look. [1] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#describe-your-changes > Co-developed-by: Taniya Das <quic_tdas@quicinc.com> > Signed-off-by: Taniya Das <quic_tdas@quicinc.com> > Signed-off-by: Imran Shaik <quic_imrashai@quicinc.com> Please don't use co-developed-by excessively. This patch is beyond trivial, did you really both author it? Regards, Bjorn > Acked-by: Rob Herring <robh@kernel.org> > --- > Changes since v3: > - None > Changes since v2: > - None > Changes since v1: > - Removed the v2 variant compatible string changes > - Updated the maintainers list > > Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml | 3 ++- > include/dt-bindings/clock/qcom,qdu1000-gcc.h | 4 +++- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml > index 767a9d03aa32..d712b1a87e25 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml > @@ -7,7 +7,8 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > title: Qualcomm Global Clock & Reset Controller for QDU1000 and QRU1000 > > maintainers: > - - Melody Olvera <quic_molvera@quicinc.com> > + - Taniya Das <quic_tdas@quicinc.com> > + - Imran Shaik <quic_imrashai@quicinc.com> > > description: | > Qualcomm global clock control module which supports the clocks, resets and > diff --git a/include/dt-bindings/clock/qcom,qdu1000-gcc.h b/include/dt-bindings/clock/qcom,qdu1000-gcc.h > index ddbc6b825e80..2fd36cbfddbb 100644 > --- a/include/dt-bindings/clock/qcom,qdu1000-gcc.h > +++ b/include/dt-bindings/clock/qcom,qdu1000-gcc.h > @@ -1,6 +1,6 @@ > /* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */ > /* > - * Copyright (c) 2021-2022, Qualcomm Innovation Center, Inc. All rights reserved. > + * Copyright (c) 2021-2023, Qualcomm Innovation Center, Inc. All rights reserved. > */ > > #ifndef _DT_BINDINGS_CLK_QCOM_GCC_QDU1000_H > @@ -138,6 +138,8 @@ > #define GCC_AGGRE_NOC_ECPRI_GSI_CLK 128 > #define GCC_PCIE_0_PIPE_CLK_SRC 129 > #define GCC_PCIE_0_PHY_AUX_CLK_SRC 130 > +#define GCC_GPLL1_OUT_EVEN 131 > +#define GCC_DDRSS_ECPRI_GSI_CLK 132 > > /* GCC resets */ > #define GCC_ECPRI_CC_BCR 0 > -- > 2.25.1 >
On 7/19/2023 9:05 PM, Bjorn Andersson wrote: > On Wed, Jul 19, 2023 at 09:44:44AM +0530, Imran Shaik wrote: >> Update the qcom GCC clock bindings for QDU1000 and QRU1000 SoCs. >> > > Please read [1], and as it says "Describe your problem.". This goes for > the most of the series. > > There are changes in this series which could be applicable to existing > or future platforms. Your description of the problems you're solving > will help others solve the same problem, not make the same mistake, and > anyone fixing adjacent issues in the future can rely on your > documentation of why things looks the way they look. > > [1] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#describe-your-changes > Sure, will update the next series with the detailed commit text. >> Co-developed-by: Taniya Das <quic_tdas@quicinc.com> >> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> >> Signed-off-by: Imran Shaik <quic_imrashai@quicinc.com> > > Please don't use co-developed-by excessively. This patch is beyond > trivial, did you really both author it? > > Regards, > Bjorn > Sure, will take care of this from now and will remove the co-developed-by for trivial changes in next series. Thanks, Imran >> Acked-by: Rob Herring <robh@kernel.org> >> --- >> Changes since v3: >> - None >> Changes since v2: >> - None >> Changes since v1: >> - Removed the v2 variant compatible string changes >> - Updated the maintainers list >> >> Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml | 3 ++- >> include/dt-bindings/clock/qcom,qdu1000-gcc.h | 4 +++- >> 2 files changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml >> index 767a9d03aa32..d712b1a87e25 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml >> @@ -7,7 +7,8 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# >> title: Qualcomm Global Clock & Reset Controller for QDU1000 and QRU1000 >> >> maintainers: >> - - Melody Olvera <quic_molvera@quicinc.com> >> + - Taniya Das <quic_tdas@quicinc.com> >> + - Imran Shaik <quic_imrashai@quicinc.com> >> >> description: | >> Qualcomm global clock control module which supports the clocks, resets and >> diff --git a/include/dt-bindings/clock/qcom,qdu1000-gcc.h b/include/dt-bindings/clock/qcom,qdu1000-gcc.h >> index ddbc6b825e80..2fd36cbfddbb 100644 >> --- a/include/dt-bindings/clock/qcom,qdu1000-gcc.h >> +++ b/include/dt-bindings/clock/qcom,qdu1000-gcc.h >> @@ -1,6 +1,6 @@ >> /* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */ >> /* >> - * Copyright (c) 2021-2022, Qualcomm Innovation Center, Inc. All rights reserved. >> + * Copyright (c) 2021-2023, Qualcomm Innovation Center, Inc. All rights reserved. >> */ >> >> #ifndef _DT_BINDINGS_CLK_QCOM_GCC_QDU1000_H >> @@ -138,6 +138,8 @@ >> #define GCC_AGGRE_NOC_ECPRI_GSI_CLK 128 >> #define GCC_PCIE_0_PIPE_CLK_SRC 129 >> #define GCC_PCIE_0_PHY_AUX_CLK_SRC 130 >> +#define GCC_GPLL1_OUT_EVEN 131 >> +#define GCC_DDRSS_ECPRI_GSI_CLK 132 >> >> /* GCC resets */ >> #define GCC_ECPRI_CC_BCR 0 >> -- >> 2.25.1 >>
diff --git a/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml index 767a9d03aa32..d712b1a87e25 100644 --- a/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml @@ -7,7 +7,8 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: Qualcomm Global Clock & Reset Controller for QDU1000 and QRU1000 maintainers: - - Melody Olvera <quic_molvera@quicinc.com> + - Taniya Das <quic_tdas@quicinc.com> + - Imran Shaik <quic_imrashai@quicinc.com> description: | Qualcomm global clock control module which supports the clocks, resets and diff --git a/include/dt-bindings/clock/qcom,qdu1000-gcc.h b/include/dt-bindings/clock/qcom,qdu1000-gcc.h index ddbc6b825e80..2fd36cbfddbb 100644 --- a/include/dt-bindings/clock/qcom,qdu1000-gcc.h +++ b/include/dt-bindings/clock/qcom,qdu1000-gcc.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */ /* - * Copyright (c) 2021-2022, Qualcomm Innovation Center, Inc. All rights reserved. + * Copyright (c) 2021-2023, Qualcomm Innovation Center, Inc. All rights reserved. */ #ifndef _DT_BINDINGS_CLK_QCOM_GCC_QDU1000_H @@ -138,6 +138,8 @@ #define GCC_AGGRE_NOC_ECPRI_GSI_CLK 128 #define GCC_PCIE_0_PIPE_CLK_SRC 129 #define GCC_PCIE_0_PHY_AUX_CLK_SRC 130 +#define GCC_GPLL1_OUT_EVEN 131 +#define GCC_DDRSS_ECPRI_GSI_CLK 132 /* GCC resets */ #define GCC_ECPRI_CC_BCR 0