Message ID | 20230717165127.2882535-2-m.felsch@pengutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1237880vqt; Mon, 17 Jul 2023 10:09:10 -0700 (PDT) X-Google-Smtp-Source: APBJJlGq9WykhZiu7LnF8IDCITJQkBzKYRVg7twblaRXDh5yA0VUeOun+zfHVdwNkZxMeTv/6AgP X-Received: by 2002:a17:906:1ce:b0:994:5317:a961 with SMTP id 14-20020a17090601ce00b009945317a961mr7614063ejj.46.1689613750024; Mon, 17 Jul 2023 10:09:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689613750; cv=none; d=google.com; s=arc-20160816; b=i0boxYWygNNOZiWEHkVgWomjjmWhLH2LpneF9BSqEYQFWCo1d6CrMzGpCUllBHGmJB pxm/BidahBuxwnsw29qiCsseqsCWiSxqzSw0VW3pxRM/T69CtUAaDrVNwu9NJwPosJyK CE9P53KZVWy11OeAg5P6lZvkex7kKrpZdH6zIEZt8QHk01DrAA0sDqG+kx/J1a2pPSTK c/MnjViShoF8+mpVZY3w5cEOPoBY2CMPE+j8InFcdIznpVYlrPaHOnySFT2OuHx1RWx5 q1QOJ28fBE2fuWgFtSCxusOsnSJDN7ihieffYI9bkO2hbw6EQXlW+FFuvt8z+YzcIDWw UXsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=rvwp8nOPtd7WqdvPY/4slATOD9FRMbNsWtU59R5pylo=; fh=wIyLjtWa5IUWDggL4LUubQn5CllRxeq3nPju63OhZzo=; b=YtXS9uQUffUjr7GxFJhncq1HJo3STyai1F5si/aNqQpNYgpdkk1yo8zOXW+BJwFD0j t8ViDu1NNP7TpFCUfc5mfgkgaF/4JBza/HUF522n5Lbk8VdLvwa31voiNGfAUtiqtt2f ZvPeVfju/IG9A1kaqA9XJUOGSuyvv/KwhiOU86xglh3n+t+y3iiqDUbHQ7c2ouNsb3pk k7a3/OQzAOwEjFGHfi2rcXFaV5Vb2zL8n2ZVIbpx0uAlE+EpUQ7CFvYkkA6JGuxVw/hR RPXyHbcSSjbUwCI2YrTwmn7cTGHFxVTPEqn10H7ehXeWDL3r808d4x1H0rM/RAyTFV3T lW9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r9-20020a170906364900b00991df86ac08si13525009ejb.256.2023.07.17.10.08.45; Mon, 17 Jul 2023 10:09:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231379AbjGQQvp (ORCPT <rfc822;daweilics@gmail.com> + 99 others); Mon, 17 Jul 2023 12:51:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229904AbjGQQvm (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 17 Jul 2023 12:51:42 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF7EAD1 for <linux-kernel@vger.kernel.org>; Mon, 17 Jul 2023 09:51:40 -0700 (PDT) Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from <m.felsch@pengutronix.de>) id 1qLRRc-00067V-4G; Mon, 17 Jul 2023 18:51:32 +0200 From: Marco Felsch <m.felsch@pengutronix.de> To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, laurent.pinchart@ideasonboard.com, dan.scally@ideasonboard.com Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 2/4] dt-bindings: arm: fsl: fix DEBIX binding Date: Mon, 17 Jul 2023 18:51:25 +0200 Message-Id: <20230717165127.2882535-2-m.felsch@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230717165127.2882535-1-m.felsch@pengutronix.de> References: <20230717165127.2882535-1-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:1101:1d::28 X-SA-Exim-Mail-From: m.felsch@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771688427482468355 X-GMAIL-MSGID: 1771688427482468355 |
Series |
[v2,1/4] arm64: dts: imx8mp-debix: remove unused fec pinctrl node
|
|
Commit Message
Marco Felsch
July 17, 2023, 4:51 p.m. UTC
The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the
corresponding bindings by adding an own entry for it. Mark
polyhex,imx8mp-debix as deprecated but keep it within the dts file since
we already have a user for it [1].
[1] https://elixir.bootlin.com/barebox/v2023.07.1/source/arch/arm/ \
boards/polyhex-debix/board.c#L38
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
Changelog:
v2:
- deprecate polyhex,imx8mp-debix
Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
Comments
On 17/07/2023 18:51, Marco Felsch wrote: > The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the > corresponding bindings by adding an own entry for it. Mark > polyhex,imx8mp-debix as deprecated but keep it within the dts file since > we already have a user for it [1]. > > [1] https://elixir.bootlin.com/barebox/v2023.07.1/source/arch/arm/ \ > boards/polyhex-debix/board.c#L38 > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> Subject: fix is too generic and binding is redundant. You already state this is binding in your prefix. Describe more precise what you are doing. > --- > Changelog: > > v2: > - deprecate polyhex,imx8mp-debix > > Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 15d4110840654..b29974e3c30b3 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -1019,8 +1019,6 @@ properties: > - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC > - fsl,imx8mp-evk # i.MX8MP EVK Board > - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board > - - polyhex,imx8mp-debix # Polyhex Debix boards > - - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules > - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT > - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules > @@ -1054,6 +1052,14 @@ properties: > - const: phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM > - const: fsl,imx8mp > > + - description: Polyhex DEBIX i.MX8MP based SBCs > + items: > + - enum: > + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > + - const: polyhex,imx8mp-debix # Polyhex Debix boards > + deprecated: true > + - const: fsl,imx8mp That's not how it works and it does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Don't deprecate some piece of entire compatible list, but entire list. The commit which deprecates compatible should bring a proper one. Otherwise at this point we have kernel only with deprecated compatibles. Best regards, Krzysztof
On 17/07/2023 18:51, Marco Felsch wrote: > The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the > corresponding bindings by adding an own entry for it. Mark > polyhex,imx8mp-debix as deprecated but keep it within the dts file since > we already have a user for it [1]. > > [1] https://elixir.bootlin.com/barebox/v2023.07.1/source/arch/arm/ \ > boards/polyhex-debix/board.c#L38 > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > Changelog: > > v2: > - deprecate polyhex,imx8mp-debix > > Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 15d4110840654..b29974e3c30b3 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -1019,8 +1019,6 @@ properties: > - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC > - fsl,imx8mp-evk # i.MX8MP EVK Board > - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board > - - polyhex,imx8mp-debix # Polyhex Debix boards > - - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules > - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT > - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules > @@ -1054,6 +1052,14 @@ properties: > - const: phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM > - const: fsl,imx8mp > > + - description: Polyhex DEBIX i.MX8MP based SBCs > + items: > + - enum: > + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > + - const: polyhex,imx8mp-debix # Polyhex Debix boards I cannot find patches which add new compatible to the binding and which fix the DTS. :/ Best regards, Krzysztof
On 23-07-17, Krzysztof Kozlowski wrote: > On 17/07/2023 18:51, Marco Felsch wrote: > > The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the > > corresponding bindings by adding an own entry for it. Mark > > polyhex,imx8mp-debix as deprecated but keep it within the dts file since > > we already have a user for it [1]. > > > > [1] https://elixir.bootlin.com/barebox/v2023.07.1/source/arch/arm/ \ > > boards/polyhex-debix/board.c#L38 > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > --- > > Changelog: > > > > v2: > > - deprecate polyhex,imx8mp-debix > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 15d4110840654..b29974e3c30b3 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -1019,8 +1019,6 @@ properties: > > - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC > > - fsl,imx8mp-evk # i.MX8MP EVK Board > > - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board > > - - polyhex,imx8mp-debix # Polyhex Debix boards > > - - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > > - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules > > - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT > > - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules > > @@ -1054,6 +1052,14 @@ properties: > > - const: phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM > > - const: fsl,imx8mp > > > > + - description: Polyhex DEBIX i.MX8MP based SBCs > > + items: > > + - enum: > > + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > > + - const: polyhex,imx8mp-debix # Polyhex Debix boards > > I cannot find patches which add new compatible to the binding and which > fix the DTS. :/ Please see my commit message, we can't remove the compatible since we already have one user of this compatible. Regards, Marco
On 23-07-17, Krzysztof Kozlowski wrote: > On 17/07/2023 18:51, Marco Felsch wrote: > > The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the > > corresponding bindings by adding an own entry for it. Mark > > polyhex,imx8mp-debix as deprecated but keep it within the dts file since > > we already have a user for it [1]. > > > > [1] https://elixir.bootlin.com/barebox/v2023.07.1/source/arch/arm/ \ > > boards/polyhex-debix/board.c#L38 > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > Subject: fix is too generic and binding is redundant. You already state > this is binding in your prefix. Describe more precise what you are doing. > > > --- > > Changelog: > > > > v2: > > - deprecate polyhex,imx8mp-debix > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 15d4110840654..b29974e3c30b3 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -1019,8 +1019,6 @@ properties: > > - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC > > - fsl,imx8mp-evk # i.MX8MP EVK Board > > - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board > > - - polyhex,imx8mp-debix # Polyhex Debix boards > > - - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > > - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules > > - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT > > - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules > > @@ -1054,6 +1052,14 @@ properties: > > - const: phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM > > - const: fsl,imx8mp > > > > + - description: Polyhex DEBIX i.MX8MP based SBCs > > + items: > > + - enum: > > + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > > + - const: polyhex,imx8mp-debix # Polyhex Debix boards > > + deprecated: true > > + - const: fsl,imx8mp > > That's not how it works and it does not look like you tested the DTS > against bindings. Please run `make dtbs_check` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). > > Don't deprecate some piece of entire compatible list, but entire list. > > The commit which deprecates compatible should bring a proper one. What did you mean by that? Regards, Marco > Otherwise at this point we have kernel only with deprecated compatibles. > > > Best regards, > Krzysztof > > >
On 17.07.23 18:51, Marco Felsch wrote: > The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the > corresponding bindings by adding an own entry for it. Mark > polyhex,imx8mp-debix as deprecated but keep it within the dts file since > we already have a user for it [1]. > > [1] https://elixir.bootlin.com/barebox/v2023.07.1/source/arch/arm/ \ > boards/polyhex-debix/board.c#L38 > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > Changelog: > > v2: > - deprecate polyhex,imx8mp-debix > > Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 15d4110840654..b29974e3c30b3 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -1019,8 +1019,6 @@ properties: > - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC > - fsl,imx8mp-evk # i.MX8MP EVK Board > - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board > - - polyhex,imx8mp-debix # Polyhex Debix boards > - - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules > - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT > - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules > @@ -1054,6 +1052,14 @@ properties: > - const: phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM > - const: fsl,imx8mp > > + - description: Polyhex DEBIX i.MX8MP based SBCs > + items: > + - enum: > + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > + - const: polyhex,imx8mp-debix # Polyhex Debix boards > + deprecated: true I don't see why you need to deprecate this. Can't you just change the comment to read "Polyhex i.MX8MP SBCs" or similar? Cheers, Ahmad > + - const: fsl,imx8mp > + > - description: Toradex Boards with Verdin iMX8M Plus Modules > items: > - enum:
On 23-07-17, Ahmad Fatoum wrote: > On 17.07.23 18:51, Marco Felsch wrote: > > The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the > > corresponding bindings by adding an own entry for it. Mark > > polyhex,imx8mp-debix as deprecated but keep it within the dts file since > > we already have a user for it [1]. > > > > [1] https://elixir.bootlin.com/barebox/v2023.07.1/source/arch/arm/ \ > > boards/polyhex-debix/board.c#L38 > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > --- > > Changelog: > > > > v2: > > - deprecate polyhex,imx8mp-debix > > > > Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > index 15d4110840654..b29974e3c30b3 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > @@ -1019,8 +1019,6 @@ properties: > > - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC > > - fsl,imx8mp-evk # i.MX8MP EVK Board > > - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board > > - - polyhex,imx8mp-debix # Polyhex Debix boards > > - - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > > - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules > > - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT > > - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules > > @@ -1054,6 +1052,14 @@ properties: > > - const: phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM > > - const: fsl,imx8mp > > > > + - description: Polyhex DEBIX i.MX8MP based SBCs > > + items: > > + - enum: > > + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > > + - const: polyhex,imx8mp-debix # Polyhex Debix boards > > + deprecated: true > > I don't see why you need to deprecate this. Can't you just change the comment > to read "Polyhex i.MX8MP SBCs" or similar? This was suggested by Krzysztof, since polyhex,imx8mp-debix was to generic. I can keep it without the deprecation notice and just change the comment since we need to keep dts compatible anyway. Regards, Marco
On 17.07.23 19:24, Marco Felsch wrote: > On 23-07-17, Ahmad Fatoum wrote: >> On 17.07.23 18:51, Marco Felsch wrote: >>> The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the >>> corresponding bindings by adding an own entry for it. Mark >>> polyhex,imx8mp-debix as deprecated but keep it within the dts file since >>> we already have a user for it [1]. >>> >>> [1] https://elixir.bootlin.com/barebox/v2023.07.1/source/arch/arm/ \ >>> boards/polyhex-debix/board.c#L38 >>> >>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> >>> --- >>> Changelog: >>> >>> v2: >>> - deprecate polyhex,imx8mp-debix >>> >>> Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++-- >>> 1 file changed, 8 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >>> index 15d4110840654..b29974e3c30b3 100644 >>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >>> @@ -1019,8 +1019,6 @@ properties: >>> - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC >>> - fsl,imx8mp-evk # i.MX8MP EVK Board >>> - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board >>> - - polyhex,imx8mp-debix # Polyhex Debix boards >>> - - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board >>> - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules >>> - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT >>> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules >>> @@ -1054,6 +1052,14 @@ properties: >>> - const: phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM >>> - const: fsl,imx8mp >>> >>> + - description: Polyhex DEBIX i.MX8MP based SBCs >>> + items: >>> + - enum: >>> + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board >>> + - const: polyhex,imx8mp-debix # Polyhex Debix boards >>> + deprecated: true >> >> I don't see why you need to deprecate this. Can't you just change the comment >> to read "Polyhex i.MX8MP SBCs" or similar? > > This was suggested by Krzysztof, since polyhex,imx8mp-debix was to > generic. I can keep it without the deprecation notice and just change > the comment since we need to keep dts compatible anyway. I agree that using it as compatible for both SBC and SoMs, when the boards aren't based on the SoM isn't useful. I still think it's useful to have a compatible for "Debix i.MX8MP SBCs" that spans current lineup of Model A, Model B, B SE and possible future compatibles. Cheers, Ahmad > > Regards, > Marco >
On 17/07/2023 19:14, Marco Felsch wrote: > On 23-07-17, Krzysztof Kozlowski wrote: >> On 17/07/2023 18:51, Marco Felsch wrote: >>> The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the >>> corresponding bindings by adding an own entry for it. Mark >>> polyhex,imx8mp-debix as deprecated but keep it within the dts file since >>> we already have a user for it [1]. >>> >>> [1] https://elixir.bootlin.com/barebox/v2023.07.1/source/arch/arm/ \ >>> boards/polyhex-debix/board.c#L38 >>> >>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> >> >> Subject: fix is too generic and binding is redundant. You already state >> this is binding in your prefix. Describe more precise what you are doing. >> >>> --- >>> Changelog: >>> >>> v2: >>> - deprecate polyhex,imx8mp-debix >>> >>> Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++-- >>> 1 file changed, 8 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >>> index 15d4110840654..b29974e3c30b3 100644 >>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >>> @@ -1019,8 +1019,6 @@ properties: >>> - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC >>> - fsl,imx8mp-evk # i.MX8MP EVK Board >>> - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board >>> - - polyhex,imx8mp-debix # Polyhex Debix boards >>> - - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board >>> - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules >>> - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT >>> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules >>> @@ -1054,6 +1052,14 @@ properties: >>> - const: phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM >>> - const: fsl,imx8mp >>> >>> + - description: Polyhex DEBIX i.MX8MP based SBCs >>> + items: >>> + - enum: >>> + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board >>> + - const: polyhex,imx8mp-debix # Polyhex Debix boards >>> + deprecated: true >>> + - const: fsl,imx8mp >> >> That's not how it works and it does not look like you tested the DTS Actually this could pass the test because this is used by DTS. Quite surprising. >> against bindings. Please run `make dtbs_check` (see >> Documentation/devicetree/bindings/writing-schema.rst or >> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ >> for instructions). >> >> Don't deprecate some piece of entire compatible list, but entire list. >> >> The commit which deprecates compatible should bring a proper one. > > What did you mean by that? Exactly what I wrote below: > > Regards, > Marco > >> Otherwise at this point we have kernel only with deprecated compatibles. You now have kernel without proper compatible, because it is deprecated. Best regards, Krzysztof
On 17/07/2023 19:12, Marco Felsch wrote: > On 23-07-17, Krzysztof Kozlowski wrote: >> On 17/07/2023 18:51, Marco Felsch wrote: >>> The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the >>> corresponding bindings by adding an own entry for it. Mark >>> polyhex,imx8mp-debix as deprecated but keep it within the dts file since >>> we already have a user for it [1]. >>> >>> [1] https://elixir.bootlin.com/barebox/v2023.07.1/source/arch/arm/ \ >>> boards/polyhex-debix/board.c#L38 Don't wrap links, they are not clickable. >>> >>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> >>> --- >>> Changelog: >>> >>> v2: >>> - deprecate polyhex,imx8mp-debix >>> >>> Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++-- >>> 1 file changed, 8 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >>> index 15d4110840654..b29974e3c30b3 100644 >>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >>> @@ -1019,8 +1019,6 @@ properties: >>> - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC >>> - fsl,imx8mp-evk # i.MX8MP EVK Board >>> - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board >>> - - polyhex,imx8mp-debix # Polyhex Debix boards >>> - - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board >>> - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules >>> - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT >>> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules >>> @@ -1054,6 +1052,14 @@ properties: >>> - const: phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM >>> - const: fsl,imx8mp >>> >>> + - description: Polyhex DEBIX i.MX8MP based SBCs >>> + items: >>> + - enum: >>> + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board >>> + - const: polyhex,imx8mp-debix # Polyhex Debix boards >> >> I cannot find patches which add new compatible to the binding and which >> fix the DTS. :/ > > Please see my commit message, we can't remove the compatible since we > already have one user of this compatible. Indeed. I wonder then what is the goal of deprecating this compatible and what is the plan for dealing with it? There is no cover letter which would point me to it. Best regards, Krzysztof
Hi Ahmad, Krzysztof, On 23-07-17, Ahmad Fatoum wrote: > On 17.07.23 19:24, Marco Felsch wrote: > > On 23-07-17, Ahmad Fatoum wrote: > >> On 17.07.23 18:51, Marco Felsch wrote: > >>> The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the > >>> corresponding bindings by adding an own entry for it. Mark > >>> polyhex,imx8mp-debix as deprecated but keep it within the dts file since > >>> we already have a user for it [1]. > >>> > >>> [1] https://elixir.bootlin.com/barebox/v2023.07.1/source/arch/arm/ \ > >>> boards/polyhex-debix/board.c#L38 > >>> > >>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > >>> --- > >>> Changelog: > >>> > >>> v2: > >>> - deprecate polyhex,imx8mp-debix > >>> > >>> Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++-- > >>> 1 file changed, 8 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > >>> index 15d4110840654..b29974e3c30b3 100644 > >>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml > >>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > >>> @@ -1019,8 +1019,6 @@ properties: > >>> - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC > >>> - fsl,imx8mp-evk # i.MX8MP EVK Board > >>> - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board > >>> - - polyhex,imx8mp-debix # Polyhex Debix boards > >>> - - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > >>> - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules > >>> - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT > >>> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules > >>> @@ -1054,6 +1052,14 @@ properties: > >>> - const: phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM > >>> - const: fsl,imx8mp > >>> > >>> + - description: Polyhex DEBIX i.MX8MP based SBCs > >>> + items: > >>> + - enum: > >>> + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board > >>> + - const: polyhex,imx8mp-debix # Polyhex Debix boards > >>> + deprecated: true > >> > >> I don't see why you need to deprecate this. Can't you just change the comment > >> to read "Polyhex i.MX8MP SBCs" or similar? > > > > This was suggested by Krzysztof, since polyhex,imx8mp-debix was to > > generic. I can keep it without the deprecation notice and just change > > the comment since we need to keep dts compatible anyway. > > I agree that using it as compatible for both SBC and SoMs, when the boards > aren't based on the SoM isn't useful. I still think it's useful to have > a compatible for "Debix i.MX8MP SBCs" that spans current lineup of Model A, > Model B, B SE and possible future compatibles. Thanks for the input. @Krzysztof how do we proceed on this topic? I can adapt the comment and drop the deprecated status. Regards, Marco
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 15d4110840654..b29974e3c30b3 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -1019,8 +1019,6 @@ properties: - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC - fsl,imx8mp-evk # i.MX8MP EVK Board - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board - - polyhex,imx8mp-debix # Polyhex Debix boards - - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules @@ -1054,6 +1052,14 @@ properties: - const: phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM - const: fsl,imx8mp + - description: Polyhex DEBIX i.MX8MP based SBCs + items: + - enum: + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board + - const: polyhex,imx8mp-debix # Polyhex Debix boards + deprecated: true + - const: fsl,imx8mp + - description: Toradex Boards with Verdin iMX8M Plus Modules items: - enum: