Message ID | 20221108181030.1611703-1-khazhy@google.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2869780wru; Tue, 8 Nov 2022 10:15:17 -0800 (PST) X-Google-Smtp-Source: AMsMyM6UNWkaBHBVNvQuWD/A6qS/L//VwEwVgyJcrib5GX5fwjxPmYBzx16fOrTkvjjWimQQ0K81 X-Received: by 2002:a17:90a:67cd:b0:213:f8ab:ff48 with SMTP id g13-20020a17090a67cd00b00213f8abff48mr45129258pjm.106.1667931316907; Tue, 08 Nov 2022 10:15:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667931316; cv=none; d=google.com; s=arc-20160816; b=LxwsqIhHOy8FUaammbBdamnDL9ejMvaRpm/W/lMUFtexvghjbhoWBnpYIoc93k/mTk bLrdF9OEHMGq+f1rZpWx5IqdH3x3FcDTN4bvDFSTZYWvuxUqm3kLBX0xGQJSC9jo0YMq s2s4Wuisy0eVl8qJWpY+eL9ubL2dAbICzGjPvv+WKOGt3W5PeCeVhu6Oly+SUmjT0eSl 4nS1RkUIa6VK/6x9KJk0kPcBEQmlpka8oqJ9Jk/WAOEEu7tLx5+TUx6h4BrIcOhIoClp zuK4sgaVHgYqetKWvUeqQOnMuEDokttd3AsbYgBdFrjO/1FMmWg78IU3fTvsabsSEpsC OZ6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eWhULAO1PGhpQ+ChwOYcLNZC3f58WMaAVvC3B9Ax33I=; b=jiZhIVp6su6dV+6iK2OTCXHWbjX0/U07I/W88fndO3AE1gedzlya7TpoWl9PnSOxkP OFpDD2ADB7xFOsf5SD/WdXbi82WMlpJamqDmyC3wrcbXwVDmQqt39Fm0gw2rBCKF86Vp /rDEmHbLI+envPhF8kSo0L0c//x8M6Z3Wzr0YSfhdgre3LmNfgZeWGnL6sogiOR90/Dt csevZb6nm7miaGvNwvOeZGHpJ+MtGwowlesSSNTbPc/phzVM27vsJFuUXRqmPH56g65s /N9M+yjEZ5IfZ9lld2d4W6DAcSBLwEXW2jvyUtAcZp4eNsMsYw5PKWgUHLrgz5R6/Nnz pYyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=OgzPo8mp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a8-20020a1709027d8800b00176939b5cd9si13422244plm.578.2022.11.08.10.15.01; Tue, 08 Nov 2022 10:15:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=OgzPo8mp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234744AbiKHSKu (ORCPT <rfc822;tony84727@gmail.com> + 99 others); Tue, 8 Nov 2022 13:10:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234268AbiKHSKs (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 8 Nov 2022 13:10:48 -0500 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 246564B99F for <linux-kernel@vger.kernel.org>; Tue, 8 Nov 2022 10:10:44 -0800 (PST) Received: by mail-pl1-x629.google.com with SMTP id b21so14872541plc.9 for <linux-kernel@vger.kernel.org>; Tue, 08 Nov 2022 10:10:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eWhULAO1PGhpQ+ChwOYcLNZC3f58WMaAVvC3B9Ax33I=; b=OgzPo8mpGNo5exrre/OhRCO+v816mE1waYy6787p/nQN/NFFZsxn5irwVZFL5r59nK x7EWvXlhyznmWuDdfthA2yb4OyR11IASvIamkj1DwgqiZa+qLYaOJi2eEilaUrVEKzk8 BmUYdSjxJ+fmBVou4WlXk29qTxMPYZ11FG5aI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eWhULAO1PGhpQ+ChwOYcLNZC3f58WMaAVvC3B9Ax33I=; b=gAW8GBO4NN4sI/qd5y/gfCEE8hmkbYs30B3S1N9pLqeSxo2NxzXkD3TxSfcyarRPcL 1XovDjxlIzXduHsR3OSVqI6xnsbZv/BrhEn3Z0mRtwkITIELTpTrmIOPkLr9Io8DAY/A Nnzlo8DJrcajmiThwMJmXR+ucxHG7si+oPS7NEKYOo6kl6BICE+Q0zAl8PNECdNoNKp9 7Mv29Ypchzw+gVVBVvHH1PfBCRC1OEUDRpCtJNvFZADCnpkCrmewN+hyhtWPdaM1b9ER Fl7rjVCY6xxE50k7W7ZrNRhY+9HieDt7jUJZw8ilIwiqhzsRqs7EJ+oQAQUvWI/Qapdq iBTA== X-Gm-Message-State: ACrzQf32mvhET+JAOP/KEsIH1T9jM2tRsBf6OlMzF2FaJ2t4R1sCfink b/8x60YYGF2pwj0XJq2TU/M+6g== X-Received: by 2002:a17:902:ecc1:b0:186:b57e:d229 with SMTP id a1-20020a170902ecc100b00186b57ed229mr58084545plh.167.1667931043637; Tue, 08 Nov 2022 10:10:43 -0800 (PST) Received: from khazhy-linux.svl.corp.google.com ([2620:15c:2d4:203:21f:525:beef:f928]) by smtp.gmail.com with ESMTPSA id h3-20020a63df43000000b0046fd180640asm6048754pgj.24.2022.11.08.10.10.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 10:10:43 -0800 (PST) From: Khazhismel Kumykov <khazhy@chromium.org> X-Google-Original-From: Khazhismel Kumykov <khazhy@google.com> To: Paolo Valente <paolo.valente@linaro.org>, Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Yu Kuai <yukuai1@huaweicloud.com>, Jan Kara <jack@suse.cz>, Khazhismel Kumykov <khazhy@google.com> Subject: [PATCH 1/2] bfq: fix waker_bfqq inconsistency crash Date: Tue, 8 Nov 2022 10:10:29 -0800 Message-Id: <20221108181030.1611703-1-khazhy@google.com> X-Mailer: git-send-email 2.38.1.431.g37b22c650d-goog In-Reply-To: <20221103013937.603626-1-khazhy@google.com> References: <20221103013937.603626-1-khazhy@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748438433438530545?= X-GMAIL-MSGID: =?utf-8?q?1748952748744051890?= |
Series |
[1/2] bfq: fix waker_bfqq inconsistency crash
|
|
Commit Message
Khazhismel Kumykov
Nov. 8, 2022, 6:10 p.m. UTC
This fixes crashes in bfq_add_bfqq_busy due to waker_bfqq being NULL,
but woken_list_node still being hashed. This would happen when
bfq_init_rq() expects a brand new allocated queue to be returned from
bfq_get_bfqq_handle_split() and unconditionally updates waker_bfqq
without resetting woken_list_node. Since we can always return oom_bfqq
when attempting to allocate, we cannot assume waker_bfqq starts as NULL.
Avoid setting woken_bfqq for oom_bfqq entirely, as it's not useful.
Crashes would have a stacktrace like:
[160595.656560] bfq_add_bfqq_busy+0x110/0x1ec
[160595.661142] bfq_add_request+0x6bc/0x980
[160595.666602] bfq_insert_request+0x8ec/0x1240
[160595.671762] bfq_insert_requests+0x58/0x9c
[160595.676420] blk_mq_sched_insert_request+0x11c/0x198
[160595.682107] blk_mq_submit_bio+0x270/0x62c
[160595.686759] __submit_bio_noacct_mq+0xec/0x178
[160595.691926] submit_bio+0x120/0x184
[160595.695990] ext4_mpage_readpages+0x77c/0x7c8
[160595.701026] ext4_readpage+0x60/0xb0
[160595.705158] filemap_read_page+0x54/0x114
[160595.711961] filemap_fault+0x228/0x5f4
[160595.716272] do_read_fault+0xe0/0x1f0
[160595.720487] do_fault+0x40/0x1c8
Tested by injecting random failures into bfq_get_queue, crashes go away
completely.
Fixes: 8ef3fc3a043c ("block, bfq: make shared queues inherit wakers")
Signed-off-by: Khazhismel Kumykov <khazhy@google.com>
---
block/bfq-iosched.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
Comments
On Tue 08-11-22 10:10:29, Khazhismel Kumykov wrote: > This fixes crashes in bfq_add_bfqq_busy due to waker_bfqq being NULL, > but woken_list_node still being hashed. This would happen when > bfq_init_rq() expects a brand new allocated queue to be returned from > bfq_get_bfqq_handle_split() and unconditionally updates waker_bfqq > without resetting woken_list_node. Since we can always return oom_bfqq > when attempting to allocate, we cannot assume waker_bfqq starts as NULL. > > Avoid setting woken_bfqq for oom_bfqq entirely, as it's not useful. > > Crashes would have a stacktrace like: > [160595.656560] bfq_add_bfqq_busy+0x110/0x1ec > [160595.661142] bfq_add_request+0x6bc/0x980 > [160595.666602] bfq_insert_request+0x8ec/0x1240 > [160595.671762] bfq_insert_requests+0x58/0x9c > [160595.676420] blk_mq_sched_insert_request+0x11c/0x198 > [160595.682107] blk_mq_submit_bio+0x270/0x62c > [160595.686759] __submit_bio_noacct_mq+0xec/0x178 > [160595.691926] submit_bio+0x120/0x184 > [160595.695990] ext4_mpage_readpages+0x77c/0x7c8 > [160595.701026] ext4_readpage+0x60/0xb0 > [160595.705158] filemap_read_page+0x54/0x114 > [160595.711961] filemap_fault+0x228/0x5f4 > [160595.716272] do_read_fault+0xe0/0x1f0 > [160595.720487] do_fault+0x40/0x1c8 > > Tested by injecting random failures into bfq_get_queue, crashes go away > completely. > > Fixes: 8ef3fc3a043c ("block, bfq: make shared queues inherit wakers") > Signed-off-by: Khazhismel Kumykov <khazhy@google.com> Looks good. Thanks! Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > block/bfq-iosched.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c > index 7ea427817f7f..ca04ec868c40 100644 > --- a/block/bfq-iosched.c > +++ b/block/bfq-iosched.c > @@ -6784,6 +6784,12 @@ static struct bfq_queue *bfq_init_rq(struct request *rq) > bfqq = bfq_get_bfqq_handle_split(bfqd, bic, bio, > true, is_sync, > NULL); > + if (unlikely(bfqq == &bfqd->oom_bfqq)) > + bfqq_already_existing = true; > + } else > + bfqq_already_existing = true; > + > + if (!bfqq_already_existing) { > bfqq->waker_bfqq = old_bfqq->waker_bfqq; > bfqq->tentative_waker_bfqq = NULL; > > @@ -6797,8 +6803,7 @@ static struct bfq_queue *bfq_init_rq(struct request *rq) > if (bfqq->waker_bfqq) > hlist_add_head(&bfqq->woken_list_node, > &bfqq->waker_bfqq->woken_list); > - } else > - bfqq_already_existing = true; > + } > } > } > > -- > 2.38.1.431.g37b22c650d-goog >
On Tue, 8 Nov 2022 10:10:29 -0800, Khazhismel Kumykov wrote: > This fixes crashes in bfq_add_bfqq_busy due to waker_bfqq being NULL, > but woken_list_node still being hashed. This would happen when > bfq_init_rq() expects a brand new allocated queue to be returned from > bfq_get_bfqq_handle_split() and unconditionally updates waker_bfqq > without resetting woken_list_node. Since we can always return oom_bfqq > when attempting to allocate, we cannot assume waker_bfqq starts as NULL. > > [...] Applied, thanks! [1/2] bfq: fix waker_bfqq inconsistency crash commit: a1795c2ccb1e4c49220d2a0d381540024d71647c [2/2] bfq: ignore oom_bfqq in bfq_check_waker commit: 99771d73ff4539f2337b84917f4792abf0d8931b Best regards,
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 7ea427817f7f..ca04ec868c40 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -6784,6 +6784,12 @@ static struct bfq_queue *bfq_init_rq(struct request *rq) bfqq = bfq_get_bfqq_handle_split(bfqd, bic, bio, true, is_sync, NULL); + if (unlikely(bfqq == &bfqd->oom_bfqq)) + bfqq_already_existing = true; + } else + bfqq_already_existing = true; + + if (!bfqq_already_existing) { bfqq->waker_bfqq = old_bfqq->waker_bfqq; bfqq->tentative_waker_bfqq = NULL; @@ -6797,8 +6803,7 @@ static struct bfq_queue *bfq_init_rq(struct request *rq) if (bfqq->waker_bfqq) hlist_add_head(&bfqq->woken_list_node, &bfqq->waker_bfqq->woken_list); - } else - bfqq_already_existing = true; + } } }