Message ID | 20230717065811.1262-1-haifeng.xu@shopee.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp958197vqt; Mon, 17 Jul 2023 00:31:15 -0700 (PDT) X-Google-Smtp-Source: APBJJlEfVZyPBJtPQSlv6ICyqyDa8B/fzmMPllHR0RPPa4xB+I29Xv+L4i3esmHy42nAGwecT1+P X-Received: by 2002:a17:907:1003:b0:993:c48f:184c with SMTP id ox3-20020a170907100300b00993c48f184cmr9405509ejb.10.1689579075287; Mon, 17 Jul 2023 00:31:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689579075; cv=none; d=google.com; s=arc-20160816; b=cP0mWDf2vSGcIVhbPA0kbxqHOu4qJDxaXPymgv8DyChR0NFYfUXaS6nRa+v2c/lGmF tXt9dloN9sAmeBtuAwcuH1XbLIgowZFHY8WSDF+3mX7GxLcnF2jgG8pC396s9hhggQWO vnhMjf76bUL8knv5QXucXz3d+MG+91YOw3uSkLPU/HxIvONgQ7WzzK2kV7aLf/uzU+N0 UDh2SBKiQQof6B/NJDQCMtqAC/aiU6XbUz6hA4uYpiwEVzWFxPrEqO/U2f/vz4s+yjjY u16BvLGr4OICbF1tkb4cXljL6Iq59Dx0xAtfF4lxbWn9lC3SYgtlLYjrQZ12eU6VL4jJ FZfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hrMY6kjr/TWa2vf5zCji0/y76YkEG4cLXIAfa8PuWOk=; fh=pBSutRcT3Ke6r121PJAguReVUAPbpSbt/jkhvupN7yA=; b=Dc4MopJmPL6Au+ONLz9zHv58fmA34F23y1JphVmp4LANpq1FY77dMMDNZ4/nJllXJy Ictf144k+J3Wh5CmwhD6xRVwTP6icAx0ggUtTBHhTjQZ0s8c8HWb3H+VzM8htKhvhlcx 8w2hrhTcAOVS9bP35p+ZZBvlPYZt3t6qJjrXhL/+uKZ7VXZEeCTOoNjlLH9/CAV5RdtM 7zDJn6WsQVOQ+xRKpfGvK9CZgXbJkl0CSGTgVLVO0ja+B+JhgmVoCUAOysObtbwEb0Qu jjcCdHMoZyhkXshZOuuinU+ZR54gIynVb81Tn/2ixF9r89BuVQpgiS4G/kZzwt8d2H19 F5jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@shopee.com header.s=shopee.com header.b=RNSGMmuA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=shopee.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u12-20020a1709064acc00b00992e26642ddsi12682619ejt.251.2023.07.17.00.30.51; Mon, 17 Jul 2023 00:31:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@shopee.com header.s=shopee.com header.b=RNSGMmuA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=shopee.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229669AbjGQG6r (ORCPT <rfc822;hadasmailinglist@gmail.com> + 99 others); Mon, 17 Jul 2023 02:58:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229885AbjGQG6q (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 17 Jul 2023 02:58:46 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7426F10C6 for <linux-kernel@vger.kernel.org>; Sun, 16 Jul 2023 23:58:44 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id af79cd13be357-76571dae5feso410442385a.1 for <linux-kernel@vger.kernel.org>; Sun, 16 Jul 2023 23:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1689577123; x=1692169123; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hrMY6kjr/TWa2vf5zCji0/y76YkEG4cLXIAfa8PuWOk=; b=RNSGMmuAzOrPik9u5wmSsHa6+R3x+CA5yez/pevLChoMshUcbGsjmNCNkDXvkedq2a oPscAApDRxykDSy/5+idTYD+XpdNUtuffPNXSJYRanB5KCrj3feq2B492CmoUie+TXeO ZgjQ2h1614Hi/42uAFgXVmYbOVdxmQohn/GG8q/gFmNkDYnGO3o8c7Dl5U2hDv46hz/R TRZo+p3VfaCjmA0tEMPOd5bvp8EL0URdhipCKy1BuctFtf15LGx46k9g2NBRNQwWm1FC c1BHX2xHEgCoLTwbC5KTZwk/X8qcjq0p2yy8PuIJTBkjGMhiV5TYtHiEZRhJqQluq/s0 EAFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689577123; x=1692169123; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hrMY6kjr/TWa2vf5zCji0/y76YkEG4cLXIAfa8PuWOk=; b=fmkzQM+STt/q1buSMKnUVd2PdHBdDEwCd+Bns4RG0gOMgITknnhb/N25jLRgStYql2 fYZ1BoWDLjq8ZZoR9F7zz50MhcSF+fou7xvKJPUl3I8ozf8j/Gv4YMppvKJRibUsFOR6 2DvAMgAcracfAjdQV0TUZgWtQiAMfy3sQ15jE7KPPBG7tlM+5aBSvrpuDLZCZmjXAXQc OTb2Fy7UNz4fm6RNd8JvWPegd2op+BGVbJpnj5tZlR1KjRhnts9Y7xVP6zLAjLBg78VR h5Sc122VX6afcCE095YvzmdNkN2BPdajQP2k5OKakrRMaEOxNKL+hZJ79XbdZQqb8LV5 FqOg== X-Gm-Message-State: ABy/qLYNi4vVyDWwfkPc4Vquokslxgy66UY2DkuTVVlcRU1PLX+J7eYa jjsTS8XBOrFDHczHoLQGJhkLiQ== X-Received: by 2002:a05:620a:1726:b0:767:352d:54f4 with SMTP id az38-20020a05620a172600b00767352d54f4mr13739339qkb.30.1689577123576; Sun, 16 Jul 2023 23:58:43 -0700 (PDT) Received: from ubuntu-hf2.default.svc.cluster.local ([101.127.248.173]) by smtp.gmail.com with ESMTPSA id f8-20020a170902684800b001b53953f314sm12218291pln.23.2023.07.16.23.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jul 2023 23:58:43 -0700 (PDT) From: Haifeng Xu <haifeng.xu@shopee.com> To: rppt@kernel.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Haifeng Xu <haifeng.xu@shopee.com> Subject: [PATCH] mm/mm_init.c: drop node_start_pfn from adjust_zone_range_for_zone_movable() Date: Mon, 17 Jul 2023 06:58:11 +0000 Message-Id: <20230717065811.1262-1-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771652068227754015 X-GMAIL-MSGID: 1771652068227754015 |
Series |
mm/mm_init.c: drop node_start_pfn from adjust_zone_range_for_zone_movable()
|
|
Commit Message
Haifeng Xu
July 17, 2023, 6:58 a.m. UTC
node_start_pfn is not used in adjust_zone_range_for_zone_movable(), so
it is pointless to waste a function argument. Drop the parameter.
Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
---
mm/mm_init.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
Comments
On 17.07.23 08:58, Haifeng Xu wrote: > node_start_pfn is not used in adjust_zone_range_for_zone_movable(), so > it is pointless to waste a function argument. Drop the parameter. > > Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com> > --- Reviewed-by: David Hildenbrand <david@redhat.com>
On Mon, Jul 17, 2023 at 06:58:11AM +0000, Haifeng Xu wrote: > node_start_pfn is not used in adjust_zone_range_for_zone_movable(), so > it is pointless to waste a function argument. Drop the parameter. > > Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com> Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org> > --- > mm/mm_init.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index a313d1828a6c..23d50541e1f7 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1105,7 +1105,6 @@ void __ref memmap_init_zone_device(struct zone *zone, > */ > static void __init adjust_zone_range_for_zone_movable(int nid, > unsigned long zone_type, > - unsigned long node_start_pfn, > unsigned long node_end_pfn, > unsigned long *zone_start_pfn, > unsigned long *zone_end_pfn) > @@ -1222,9 +1221,8 @@ static unsigned long __init zone_spanned_pages_in_node(int nid, > /* Get the start and end of the zone */ > *zone_start_pfn = clamp(node_start_pfn, zone_low, zone_high); > *zone_end_pfn = clamp(node_end_pfn, zone_low, zone_high); > - adjust_zone_range_for_zone_movable(nid, zone_type, > - node_start_pfn, node_end_pfn, > - zone_start_pfn, zone_end_pfn); > + adjust_zone_range_for_zone_movable(nid, zone_type, node_end_pfn, > + zone_start_pfn, zone_end_pfn); > > /* Check that this node has pages within the zone's required range */ > if (*zone_end_pfn < node_start_pfn || *zone_start_pfn > node_end_pfn) > -- > 2.25.1 >
On Mon, Jul 17, 2023 at 06:58:11AM +0000, Haifeng Xu wrote: > node_start_pfn is not used in adjust_zone_range_for_zone_movable(), so > it is pointless to waste a function argument. Drop the parameter. > > Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com> Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org> > --- > mm/mm_init.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index a313d1828a6c..23d50541e1f7 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1105,7 +1105,6 @@ void __ref memmap_init_zone_device(struct zone *zone, > */ > static void __init adjust_zone_range_for_zone_movable(int nid, > unsigned long zone_type, > - unsigned long node_start_pfn, > unsigned long node_end_pfn, > unsigned long *zone_start_pfn, > unsigned long *zone_end_pfn) > @@ -1222,9 +1221,8 @@ static unsigned long __init zone_spanned_pages_in_node(int nid, > /* Get the start and end of the zone */ > *zone_start_pfn = clamp(node_start_pfn, zone_low, zone_high); > *zone_end_pfn = clamp(node_end_pfn, zone_low, zone_high); > - adjust_zone_range_for_zone_movable(nid, zone_type, > - node_start_pfn, node_end_pfn, > - zone_start_pfn, zone_end_pfn); > + adjust_zone_range_for_zone_movable(nid, zone_type, node_end_pfn, > + zone_start_pfn, zone_end_pfn); > > /* Check that this node has pages within the zone's required range */ > if (*zone_end_pfn < node_start_pfn || *zone_start_pfn > node_end_pfn) > -- > 2.25.1 >
On 7/17/23 12:28, Haifeng Xu wrote: > node_start_pfn is not used in adjust_zone_range_for_zone_movable(), so > it is pointless to waste a function argument. Drop the parameter. > > Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com> > --- > mm/mm_init.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index a313d1828a6c..23d50541e1f7 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1105,7 +1105,6 @@ void __ref memmap_init_zone_device(struct zone *zone, > */ > static void __init adjust_zone_range_for_zone_movable(int nid, > unsigned long zone_type, > - unsigned long node_start_pfn, > unsigned long node_end_pfn, > unsigned long *zone_start_pfn, > unsigned long *zone_end_pfn) > @@ -1222,9 +1221,8 @@ static unsigned long __init zone_spanned_pages_in_node(int nid, > /* Get the start and end of the zone */ > *zone_start_pfn = clamp(node_start_pfn, zone_low, zone_high); > *zone_end_pfn = clamp(node_end_pfn, zone_low, zone_high); > - adjust_zone_range_for_zone_movable(nid, zone_type, > - node_start_pfn, node_end_pfn, > - zone_start_pfn, zone_end_pfn); > + adjust_zone_range_for_zone_movable(nid, zone_type, node_end_pfn, > + zone_start_pfn, zone_end_pfn); > > /* Check that this node has pages within the zone's required range */ > if (*zone_end_pfn < node_start_pfn || *zone_start_pfn > node_end_pfn)
diff --git a/mm/mm_init.c b/mm/mm_init.c index a313d1828a6c..23d50541e1f7 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -1105,7 +1105,6 @@ void __ref memmap_init_zone_device(struct zone *zone, */ static void __init adjust_zone_range_for_zone_movable(int nid, unsigned long zone_type, - unsigned long node_start_pfn, unsigned long node_end_pfn, unsigned long *zone_start_pfn, unsigned long *zone_end_pfn) @@ -1222,9 +1221,8 @@ static unsigned long __init zone_spanned_pages_in_node(int nid, /* Get the start and end of the zone */ *zone_start_pfn = clamp(node_start_pfn, zone_low, zone_high); *zone_end_pfn = clamp(node_end_pfn, zone_low, zone_high); - adjust_zone_range_for_zone_movable(nid, zone_type, - node_start_pfn, node_end_pfn, - zone_start_pfn, zone_end_pfn); + adjust_zone_range_for_zone_movable(nid, zone_type, node_end_pfn, + zone_start_pfn, zone_end_pfn); /* Check that this node has pages within the zone's required range */ if (*zone_end_pfn < node_start_pfn || *zone_start_pfn > node_end_pfn)