Message ID | 20230623100822.274706-5-sui.jingfeng@linux.dev |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5668105vqr; Fri, 23 Jun 2023 03:29:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4QUDaj1EQxCmVP3yitjhx6jFXHHtDHrKpUMPREaObOzrGoTd9HZrcJT8rAJaWHBsZ6yvJ4 X-Received: by 2002:a92:c502:0:b0:342:512a:ccec with SMTP id r2-20020a92c502000000b00342512accecmr15772273ilg.31.1687516144341; Fri, 23 Jun 2023 03:29:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687516144; cv=none; d=google.com; s=arc-20160816; b=gIbC1tD2FNUzyRHpJdpn7k9IYWoPJdoEjL7PljMvEE//S1WeTv8cQuFS+eEEom+qX0 4jBd/q5vahdyk1iRJA8V62GylDyGYSRKSCzAsAtSaCYPy8fRb7l4NtnP3HOY3u6G+Fpe t9J7RTxh98BOh0hNyGIsrTSsGnvdXKEs2ARqPmioEwTASznxMMRYjinQTII+85nEQQA5 gMayeZ5tLG95KU/pFfglg/Kb1uFJfJ/n+Vz7B2gPQCECf195s8kwyvDtCFq6wbE54q+a OA5QNAucil0bfiEzRnCvcTkGesolSokg68s7ANWm0fm0BTWYekotPlYtwhG+q0xqedBe vF1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mF5gwWREhceV79QC2kAelYl92prkgsyFzXbQ6wC4rh4=; b=Jc628UHvgjk+T0JtAUWDvOtAvbRGEr3t1dcbnUkpH+1Ck1lciXNJkBTBTVwHUB/4LQ w1drDW3XeyktO3UCxoDRIyGcDcHOiBAtmDBmdRH9hAWTG42feXXiXbSDKQhbR16upoP6 Ca2AfFI6GGQowTRpIav37n8ZZmegaXCQnOFhuvypM34i/Ghw3lF7M8w2gDV/mIy8ORw3 YE1GhRmZal8w/YzqL2YkvKDZPulVtTpDx+ckomK7KabuUK085UiPEotslwgkTXqt23q4 ZhrakWd6VZuwWO3aSZmlrMtWxmMCJLQF6hx2VatzEZghs8KYleCgfc6cMHInRSJTTkjA YMpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=BSm1nw4V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u13-20020a63b54d000000b0054fd2a6c847si8156779pgo.766.2023.06.23.03.28.52; Fri, 23 Jun 2023 03:29:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=BSm1nw4V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231696AbjFWKRk (ORCPT <rfc822;maxin.john@gmail.com> + 99 others); Fri, 23 Jun 2023 06:17:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231617AbjFWKRQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 23 Jun 2023 06:17:16 -0400 X-Greylist: delayed 516 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 23 Jun 2023 03:17:05 PDT Received: from out-29.mta0.migadu.com (out-29.mta0.migadu.com [91.218.175.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7D2FE6E for <linux-kernel@vger.kernel.org>; Fri, 23 Jun 2023 03:17:05 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1687514917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mF5gwWREhceV79QC2kAelYl92prkgsyFzXbQ6wC4rh4=; b=BSm1nw4VrOmP8VdV9c5EodP7YP0Z5hbl3KDGUfa8Du91PXb1dpwrhjKUp86e+/jyxxXU1e vZja+Rmj3BD/izV10syp9mrt2A3LY5wHfuhMwrlADqRBka7KcZeSV7XS0oCLWXLGhWzPfS V68pU98aDw5OtnR/vXlTfCT1IKFxm+Q= From: Sui Jingfeng <sui.jingfeng@linux.dev> To: Lucas Stach <l.stach@pengutronix.de>, Russell King <linux+etnaviv@armlinux.org.uk>, Christian Gmeiner <christian.gmeiner@gmail.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch> Cc: etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn, Sui Jingfeng <suijingfeng@loongson.cn> Subject: [PATCH v1 4/8] drm/etnaviv: Remove surplus else after return Date: Fri, 23 Jun 2023 18:08:18 +0800 Message-Id: <20230623100822.274706-5-sui.jingfeng@linux.dev> In-Reply-To: <20230623100822.274706-1-sui.jingfeng@linux.dev> References: <20230623100822.274706-1-sui.jingfeng@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769488928742842288?= X-GMAIL-MSGID: =?utf-8?q?1769488928742842288?= |
Series |
drm/etnaviv: Various cleanup
|
|
Commit Message
Sui Jingfeng
June 23, 2023, 10:08 a.m. UTC
From: Sui Jingfeng <suijingfeng@loongson.cn> Because the 'else' is not generally useful after the 'return'. Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
Comments
Am Freitag, dem 23.06.2023 um 18:08 +0800 schrieb Sui Jingfeng: > From: Sui Jingfeng <suijingfeng@loongson.cn> > > Because the 'else' is not generally useful after the 'return'. While your cleanup is a correct rewrite of the function, the current code in this function is bogus, as we need to check for the bidirectional (READ | WRITE) case first. Currently we just pick the DMA_FROM_DEVICE direction when both flags are set, which is clearly not right. Regards, Lucas > > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> > --- > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > index be2f459c66b5..271470723d5e 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > @@ -358,10 +358,11 @@ static inline enum dma_data_direction etnaviv_op_to_dma_dir(u32 op) > { > if (op & ETNA_PREP_READ) > return DMA_FROM_DEVICE; > - else if (op & ETNA_PREP_WRITE) > + > + if (op & ETNA_PREP_WRITE) > return DMA_TO_DEVICE; > - else > - return DMA_BIDIRECTIONAL; > + > + return DMA_BIDIRECTIONAL; > } > > int etnaviv_gem_cpu_prep(struct drm_gem_object *obj, u32 op,
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c index be2f459c66b5..271470723d5e 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c @@ -358,10 +358,11 @@ static inline enum dma_data_direction etnaviv_op_to_dma_dir(u32 op) { if (op & ETNA_PREP_READ) return DMA_FROM_DEVICE; - else if (op & ETNA_PREP_WRITE) + + if (op & ETNA_PREP_WRITE) return DMA_TO_DEVICE; - else - return DMA_BIDIRECTIONAL; + + return DMA_BIDIRECTIONAL; } int etnaviv_gem_cpu_prep(struct drm_gem_object *obj, u32 op,