Message ID | 20230717031221.55073-1-yunchuan@nfschina.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp883143vqt; Sun, 16 Jul 2023 20:32:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlFQZSJKoPZr58ENcwIKlyI5ai4DJ0k3i/kt/LUK8/Pjwyx3STCrkiskIrgIvmWRs4oEUj/B X-Received: by 2002:a05:6a20:3ca4:b0:132:8620:8d21 with SMTP id b36-20020a056a203ca400b0013286208d21mr13365142pzj.58.1689564744041; Sun, 16 Jul 2023 20:32:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689564744; cv=none; d=google.com; s=arc-20160816; b=AA1gMhEA4ZOzdaO3IuvMu2XeXg2taU0LgRjMLHPZNQe+8KYEo3ckbYZd3YwegFLiFu JUbzTi9OKC1kRQS81oM9/vCUQ2vNYNRZw/2nMdWgVJr5g4UbEFJVdzEF1baQNFd6/0BH TKcXIhtLj1QEdi8sXHG/VlN0LpWAJviNzGXwwg9oebgoCd4uFBYS8eBhC3bzKvGUI1X8 7rdTugeJ8LRD7Symv8JMVb9N5d1ia4rx8+lGKZZwEjp9EqPf9zBMOT4LOvMQvEaZ+OPm S5n/EtTSeS/IjupvH5yrYB+3V70jXZfVQqYlDi4V11szETScoDpacitcAc/0LK2LwkY+ x/yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Mc+aFb8rDHAgJrhqrTp2V5cU19ZfKbp6Bpvr88h2km0=; fh=h/9efll7V8daxAa4jOG4DuJjWmMYAkKnU0SjU0rbuI4=; b=cXDN49Ky4akIikHtuxdyO8ePzEqAW6wN/bTlvX3bJMCc4DPg4rqNkbBXilH9cfRdJL 8UpZYrafh8AGfzykPfJXq9m4iqNy5YwU4qTDygzpnJWI7VSMPvEbTnEgxHK0lgXoUWtT QY/hHeQQW/jqfKdo5Qp0L2CjVAC3m1Zu1scsJvmXlhUkhexRzARFLPX8rVkbBTzkzQZ1 j3XS+wR2xcULQQTyv2o6bcjXgrHh9xil1Zf8vjUpL2ogKsktbTsIbeX9tBqdG8wmuhS/ 5nlUsbXSdzdQIu9M+G6U89XLZ7RoeHSWGHaF1UMHCabgB7YLqmuWLShe0ZjxYo4wyqK5 UYJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c19-20020a056a000ad300b0066d93ab678asi11241679pfl.16.2023.07.16.20.32.10; Sun, 16 Jul 2023 20:32:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231293AbjGQDNR (ORCPT <rfc822;assdfgzxcv4@gmail.com> + 99 others); Sun, 16 Jul 2023 23:13:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231331AbjGQDMr (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 16 Jul 2023 23:12:47 -0400 Received: from mail.nfschina.com (unknown [42.101.60.195]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 6CBCE18D; Sun, 16 Jul 2023 20:12:30 -0700 (PDT) Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id 03B58601858F5; Mon, 17 Jul 2023 11:12:22 +0800 (CST) X-MD-Sfrom: yunchuan@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Wu Yunchuan <yunchuan@nfschina.com> To: wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: uttenthaler@ems-wuensche.com, yunchuan@nfschina.com, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH net-next v3 8/9] can: ems_pci: Remove unnecessary (void*) conversions Date: Mon, 17 Jul 2023 11:12:21 +0800 Message-Id: <20230717031221.55073-1-yunchuan@nfschina.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RDNS_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771637040875820596 X-GMAIL-MSGID: 1771637040875820596 |
Series |
[net-next,v3,1/9] net: atlantic: Remove unnecessary (void*) conversions
|
|
Commit Message
Wu Yunchuan
July 17, 2023, 3:12 a.m. UTC
No need cast (void*) to (struct ems_pci_card *). Signed-off-by: Wu Yunchuan <yunchuan@nfschina.com> Acked-by: Marc Kleine-Budde<mkl@pengutronix.de> --- drivers/net/can/sja1000/ems_pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Comments
On 17.07.2023 11:12:21, Wu Yunchuan wrote: > No need cast (void*) to (struct ems_pci_card *). > > Signed-off-by: Wu Yunchuan <yunchuan@nfschina.com> > Acked-by: Marc Kleine-Budde<mkl@pengutronix.de> Please add a space between my name and my e-mail address, so that it reads: Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> nitpick: You should add your S-o-b as the last trailer. regards, Marc
On 2023/7/17 14:52, Marc Kleine-Budde wrote: > On 17.07.2023 11:12:21, Wu Yunchuan wrote: >> No need cast (void*) to (struct ems_pci_card *). >> >> Signed-off-by: Wu Yunchuan <yunchuan@nfschina.com> >> Acked-by: Marc Kleine-Budde<mkl@pengutronix.de> > Please add a space between my name and my e-mail address, so that it > reads: > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> Hi, Sorry for this, I will resend this patch to add a space. > > nitpick: > You should add your S-o-b as the last trailer. Oh, thanks for this reminder! Wu Yunchuan > regards, > Marc >
On 17.07.2023 08:52:42, Marc Kleine-Budde wrote: > On 17.07.2023 11:12:21, Wu Yunchuan wrote: > > No need cast (void*) to (struct ems_pci_card *). > > > > Signed-off-by: Wu Yunchuan <yunchuan@nfschina.com> > > Acked-by: Marc Kleine-Budde<mkl@pengutronix.de> > > Please add a space between my name and my e-mail address, so that it > reads: > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> > > nitpick: > You should add your S-o-b as the last trailer. BTW: The threading of this series is still broken. Make sure you send the whole patch series with one single "git send-email" command. For regular contribution you might have a look at the "b4" [1] tool. regards, Marc [1] https://people.kernel.org/monsieuricon/sending-a-kernel-patch-with-b4-part-1
On 2023/7/17 15:07, Marc Kleine-Budde wrote: > On 17.07.2023 08:52:42, Marc Kleine-Budde wrote: >> On 17.07.2023 11:12:21, Wu Yunchuan wrote: >>> No need cast (void*) to (struct ems_pci_card *). >>> >>> Signed-off-by: Wu Yunchuan <yunchuan@nfschina.com> >>> Acked-by: Marc Kleine-Budde<mkl@pengutronix.de> >> Please add a space between my name and my e-mail address, so that it >> reads: >> >> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> >> >> nitpick: >> You should add your S-o-b as the last trailer. > BTW: The threading of this series is still broken. Make sure you send > the whole patch series with one single "git send-email" command. For > regular contribution you might have a look at the "b4" [1] tool. Hi, Thanks for you suggestions, I use 'git send-email' to send patch. I messing up the patch's order in different patchset. This might be the reason of the broken threading. Really sorry for this, I will take careful next time. Wu Yunchuan > regards, > Marc > > [1] https://people.kernel.org/monsieuricon/sending-a-kernel-patch-with-b4-part-1 >
On 17.07.2023 15:30:33, yunchuan wrote: > > On 2023/7/17 15:07, Marc Kleine-Budde wrote: > > On 17.07.2023 08:52:42, Marc Kleine-Budde wrote: > > > On 17.07.2023 11:12:21, Wu Yunchuan wrote: > > > > No need cast (void*) to (struct ems_pci_card *). > > > > > > > > Signed-off-by: Wu Yunchuan <yunchuan@nfschina.com> > > > > Acked-by: Marc Kleine-Budde<mkl@pengutronix.de> > > > Please add a space between my name and my e-mail address, so that it > > > reads: > > > > > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> > > > > > > nitpick: > > > You should add your S-o-b as the last trailer. > > BTW: The threading of this series is still broken. Make sure you send > > the whole patch series with one single "git send-email" command. For > > regular contribution you might have a look at the "b4" [1] tool. > > Hi, > > Thanks for you suggestions, I use 'git send-email' to send patch. > I messing up the patch's order in different patchset. This might be the > reason of the broken threading. > Really sorry for this, I will take careful next time. You should send _all_ 9 patches in the series with a _single_ "git send-email" command. There's no risk to mess up the order. regards, Marc
diff --git a/drivers/net/can/sja1000/ems_pci.c b/drivers/net/can/sja1000/ems_pci.c index c56e27223e5f..ac86640998a8 100644 --- a/drivers/net/can/sja1000/ems_pci.c +++ b/drivers/net/can/sja1000/ems_pci.c @@ -148,7 +148,7 @@ static void ems_pci_v1_write_reg(const struct sja1000_priv *priv, static void ems_pci_v1_post_irq(const struct sja1000_priv *priv) { - struct ems_pci_card *card = (struct ems_pci_card *)priv->priv; + struct ems_pci_card *card = priv->priv; /* reset int flag of pita */ writel(PITA2_ICR_INT0_EN | PITA2_ICR_INT0, @@ -168,7 +168,7 @@ static void ems_pci_v2_write_reg(const struct sja1000_priv *priv, static void ems_pci_v2_post_irq(const struct sja1000_priv *priv) { - struct ems_pci_card *card = (struct ems_pci_card *)priv->priv; + struct ems_pci_card *card = priv->priv; writel(PLX_ICSR_ENA_CLR, card->conf_addr + PLX_ICSR); } @@ -186,7 +186,7 @@ static void ems_pci_v3_write_reg(const struct sja1000_priv *priv, static void ems_pci_v3_post_irq(const struct sja1000_priv *priv) { - struct ems_pci_card *card = (struct ems_pci_card *)priv->priv; + struct ems_pci_card *card = priv->priv; writel(ASIX_LINTSR_INT0AC, card->conf_addr + ASIX_LINTSR); }