diff mbox series

dt-bindings: extcon: extcon-usb-gpio: convert to yaml format

Message ID 20230713002519.109392-1-david@ixit.cz
State New
Headers
Series dt-bindings: extcon: extcon-usb-gpio: convert to yaml format |

Commit Message

David Heidelberg July 13, 2023, 12:25 a.m. UTC 
  Signed-off-by: David Heidelberg <david@ixit.cz>
---
 .../bindings/extcon/extcon-usb-gpio.txt       | 21 ---------
 .../bindings/extcon/extcon-usb-gpio.yaml      | 45 +++++++++++++++++++
 2 files changed, 45 insertions(+), 21 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
 create mode 100644 Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml

Comments

MyungJoo Ham July 13, 2023, 4:42 a.m. UTC | #1 
>--------- Original Message ---------
>Sender : David Heidelberg <david@ixit.cz>
>Date   : 2023-07-13 09:25 (GMT+9)
>Title  : [PATCH] dt-bindings: extcon: extcon-usb-gpio: convert to yaml format
> 
>Signed-off-by: David Heidelberg <david@ixit.cz>

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

>---
> .../bindings/extcon/extcon-usb-gpio.txt       | 21 ---------
> .../bindings/extcon/extcon-usb-gpio.yaml      | 45 +++++++++++++++++++
> 2 files changed, 45 insertions(+), 21 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
> create mode 100644 Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml
>
>diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>deleted file mode 100644
>index dfc14f71e81f..000000000000
>--- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>+++ /dev/null
[]
>diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml
>new file mode 100644
>index 000000000000..b345745013a2
>--- /dev/null
>+++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml
[]
Krzysztof Kozlowski July 13, 2023, 6:34 a.m. UTC | #2 
On 13/07/2023 02:25, David Heidelberg wrote:
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---

Missing commit msg... but anyway this was sent a month ago:

https://lore.kernel.org/all/20230615145838.1526919-1-alexander.stein@ew.tq-group.com/

plus your version unfortunately makes similar mistake as Alexander's.



Best regards,
Krzysztof
Linus Walleij July 15, 2023, 7:49 p.m. UTC | #3 
On Thu, Jul 13, 2023 at 2:25 AM David Heidelberg <david@ixit.cz> wrote:

> +maintainers:
> +  - Linus Walleij <linus.walleij@linaro.org>

I don't see why I should be listed for this? I have nothing to
do with it, I think.

On the topic:
Can't this just reuse Rob's excellent binding in
Documentation/devicetree/bindings/connector/usb-connector.yaml
just add id-gpios to it and list const: linux,extcon-usb-gpio as a
deprecated compatible.

(Then we should make the Linux driver probe from the existing
and better compatibles from that file, but it's a whole other issue.)

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
deleted file mode 100644
index dfc14f71e81f..000000000000
--- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
+++ /dev/null
@@ -1,21 +0,0 @@ 
-USB GPIO Extcon device
-
-This is a virtual device used to generate USB cable states from the USB ID pin
-connected to a GPIO pin.
-
-Required properties:
-- compatible: Should be "linux,extcon-usb-gpio"
-
-Either one of id-gpio or vbus-gpio must be present. Both can be present as well.
-- id-gpio: gpio for USB ID pin. See gpio binding.
-- vbus-gpio: gpio for USB VBUS pin.
-
-Example: Examples of extcon-usb-gpio node in dra7-evm.dts as listed below:
-	extcon_usb1 {
-		compatible = "linux,extcon-usb-gpio";
-		id-gpio = <&gpio6 1 GPIO_ACTIVE_HIGH>;
-	}
-
-	&omap_dwc3_1 {
-		extcon = <&extcon_usb1>;
-	};
diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml
new file mode 100644
index 000000000000..b345745013a2
--- /dev/null
+++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.yaml
@@ -0,0 +1,45 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/extcon/extcon-usb-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: USB GPIO Extcon device
+
+maintainers:
+  - Linus Walleij <linus.walleij@linaro.org>
+
+description:
+  This is a virtual device used to generate USB cable states
+  from the USB ID pin connected to a GPIO pin.
+
+properties:
+  compatible:
+    const: linux,extcon-usb-gpio
+
+  id-gpio:
+    description: GPIO for USB ID pin.
+
+  vbus-gpio:
+    description: GPIO for USB VBUS pin.
+
+required:
+  - compatible
+
+anyOf:
+  - required:
+      - id-gpio
+  - required:
+      - vbus-gpio
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    extcon_usb1 {
+        compatible = "linux,extcon-usb-gpio";
+        id-gpio = <&gpio6 1 GPIO_ACTIVE_HIGH>;
+    };
+
+...