Message ID | 20221005-mt6357-support-v4-2-5d2bb58e6087@baylibre.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2885175wru; Tue, 8 Nov 2022 10:45:15 -0800 (PST) X-Google-Smtp-Source: AMsMyM6JIl3Bgg7RbXYx819sL4yCklHARQlPvB91os0mZAqfsvvAmOHbgIGmuDKofboti14QRZVV X-Received: by 2002:a17:90a:ca87:b0:212:d2bd:82f5 with SMTP id y7-20020a17090aca8700b00212d2bd82f5mr60068513pjt.203.1667933115417; Tue, 08 Nov 2022 10:45:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667933115; cv=none; d=google.com; s=arc-20160816; b=yBjFVQX1COTykeDOcfnZFyNh1prVg+zq0nbRwiezcuSw1rzWw7Qy58SCIo52npuZUy 9OCDlE/2jfgCrvNfjtNGmFE/YZYEmBtQdMTz1Gf6mxSkJnBcjvYIcLSi8PZ//2GpgeLT xXB77E5PLaWhpc5FJ8h37vGPZv0/mIaGh+AES34UWjJgzGN4m99XE+J+TUXDn3eTb208 1cioO0m1gc/c6zAAQ2pphnVliRD8tENehSTCyxrnjF2ofiaHiWp71G2HjgQHxwWnX5qQ DFsJUuwoDbD+gVoRc+5bYQcR1A4zYyrZOxxg3PQHu2pnTx5hwRnrwlrUpnseHykFTmez ltyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=0/WfzvHJubbv56pooqVBj0w476tmu7QbHTTDbRCIA5E=; b=HQxB5roxFJ0HS5JYVTtnbAq3pBzG5XA/F+Tzp+VeGfd2H6tusSAKaWPWnp38xsWR/Y GAc2UMb99MCNiMU2w9QrYkshOloxvZN83B/V8v/R6HR54yNf+R0EoyRIv7Budolu8kAF Dnb+m5CeCG8BifcKscb3771gJfkr0y6XtgT9Cq/lF44pxSTQ8++HLvw8ete2pWDiUSlt DI6TUmSs28Aw1DShwEUxNbCYyL+Qu11vsKXRvPMWf6QX9p046d6/kimg8qXPow2PmQrD 8nvFOfbkED3K5xtG8Yly5K3Ymx1jby2siWfXMPpibk31GdmjNlbJM3QP34aAumTGiT/P zhKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b="TewWiwo/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bn22-20020a056a02031600b00462da7a1de0si16486844pgb.301.2022.11.08.10.45.01; Tue, 08 Nov 2022 10:45:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b="TewWiwo/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232532AbiKHSob (ORCPT <rfc822;tony84727@gmail.com> + 99 others); Tue, 8 Nov 2022 13:44:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231665AbiKHSoR (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 8 Nov 2022 13:44:17 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 419521DF26 for <linux-kernel@vger.kernel.org>; Tue, 8 Nov 2022 10:44:16 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id o4so22447878wrq.6 for <linux-kernel@vger.kernel.org>; Tue, 08 Nov 2022 10:44:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0/WfzvHJubbv56pooqVBj0w476tmu7QbHTTDbRCIA5E=; b=TewWiwo/fKUKHnrl/jdGAA26gbsYfnUGzuWcy1Z6I8182suw87I83Z6VUuQrsVqIgV 8eYu6BsyAZSa2Nbii6LBsVNDvsHOXsbu9sQiuVGO3cAJ+MaATm0I8yqJ0Xw8ffODeFyL oTtw//bUxz0QR9Rh/ZOuKZkYUjsGnf9FlVVE5pDQJCY138jZVgeOhO4agYzEX4G5dVHx 8mhro01GcAXguWqqFwAsc/+Jrq6ya5VG5hzHT+nBE2q+KKQIyaSgn8PzHEezPJsZWA2V aPgzrhpztrn9y9rs5z0CAn2TxZ3lj53L1G5uTCW/ogDbt2i3PrGJkAnF1k6Ihwz+nclx vZ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0/WfzvHJubbv56pooqVBj0w476tmu7QbHTTDbRCIA5E=; b=YcqYRXAQ5it1p2IVe1kEjkNBDIxcy/B/zU83sI7sXKQ3pvffdo/anq+NwzX1GYz6vl DddUALHHMtLB8/RaOSyaZAT2pyl+1vRn1tCrTyi068qzsFPj+aHVYxsUADBTnmdiNJ7b BOKx8hHkJTUdr9zeSTH96gerRuSXqu7gkmEdKeidW4g9Lrn8wDrwkwy8ojcO15ziCxfK Ds8iuJ3heSj8qz8IyK7ndwbeXevMwVJ1qrzilmHIAp56Q+2k1qTKxvwbbE1NjJO4Gtj0 JMzlHSCqTE0/pM1H4kTO/HjTQM9RH/S7YB3ohuUFs1Ibm8zLPgPedX4SqH4Cheu9ESqf kHEw== X-Gm-Message-State: ACrzQf2BqZ1hPrn1HdnNBmkvWNWtflgMADGHoj6Bxe5NcZhi6vwE0Lj6 8GL2ye8YmUdR2MjoGriPBwzsEw== X-Received: by 2002:adf:ba8f:0:b0:22c:def3:1179 with SMTP id p15-20020adfba8f000000b0022cdef31179mr36812897wrg.571.1667933054732; Tue, 08 Nov 2022 10:44:14 -0800 (PST) Received: from [127.0.1.1] (158.22.5.93.rev.sfr.net. [93.5.22.158]) by smtp.googlemail.com with ESMTPSA id m6-20020a05600c3b0600b003cf6c2f9513sm13564009wms.2.2022.11.08.10.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 10:44:14 -0800 (PST) From: Alexandre Mergnat <amergnat@baylibre.com> Date: Tue, 08 Nov 2022 19:43:37 +0100 Subject: [PATCH v4 2/9] dt-bindings: rtc: mediatek: convert MT6397 rtc documentation MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20221005-mt6357-support-v4-2-5d2bb58e6087@baylibre.com> References: <20221005-mt6357-support-v4-0-5d2bb58e6087@baylibre.com> In-Reply-To: <20221005-mt6357-support-v4-0-5d2bb58e6087@baylibre.com> To: Fabien Parent <fabien.parent@linaro.org>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Sean Wang <sean.wang@mediatek.com>, Mark Brown <broonie@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, Lee Jones <lee@kernel.org>, Chen Zhong <chen.zhong@mediatek.com>, Alessandro Zummo <a.zummo@towertech.it>, Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: linux-leds@vger.kernel.org, Alexandre Mergnat <amergnat@baylibre.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Fabien Parent <fparent@baylibre.com>, linux-rtc@vger.kernel.org, Rob Herring <robh@kernel.org>, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, Mattijs Korpershoek <mkorpershoek@baylibre.com> X-Mailer: b4 0.10.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3705; i=amergnat@baylibre.com; h=from:subject:message-id; bh=/h7YGXK8tw+BLV0bfVCW4btQXGCozMogPt+Hd7yMb0w=; b=owEBbQKS/ZANAwAKAStGSZ1+MdRFAcsmYgBjaqN6CcEIylfYlBT9eGuZhBXMu2i4n3Ib1lYHdH1n C4gPsFeJAjMEAAEKAB0WIQQjG17X8+qqcA5g/osrRkmdfjHURQUCY2qjegAKCRArRkmdfjHURVVaD/ 0RFrYM5QhJtj1wxw1WP8Su/8jf7SX9w6CEJdEwgOv8MoNVRPajQAS1CfjLMls9gf9+mBKCXnidGzPM bDWm+UFzkoCFRRfvNaz03yHPv/xtw4d1Mx68maavKuNtPHP4G4A1b4nK72gTK06NCa3RDJ/0LO94kJ 2szrH6wmsgb2qAIMxhv5J8IFuVg4KlGa0/GKRz2CNljD6gD33IRqmel1gDHoPLxcKgqRnTVleGNZOr obiskESHGXywTJ8h3BABgXOCUbnXOnSscs7//0XL4e61yBMOSQmeQV9e6xm9Ia1ZR3o+IAywUazdho GihclUAEcvj2Lgwu7T/xgwYy4zt8hbvK9M2m7JC4hRhtdrNMjPYpuj/irv5uAUVafwyP5PK4tAdnkU EOeTLNmgd4xgCbgVVB8hgA0Cuxfrrp1+CG4y0Y+NIBneVy3ghLzMgM1wDwTCC+BWlRaPBp1n/4tgCa 1v7AsxSaYYhb7wEeKQP//eBC0mrsfkQ5xx9MbhDWB5qq02BCwjfHci9hPcJ9YSGWQehuyckkmLIyKx fxLuAqts76aL7lWlnt+7GplIKMWrT6ORB9Lq79G2j4VVY1SM8TXFgoHUpBhYhFtDoCggWrehJLnEl4 hLr4Ae2OS/ZHx0MFVFeEJJ8C/A0cs4jE2IrLSZhbLGxc8tYCtZWq/Z2j49aQ== X-Developer-Key: i=amergnat@baylibre.com; a=openpgp; fpr=231B5ED7F3EAAA700E60FE8B2B46499D7E31D445 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748954634418544503?= X-GMAIL-MSGID: =?utf-8?q?1748954634418544503?= |
Series |
Add MediaTek MT6357 PMIC support
|
|
Commit Message
Alexandre Mergnat
Nov. 8, 2022, 6:43 p.m. UTC
- Convert rtc/rtc-mt6397.txt to rtc/mt6397-rtc.yaml
- Add mediatek,mt6357-rtc compatible.
- Add maintainer
- Remove the .txt binding file
Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
---
Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +-
.../bindings/rtc/mediatek,mt6397-rtc.yaml | 40 ++++++++++++++++++++++
.../devicetree/bindings/rtc/rtc-mt6397.txt | 31 -----------------
3 files changed, 41 insertions(+), 32 deletions(-)
Comments
On Tue, 08 Nov 2022 19:43:37 +0100, Alexandre Mergnat wrote: > - Convert rtc/rtc-mt6397.txt to rtc/mt6397-rtc.yaml > - Add mediatek,mt6357-rtc compatible. > - Add maintainer > - Remove the .txt binding file > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +- > .../bindings/rtc/mediatek,mt6397-rtc.yaml | 40 ++++++++++++++++++++++ > .../devicetree/bindings/rtc/rtc-mt6397.txt | 31 ----------------- > 3 files changed, 41 insertions(+), 32 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.example.dtb:0:0: /example-0/pmic: failed to match any schema with compatible: ['mediatek,mt6397'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Il 08/11/22 19:43, Alexandre Mergnat ha scritto: > - Convert rtc/rtc-mt6397.txt to rtc/mt6397-rtc.yaml > - Add mediatek,mt6357-rtc compatible. > - Add maintainer > - Remove the .txt binding file > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +- > .../bindings/rtc/mediatek,mt6397-rtc.yaml | 40 ++++++++++++++++++++++ > .../devicetree/bindings/rtc/rtc-mt6397.txt | 31 ----------------- > 3 files changed, 41 insertions(+), 32 deletions(-) > Please split the txt->yaml conversion in one commit and the addition of the new mt6357-rtc compatible in another commit. Also, isn't the original maintainer of rtc-mt6397 supposed to be... Tianping Fang <tianping.fang@mediatek.com> ? You can add yourself to the list of maintainers, though, unless Tianping explicitly says that he doesn't want to maintain this driver anymore? Regards, Angelo
On 09/11/2022 10:40:39+0100, AngeloGioacchino Del Regno wrote: > Il 08/11/22 19:43, Alexandre Mergnat ha scritto: > > - Convert rtc/rtc-mt6397.txt to rtc/mt6397-rtc.yaml > > - Add mediatek,mt6357-rtc compatible. > > - Add maintainer > > - Remove the .txt binding file > > > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > > --- > > Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +- > > .../bindings/rtc/mediatek,mt6397-rtc.yaml | 40 ++++++++++++++++++++++ > > .../devicetree/bindings/rtc/rtc-mt6397.txt | 31 ----------------- > > 3 files changed, 41 insertions(+), 32 deletions(-) > > > > Please split the txt->yaml conversion in one commit and the addition of the > new mt6357-rtc compatible in another commit. > > Also, isn't the original maintainer of rtc-mt6397 supposed to be... > Tianping Fang <tianping.fang@mediatek.com> ? > > You can add yourself to the list of maintainers, though, unless Tianping > explicitly says that he doesn't want to maintain this driver anymore? > This is not about the maintenance of the driver but of the device tree bindings for the IP > Regards, > Angelo >
On Tue, Nov 08, 2022 at 07:43:37PM +0100, Alexandre Mergnat wrote: > - Convert rtc/rtc-mt6397.txt to rtc/mt6397-rtc.yaml > - Add mediatek,mt6357-rtc compatible. > - Add maintainer > - Remove the .txt binding file > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +- > .../bindings/rtc/mediatek,mt6397-rtc.yaml | 40 ++++++++++++++++++++++ > .../devicetree/bindings/rtc/rtc-mt6397.txt | 31 ----------------- > 3 files changed, 41 insertions(+), 32 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt > index 0088442efca1..79aaf21af8e9 100644 > --- a/Documentation/devicetree/bindings/mfd/mt6397.txt > +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt > @@ -33,7 +33,7 @@ Optional subnodes: > - compatible: "mediatek,mt6331-rtc" > - compatible: "mediatek,mt6358-rtc" > - compatible: "mediatek,mt6397-rtc" > - For details, see ../rtc/rtc-mt6397.txt > + For details, see ../rtc/mediatek,mt6397-rtc.yaml > - regulators > Required properties: > - compatible: "mediatek,mt6323-regulator" > diff --git a/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml > new file mode 100644 > index 000000000000..bb48c0150f95 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml > @@ -0,0 +1,40 @@ > + # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/mediatek,mt6397-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT6397/MT6366/MT6358/MT6357/MT6323 RTC > + > +maintainers: > + - Alexandre Mergnat <amergnat@baylibre.com> > + > +description: | > + MediaTek PMIC based RTC is an independent function of MediaTek PMIC that works > + as a type of multi-function device (MFD). The RTC can be configured and set up > + with PMIC wrapper bus which is a common resource shared with the other > + functions found on the same PMIC. > + > +properties: > + compatible: > + enum: > + - mediatek,mt6323-rtc > + - mediatek,mt6357-rtc > + - mediatek,mt6358-rtc > + - mediatek,mt6366-rtc > + - mediatek,mt6397-rtc As this is only a compatible string, just fold this into the MFD schema doc. > + > +additionalProperties: false > + > +required: > + - compatible > + > +examples: > + - | > + pmic { > + compatible = "mediatek,mt6397"; > + > + rtc { > + compatible = "mediatek,mt6397-rtc"; > + }; > + };
On 09/11/2022 16:29:16-0600, Rob Herring wrote: > On Tue, Nov 08, 2022 at 07:43:37PM +0100, Alexandre Mergnat wrote: > > - Convert rtc/rtc-mt6397.txt to rtc/mt6397-rtc.yaml > > - Add mediatek,mt6357-rtc compatible. > > - Add maintainer > > - Remove the .txt binding file > > > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > > --- > > Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +- > > .../bindings/rtc/mediatek,mt6397-rtc.yaml | 40 ++++++++++++++++++++++ > > .../devicetree/bindings/rtc/rtc-mt6397.txt | 31 ----------------- > > 3 files changed, 41 insertions(+), 32 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt > > index 0088442efca1..79aaf21af8e9 100644 > > --- a/Documentation/devicetree/bindings/mfd/mt6397.txt > > +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt > > @@ -33,7 +33,7 @@ Optional subnodes: > > - compatible: "mediatek,mt6331-rtc" > > - compatible: "mediatek,mt6358-rtc" > > - compatible: "mediatek,mt6397-rtc" > > - For details, see ../rtc/rtc-mt6397.txt > > + For details, see ../rtc/mediatek,mt6397-rtc.yaml > > - regulators > > Required properties: > > - compatible: "mediatek,mt6323-regulator" > > diff --git a/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml > > new file mode 100644 > > index 000000000000..bb48c0150f95 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml > > @@ -0,0 +1,40 @@ > > + # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/rtc/mediatek,mt6397-rtc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MediaTek MT6397/MT6366/MT6358/MT6357/MT6323 RTC > > + > > +maintainers: > > + - Alexandre Mergnat <amergnat@baylibre.com> > > + > > +description: | > > + MediaTek PMIC based RTC is an independent function of MediaTek PMIC that works > > + as a type of multi-function device (MFD). The RTC can be configured and set up > > + with PMIC wrapper bus which is a common resource shared with the other > > + functions found on the same PMIC. > > + > > +properties: > > + compatible: > > + enum: > > + - mediatek,mt6323-rtc > > + - mediatek,mt6357-rtc > > + - mediatek,mt6358-rtc > > + - mediatek,mt6366-rtc > > + - mediatek,mt6397-rtc > > As this is only a compatible string, just fold this into the MFD schema > doc. Actually, it probably also supports the start-year property > > > + > > +additionalProperties: false > > + > > +required: > > + - compatible > > + > > +examples: > > + - | > > + pmic { > > + compatible = "mediatek,mt6397"; > > + > > + rtc { > > + compatible = "mediatek,mt6397-rtc"; > > + }; > > + };
On 09/11/2022 23:57, Alexandre Belloni wrote: > On 09/11/2022 16:29:16-0600, Rob Herring wrote: >> On Tue, Nov 08, 2022 at 07:43:37PM +0100, Alexandre Mergnat wrote: >>> - Convert rtc/rtc-mt6397.txt to rtc/mt6397-rtc.yaml >>> - Add mediatek,mt6357-rtc compatible. >>> - Add maintainer >>> - Remove the .txt binding file >>> >>> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> >>> --- >>> Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +- >>> .../bindings/rtc/mediatek,mt6397-rtc.yaml | 40 ++++++++++++++++++++++ >>> .../devicetree/bindings/rtc/rtc-mt6397.txt | 31 ----------------- >>> 3 files changed, 41 insertions(+), 32 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt >>> index 0088442efca1..79aaf21af8e9 100644 >>> --- a/Documentation/devicetree/bindings/mfd/mt6397.txt >>> +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt >>> @@ -33,7 +33,7 @@ Optional subnodes: >>> - compatible: "mediatek,mt6331-rtc" >>> - compatible: "mediatek,mt6358-rtc" >>> - compatible: "mediatek,mt6397-rtc" >>> - For details, see ../rtc/rtc-mt6397.txt >>> + For details, see ../rtc/mediatek,mt6397-rtc.yaml >>> - regulators >>> Required properties: >>> - compatible: "mediatek,mt6323-regulator" >>> diff --git a/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml >>> new file mode 100644 >>> index 000000000000..bb48c0150f95 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml >>> @@ -0,0 +1,40 @@ >>> + # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/rtc/mediatek,mt6397-rtc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: MediaTek MT6397/MT6366/MT6358/MT6357/MT6323 RTC >>> + >>> +maintainers: >>> + - Alexandre Mergnat <amergnat@baylibre.com> >>> + >>> +description: | >>> + MediaTek PMIC based RTC is an independent function of MediaTek PMIC that works >>> + as a type of multi-function device (MFD). The RTC can be configured and set up >>> + with PMIC wrapper bus which is a common resource shared with the other >>> + functions found on the same PMIC. >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - mediatek,mt6323-rtc >>> + - mediatek,mt6357-rtc >>> + - mediatek,mt6358-rtc >>> + - mediatek,mt6366-rtc >>> + - mediatek,mt6397-rtc >> >> As this is only a compatible string, just fold this into the MFD schema >> doc. > > Actually, it probably also supports the start-year property What about rest of rtc.yaml schema? Best regards, Krzysztof
On 10/11/2022 15:14:01+0100, Krzysztof Kozlowski wrote: > On 09/11/2022 23:57, Alexandre Belloni wrote: > > On 09/11/2022 16:29:16-0600, Rob Herring wrote: > >> On Tue, Nov 08, 2022 at 07:43:37PM +0100, Alexandre Mergnat wrote: > >>> - Convert rtc/rtc-mt6397.txt to rtc/mt6397-rtc.yaml > >>> - Add mediatek,mt6357-rtc compatible. > >>> - Add maintainer > >>> - Remove the .txt binding file > >>> > >>> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > >>> --- > >>> Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +- > >>> .../bindings/rtc/mediatek,mt6397-rtc.yaml | 40 ++++++++++++++++++++++ > >>> .../devicetree/bindings/rtc/rtc-mt6397.txt | 31 ----------------- > >>> 3 files changed, 41 insertions(+), 32 deletions(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt > >>> index 0088442efca1..79aaf21af8e9 100644 > >>> --- a/Documentation/devicetree/bindings/mfd/mt6397.txt > >>> +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt > >>> @@ -33,7 +33,7 @@ Optional subnodes: > >>> - compatible: "mediatek,mt6331-rtc" > >>> - compatible: "mediatek,mt6358-rtc" > >>> - compatible: "mediatek,mt6397-rtc" > >>> - For details, see ../rtc/rtc-mt6397.txt > >>> + For details, see ../rtc/mediatek,mt6397-rtc.yaml > >>> - regulators > >>> Required properties: > >>> - compatible: "mediatek,mt6323-regulator" > >>> diff --git a/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml > >>> new file mode 100644 > >>> index 000000000000..bb48c0150f95 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml > >>> @@ -0,0 +1,40 @@ > >>> + # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/rtc/mediatek,mt6397-rtc.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: MediaTek MT6397/MT6366/MT6358/MT6357/MT6323 RTC > >>> + > >>> +maintainers: > >>> + - Alexandre Mergnat <amergnat@baylibre.com> > >>> + > >>> +description: | > >>> + MediaTek PMIC based RTC is an independent function of MediaTek PMIC that works > >>> + as a type of multi-function device (MFD). The RTC can be configured and set up > >>> + with PMIC wrapper bus which is a common resource shared with the other > >>> + functions found on the same PMIC. > >>> + > >>> +properties: > >>> + compatible: > >>> + enum: > >>> + - mediatek,mt6323-rtc > >>> + - mediatek,mt6357-rtc > >>> + - mediatek,mt6358-rtc > >>> + - mediatek,mt6366-rtc > >>> + - mediatek,mt6397-rtc > >> > >> As this is only a compatible string, just fold this into the MFD schema > >> doc. > > > > Actually, it probably also supports the start-year property > I checked and it doesn't support it but this needs to be fixed. > What about rest of rtc.yaml schema? > wakeup-source would make sense but the driver doesn't support it yet.
On 14/11/2022 23:57, Alexandre Belloni wrote: >>>> As this is only a compatible string, just fold this into the MFD schema >>>> doc. >>> >>> Actually, it probably also supports the start-year property >> > > I checked and it doesn't support it but this needs to be fixed. > >> What about rest of rtc.yaml schema? >> > > wakeup-source would make sense but the driver doesn't support it yet. The question is about hardware - does hardware support waking up the system via interrupt? This is usually a domain of PMICs which still are powered on when system sleeps. Best regards, Krzysztof
On 15/11/2022 08:56:40+0100, Krzysztof Kozlowski wrote: > On 14/11/2022 23:57, Alexandre Belloni wrote: > > >>>> As this is only a compatible string, just fold this into the MFD schema > >>>> doc. > >>> > >>> Actually, it probably also supports the start-year property > >> > > > > I checked and it doesn't support it but this needs to be fixed. > > > >> What about rest of rtc.yaml schema? > >> > > > > wakeup-source would make sense but the driver doesn't support it yet. > > The question is about hardware - does hardware support waking up the > system via interrupt? This is usually a domain of PMICs which still are > powered on when system sleeps. > I'd say that it is possible that a PMIC is able to wake up the system with or without having an interrupt wired to the SoC so wakeup-source makes sense. We don't need it if it is interrupt only.
On 15/11/2022 09:05, Alexandre Belloni wrote: >>> I checked and it doesn't support it but this needs to be fixed. >>> >>>> What about rest of rtc.yaml schema? >>>> >>> >>> wakeup-source would make sense but the driver doesn't support it yet. >> >> The question is about hardware - does hardware support waking up the >> system via interrupt? This is usually a domain of PMICs which still are >> powered on when system sleeps. >> > > I'd say that it is possible that a PMIC is able to wake up the system > with or without having an interrupt wired to the SoC so wakeup-source > makes sense. We don't need it if it is interrupt only. Then I propose to reference the rtc.yaml. Best regards, Krzysztof
Hi, thanks for your help >>>> I checked and it doesn't support it but this needs to be fixed. >>>> >>>>> What about rest of rtc.yaml schema? >>>>> >>>> >>>> wakeup-source would make sense but the driver doesn't support it yet. >>> >>> The question is about hardware - does hardware support waking up the >>> system via interrupt? This is usually a domain of PMICs which still are >>> powered on when system sleeps. >>> >> >> I'd say that it is possible that a PMIC is able to wake up the system >> with or without having an interrupt wired to the SoC so wakeup-source >> makes sense. We don't need it if it is interrupt only. > >Then I propose to reference the rtc.yaml. I think I understand my error. Actually, the RTC (HW) support the "start-year" feature, then I suggest to fix the binding like that: allOf: - $ref: "rtc.yaml#" properties: compatible: enum: - mediatek,mt6323-rtc - mediatek,mt6357-rtc - mediatek,mt6358-rtc - mediatek,mt6366-rtc - mediatek,mt6397-rtc start-year: true additionalProperties: false required: - compatible examples: - | pmic { rtc { compatible = "mediatek,mt6397-rtc"; }; };
On 15/11/2022 11:34, Alexandre Mergnat wrote: > I think I understand my error. > Actually, the RTC (HW) support the "start-year" feature, then I suggest > to fix the binding like that: > > allOf: > - $ref: "rtc.yaml#" No quotes. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt index 0088442efca1..79aaf21af8e9 100644 --- a/Documentation/devicetree/bindings/mfd/mt6397.txt +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt @@ -33,7 +33,7 @@ Optional subnodes: - compatible: "mediatek,mt6331-rtc" - compatible: "mediatek,mt6358-rtc" - compatible: "mediatek,mt6397-rtc" - For details, see ../rtc/rtc-mt6397.txt + For details, see ../rtc/mediatek,mt6397-rtc.yaml - regulators Required properties: - compatible: "mediatek,mt6323-regulator" diff --git a/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml new file mode 100644 index 000000000000..bb48c0150f95 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml @@ -0,0 +1,40 @@ + # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/mediatek,mt6397-rtc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek MT6397/MT6366/MT6358/MT6357/MT6323 RTC + +maintainers: + - Alexandre Mergnat <amergnat@baylibre.com> + +description: | + MediaTek PMIC based RTC is an independent function of MediaTek PMIC that works + as a type of multi-function device (MFD). The RTC can be configured and set up + with PMIC wrapper bus which is a common resource shared with the other + functions found on the same PMIC. + +properties: + compatible: + enum: + - mediatek,mt6323-rtc + - mediatek,mt6357-rtc + - mediatek,mt6358-rtc + - mediatek,mt6366-rtc + - mediatek,mt6397-rtc + +additionalProperties: false + +required: + - compatible + +examples: + - | + pmic { + compatible = "mediatek,mt6397"; + + rtc { + compatible = "mediatek,mt6397-rtc"; + }; + }; diff --git a/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt b/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt deleted file mode 100644 index 7212076a8f1b..000000000000 --- a/Documentation/devicetree/bindings/rtc/rtc-mt6397.txt +++ /dev/null @@ -1,31 +0,0 @@ -Device-Tree bindings for MediaTek PMIC based RTC - -MediaTek PMIC based RTC is an independent function of MediaTek PMIC that works -as a type of multi-function device (MFD). The RTC can be configured and set up -with PMIC wrapper bus which is a common resource shared with the other -functions found on the same PMIC. - -For MediaTek PMIC MFD bindings, see: -../mfd/mt6397.txt - -For MediaTek PMIC wrapper bus bindings, see: -../soc/mediatek/pwrap.txt - -Required properties: -- compatible: Should be one of follows - "mediatek,mt6323-rtc": for MT6323 PMIC - "mediatek,mt6358-rtc": for MT6358 PMIC - "mediatek,mt6366-rtc", "mediatek,mt6358-rtc": for MT6366 PMIC - "mediatek,mt6397-rtc": for MT6397 PMIC - -Example: - - pmic { - compatible = "mediatek,mt6323"; - - ... - - rtc { - compatible = "mediatek,mt6323-rtc"; - }; - };