Message ID | 20230714114749.1743032-3-shikemeng@huaweicloud.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp2258961vqm; Thu, 13 Jul 2023 21:10:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlFbvUdM3qt0Ic7mmqRivKas9LK2oqtdDCdIUwEyZIUY5dtcXeTN9m44FeeRwJ2Ri1+octMI X-Received: by 2002:a17:90b:19c3:b0:256:807e:6bd with SMTP id nm3-20020a17090b19c300b00256807e06bdmr2631405pjb.28.1689307829404; Thu, 13 Jul 2023 21:10:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689307829; cv=none; d=google.com; s=arc-20160816; b=PzMMvrHlouKrQZxqhp0l8qwiPqJVt/XqwDpIhJ5b0qqZdYSbkhinQPKrrqbm9tiiE7 zpV03KfOqxpsnn7e+mQCJLXIDms2eZceVmtSRwvH8Zbh9yCge1P9i9CNlgrUC+nMvj69 gjkmvGa+R3lHHYoVnVKubqAX+O8ZYmEdLbsDHsbBhkZIGdvoD+dnAUajMJupIjQDXWpH 2bG0tfvpQ1p+/qKUD8a6Axx2QcHFNhAsLz/GK954GKNAJj3kOmVzsXeLGMMc8SIX/zbf iKnkUqnnf4gsROqo6lGSEvK2+1CudCZR5g0jFIg391ulF1hxkc4BkvxdevNr5/mRf5vK 0hmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=YIF/CILq6xB7k2rsfEIAFjPPlshvGr9SaJOMxy2kl1Q=; fh=Gzi1aFpH4bsuJxl33dRilzaRcjMW8JVkCVkQbG3Bsew=; b=IKBh0VewAi2UGTj9uZ0trFZ1JkycbvNvWv9WywLQUJQC88d7zyI+TE5OK9d4UlWZcr tln/NXqQOlimzpYnI2IGbRuOE+NVEU2+KbQp9/PabUzEaKQTbQuieFBaJTsGskAc0b2k VAg/CJpW6a+8DavEdoi3iGIn/hrnq3miBsOtWNkgp4Kxzy0WMu7/p13MWN80l14SCZtD p1qOClfVyKYbsq6NLkbZFIsWQk9hFe5nOnJPSp/wnpVuvRxpsbn/H7xegaU6P3cDHmzE 5JCyHeYvVe0Vxf4j4U3p5X7UHDTnoRtDAkSSU3VNjpBJL9dsu49DZjbf+hr9XJh6RS2r vnfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mh15-20020a17090b4acf00b00260f28b14e4si594343pjb.4.2023.07.13.21.10.15; Thu, 13 Jul 2023 21:10:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234886AbjGNDrP (ORCPT <rfc822;tebrre53rla2o@gmail.com> + 99 others); Thu, 13 Jul 2023 23:47:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234383AbjGNDrO (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 13 Jul 2023 23:47:14 -0400 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C8C226B5 for <linux-kernel@vger.kernel.org>; Thu, 13 Jul 2023 20:47:12 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4R2HV35Dmgz4f3swL for <linux-kernel@vger.kernel.org>; Fri, 14 Jul 2023 11:47:07 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgBnTbE8xbBk4HW0Nw--.17751S4; Fri, 14 Jul 2023 11:47:10 +0800 (CST) From: Kemeng Shi <shikemeng@huaweicloud.com> To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: shikemeng@huaweicloud.com Subject: [PATCH 2/3] mm/page_ext: remove rollback for untouched mem_section in online_page_ext Date: Fri, 14 Jul 2023 19:47:48 +0800 Message-Id: <20230714114749.1743032-3-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230714114749.1743032-1-shikemeng@huaweicloud.com> References: <20230714114749.1743032-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: gCh0CgBnTbE8xbBk4HW0Nw--.17751S4 X-Coremail-Antispam: 1UD129KBjvdXoWrKFy8uF45CrW8Wr48Xr18Xwb_yoWfXFb_Aa 1xXFn7Xw1jvFnIqFWjywn7XryDW398Cw4jgFn7Gw4YyFySqwsYka4DtwnxZr1kXr4ay34Y kwsrZF4qqry2qjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb6AFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUXwA2048vs2IY020Ec7CjxVAFwI0_JFI_Gr1l8cAvFVAK0II2c7xJM28C jxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI 8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E 87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64 kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm 72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYx C7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_ Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x 0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8 JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIx AIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7sRET5lUUUUUU= = X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, MAY_BE_FORGED,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771367646707393754 X-GMAIL-MSGID: 1771367646707393754 |
Series |
minor cleanups for page_ext
|
|
Commit Message
Kemeng Shi
July 14, 2023, 11:47 a.m. UTC
If init_section_page_ext failed, we only need rollback for mem_section
before failed mem_section. Make rollback end point to failed mem_section
to remove unnecessary rollback.
As pfn += PAGES_PER_SECTION will be executed even if init_section_page_ext
failed. So pfn points to mem_section after failed mem_section. Subtract
one mem_section from pfn to get failed mem_section.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
mm/page_ext.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Fri, 14 Jul 2023 19:47:48 +0800 Kemeng Shi <shikemeng@huaweicloud.com> wrote: > If init_section_page_ext failed, we only need rollback for mem_section > before failed mem_section. Make rollback end point to failed mem_section > to remove unnecessary rollback. > > As pfn += PAGES_PER_SECTION will be executed even if init_section_page_ext > failed. So pfn points to mem_section after failed mem_section. Subtract > one mem_section from pfn to get failed mem_section. > > ... > > --- a/mm/page_ext.c > +++ b/mm/page_ext.c > @@ -424,6 +424,7 @@ static int __meminit online_page_ext(unsigned long start_pfn, > return 0; > > /* rollback */ > + end = pfn - PAGES_PER_SECTION; > for (pfn = start; pfn < end; pfn += PAGES_PER_SECTION) > __free_page_ext(pfn); > This is a bugfix, yes? I guess init_section_page_ext() never fails for anyone...
on 7/15/2023 1:54 AM, Andrew Morton wrote: > On Fri, 14 Jul 2023 19:47:48 +0800 Kemeng Shi <shikemeng@huaweicloud.com> wrote: > >> If init_section_page_ext failed, we only need rollback for mem_section >> before failed mem_section. Make rollback end point to failed mem_section >> to remove unnecessary rollback. >> >> As pfn += PAGES_PER_SECTION will be executed even if init_section_page_ext >> failed. So pfn points to mem_section after failed mem_section. Subtract >> one mem_section from pfn to get failed mem_section. >> >> ... >> >> --- a/mm/page_ext.c >> +++ b/mm/page_ext.c >> @@ -424,6 +424,7 @@ static int __meminit online_page_ext(unsigned long start_pfn, >> return 0; >> >> /* rollback */ >> + end = pfn - PAGES_PER_SECTION; >> for (pfn = start; pfn < end; pfn += PAGES_PER_SECTION) >> __free_page_ext(pfn); >> > > This is a bugfix, yes? > > I guess init_section_page_ext() never fails for anyone... I marked this as cleanup because __free_page_ext can handle NULL page_ext from uninitialized mem_section. Then no real bug will be triggered even if init_section_page_ext failed.
diff --git a/mm/page_ext.c b/mm/page_ext.c index 096451df1c87..f052397dc70f 100644 --- a/mm/page_ext.c +++ b/mm/page_ext.c @@ -424,6 +424,7 @@ static int __meminit online_page_ext(unsigned long start_pfn, return 0; /* rollback */ + end = pfn - PAGES_PER_SECTION; for (pfn = start; pfn < end; pfn += PAGES_PER_SECTION) __free_page_ext(pfn);