[v8,2/2] dt-bindings: hpet: add loongson-2 hpet

Message ID 20221103065351.32603-2-zhuyinbo@loongson.cn
State New
Headers
Series [v8,1/2] clocksource: loongson2_hpet: add hpet driver support |

Commit Message

Yinbo Zhu Nov. 3, 2022, 6:53 a.m. UTC
  Add the Loongson-2 High Precision Event Timer (HPET) binding
with DT schema format using json-schema.

Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Change in v8:
                1. This patch need rely on clock patch, which patchwork  
		   link was "https://patchwork.kernel.org/project/linux-clk/list/?series=691497".
		2. Add all history change log information.
Change in v7:
		1. NO change, but other patch in this series of patches set
		   has changes.
Change in v6:
		1. NO change, but other patch in this series of patches set
		   has changes.
Change in v5:
		1. Replace string loongson2/Loongson2 with Loongson-2/loongson-2.
		2. Add the patch review information.
Change in v4: 
                1. Fixup the clock-names that replace apb-clk with apb.
                2. This patch need rely on clock patch, which patchwork  
                   link was "https://patchwork.kernel.org/project/linux-clk/list/?series=688892".
Change in v3:
		1. Update dts that base on common clock framework.
Change in v2:
		1. Drop the  "hpet0" label.
		2. Modify the hpet node name to timer.

 .../bindings/timer/loongson,ls2k-hpet.yaml    | 50 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
  

Comments

Yinbo Zhu Nov. 9, 2022, 9:19 a.m. UTC | #1
Hi maintainer,

please help me merge it to upstream.
in addition, this patch need rely on 
"https://patchwork.kernel.org/project/linux-clk/list/?series=691497"

thanks,
Yinbo.

在 2022/11/3 下午2:53, Yinbo Zhu 写道:
> Add the Loongson-2 High Precision Event Timer (HPET) binding
> with DT schema format using json-schema.
> 
> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Change in v8:
>                  1. This patch need rely on clock patch, which patchwork
> 		   link was "https://patchwork.kernel.org/project/linux-clk/list/?series=691497".
> 		2. Add all history change log information.
> Change in v7:
> 		1. NO change, but other patch in this series of patches set
> 		   has changes.
> Change in v6:
> 		1. NO change, but other patch in this series of patches set
> 		   has changes.
> Change in v5:
> 		1. Replace string loongson2/Loongson2 with Loongson-2/loongson-2.
> 		2. Add the patch review information.
> Change in v4:
>                  1. Fixup the clock-names that replace apb-clk with apb.
>                  2. This patch need rely on clock patch, which patchwork
>                     link was "https://patchwork.kernel.org/project/linux-clk/list/?series=688892".
> Change in v3:
> 		1. Update dts that base on common clock framework.
> Change in v2:
> 		1. Drop the  "hpet0" label.
> 		2. Modify the hpet node name to timer.
> 
>   .../bindings/timer/loongson,ls2k-hpet.yaml    | 50 +++++++++++++++++++
>   MAINTAINERS                                   |  1 +
>   2 files changed, 51 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
> 
> diff --git a/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml b/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
> new file mode 100644
> index 000000000000..30685c8fbead
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/timer/loongson,ls2k-hpet.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Loongson-2 High Precision Event Timer (HPET)
> +
> +maintainers:
> +  - Yinbo Zhu <zhuyinbo@loongson.cn>
> +
> +properties:
> +  compatible:
> +    const: loongson,ls2k-hpet
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: SoC apb clock
> +
> +  clock-names:
> +    items:
> +      - const: apb
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/loongson,ls2k-clk.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    timer@1fe24000 {
> +        compatible = "loongson,ls2k-hpet";
> +        reg = <0x1fe24000 0x15f>;
> +        clocks = <&clk LOONGSON2_APB_CLK>;
> +        clock-names = "apb";
> +        interrupt-parent = <&liointc0>;
> +        interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 52519695a458..939af260fe0f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12030,6 +12030,7 @@ LOONGSON-2 SOC SERIES HPET DRIVER
>   M:	Yinbo Zhu <zhuyinbo@loongson.cn>
>   L:	linux-kernel@vger.kernel.org
>   S:	Maintained
> +F:	Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
>   F:	drivers/clocksource/loongson2_hpet.c
>   
>   LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)
>
  
Krzysztof Kozlowski Nov. 9, 2022, 9:24 a.m. UTC | #2
On 09/11/2022 10:19, Yinbo Zhu wrote:
> Hi maintainer,
> 
> please help me merge it to upstream.
> in addition, this patch need rely on 
> "https://patchwork.kernel.org/project/linux-clk/list/?series=691497"

Why pinging for v8? Didn't you have v9 and v10?

Several of your Loongson patches had many build errors, pointed out by
lkp. Therefore I have doubts that you test these extensively. This might
be the reason why your patches float around...

Best regards,
Krzysztof
  
Yinbo Zhu Nov. 9, 2022, 9:38 a.m. UTC | #3
在 2022/11/9 下午5:24, Krzysztof Kozlowski 写道:
> On 09/11/2022 10:19, Yinbo Zhu wrote:
>> Hi maintainer,
>>
>> please help me merge it to upstream.
>> in addition, this patch need rely on
>> "https://patchwork.kernel.org/project/linux-clk/list/?series=691497"
> 
> Why pinging for v8? Didn't you have v9 and v10?
> 
> Several of your Loongson patches had many build errors, pointed out by
> lkp. Therefore I have doubts that you test these extensively. This might
> be the reason why your patches float around...
> 
> Best regards,
> Krzysztof
Yes, thanks your remind.
and I have a compile test and function test about hpet in mainline linux 
tree 6.1-rc3.
>
  
Yinbo Zhu Nov. 9, 2022, 9:41 a.m. UTC | #4
sorry, please ignore this ping in v8.

在 2022/11/9 下午5:38, Yinbo Zhu 写道:
> 
> 
> 在 2022/11/9 下午5:24, Krzysztof Kozlowski 写道:
>> On 09/11/2022 10:19, Yinbo Zhu wrote:
>>> Hi maintainer,
>>>
>>> please help me merge it to upstream.
>>> in addition, this patch need rely on
>>> "https://patchwork.kernel.org/project/linux-clk/list/?series=691497"
>>
>> Why pinging for v8? Didn't you have v9 and v10?
>>
>> Several of your Loongson patches had many build errors, pointed out by
>> lkp. Therefore I have doubts that you test these extensively. This might
>> be the reason why your patches float around...
>>
>> Best regards,
>> Krzysztof
> Yes, thanks your remind.
> and I have a compile test and function test about hpet in mainline linux 
> tree 6.1-rc3.
>>
  

Patch

diff --git a/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml b/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
new file mode 100644
index 000000000000..30685c8fbead
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
@@ -0,0 +1,50 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/timer/loongson,ls2k-hpet.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Loongson-2 High Precision Event Timer (HPET)
+
+maintainers:
+  - Yinbo Zhu <zhuyinbo@loongson.cn>
+
+properties:
+  compatible:
+    const: loongson,ls2k-hpet
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: SoC apb clock
+
+  clock-names:
+    items:
+      - const: apb
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/loongson,ls2k-clk.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    timer@1fe24000 {
+        compatible = "loongson,ls2k-hpet";
+        reg = <0x1fe24000 0x15f>;
+        clocks = <&clk LOONGSON2_APB_CLK>;
+        clock-names = "apb";
+        interrupt-parent = <&liointc0>;
+        interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index 52519695a458..939af260fe0f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12030,6 +12030,7 @@  LOONGSON-2 SOC SERIES HPET DRIVER
 M:	Yinbo Zhu <zhuyinbo@loongson.cn>
 L:	linux-kernel@vger.kernel.org
 S:	Maintained
+F:	Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
 F:	drivers/clocksource/loongson2_hpet.c
 
 LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)