| Message ID | 20230713135440.3651409-3-ryan.roberts@arm.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1856893vqm;
Thu, 13 Jul 2023 07:17:41 -0700 (PDT)
X-Google-Smtp-Source:
APBJJlGnLwDM2Sqm7VmOTLWGTcdRY7jFQbl7/9AbJcA1iNAg4D9dxbrEB8D5VHXMAkxiugufRF5i
X-Received: by 2002:a92:d44b:0:b0:345:3378:4258 with SMTP id
r11-20020a92d44b000000b0034533784258mr1352274ilm.30.1689257861501;
Thu, 13 Jul 2023 07:17:41 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1689257861; cv=none;
d=google.com; s=arc-20160816;
b=yG9TkpBhLaHR/z3+37NM3AxwY1XPZM3LYsuCIdb7wBzY/iNgYzXaHWuTHMu69wbSFj
D4GzTa3Wn7pLaN/DF79i7DzmCpByyaa5MfchBhjV0zphzjkKtgSAFTQCdXC7Vn3hSu8K
D0n1vugEKQAiN6MZFLTCfQeonQ3OdD47eooVjA+AvaZuQcBu0UBh+CDtwwN6x3D6/Wmf
ZDRDWxNjI7IAwnfTqjpqY3uVeXc6UoeHFf/sn8pxE5RZvt5MSM0J/SSxpd+9DcHYtI3z
gwLJOHw6mwtXmUuwWyVjmPVv4e+hqGiPpDDPNGBJRiC/mjEwoxuKU1mxEzw0dbSdEQIR
YG9g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=yIADLCW8ozAl6AFw8ZxNQyL6kxz5rjSce+zRJErHvIk=;
fh=PBHZcfMfFxGGBVmDESRU6Gjyj3qxzeiTc8DMNv9diCw=;
b=J3Tl45k/k5hjrDb8YGlUCa97XYg4E9+qXZyjGmifuFSZjdlzwYEqcHlVT+1qCxJGgq
7qc9ZogXtJGb7XaDYaFtqXknWUmdBz9sBRtF7VajXUssFb95rBWq79kSPElYoEWaE9qV
Iyq/vN9k+GKSTv1q/PdjOYiMyevVCTC2fbutUs2YLSXQyqLHlIRF2NssF5EeByYIpX6A
gkoJe68U3UYuxxdfSPjrE9GBmcKSTy5b8G9LQdRsswqAueFJaKiYyh1loNVXr7WZrKuV
+b2Rj918vbVc+qT7NxDnq+wHkORs2Y7FFSrpKPkMd61HZRHlvC7wKlvnY6Z9gCdeLooI
OjAQ==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
i17-20020a17090ad35100b0024e3527e8e9si12991465pjx.9.2023.07.13.07.17.26;
Thu, 13 Jul 2023 07:17:41 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231818AbjGMNzC (ORCPT <rfc822;ybw1215001957@gmail.com>
+ 99 others); Thu, 13 Jul 2023 09:55:02 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49204 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231182AbjGMNyz (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 13 Jul 2023 09:54:55 -0400
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2DFBD1992;
Thu, 13 Jul 2023 06:54:54 -0700 (PDT)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 75C6C1595;
Thu, 13 Jul 2023 06:55:36 -0700 (PDT)
Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com
[10.1.196.26])
by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id
6BABF3F73F;
Thu, 13 Jul 2023 06:54:52 -0700 (PDT)
From: Ryan Roberts <ryan.roberts@arm.com>
To: Andrew Morton <akpm@linux-foundation.org>, Shuah Khan <shuah@kernel.org>,
=?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
David Hildenbrand <david@redhat.com>, Mark Brown <broonie@kernel.org>,
John Hubbard <jhubbard@nvidia.com>, Florent Revest <revest@chromium.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Subject: [PATCH v1 2/9] selftests/mm: Give scripts execute permission
Date: Thu, 13 Jul 2023 14:54:33 +0100
Message-Id: <20230713135440.3651409-3-ryan.roberts@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20230713135440.3651409-1-ryan.roberts@arm.com>
References: <20230713135440.3651409-1-ryan.roberts@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,
RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1771315251178500947
X-GMAIL-MSGID: 1771315251178500947
|
| Series |
selftests/mm fixes for arm64
|
|
Commit Message
Ryan Roberts
July 13, 2023, 1:54 p.m. UTC
When run under run_vmtests.sh, test scripts were failing to run with
"permission denied" due to the scripts not being executable.
It is also annoying not to be able to directly invoke run_vmtests.sh,
which is solved by giving also it the execute permission.
Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
---
tools/testing/selftests/mm/charge_reserved_hugetlb.sh | 0
tools/testing/selftests/mm/check_config.sh | 0
tools/testing/selftests/mm/hugetlb_reparenting_test.sh | 0
tools/testing/selftests/mm/run_vmtests.sh | 0
tools/testing/selftests/mm/test_hmm.sh | 0
tools/testing/selftests/mm/test_vmalloc.sh | 0
tools/testing/selftests/mm/va_high_addr_switch.sh | 0
tools/testing/selftests/mm/write_hugetlb_memory.sh | 0
8 files changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 tools/testing/selftests/mm/charge_reserved_hugetlb.sh
mode change 100644 => 100755 tools/testing/selftests/mm/check_config.sh
mode change 100644 => 100755 tools/testing/selftests/mm/hugetlb_reparenting_test.sh
mode change 100644 => 100755 tools/testing/selftests/mm/run_vmtests.sh
mode change 100644 => 100755 tools/testing/selftests/mm/test_hmm.sh
mode change 100644 => 100755 tools/testing/selftests/mm/test_vmalloc.sh
mode change 100644 => 100755 tools/testing/selftests/mm/va_high_addr_switch.sh
mode change 100644 => 100755 tools/testing/selftests/mm/write_hugetlb_memory.sh
Comments
On 13.07.23 15:54, Ryan Roberts wrote: > When run under run_vmtests.sh, test scripts were failing to run with > "permission denied" due to the scripts not being executable. > > It is also annoying not to be able to directly invoke run_vmtests.sh, > which is solved by giving also it the execute permission. > > Signed-off-by: Ryan Roberts <ryan.roberts@arm.com> > --- > tools/testing/selftests/mm/charge_reserved_hugetlb.sh | 0 > tools/testing/selftests/mm/check_config.sh | 0 > tools/testing/selftests/mm/hugetlb_reparenting_test.sh | 0 > tools/testing/selftests/mm/run_vmtests.sh | 0 > tools/testing/selftests/mm/test_hmm.sh | 0 > tools/testing/selftests/mm/test_vmalloc.sh | 0 > tools/testing/selftests/mm/va_high_addr_switch.sh | 0 > tools/testing/selftests/mm/write_hugetlb_memory.sh | 0 > 8 files changed, 0 insertions(+), 0 deletions(-) > mode change 100644 => 100755 tools/testing/selftests/mm/charge_reserved_hugetlb.sh > mode change 100644 => 100755 tools/testing/selftests/mm/check_config.sh > mode change 100644 => 100755 tools/testing/selftests/mm/hugetlb_reparenting_test.sh > mode change 100644 => 100755 tools/testing/selftests/mm/run_vmtests.sh > mode change 100644 => 100755 tools/testing/selftests/mm/test_hmm.sh > mode change 100644 => 100755 tools/testing/selftests/mm/test_vmalloc.sh > mode change 100644 => 100755 tools/testing/selftests/mm/va_high_addr_switch.sh > mode change 100644 => 100755 tools/testing/selftests/mm/write_hugetlb_memory.sh > > diff --git a/tools/testing/selftests/mm/charge_reserved_hugetlb.sh b/tools/testing/selftests/mm/charge_reserved_hugetlb.sh > old mode 100644 > new mode 100755 > diff --git a/tools/testing/selftests/mm/check_config.sh b/tools/testing/selftests/mm/check_config.sh > old mode 100644 > new mode 100755 > diff --git a/tools/testing/selftests/mm/hugetlb_reparenting_test.sh b/tools/testing/selftests/mm/hugetlb_reparenting_test.sh > old mode 100644 > new mode 100755 > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > old mode 100644 > new mode 100755 > diff --git a/tools/testing/selftests/mm/test_hmm.sh b/tools/testing/selftests/mm/test_hmm.sh > old mode 100644 > new mode 100755 > diff --git a/tools/testing/selftests/mm/test_vmalloc.sh b/tools/testing/selftests/mm/test_vmalloc.sh > old mode 100644 > new mode 100755 > diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh > old mode 100644 > new mode 100755 > diff --git a/tools/testing/selftests/mm/write_hugetlb_memory.sh b/tools/testing/selftests/mm/write_hugetlb_memory.sh > old mode 100644 > new mode 100755 Sounds reasonable to me. Probably due to: commit baa489fabd01596d5426d6e112b34ba5fb59ab82 Author: SeongJae Park <sj@kernel.org> Date: Tue Jan 3 18:07:53 2023 +0000 selftests/vm: rename selftests/vm to selftests/mm Rename selftets/vm to selftests/mm for being more consistent with the code, documentation, and tools directories, and won't be confused with virtual machines. and indeed, it contains diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh old mode 100755 new mode 100644 similarity index 100% rename from tools/testing/selftests/vm/run_vmtests.sh rename to tools/testing/selftests/mm/run_vmtests.sh Reviewed-by: David Hildenbrand <david@redhat.com>
On Thu, 13 Jul 2023 16:39:33 +0200 David Hildenbrand <david@redhat.com> wrote: > On 13.07.23 15:54, Ryan Roberts wrote: > > When run under run_vmtests.sh, test scripts were failing to run with > > "permission denied" due to the scripts not being executable. > > > > It is also annoying not to be able to directly invoke run_vmtests.sh, > > which is solved by giving also it the execute permission. > > > > Signed-off-by: Ryan Roberts <ryan.roberts@arm.com> > > --- > > tools/testing/selftests/mm/charge_reserved_hugetlb.sh | 0 > > tools/testing/selftests/mm/check_config.sh | 0 > > tools/testing/selftests/mm/hugetlb_reparenting_test.sh | 0 > > tools/testing/selftests/mm/run_vmtests.sh | 0 > > tools/testing/selftests/mm/test_hmm.sh | 0 > > tools/testing/selftests/mm/test_vmalloc.sh | 0 > > tools/testing/selftests/mm/va_high_addr_switch.sh | 0 > > tools/testing/selftests/mm/write_hugetlb_memory.sh | 0 > > 8 files changed, 0 insertions(+), 0 deletions(-) > > mode change 100644 => 100755 tools/testing/selftests/mm/charge_reserved_hugetlb.sh > > mode change 100644 => 100755 tools/testing/selftests/mm/check_config.sh > > mode change 100644 => 100755 tools/testing/selftests/mm/hugetlb_reparenting_test.sh > > mode change 100644 => 100755 tools/testing/selftests/mm/run_vmtests.sh > > mode change 100644 => 100755 tools/testing/selftests/mm/test_hmm.sh > > mode change 100644 => 100755 tools/testing/selftests/mm/test_vmalloc.sh > > mode change 100644 => 100755 tools/testing/selftests/mm/va_high_addr_switch.sh > > mode change 100644 => 100755 tools/testing/selftests/mm/write_hugetlb_memory.sh > > > > diff --git a/tools/testing/selftests/mm/charge_reserved_hugetlb.sh b/tools/testing/selftests/mm/charge_reserved_hugetlb.sh > > old mode 100644 > > new mode 100755 > > diff --git a/tools/testing/selftests/mm/check_config.sh b/tools/testing/selftests/mm/check_config.sh > > old mode 100644 > > new mode 100755 > > diff --git a/tools/testing/selftests/mm/hugetlb_reparenting_test.sh b/tools/testing/selftests/mm/hugetlb_reparenting_test.sh > > old mode 100644 > > new mode 100755 > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > > old mode 100644 > > new mode 100755 > > diff --git a/tools/testing/selftests/mm/test_hmm.sh b/tools/testing/selftests/mm/test_hmm.sh > > old mode 100644 > > new mode 100755 > > diff --git a/tools/testing/selftests/mm/test_vmalloc.sh b/tools/testing/selftests/mm/test_vmalloc.sh > > old mode 100644 > > new mode 100755 > > diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh > > old mode 100644 > > new mode 100755 > > diff --git a/tools/testing/selftests/mm/write_hugetlb_memory.sh b/tools/testing/selftests/mm/write_hugetlb_memory.sh > > old mode 100644 > > new mode 100755 > > Sounds reasonable to me. > > Probably due to: > > commit baa489fabd01596d5426d6e112b34ba5fb59ab82 > Author: SeongJae Park <sj@kernel.org> > Date: Tue Jan 3 18:07:53 2023 +0000 > > selftests/vm: rename selftests/vm to selftests/mm > > Rename selftets/vm to selftests/mm for being more consistent with the > code, documentation, and tools directories, and won't be confused with > virtual machines. > > > and indeed, it contains > > diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > old mode 100755 > new mode 100644 > similarity index 100% > rename from tools/testing/selftests/vm/run_vmtests.sh > rename to tools/testing/selftests/mm/run_vmtests.sh Thank you for tracking this and kindly Cc-ing me! I'd like to clarify a little bit more, though. The permission change has made by the commit as you found. Nevertheless, the submitted version[1] of the patch didn't change the permission. I guess the change was made while managing it via some file permission unsupported patches management tool. I had a similar issue with DAMON selftest and sent a patch restoring the permission. Greg suggested me to update the framework instead, to support such management tool[2], so I made it[3]. It recently also merged into 5.15.y for DAMON selftests[4]. I have no strong opinion about whether we need to keep the permission or it's good to have no execute permission since kselftest framework supports it. I just wanted to clarify the events I've shown. Please correct me if I missed or wrong something. Cc-ing Greg, since he might have an opinion. [1] https://lore.kernel.org/all/20230103180754.129637-5-sj@kernel.org/ [2] https://lore.kernel.org/mm-commits/YRJisBs9AunccCD4@kroah.com/ [3] https://lore.kernel.org/all/20210810164534.25902-1-sj38.park@gmail.com/ [4] https://lore.kernel.org/stable/2023042743-cheesy-parasitic-206d@gregkh/ Thanks, SJ > > > Reviewed-by: David Hildenbrand <david@redhat.com> > > -- > Cheers, > > David / dhildenb > > >
On 13/07/2023 18:32, SeongJae Park wrote: > On Thu, 13 Jul 2023 16:39:33 +0200 David Hildenbrand <david@redhat.com> wrote: > >> On 13.07.23 15:54, Ryan Roberts wrote: >>> When run under run_vmtests.sh, test scripts were failing to run with >>> "permission denied" due to the scripts not being executable. >>> >>> It is also annoying not to be able to directly invoke run_vmtests.sh, >>> which is solved by giving also it the execute permission. >>> >>> Signed-off-by: Ryan Roberts <ryan.roberts@arm.com> >>> --- >>> tools/testing/selftests/mm/charge_reserved_hugetlb.sh | 0 >>> tools/testing/selftests/mm/check_config.sh | 0 >>> tools/testing/selftests/mm/hugetlb_reparenting_test.sh | 0 >>> tools/testing/selftests/mm/run_vmtests.sh | 0 >>> tools/testing/selftests/mm/test_hmm.sh | 0 >>> tools/testing/selftests/mm/test_vmalloc.sh | 0 >>> tools/testing/selftests/mm/va_high_addr_switch.sh | 0 >>> tools/testing/selftests/mm/write_hugetlb_memory.sh | 0 >>> 8 files changed, 0 insertions(+), 0 deletions(-) >>> mode change 100644 => 100755 tools/testing/selftests/mm/charge_reserved_hugetlb.sh >>> mode change 100644 => 100755 tools/testing/selftests/mm/check_config.sh >>> mode change 100644 => 100755 tools/testing/selftests/mm/hugetlb_reparenting_test.sh >>> mode change 100644 => 100755 tools/testing/selftests/mm/run_vmtests.sh >>> mode change 100644 => 100755 tools/testing/selftests/mm/test_hmm.sh >>> mode change 100644 => 100755 tools/testing/selftests/mm/test_vmalloc.sh >>> mode change 100644 => 100755 tools/testing/selftests/mm/va_high_addr_switch.sh >>> mode change 100644 => 100755 tools/testing/selftests/mm/write_hugetlb_memory.sh >>> >>> diff --git a/tools/testing/selftests/mm/charge_reserved_hugetlb.sh b/tools/testing/selftests/mm/charge_reserved_hugetlb.sh >>> old mode 100644 >>> new mode 100755 >>> diff --git a/tools/testing/selftests/mm/check_config.sh b/tools/testing/selftests/mm/check_config.sh >>> old mode 100644 >>> new mode 100755 >>> diff --git a/tools/testing/selftests/mm/hugetlb_reparenting_test.sh b/tools/testing/selftests/mm/hugetlb_reparenting_test.sh >>> old mode 100644 >>> new mode 100755 >>> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh >>> old mode 100644 >>> new mode 100755 >>> diff --git a/tools/testing/selftests/mm/test_hmm.sh b/tools/testing/selftests/mm/test_hmm.sh >>> old mode 100644 >>> new mode 100755 >>> diff --git a/tools/testing/selftests/mm/test_vmalloc.sh b/tools/testing/selftests/mm/test_vmalloc.sh >>> old mode 100644 >>> new mode 100755 >>> diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh >>> old mode 100644 >>> new mode 100755 >>> diff --git a/tools/testing/selftests/mm/write_hugetlb_memory.sh b/tools/testing/selftests/mm/write_hugetlb_memory.sh >>> old mode 100644 >>> new mode 100755 >> >> Sounds reasonable to me. >> >> Probably due to: >> >> commit baa489fabd01596d5426d6e112b34ba5fb59ab82 >> Author: SeongJae Park <sj@kernel.org> >> Date: Tue Jan 3 18:07:53 2023 +0000 >> >> selftests/vm: rename selftests/vm to selftests/mm >> >> Rename selftets/vm to selftests/mm for being more consistent with the >> code, documentation, and tools directories, and won't be confused with >> virtual machines. >> >> >> and indeed, it contains >> >> diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh >> old mode 100755 >> new mode 100644 >> similarity index 100% >> rename from tools/testing/selftests/vm/run_vmtests.sh >> rename to tools/testing/selftests/mm/run_vmtests.sh > > Thank you for tracking this and kindly Cc-ing me! I'd like to clarify a little > bit more, though. The permission change has made by the commit as you found. > Nevertheless, the submitted version[1] of the patch didn't change the > permission. I guess the change was made while managing it via some file > permission unsupported patches management tool. > > I had a similar issue with DAMON selftest and sent a patch restoring the > permission. Greg suggested me to update the framework instead, to support such > management tool[2], so I made it[3]. It recently also merged into 5.15.y for > DAMON selftests[4]. > > I have no strong opinion about whether we need to keep the permission or it's > good to have no execute permission since kselftest framework supports it. I > just wanted to clarify the events I've shown. Please correct me if I missed or > wrong something. Cc-ing Greg, since he might have an opinion. Thanks for the detailed explanation. Are you effectively saying this patch will turn into a no-op once its been munged through the various patch management tools? That's disappointing because it's a pain to have to invoke everything though bash explicitly. Many other scripts manage to have the correct execute permission set (see everything in ./scripts for example). Personally I'd rather keep this patch and try rather than proactively do a work around. > > [1] https://lore.kernel.org/all/20230103180754.129637-5-sj@kernel.org/ > [2] https://lore.kernel.org/mm-commits/YRJisBs9AunccCD4@kroah.com/ > [3] https://lore.kernel.org/all/20210810164534.25902-1-sj38.park@gmail.com/ > [4] https://lore.kernel.org/stable/2023042743-cheesy-parasitic-206d@gregkh/ > > > Thanks, > SJ > >> >> >> Reviewed-by: David Hildenbrand <david@redhat.com> >> >> -- >> Cheers, >> >> David / dhildenb >> >> >>
On Fri, 14 Jul 2023 10:44:14 +0100 Ryan Roberts <ryan.roberts@arm.com> wrote: > On 13/07/2023 18:32, SeongJae Park wrote: > > On Thu, 13 Jul 2023 16:39:33 +0200 David Hildenbrand <david@redhat.com> wrote: > > > >> On 13.07.23 15:54, Ryan Roberts wrote: > >>> When run under run_vmtests.sh, test scripts were failing to run with > >>> "permission denied" due to the scripts not being executable. > >>> > >>> It is also annoying not to be able to directly invoke run_vmtests.sh, > >>> which is solved by giving also it the execute permission. > >>> > >>> Signed-off-by: Ryan Roberts <ryan.roberts@arm.com> > >>> --- > >>> tools/testing/selftests/mm/charge_reserved_hugetlb.sh | 0 > >>> tools/testing/selftests/mm/check_config.sh | 0 > >>> tools/testing/selftests/mm/hugetlb_reparenting_test.sh | 0 > >>> tools/testing/selftests/mm/run_vmtests.sh | 0 > >>> tools/testing/selftests/mm/test_hmm.sh | 0 > >>> tools/testing/selftests/mm/test_vmalloc.sh | 0 > >>> tools/testing/selftests/mm/va_high_addr_switch.sh | 0 > >>> tools/testing/selftests/mm/write_hugetlb_memory.sh | 0 > >>> 8 files changed, 0 insertions(+), 0 deletions(-) > >>> mode change 100644 => 100755 tools/testing/selftests/mm/charge_reserved_hugetlb.sh > >>> mode change 100644 => 100755 tools/testing/selftests/mm/check_config.sh > >>> mode change 100644 => 100755 tools/testing/selftests/mm/hugetlb_reparenting_test.sh > >>> mode change 100644 => 100755 tools/testing/selftests/mm/run_vmtests.sh > >>> mode change 100644 => 100755 tools/testing/selftests/mm/test_hmm.sh > >>> mode change 100644 => 100755 tools/testing/selftests/mm/test_vmalloc.sh > >>> mode change 100644 => 100755 tools/testing/selftests/mm/va_high_addr_switch.sh > >>> mode change 100644 => 100755 tools/testing/selftests/mm/write_hugetlb_memory.sh > >>> > >>> diff --git a/tools/testing/selftests/mm/charge_reserved_hugetlb.sh b/tools/testing/selftests/mm/charge_reserved_hugetlb.sh > >>> old mode 100644 > >>> new mode 100755 > >>> diff --git a/tools/testing/selftests/mm/check_config.sh b/tools/testing/selftests/mm/check_config.sh > >>> old mode 100644 > >>> new mode 100755 > >>> diff --git a/tools/testing/selftests/mm/hugetlb_reparenting_test.sh b/tools/testing/selftests/mm/hugetlb_reparenting_test.sh > >>> old mode 100644 > >>> new mode 100755 > >>> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > >>> old mode 100644 > >>> new mode 100755 > >>> diff --git a/tools/testing/selftests/mm/test_hmm.sh b/tools/testing/selftests/mm/test_hmm.sh > >>> old mode 100644 > >>> new mode 100755 > >>> diff --git a/tools/testing/selftests/mm/test_vmalloc.sh b/tools/testing/selftests/mm/test_vmalloc.sh > >>> old mode 100644 > >>> new mode 100755 > >>> diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh > >>> old mode 100644 > >>> new mode 100755 > >>> diff --git a/tools/testing/selftests/mm/write_hugetlb_memory.sh b/tools/testing/selftests/mm/write_hugetlb_memory.sh > >>> old mode 100644 > >>> new mode 100755 > >> > >> Sounds reasonable to me. > >> > >> Probably due to: > >> > >> commit baa489fabd01596d5426d6e112b34ba5fb59ab82 > >> Author: SeongJae Park <sj@kernel.org> > >> Date: Tue Jan 3 18:07:53 2023 +0000 > >> > >> selftests/vm: rename selftests/vm to selftests/mm > >> > >> Rename selftets/vm to selftests/mm for being more consistent with the > >> code, documentation, and tools directories, and won't be confused with > >> virtual machines. > >> > >> > >> and indeed, it contains > >> > >> diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > >> old mode 100755 > >> new mode 100644 > >> similarity index 100% > >> rename from tools/testing/selftests/vm/run_vmtests.sh > >> rename to tools/testing/selftests/mm/run_vmtests.sh > > > > Thank you for tracking this and kindly Cc-ing me! I'd like to clarify a little > > bit more, though. The permission change has made by the commit as you found. > > Nevertheless, the submitted version[1] of the patch didn't change the > > permission. I guess the change was made while managing it via some file > > permission unsupported patches management tool. > > > > I had a similar issue with DAMON selftest and sent a patch restoring the > > permission. Greg suggested me to update the framework instead, to support such > > management tool[2], so I made it[3]. It recently also merged into 5.15.y for > > DAMON selftests[4]. > > > > I have no strong opinion about whether we need to keep the permission or it's > > good to have no execute permission since kselftest framework supports it. I > > just wanted to clarify the events I've shown. Please correct me if I missed or > > wrong something. Cc-ing Greg, since he might have an opinion. > > Thanks for the detailed explanation. Are you effectively saying this patch will > turn into a no-op once its been munged through the various patch management > tools? Depending on what tool maintainers that will pick this patch is using in what way, I guess. > That's disappointing because it's a pain to have to invoke everything > though bash explicitly. Many other scripts manage to have the correct execute > permission set (see everything in ./scripts for example). > > Personally I'd rather keep this patch and try rather than proactively do a work > around. I don't have a strong opinion here, as mentioned before. That said, I feel it would be good to have a clear agreement or explanation about that, since I got similar situation before[1]. [1] https://lore.kernel.org/damon/20230221175612.131555-1-sj@kernel.org/ Thanks, SJ > > > > > > [1] https://lore.kernel.org/all/20230103180754.129637-5-sj@kernel.org/ > > [2] https://lore.kernel.org/mm-commits/YRJisBs9AunccCD4@kroah.com/ > > [3] https://lore.kernel.org/all/20210810164534.25902-1-sj38.park@gmail.com/ > > [4] https://lore.kernel.org/stable/2023042743-cheesy-parasitic-206d@gregkh/ > > > > > > Thanks, > > SJ > > > >> > >> > >> Reviewed-by: David Hildenbrand <david@redhat.com> > >> > >> -- > >> Cheers, > >> > >> David / dhildenb > >> > >> > >> > >
On Fri, Jul 14, 2023 at 04:00:58PM +0000, SeongJae Park wrote: > On Fri, 14 Jul 2023 10:44:14 +0100 Ryan Roberts <ryan.roberts@arm.com> wrote: > > Personally I'd rather keep this patch and try rather than proactively do a work > > around. > I don't have a strong opinion here, as mentioned before. That said, I feel it > would be good to have a clear agreement or explanation about that, since I got > similar situation before[1]. I think just from a usability point of view we want to end up with things people are expected to execute actually executable.
On Fri, 14 Jul 2023 10:44:14 +0100 Ryan Roberts <ryan.roberts@arm.com> wrote: > Thanks for the detailed explanation. Are you effectively saying this patch will > turn into a no-op once its been munged through the various patch management > tools? That's disappointing because it's a pain to have to invoke everything > though bash explicitly. Many other scripts manage to have the correct execute > permission set (see everything in ./scripts for example). Such patches need delicate handling :( I queued this as a standalone thing, for 6.5-rcx.
On 14/07/2023 17:26, Andrew Morton wrote: > On Fri, 14 Jul 2023 10:44:14 +0100 Ryan Roberts <ryan.roberts@arm.com> wrote: > >> Thanks for the detailed explanation. Are you effectively saying this patch will >> turn into a no-op once its been munged through the various patch management >> tools? That's disappointing because it's a pain to have to invoke everything >> though bash explicitly. Many other scripts manage to have the correct execute >> permission set (see everything in ./scripts for example). > > Such patches need delicate handling :( > > I queued this as a standalone thing, for 6.5-rcx. That's great - thanks Andrew! Do I'll drop this patch for my v2 of the series (hopefully Monday).
diff --git a/tools/testing/selftests/mm/charge_reserved_hugetlb.sh b/tools/testing/selftests/mm/charge_reserved_hugetlb.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/mm/check_config.sh b/tools/testing/selftests/mm/check_config.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/mm/hugetlb_reparenting_test.sh b/tools/testing/selftests/mm/hugetlb_reparenting_test.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/mm/test_hmm.sh b/tools/testing/selftests/mm/test_hmm.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/mm/test_vmalloc.sh b/tools/testing/selftests/mm/test_vmalloc.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh old mode 100644 new mode 100755 diff --git a/tools/testing/selftests/mm/write_hugetlb_memory.sh b/tools/testing/selftests/mm/write_hugetlb_memory.sh old mode 100644 new mode 100755