diff mbox series

[v1,4/9] selftests/mm: Enable mrelease_test for arm64

Message ID	20230713135440.3651409-5-ryan.roberts@arm.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Ryan Roberts <ryan.roberts@arm.com> To: Andrew Morton <akpm@linux-foundation.org>, Shuah Khan <shuah@kernel.org>, =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>, David Hildenbrand <david@redhat.com>, Mark Brown <broonie@kernel.org>, John Hubbard <jhubbard@nvidia.com>, Florent Revest <revest@chromium.org>, "Liam R. Howlett" <Liam.Howlett@oracle.com> Cc: Ryan Roberts <ryan.roberts@arm.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: [PATCH v1 4/9] selftests/mm: Enable mrelease_test for arm64 Date: Thu, 13 Jul 2023 14:54:35 +0100 Message-Id: <20230713135440.3651409-5-ryan.roberts@arm.com> In-Reply-To: <20230713135440.3651409-1-ryan.roberts@arm.com> References: <20230713135440.3651409-1-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	selftests/mm fixes for arm64 \| [v1,0/9] selftests/mm fixes for arm64 [v1,1/9] selftests: Line buffer test program's stdout [v1,2/9] selftests/mm: Give scripts execute permission [v1,3/9] selftests/mm: Skip soft-dirty tests on arm64 [v1,4/9] selftests/mm: Enable mrelease_test for arm64 [v1,5/9] selftests/mm: Fix thuge-gen test bugs [v1,6/9] selftests/mm: va_high_addr_switch should skip unsupported arm64 configs [v1,7/9] selftests/mm: Make migration test robust to failure [v1,8/9] selftests/mm: Optionally pass duration to transhuge-stress [v1,9/9] selftests/mm: Run all tests from run_vmtests.sh

Commit Message

Ryan Roberts July 13, 2023, 1:54 p.m. UTC

  mrelease_test defaults to defining __NR_pidfd_open and
__NR_process_mrelease syscall numbers to -1, if they are not defined
anywhere else, and the suite would then be marked as skipped as a
result.

arm64 (at least the stock debian toolchain that I'm using) requires
including <sys/syscall.h> to pull in the defines for these syscalls. So
let's add this header. With this in place, the test is passing on arm64.

Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
---
 tools/testing/selftests/mm/mrelease_test.c | 1 +
 1 file changed, 1 insertion(+)

Comments

David Hildenbrand July 13, 2023, 2:32 p.m. UTC | #1

On 13.07.23 15:54, Ryan Roberts wrote:
> mrelease_test defaults to defining __NR_pidfd_open and
> __NR_process_mrelease syscall numbers to -1, if they are not defined
> anywhere else, and the suite would then be marked as skipped as a
> result.
> 
> arm64 (at least the stock debian toolchain that I'm using) requires
> including <sys/syscall.h> to pull in the defines for these syscalls. So
> let's add this header. With this in place, the test is passing on arm64.
> 
> Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
> ---
>   tools/testing/selftests/mm/mrelease_test.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/mm/mrelease_test.c b/tools/testing/selftests/mm/mrelease_test.c
> index dca21042b679..d822004a374e 100644
> --- a/tools/testing/selftests/mm/mrelease_test.c
> +++ b/tools/testing/selftests/mm/mrelease_test.c
> @@ -7,6 +7,7 @@
>   #include <stdbool.h>
>   #include <stdio.h>
>   #include <stdlib.h>
> +#include <sys/syscall.h>
>   #include <sys/wait.h>
>   #include <unistd.h>
>   #include <asm-generic/unistd.h>

Reviewed-by: David Hildenbrand <david@redhat.com>

diff mbox series

Patch

diff --git a/tools/testing/selftests/mm/mrelease_test.c b/tools/testing/selftests/mm/mrelease_test.c
index dca21042b679..d822004a374e 100644
--- a/tools/testing/selftests/mm/mrelease_test.c
+++ b/tools/testing/selftests/mm/mrelease_test.c
@@ -7,6 +7,7 @@ 
 #include <stdbool.h>
 #include <stdio.h>
 #include <stdlib.h>
+#include <sys/syscall.h>
 #include <sys/wait.h>
 #include <unistd.h>
 #include <asm-generic/unistd.h>