[1/3] mmc: mxcmmc: Use devm_platform_get_and_ioremap_resource()

Message ID 20230704131939.22562-1-frank.li@vivo.com
State New
Headers
Series [1/3] mmc: mxcmmc: Use devm_platform_get_and_ioremap_resource() |

Commit Message

李扬韬 July 4, 2023, 1:19 p.m. UTC
  Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/mmc/host/mxcmmc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
  

Comments

Ulf Hansson July 13, 2023, 11:06 a.m. UTC | #1
On Tue, 4 Jul 2023 at 15:19, Yangtao Li <frank.li@vivo.com> wrote:
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/mxcmmc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c
> index 668f865f3efb..f3a72569dd1a 100644
> --- a/drivers/mmc/host/mxcmmc.c
> +++ b/drivers/mmc/host/mxcmmc.c
> @@ -989,7 +989,6 @@ static int mxcmci_probe(struct platform_device *pdev)
>
>         pr_info("i.MX/MPC512x SDHC driver\n");
>
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>         irq = platform_get_irq(pdev, 0);
>         if (irq < 0)
>                 return irq;
> @@ -1000,7 +999,7 @@ static int mxcmci_probe(struct platform_device *pdev)
>
>         host = mmc_priv(mmc);
>
> -       host->base = devm_ioremap_resource(&pdev->dev, res);
> +       host->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>         if (IS_ERR(host->base)) {
>                 ret = PTR_ERR(host->base);
>                 goto out_free;
> --
> 2.39.0
>
  

Patch

diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c
index 668f865f3efb..f3a72569dd1a 100644
--- a/drivers/mmc/host/mxcmmc.c
+++ b/drivers/mmc/host/mxcmmc.c
@@ -989,7 +989,6 @@  static int mxcmci_probe(struct platform_device *pdev)
 
 	pr_info("i.MX/MPC512x SDHC driver\n");
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0)
 		return irq;
@@ -1000,7 +999,7 @@  static int mxcmci_probe(struct platform_device *pdev)
 
 	host = mmc_priv(mmc);
 
-	host->base = devm_ioremap_resource(&pdev->dev, res);
+	host->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
 	if (IS_ERR(host->base)) {
 		ret = PTR_ERR(host->base);
 		goto out_free;