Message ID | 7519324a34015e1c046227269409fef688889f4f.1688643442.git.geert@linux-m68k.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp2510621vqx; Thu, 6 Jul 2023 05:09:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlHsaBWKPoMCmRJA5OhgKlWa24KTq45n5GO8iaeEBgfJZieIlOt2b2nW0/9QgN+KJwZnR+KF X-Received: by 2002:a05:6a00:194d:b0:668:7b5b:c1aa with SMTP id s13-20020a056a00194d00b006687b5bc1aamr1862677pfk.20.1688645373870; Thu, 06 Jul 2023 05:09:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688645373; cv=none; d=google.com; s=arc-20160816; b=EltzdH8ZgoiwkixxwmOfD+yeJy2bgH768wUCmgViVYLdYRMVRy8LocUiqO9lXayFOr 73JX2nB+6Dui+7Hc7KzMJhy0N0FPCsI+extdHHvF11gQ4CvHs6pxj9x/leH/qy98S1UG ZAuVNXCqc4NsIDT1EIP1svJ41Q+ESa9hEAz0bUGWW08WXPIrTHzgavYLpC4nTI2BGBSD kzP4kgYlJmmy3lZ1MNDz8Pb0RO+iSGstJagJ/WWr66qvrKAKhzNhsDs5EMN5z/0cYJ4J DgVLgx02cTDZaqZXz+v3ViSdm68jt7bPg5HUw1SF8TmgRQP6utS+3yZPhmEICLJ/lF6z KPCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zWs8bwHH6cZjAmtCgxp9HJ8bEp8/99TbL0yjvu7oPvs=; fh=gEa+jXONTRUMy72sPLZS/6Tev+RvK53AuTJh7z6JgZA=; b=uJDnHcvvG6T4Q88tlgK8/YVKiYPmx7l0oOVGVAjVoHk/oEkpnuleIh8h08BKoNimNy QwOCvOgQI8n2awSyUx/HTroDM/LTj2iwSjDFBZODDUd1kgY9ri6qqF9tpUKhgl8cPLPF 388A3VcMV0VbGZthhh92EoJwtrbJTBQ6ZmZM/agsLWEdkDhUWD1w64JMLycZPFEJlrBT vp3eXLRYfZa7i9zH31u2g6iPHWR7EhZKIJdq6FNz9xAzLTGQJdZBOnw2Ha/L9SWpNbkx datxlmHgtLTEmK7jIbEDWSwVaLi+qod9qpUjFMYpp219V2ipNtHbE1rnK96qzoLNKLNY NjsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i63-20020a638742000000b0055792e57c89si1372943pge.450.2023.07.06.05.09.20; Thu, 06 Jul 2023 05:09:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229693AbjGFLmh (ORCPT <rfc822;hadasmailinglist@gmail.com> + 99 others); Thu, 6 Jul 2023 07:42:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232505AbjGFLmd (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 6 Jul 2023 07:42:33 -0400 Received: from laurent.telenet-ops.be (laurent.telenet-ops.be [IPv6:2a02:1800:110:4::f00:19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8697B1BEE for <linux-kernel@vger.kernel.org>; Thu, 6 Jul 2023 04:42:11 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:5979:7b6f:39a:b9cb]) by laurent.telenet-ops.be with bizsmtp id Hni62A00445Xpxs01ni6ha; Thu, 06 Jul 2023 13:42:08 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qHNN3-000fav-Hy; Thu, 06 Jul 2023 13:42:06 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qHNN7-000QkI-Td; Thu, 06 Jul 2023 13:42:05 +0200 From: Geert Uytterhoeven <geert@linux-m68k.org> To: Mark Brown <broonie@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J . Wysocki" <rafael@kernel.org>, Lee Jones <lee@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Benjamin Gray <bgray@linux.ibm.com>, Christophe Leroy <christophe.leroy@csgroup.eu> Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org> Subject: [PATCH 2/3] regmap: REGMAP_SLIMBUS should select REGMAP Date: Thu, 6 Jul 2023 13:42:03 +0200 Message-Id: <7519324a34015e1c046227269409fef688889f4f.1688643442.git.geert@linux-m68k.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <cover.1688643442.git.geert@linux-m68k.org> References: <cover.1688643442.git.geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770673011183055454?= X-GMAIL-MSGID: =?utf-8?q?1770673011183055454?= |
Series |
regmap: Fix REGMAP selections
|
|
Commit Message
Geert Uytterhoeven
July 6, 2023, 11:42 a.m. UTC
If CONFIG_SND_SOC_WCD934X=y, CONFIG_COMPILE_TEST=y,
CONFIG_MFD_WCD934X=n, CONFIG_REGMAP=n:
sound/soc/codecs/wcd934x.c:518:38: error: array type has incomplete element type ‘struct regmap_range_cfg’
518 | static const struct regmap_range_cfg wcd934x_ifc_ranges[] = {
| ^~~~~~~~~~~~~~~~~~
Fix this by making REGMAP_SLIMBUS select REGMAP.
Drop the selection of REGMAP by MFD_WCD934X, as this is not needed
(now both REGMAP_SLIMBUS and REGMAP_IRQ select REGMAP).
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/base/regmap/Kconfig | 1 +
drivers/mfd/Kconfig | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, Jul 06, 2023 at 01:42:03PM +0200, Geert Uytterhoeven wrote: > Fix this by making REGMAP_SLIMBUS select REGMAP. Why is this being done as a separate patch? > Drop the selection of REGMAP by MFD_WCD934X, as this is not needed > (now both REGMAP_SLIMBUS and REGMAP_IRQ select REGMAP). This has always been redudnant, why is it mixed into this patch?
Hi Mark, On Thu, Jul 6, 2023 at 2:18 PM Mark Brown <broonie@kernel.org> wrote: > On Thu, Jul 06, 2023 at 01:42:03PM +0200, Geert Uytterhoeven wrote: > > > Fix this by making REGMAP_SLIMBUS select REGMAP. > > Why is this being done as a separate patch? Because this is a new select, which was not handled through the "default y" before. [PATCH 1/3] converted only the existing ones. > > Drop the selection of REGMAP by MFD_WCD934X, as this is not needed > > (now both REGMAP_SLIMBUS and REGMAP_IRQ select REGMAP). > > This has always been redudnant, why is it mixed into this patch? Because it is related to REGMAP_SLIMBUS selecting REGMAP. I agree it was redundant before, as REGMAP_IRQ already selected REGMAP. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, 06 Jul 2023, Geert Uytterhoeven wrote: > If CONFIG_SND_SOC_WCD934X=y, CONFIG_COMPILE_TEST=y, > CONFIG_MFD_WCD934X=n, CONFIG_REGMAP=n: > > sound/soc/codecs/wcd934x.c:518:38: error: array type has incomplete element type ‘struct regmap_range_cfg’ > 518 | static const struct regmap_range_cfg wcd934x_ifc_ranges[] = { > | ^~~~~~~~~~~~~~~~~~ > > Fix this by making REGMAP_SLIMBUS select REGMAP. > > Drop the selection of REGMAP by MFD_WCD934X, as this is not needed > (now both REGMAP_SLIMBUS and REGMAP_IRQ select REGMAP). > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > drivers/base/regmap/Kconfig | 1 + > drivers/mfd/Kconfig | 1 - Acked-by: Lee Jones <lee@kernel.org> > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig > index e25cc619c75de3d9..c3a260ed4e864959 100644 > --- a/drivers/base/regmap/Kconfig > +++ b/drivers/base/regmap/Kconfig > @@ -34,6 +34,7 @@ config REGMAP_I2C > config REGMAP_SLIMBUS > tristate > depends on SLIMBUS > + select REGMAP > > config REGMAP_SPI > tristate > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 0b6af476f554a191..5857dad2c64828fa 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -2121,7 +2121,6 @@ config MFD_STMFX > config MFD_WCD934X > tristate "Support for WCD9340/WCD9341 Codec" > depends on SLIMBUS > - select REGMAP > select REGMAP_SLIMBUS > select REGMAP_IRQ > select MFD_CORE > -- > 2.34.1 >
diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig index e25cc619c75de3d9..c3a260ed4e864959 100644 --- a/drivers/base/regmap/Kconfig +++ b/drivers/base/regmap/Kconfig @@ -34,6 +34,7 @@ config REGMAP_I2C config REGMAP_SLIMBUS tristate depends on SLIMBUS + select REGMAP config REGMAP_SPI tristate diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 0b6af476f554a191..5857dad2c64828fa 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -2121,7 +2121,6 @@ config MFD_STMFX config MFD_WCD934X tristate "Support for WCD9340/WCD9341 Codec" depends on SLIMBUS - select REGMAP select REGMAP_SLIMBUS select REGMAP_IRQ select MFD_CORE