[RESEND] scsi: ufs-mediatek: add dependency for RESET_CONTROLLER

Message ID 20230701052348.28046-1-rdunlap@infradead.org
State New
Headers
Series [RESEND] scsi: ufs-mediatek: add dependency for RESET_CONTROLLER |

Commit Message

Randy Dunlap July 1, 2023, 5:23 a.m. UTC
  When RESET_CONTROLLER is not set, kconfig complains about missing
dependencies for RESET_TI_SYSCON, so add the missing dependency
just as is done above for SCSI_UFS_QCOM.

Silences this kconfig warning:

WARNING: unmet direct dependencies detected for RESET_TI_SYSCON
  Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y]
  Selected by [m]:
  - SCSI_UFS_MEDIATEK [=m] && SCSI_UFSHCD [=y] && SCSI_UFSHCD_PLATFORM [=y] && ARCH_MEDIATEK [=y]

Fixes: de48898d0cb6 ("scsi: ufs-mediatek: Create reset control device_link")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Link: lore.kernel.org/r/202306020859.1wHg9AaT-lkp@intel.com
Cc: Stanley Chu <stanley.chu@mediatek.com>
Cc: Peter Wang <peter.wang@mediatek.com>
Cc: Paul Gazzillo <paul@pgazz.com>
Cc: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Cc: linux-scsi@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-mediatek@lists.infradead.org
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
---
 drivers/ufs/host/Kconfig |    1 +
 1 file changed, 1 insertion(+)
  

Comments

Martin K. Petersen July 6, 2023, 1:41 a.m. UTC | #1
Randy,

> When RESET_CONTROLLER is not set, kconfig complains about missing
> dependencies for RESET_TI_SYSCON, so add the missing dependency just
> as is done above for SCSI_UFS_QCOM.

Applied to 6.5/scsi-staging, thanks!
  
Martin K. Petersen July 11, 2023, 4:31 p.m. UTC | #2
On Fri, 30 Jun 2023 22:23:48 -0700, Randy Dunlap wrote:

> When RESET_CONTROLLER is not set, kconfig complains about missing
> dependencies for RESET_TI_SYSCON, so add the missing dependency
> just as is done above for SCSI_UFS_QCOM.
> 
> Silences this kconfig warning:
> 
> WARNING: unmet direct dependencies detected for RESET_TI_SYSCON
>   Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y]
>   Selected by [m]:
>   - SCSI_UFS_MEDIATEK [=m] && SCSI_UFSHCD [=y] && SCSI_UFSHCD_PLATFORM [=y] && ARCH_MEDIATEK [=y]
> 
> [...]

Applied to 6.5/scsi-fixes, thanks!

[1/1] scsi: ufs-mediatek: add dependency for RESET_CONTROLLER
      https://git.kernel.org/mkp/scsi/c/89f7ef7f2b23
  

Patch

diff -- a/drivers/ufs/host/Kconfig b/drivers/ufs/host/Kconfig
--- a/drivers/ufs/host/Kconfig
+++ b/drivers/ufs/host/Kconfig
@@ -72,6 +72,7 @@  config SCSI_UFS_QCOM
 config SCSI_UFS_MEDIATEK
 	tristate "Mediatek specific hooks to UFS controller platform driver"
 	depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK
+	depends on RESET_CONTROLLER
 	select PHY_MTK_UFS
 	select RESET_TI_SYSCON
 	help