Message ID | 1689054169-10800-2-git-send-email-quic_rohiagar@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp265385vqm; Mon, 10 Jul 2023 22:56:25 -0700 (PDT) X-Google-Smtp-Source: APBJJlG8zDhiqVmDciDj6LyC1JQObQpa/Jwz0RxBtl71LfcB4kamlh/U/Us2rsM/Sl7+3fjJgQZF X-Received: by 2002:a17:907:bcf:b0:971:eb29:a082 with SMTP id ez15-20020a1709070bcf00b00971eb29a082mr12169986ejc.49.1689054985191; Mon, 10 Jul 2023 22:56:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689054985; cv=none; d=google.com; s=arc-20160816; b=hOHF1NloBbs8IfewZUcbDS/dT6mASOYtiE//dxxJfB/OpeKFzfX7DZ4wSj2PmZkrf7 VHi+ShNK4nje8eGdfmwlgZCTghpiYRRcs7TC4lbPvNJJjd3h2wuqJVTKlWUMImrtxT57 x43M39S9EE/cHgZbJxq1n4g3BrrJ8qTGLEen4xmnfwsRIi5Qj5OojaFvy1MoQFP7Lwmm TL1u3V2eZcCn+tKexvYlWvLp4fAqHtru5ewEITf2PNSPT53S+kBi6gEiGEWLelAJyk4Z hVs1HWOKcLIEEaU288HFa55BXfk9IfaaBWxtQ2oKHaiK8w4n+cy0cWybtX2lcdghWBdG pHfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=SmF8gFWZK/ulLhm//87qgNEIyb7zdCSCY6H1RlByBWY=; fh=FqIaZmJRa7M15GQeKUdLg2SE2zbDk9BBzU6UB9zaVuw=; b=Xb32kyiC51L1NaIQj+VzehjNQcBx/ZLkm4KipZ1MGJh569xHTuUpmEgWku6UiFO5wP VRAdIJCrYjj3qDgOtvDnRoafbOmpYFWsglJDXfxORDJSkSFlCjyyVLxuxaNNhuBjmBix Dl1097F26s5K8t656Kq507RffuOMh+3fSW9Zzufpbf+bYOXG8fapo2CaeU992hFsUIBz jdZJbGlDSspF6HzXWrd0TJc8mZBqfsT0omh+CRIkS7gDTJNjIh9i55vHj2rQUEtVFMyD GpWbunJnFVafs4ibYXDGKz6LLXn8a9tn/pLeyYE8lJbcgLNcm3xVo7PX1+pak3Rwumtv HApQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=dxp6xGKF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u9-20020a1709067d0900b00988e942e12csi1254570ejo.716.2023.07.10.22.56.01; Mon, 10 Jul 2023 22:56:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=dxp6xGKF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230431AbjGKFnK (ORCPT <rfc822;gnulinuxfreebsd@gmail.com> + 99 others); Tue, 11 Jul 2023 01:43:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229917AbjGKFnH (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 11 Jul 2023 01:43:07 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 031DD195; Mon, 10 Jul 2023 22:43:07 -0700 (PDT) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36B5gR8A021415; Tue, 11 Jul 2023 05:43:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=SmF8gFWZK/ulLhm//87qgNEIyb7zdCSCY6H1RlByBWY=; b=dxp6xGKFOy5Ux7v5Z+wIBpLiva6QFsLlF7U2RjevJ/l1sEYm0rSNaUU9muyAwGvnY/KS Wks3Eu31mEmRIuhuSBsnLkS+vIcPh+NwExonH/RLcWzwCXx10vBNEoUkVa2HOn2JhvNL DbDfdc3RT3LMHNmJkp8OmYk5PXHoFLvj675hGeP0RHR5Fxu104mYveip6lxgzg9pQtOh 7J0lf3bhJ6HR5bPTWzK6aRM/6bjfBf6oh75mpl5atpllqSu/dUNMZB0thSTnIgWWkiAH tdXAZLWgqjErO2y7rOYiJ6GpnA5WnqkoBDTHjV9yRj6EdsBoFXH1bk43cfHY4FeDfwWV wQ== Received: from apblrppmta02.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rs15nr01t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Jul 2023 05:43:03 +0000 Received: from pps.filterd (APBLRPPMTA02.qualcomm.com [127.0.0.1]) by APBLRPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 36B5gx2D005033; Tue, 11 Jul 2023 05:42:59 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA02.qualcomm.com (PPS) with ESMTPS id 3rq0vm2h7n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 11 Jul 2023 05:42:59 +0000 Received: from APBLRPPMTA02.qualcomm.com (APBLRPPMTA02.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 36B5gxxs004995; Tue, 11 Jul 2023 05:42:59 GMT Received: from hu-sgudaval-hyd.qualcomm.com (hu-rohiagar-hyd.qualcomm.com [10.213.106.138]) by APBLRPPMTA02.qualcomm.com (PPS) with ESMTP id 36B5gwcS004967; Tue, 11 Jul 2023 05:42:59 +0000 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3970568) id 54ADC5040; Tue, 11 Jul 2023 11:12:58 +0530 (+0530) From: Rohit Agarwal <quic_rohiagar@quicinc.com> To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rohit Agarwal <quic_rohiagar@quicinc.com> Subject: [PATCH v3 1/3] dt-bindings: power: rpmhpd: Add Generic RPMh PD indexes Date: Tue, 11 Jul 2023 11:12:47 +0530 Message-Id: <1689054169-10800-2-git-send-email-quic_rohiagar@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1689054169-10800-1-git-send-email-quic_rohiagar@quicinc.com> References: <1689054169-10800-1-git-send-email-quic_rohiagar@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: h4n6sN0oks_VIK-FImTDgfBI74YE_T-Q X-Proofpoint-ORIG-GUID: h4n6sN0oks_VIK-FImTDgfBI74YE_T-Q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-11_02,2023-07-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 spamscore=0 phishscore=0 mlxlogscore=511 bulkscore=0 impostorscore=0 mlxscore=0 priorityscore=1501 malwarescore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307110050 X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771102520112510871 X-GMAIL-MSGID: 1771102520112510871 |
Series |
Add rpmhpd support for SDX75
|
|
Commit Message
Rohit Agarwal
July 11, 2023, 5:42 a.m. UTC
Add Generic RPMh Power Domain indexes that can be used
for all the Qualcomm SoC henceforth.
Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h
Comments
On 11/07/2023 07:42, Rohit Agarwal wrote: > Add Generic RPMh Power Domain indexes that can be used > for all the Qualcomm SoC henceforth. > > Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> > Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h > > diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h > new file mode 100644 > index 0000000..4da2e04 > --- /dev/null > +++ b/include/dt-bindings/power/qcom-rpmhpd.h Filename based on compatible. > @@ -0,0 +1,30 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H > +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H > + > +/* Generic RPMH Power Domain Indexes */ > +#define CX 0 These are very generic names, usually not used in global headers. Please use some reasonable prefix. Best regards, Krzysztof
On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote: > On 11/07/2023 07:42, Rohit Agarwal wrote: >> Add Generic RPMh Power Domain indexes that can be used >> for all the Qualcomm SoC henceforth. >> >> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h >> >> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h >> new file mode 100644 >> index 0000000..4da2e04 >> --- /dev/null >> +++ b/include/dt-bindings/power/qcom-rpmhpd.h > Filename based on compatible. This is not specific for SDX75. These are generic ones that should be used for all other targets. Konrad suggested in v1 to avoid target specific prefixes everytime and to create a new generic dt-bindings that can be reused. >> @@ -0,0 +1,30 @@ >> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >> +/* >> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. >> + */ >> + >> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H >> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H >> + >> +/* Generic RPMH Power Domain Indexes */ >> +#define CX 0 > These are very generic names, usually not used in global headers. Please > use some reasonable prefix. This was based on the suggestion from Konrad in v2 to drop the RPMHPD prefix and we can go only with names like CX, etc. Thanks, Rohit. > > > Best regards, > Krzysztof >
On 11/07/2023 08:17, Rohit Agarwal wrote: > > On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote: >> On 11/07/2023 07:42, Rohit Agarwal wrote: >>> Add Generic RPMh Power Domain indexes that can be used >>> for all the Qualcomm SoC henceforth. >>> >>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>> --- >>> include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++ >>> 1 file changed, 30 insertions(+) >>> create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h >>> >>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h >>> new file mode 100644 >>> index 0000000..4da2e04 >>> --- /dev/null >>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h >> Filename based on compatible. > This is not specific for SDX75. These are generic ones that should be > used for all other targets. > Konrad suggested in v1 to avoid target specific prefixes everytime and > to create a new generic > dt-bindings that can be reused. >>> @@ -0,0 +1,30 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >>> +/* >>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. >>> + */ >>> + >>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>> + >>> +/* Generic RPMH Power Domain Indexes */ >>> +#define CX 0 >> These are very generic names, usually not used in global headers. Please >> use some reasonable prefix. > This was based on the suggestion from Konrad in v2 to drop the RPMHPD > prefix and we can go only with names like CX, etc. I don't think having so generic name in tree-wide header is good idea. CX can mean anything. Best regards, Krzysztof
On 11/07/2023 08:17, Rohit Agarwal wrote: > > On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote: >> On 11/07/2023 07:42, Rohit Agarwal wrote: >>> Add Generic RPMh Power Domain indexes that can be used >>> for all the Qualcomm SoC henceforth. >>> >>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>> --- >>> include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++ >>> 1 file changed, 30 insertions(+) >>> create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h >>> >>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h >>> new file mode 100644 >>> index 0000000..4da2e04 >>> --- /dev/null >>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h >> Filename based on compatible. > This is not specific for SDX75. These are generic ones that should be > used for all other targets. qcom,rpmhpd.h Best regards, Krzysztof
On 7/11/2023 12:04 PM, Krzysztof Kozlowski wrote: > On 11/07/2023 08:17, Rohit Agarwal wrote: >> On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote: >>> On 11/07/2023 07:42, Rohit Agarwal wrote: >>>> Add Generic RPMh Power Domain indexes that can be used >>>> for all the Qualcomm SoC henceforth. >>>> >>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>>> --- >>>> include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++ >>>> 1 file changed, 30 insertions(+) >>>> create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h >>>> >>>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h >>>> new file mode 100644 >>>> index 0000000..4da2e04 >>>> --- /dev/null >>>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h >>> Filename based on compatible. >> This is not specific for SDX75. These are generic ones that should be >> used for all other targets. > qcom,rpmhpd.h Ok, got it. Thanks, Rohit. > Best regards, > Krzysztof >
On 11.07.2023 08:22, Krzysztof Kozlowski wrote: > On 11/07/2023 08:17, Rohit Agarwal wrote: >> >> On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote: >>> On 11/07/2023 07:42, Rohit Agarwal wrote: >>>> Add Generic RPMh Power Domain indexes that can be used >>>> for all the Qualcomm SoC henceforth. >>>> >>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>>> --- >>>> include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++ >>>> 1 file changed, 30 insertions(+) >>>> create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h >>>> >>>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h >>>> new file mode 100644 >>>> index 0000000..4da2e04 >>>> --- /dev/null >>>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h >>> Filename based on compatible. >> This is not specific for SDX75. These are generic ones that should be >> used for all other targets. >> Konrad suggested in v1 to avoid target specific prefixes everytime and >> to create a new generic >> dt-bindings that can be reused. >>>> @@ -0,0 +1,30 @@ >>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >>>> +/* >>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. >>>> + */ >>>> + >>>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>>> + >>>> +/* Generic RPMH Power Domain Indexes */ >>>> +#define CX 0 >>> These are very generic names, usually not used in global headers. Please >>> use some reasonable prefix. >> This was based on the suggestion from Konrad in v2 to drop the RPMHPD >> prefix and we can go only with names like CX, etc. > > I don't think having so generic name in tree-wide header is good idea. Conversely, I think that it would be very clear in files including this header. Konrad > CX can mean anything. > > Best regards, > Krzysztof >
On 11/07/2023 14:44, Konrad Dybcio wrote: > On 11.07.2023 08:22, Krzysztof Kozlowski wrote: >> On 11/07/2023 08:17, Rohit Agarwal wrote: >>> >>> On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote: >>>> On 11/07/2023 07:42, Rohit Agarwal wrote: >>>>> Add Generic RPMh Power Domain indexes that can be used >>>>> for all the Qualcomm SoC henceforth. >>>>> >>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >>>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>>>> --- >>>>> include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++ >>>>> 1 file changed, 30 insertions(+) >>>>> create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h >>>>> >>>>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h >>>>> new file mode 100644 >>>>> index 0000000..4da2e04 >>>>> --- /dev/null >>>>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h >>>> Filename based on compatible. >>> This is not specific for SDX75. These are generic ones that should be >>> used for all other targets. >>> Konrad suggested in v1 to avoid target specific prefixes everytime and >>> to create a new generic >>> dt-bindings that can be reused. >>>>> @@ -0,0 +1,30 @@ >>>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >>>>> +/* >>>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. >>>>> + */ >>>>> + >>>>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>>>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>>>> + >>>>> +/* Generic RPMH Power Domain Indexes */ >>>>> +#define CX 0 >>>> These are very generic names, usually not used in global headers. Please >>>> use some reasonable prefix. >>> This was based on the suggestion from Konrad in v2 to drop the RPMHPD >>> prefix and we can go only with names like CX, etc. >> >> I don't think having so generic name in tree-wide header is good idea. > Conversely, I think that it would be very clear in files including this header. It is expected to be included into dtsi and into rpmhpd driver (only). However I'd also suggest adding some generic prefix (e.g. RPMHPD_CX). Just `CX' is too short and has a sensible possibility of getting a symbol conflict. > > Konrad >> CX can mean anything. >> >> Best regards, >> Krzysztof >>
On 11/07/2023 08:42, Rohit Agarwal wrote: > Add Generic RPMh Power Domain indexes that can be used > for all the Qualcomm SoC henceforth. > > Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> > Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h > > diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h > new file mode 100644 > index 0000000..4da2e04 > --- /dev/null > +++ b/include/dt-bindings/power/qcom-rpmhpd.h > @@ -0,0 +1,30 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H > +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H > + > +/* Generic RPMH Power Domain Indexes */ > +#define CX 0 > +#define MX 1 > +#define CX_AO 2 > +#define MX_AO 3 > +#define GFX 4 > +#define MSS 5 > +#define EBI 6 > +#define LCX 7 > +#define LMX 8 > +#define MMCX 9 > +#define MMCX_AO 10 > +#define MXC 11 > +#define MXC_AO 12 > +#define NSP 13 > +#define NSP0 14 > +#define NSP1 15 > +#define QPHY 16 > +#define DDR 17 > +#define XO 18 I went through the existing defines. If we adopt the order of defines for sm8550, we can migrate that platform and all of sm8[234]50 without breaking ABI. This would be a minor gain, but still something. > + > +#endif
On 7/11/2023 8:29 PM, Dmitry Baryshkov wrote: > On 11/07/2023 14:44, Konrad Dybcio wrote: >> On 11.07.2023 08:22, Krzysztof Kozlowski wrote: >>> On 11/07/2023 08:17, Rohit Agarwal wrote: >>>> >>>> On 7/11/2023 11:22 AM, Krzysztof Kozlowski wrote: >>>>> On 11/07/2023 07:42, Rohit Agarwal wrote: >>>>>> Add Generic RPMh Power Domain indexes that can be used >>>>>> for all the Qualcomm SoC henceforth. >>>>>> >>>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >>>>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>>>>> --- >>>>>> include/dt-bindings/power/qcom-rpmhpd.h | 30 >>>>>> ++++++++++++++++++++++++++++++ >>>>>> 1 file changed, 30 insertions(+) >>>>>> create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h >>>>>> >>>>>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h >>>>>> b/include/dt-bindings/power/qcom-rpmhpd.h >>>>>> new file mode 100644 >>>>>> index 0000000..4da2e04 >>>>>> --- /dev/null >>>>>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h >>>>> Filename based on compatible. >>>> This is not specific for SDX75. These are generic ones that should be >>>> used for all other targets. >>>> Konrad suggested in v1 to avoid target specific prefixes everytime and >>>> to create a new generic >>>> dt-bindings that can be reused. >>>>>> @@ -0,0 +1,30 @@ >>>>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >>>>>> +/* >>>>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All >>>>>> rights reserved. >>>>>> + */ >>>>>> + >>>>>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>>>>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>>>>> + >>>>>> +/* Generic RPMH Power Domain Indexes */ >>>>>> +#define CX 0 >>>>> These are very generic names, usually not used in global headers. >>>>> Please >>>>> use some reasonable prefix. >>>> This was based on the suggestion from Konrad in v2 to drop the RPMHPD >>>> prefix and we can go only with names like CX, etc. >>> >>> I don't think having so generic name in tree-wide header is good idea. >> Conversely, I think that it would be very clear in files including >> this header. > > It is expected to be included into dtsi and into rpmhpd driver (only). > However I'd also suggest adding some generic prefix (e.g. RPMHPD_CX). > Just `CX' is too short and has a sensible possibility of getting a > symbol conflict. > Ok, Will add them back as in v2. Thanks, Rohit. >> >> Konrad >>> CX can mean anything. >>> >>> Best regards, >>> Krzysztof >>> >
On 7/11/2023 8:41 PM, Dmitry Baryshkov wrote: > On 11/07/2023 08:42, Rohit Agarwal wrote: >> Add Generic RPMh Power Domain indexes that can be used >> for all the Qualcomm SoC henceforth. >> >> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> include/dt-bindings/power/qcom-rpmhpd.h | 30 >> ++++++++++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h >> >> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h >> b/include/dt-bindings/power/qcom-rpmhpd.h >> new file mode 100644 >> index 0000000..4da2e04 >> --- /dev/null >> +++ b/include/dt-bindings/power/qcom-rpmhpd.h >> @@ -0,0 +1,30 @@ >> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >> +/* >> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights >> reserved. >> + */ >> + >> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H >> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H >> + >> +/* Generic RPMH Power Domain Indexes */ >> +#define CX 0 >> +#define MX 1 >> +#define CX_AO 2 >> +#define MX_AO 3 >> +#define GFX 4 >> +#define MSS 5 >> +#define EBI 6 >> +#define LCX 7 >> +#define LMX 8 >> +#define MMCX 9 >> +#define MMCX_AO 10 >> +#define MXC 11 >> +#define MXC_AO 12 >> +#define NSP 13 >> +#define NSP0 14 >> +#define NSP1 15 >> +#define QPHY 16 >> +#define DDR 17 >> +#define XO 18 > > I went through the existing defines. If we adopt the order of defines > for sm8550, we can migrate that platform and all of sm8[234]50 without > breaking ABI. This would be a minor gain, but still something. > Actually, I added them in the sequence based on the frequency with which they occur in the driver, so that there are less NULL entries created for any target additions. Shouldnt we keep it this way and ignore for previous targets then? Thanks, Rohit. >> + >> +#endif >
On 12.07.2023 10:24, Rohit Agarwal wrote: > > On 7/11/2023 8:41 PM, Dmitry Baryshkov wrote: >> On 11/07/2023 08:42, Rohit Agarwal wrote: >>> Add Generic RPMh Power Domain indexes that can be used >>> for all the Qualcomm SoC henceforth. >>> >>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>> --- >>> include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++ >>> 1 file changed, 30 insertions(+) >>> create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h >>> >>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h >>> new file mode 100644 >>> index 0000000..4da2e04 >>> --- /dev/null >>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h >>> @@ -0,0 +1,30 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >>> +/* >>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. >>> + */ >>> + >>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>> + >>> +/* Generic RPMH Power Domain Indexes */ >>> +#define CX 0 >>> +#define MX 1 >>> +#define CX_AO 2 >>> +#define MX_AO 3 >>> +#define GFX 4 >>> +#define MSS 5 >>> +#define EBI 6 >>> +#define LCX 7 >>> +#define LMX 8 >>> +#define MMCX 9 >>> +#define MMCX_AO 10 >>> +#define MXC 11 >>> +#define MXC_AO 12 >>> +#define NSP 13 >>> +#define NSP0 14 >>> +#define NSP1 15 >>> +#define QPHY 16 >>> +#define DDR 17 >>> +#define XO 18 >> >> I went through the existing defines. If we adopt the order of defines for sm8550, we can migrate that platform and all of sm8[234]50 without breaking ABI. This would be a minor gain, but still something. >> > Actually, I added them in the sequence based on the frequency with which they occur in the driver, so that there are less NULL entries created for any target additions. Shouldnt we keep it this way and ignore for previous targets then? Don't bother yourself with this, we've already dragged you through some bindings mess ;) Dmitry just noticed that a happy coincidence occured and we could swap out SM8[234]_50 indices with these ones and they would still match. It'd be a separate patch though. Konrad > > Thanks, > Rohit. >>> + >>> +#endif >>
On 7/12/2023 2:52 PM, Konrad Dybcio wrote: > On 12.07.2023 10:24, Rohit Agarwal wrote: >> On 7/11/2023 8:41 PM, Dmitry Baryshkov wrote: >>> On 11/07/2023 08:42, Rohit Agarwal wrote: >>>> Add Generic RPMh Power Domain indexes that can be used >>>> for all the Qualcomm SoC henceforth. >>>> >>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org> >>>> --- >>>> include/dt-bindings/power/qcom-rpmhpd.h | 30 ++++++++++++++++++++++++++++++ >>>> 1 file changed, 30 insertions(+) >>>> create mode 100644 include/dt-bindings/power/qcom-rpmhpd.h >>>> >>>> diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h >>>> new file mode 100644 >>>> index 0000000..4da2e04 >>>> --- /dev/null >>>> +++ b/include/dt-bindings/power/qcom-rpmhpd.h >>>> @@ -0,0 +1,30 @@ >>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >>>> +/* >>>> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. >>>> + */ >>>> + >>>> +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>>> +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H >>>> + >>>> +/* Generic RPMH Power Domain Indexes */ >>>> +#define CX 0 >>>> +#define MX 1 >>>> +#define CX_AO 2 >>>> +#define MX_AO 3 >>>> +#define GFX 4 >>>> +#define MSS 5 >>>> +#define EBI 6 >>>> +#define LCX 7 >>>> +#define LMX 8 >>>> +#define MMCX 9 >>>> +#define MMCX_AO 10 >>>> +#define MXC 11 >>>> +#define MXC_AO 12 >>>> +#define NSP 13 >>>> +#define NSP0 14 >>>> +#define NSP1 15 >>>> +#define QPHY 16 >>>> +#define DDR 17 >>>> +#define XO 18 >>> I went through the existing defines. If we adopt the order of defines for sm8550, we can migrate that platform and all of sm8[234]50 without breaking ABI. This would be a minor gain, but still something. >>> >> Actually, I added them in the sequence based on the frequency with which they occur in the driver, so that there are less NULL entries created for any target additions. Shouldnt we keep it this way and ignore for previous targets then? > Don't bother yourself with this, we've already dragged you through > some bindings mess ;) > > Dmitry just noticed that a happy coincidence occured and we could > swap out SM8[234]_50 indices with these ones and they would still > match. It'd be a separate patch though. Yes sure. Will make a separate patch updating entries for these targets. Thanks, Rohit. > Konrad >> Thanks, >> Rohit. >>>> + >>>> +#endif
diff --git a/include/dt-bindings/power/qcom-rpmhpd.h b/include/dt-bindings/power/qcom-rpmhpd.h new file mode 100644 index 0000000..4da2e04 --- /dev/null +++ b/include/dt-bindings/power/qcom-rpmhpd.h @@ -0,0 +1,30 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. + */ + +#ifndef _DT_BINDINGS_POWER_QCOM_RPMHPD_H +#define _DT_BINDINGS_POWER_QCOM_RPMHPD_H + +/* Generic RPMH Power Domain Indexes */ +#define CX 0 +#define MX 1 +#define CX_AO 2 +#define MX_AO 3 +#define GFX 4 +#define MSS 5 +#define EBI 6 +#define LCX 7 +#define LMX 8 +#define MMCX 9 +#define MMCX_AO 10 +#define MXC 11 +#define MXC_AO 12 +#define NSP 13 +#define NSP0 14 +#define NSP1 15 +#define QPHY 16 +#define DDR 17 +#define XO 18 + +#endif