Message ID | 20230707063335.13317-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3067621vqx; Thu, 6 Jul 2023 23:49:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlGju0mS+j4H7wG2jiJ4fE9JXf5OJdc/O/v3ig2aWuLuhju+fSNzyiVPRbNvYk9fqVPbNYqN X-Received: by 2002:a05:6808:220b:b0:3a0:41d4:b144 with SMTP id bd11-20020a056808220b00b003a041d4b144mr5049287oib.1.1688712584620; Thu, 06 Jul 2023 23:49:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688712584; cv=none; d=google.com; s=arc-20160816; b=Ichllj9Su5GJU660w9rWPLgCpOmPCinjoNMVUD9hfZjTzTRNCCn/jkCk56P3bmUktW 6M3KchO0KBexIma2n9DvP74GRfg3U9kUbX4YrBN+E0FdLKZWHbvwx6rNrTTwnWhbUnaK 5NrfecLS0Vr3m6pz/wNbqeC3jLYSsq9/RL+Dlt1+CL745G+2hG9WjO9Iqwp/7cHuEWA9 iuu4ndKV6XvVG4hNBkG1YhzwIXjCqUFRhY5dNIr5ppB1ngNMCcigzyUh17trr+lJwQx1 YZMX169q8/Zt+ZRc4SHYONtxZwYx/aH4NaJMPnyllU5fOmoURjDnRxHaVAxUFvLwXmlW e7bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=e1W0PEIp2Z9O+/54QqCCTT57o1K3eq1ISnoT3iEkIG4=; fh=r102X2Gp3Ll0scyBTiyjmxYlXDGfBgzF9EqFvsdroRM=; b=D3lNH0zE8QfFOZkdH1nTDaqWNOUrqem4SY8Y0KFc8UyykXamMF6k9id/1LZMlezm9x 6SG8dgaYWKewFNt1vmd3DzW/j+5w1/dguAge1Jbsdmty1Goau5bfUc4ayT8ZYhKAIPbW rz9m8Kxx+quy3gPMQk5JSRN8lvcOn1ljQo1gLSUmOOurhNwlDS7sY2gHmvEifMZhh00b 0REYXAVNv5rCyEjOmSwvtHMy9pc5rbZ9csfthyEGYuvXv4kMp46namLsIKgKa+dHLeVp QKkyPFaGHhblASRs1m6zBySfWBnxyq5gO17bi/wMeD+p4m/jEH0ZVZAaQiduJoO/wQvS T2Rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ji+vp0Rf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kk15-20020a17090b4a0f00b002632a1243dbsi897656pjb.104.2023.07.06.23.49.30; Thu, 06 Jul 2023 23:49:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ji+vp0Rf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231769AbjGGGdn (ORCPT <rfc822;daweilics@gmail.com> + 99 others); Fri, 7 Jul 2023 02:33:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbjGGGdl (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 7 Jul 2023 02:33:41 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED1491FC9 for <linux-kernel@vger.kernel.org>; Thu, 6 Jul 2023 23:33:39 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-992ca792065so186613066b.2 for <linux-kernel@vger.kernel.org>; Thu, 06 Jul 2023 23:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688711618; x=1691303618; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=e1W0PEIp2Z9O+/54QqCCTT57o1K3eq1ISnoT3iEkIG4=; b=Ji+vp0Rf7GnjgL/ryIs4zj5psew4pNxA0cs8GFKCCt4E8wh0ztH3y1BPKo8A6Kr5CR Ssh+LsCi0ePSmFr6nLgrN73CA2MGcMaJIrfjpg/jM7aBYCC7QstmFfJTkw+D0od4S9CL fK43PEE9RS+gtkkroUsHTHuZrB4sb2u/XCw+wBuIGWfkCD0UmOg1nuWcTcVNjB4Y9lBJ XtIxHr9Fe2nvRTn/d7F6dMPhkKhvs3PfzluZg24d0Fqx/c5HsGGJBo/U2On4yiyKU7x2 jekKm74a17Mc0FGyAaRQgC6mRyV6NJcMAVHpqNP/NinRZ88jHW6ZblkBXu+EnDP5KDX+ smmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688711618; x=1691303618; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e1W0PEIp2Z9O+/54QqCCTT57o1K3eq1ISnoT3iEkIG4=; b=CH6oYhL5vXL6mBbBRHmNs5OTl8kY/3NjWwsJZ89Bd6u40787udscaO/RyY0Xta7qe8 l4i+Wz4/WTHrLBFfsVzve2JmQNsoFX+vmL2zZeAv7pIrsCk33IJoiOUq+HkIzmrlAxni afbqX5v7nHqhHQNmG+UZLOwC+v84JMLsd4Aq8pkuqIgGwe/XcYVbMxOeTJYRl5Mp+QAj OmfQX7NOgyW9BIXVV3IyRUqLFbZz3SNX8cdt9m/3KZH2Yqk6CI4MptbYh7j+4tj663OW z33raKcqyELbVUYM3OAYA92YuXA8Mlb8wtqPdycRTrJ5gwMRLnbsaSFT/3fj+APFZhfK FU+w== X-Gm-Message-State: ABy/qLaC0DQxNkGu+c36ugQdAUGwSTSTmnYmB7MmNhCrmMitH77RnvBa QAS+O6Y7q+bF9KITI08tTwkEUA== X-Received: by 2002:a17:907:75f6:b0:94f:449e:75db with SMTP id jz22-20020a17090775f600b0094f449e75dbmr3160188ejc.52.1688711618411; Thu, 06 Jul 2023 23:33:38 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id s24-20020a170906169800b0096f7500502csm1724803ejd.199.2023.07.06.23.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 23:33:38 -0700 (PDT) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Heiko Stuebner <heiko@sntech.de>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [RFT PATCH v2 1/3] arm64: dts: rockchip: correct wifi interrupt flag in eaidk-610 Date: Fri, 7 Jul 2023 08:33:33 +0200 Message-Id: <20230707063335.13317-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770743487188437655?= X-GMAIL-MSGID: =?utf-8?q?1770743487188437655?= |
Series |
[RFT,v2,1/3] arm64: dts: rockchip: correct wifi interrupt flag in eaidk-610
|
|
Commit Message
Krzysztof Kozlowski
July 7, 2023, 6:33 a.m. UTC
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE.
Correct the interrupt flags, assuming the author of the code wanted same
logical behavior behind the name "ACTIVE_xxx", this is:
ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes in v2:
1. Correct subject and commit msg (active low -> high)
---
arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, 7 Jul 2023 08:33:33 +0200, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. > > Correct the interrupt flags, assuming the author of the code wanted same > logical behavior behind the name "ACTIVE_xxx", this is: > ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH > > [...] Applied, thanks! [1/3] arm64: dts: rockchip: correct wifi interrupt flag in eaidk-610 commit: 8183bb7e291b7818f49ea39687c2fafa01a46e27 [2/3] arm64: dts: rockchip: correct wifi interrupt flag in Rock Pi 4B commit: cfa12c32b96fd5b12f77d880d6a1ddd2a502756e [3/3] arm64: dts: rockchip: correct wifi interrupt flag in Box Demo commit: 2d6f7e3938a7aba154c8e8afaddc8b7f1e0a1b56 Best regards,
Am Montag, 10. Juli 2023, 16:16:20 CEST schrieb Heiko Stuebner: > On Fri, 7 Jul 2023 08:33:33 +0200, Krzysztof Kozlowski wrote: > > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > > These are simple defines so they could be used in DTS but they will not > > have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. > > > > Correct the interrupt flags, assuming the author of the code wanted same > > logical behavior behind the name "ACTIVE_xxx", this is: > > ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH > > > > [...] > > Applied, thanks! > > [1/3] arm64: dts: rockchip: correct wifi interrupt flag in eaidk-610 > commit: 8183bb7e291b7818f49ea39687c2fafa01a46e27 > [2/3] arm64: dts: rockchip: correct wifi interrupt flag in Rock Pi 4B > commit: cfa12c32b96fd5b12f77d880d6a1ddd2a502756e > [3/3] arm64: dts: rockchip: correct wifi interrupt flag in Box Demo > commit: 2d6f7e3938a7aba154c8e8afaddc8b7f1e0a1b56 we got one successful test and all the changes concern broadcom wifi modules, I assume that this should work on all of them the same :-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts index d1f343345f67..6464ef4d113d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts @@ -773,7 +773,7 @@ brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpio0>; - interrupts = <RK_PA3 GPIO_ACTIVE_HIGH>; + interrupts = <RK_PA3 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_l>;