Message ID | 20230708084027.18352-4-paul@crapouillou.net |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3795180vqx; Sat, 8 Jul 2023 01:58:37 -0700 (PDT) X-Google-Smtp-Source: APBJJlGb1sUQeXBCCsRfrDKvm/hqcOmiXLb40RKxEBaRqpPZzWy5Iui/TmtziASgr8b8GMMr3bAu X-Received: by 2002:a05:6402:1a33:b0:51b:df14:594e with SMTP id be19-20020a0564021a3300b0051bdf14594emr5415774edb.39.1688806716739; Sat, 08 Jul 2023 01:58:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688806716; cv=none; d=google.com; s=arc-20160816; b=EZObMMAa/bPfObPEe6JDKlXYD6IXtQqZi61PJZLXE0IMultaA6RNHBzapZnuhzIdnX WO5Bts4J//IU1gX208LG06WaWgS/qxe9kifICVyExJWw5AwJrCvdDPsldYJRKBN9KB2j mLUwfOJp86Y9PzXQ1lPGoWpeO9GgOqW48WBCky73C/qjCEOvYKL/raXB5vylyGonDfsN H4jL0++WmKW6osXBhDKb21w4uNke0NyNhYqP3BnO0rFJvnvDN6ZJx8hzyW59tlyz394X wFqzGqB5cO3WSrpvau/EX5G8kQrVW5AmtOfMPO1tcRgN0I4SUmCuoaUa6RGj4rmaiRpj Izhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WirPH1rGCBNSwdNcVLcYapLshg/0Im7Zm/a2Plr7i4M=; fh=f1Xbhg+XXir6LkY+JcvZdgC1ubfoYPkHOkuWGz1+t0U=; b=jjWPdQZhPZvZsS58OHxn4v8yfGRf//gbK8Ay2J79aBJc1l/4nZ+xemU+IWlqIWxdm6 +QaDHpqoOfYVfQWmH3/pH0VrqXZNtF1iRsyiUF+BDpI4b4LdNfDjNwPiXGYIoPs/rrzg 6Ih+nW4cWFClMqF0rWTd8s3aKMNYh0ts2VxBm0X2FxUJ8gJCUXMw5w/FpyUzVCiWkwDG XazDDKKAVkgTtKn561ZjgPPDjBY79N/l/ApxUScQl0yMZ5jEWUJORfLEl/AkmWK1J+yA c+gAzH7Kl+QeZrp3bMcvS6YQghhM3WaHlIQBF4itMI2gbGAptZel8EzTubm/PRXttAgN UBtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b="rK/oWbmB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b3-20020a05640202c300b0051de3779436si3163050edx.454.2023.07.08.01.58.11; Sat, 08 Jul 2023 01:58:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b="rK/oWbmB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229627AbjGHIlP (ORCPT <rfc822;tebrre53rla2o@gmail.com> + 99 others); Sat, 8 Jul 2023 04:41:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjGHIlN (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 8 Jul 2023 04:41:13 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8B6A268C; Sat, 8 Jul 2023 01:41:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1688805642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WirPH1rGCBNSwdNcVLcYapLshg/0Im7Zm/a2Plr7i4M=; b=rK/oWbmBJv/Ltz0ypARywuPgkeXGSgrmc9NsjeXHTQ9BcPUDJwZ7JVLxiftY9etLvKoO7x BTN8Rmm/t1HYw83LCDLCI0o8m3mO1yPHjojz2lzjedEUaFzRBV4R7whXiN1U9L/M/lt7+C vEKakKwEMNOBH3p0yVtTDjFBKzOp2O8= From: Paul Cercueil <paul@crapouillou.net> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, Alim Akhtar <alim.akhtar@samsung.com>, Neil Armstrong <neil.armstrong@linaro.org>, Sam Ravnborg <sam@ravnborg.org> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Paul Cercueil <paul@crapouillou.net>, stable@vger.kernel.org Subject: [PATCH v2 3/3] ARM: dts: exynos/i9100: Fix LCD screen's physical size Date: Sat, 8 Jul 2023 10:40:27 +0200 Message-Id: <20230708084027.18352-4-paul@crapouillou.net> In-Reply-To: <20230708084027.18352-1-paul@crapouillou.net> References: <20230708084027.18352-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam: Yes X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770842191781738290?= X-GMAIL-MSGID: =?utf-8?q?1770842191781738290?= |
Series |
Galaxy S2 (i9100) panel updates v2
|
|
Commit Message
Paul Cercueil
July 8, 2023, 8:40 a.m. UTC
The previous values were completely bogus, and resulted in the computed
DPI ratio being much lower than reality, causing applications and UIs to
misbehave.
The new values were measured by myself with a ruler.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for the Galaxy S2")
Cc: <stable@vger.kernel.org> # v5.8+
---
arch/arm/boot/dts/exynos4210-i9100.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 08/07/2023 10:40, Paul Cercueil wrote: > The previous values were completely bogus, and resulted in the computed > DPI ratio being much lower than reality, causing applications and UIs to > misbehave. > > The new values were measured by myself with a ruler. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for the Galaxy S2") > Cc: <stable@vger.kernel.org> # v5.8+ > --- This does not apply. You rebased your work on some older version/tree, without new layout. Please work on linux-next. Best regards, Krzysztof
Hi Krzysztof, Le lundi 10 juillet 2023 à 08:59 +0200, Krzysztof Kozlowski a écrit : > On 08/07/2023 10:40, Paul Cercueil wrote: > > The previous values were completely bogus, and resulted in the > > computed > > DPI ratio being much lower than reality, causing applications and > > UIs to > > misbehave. > > > > The new values were measured by myself with a ruler. > > > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > > Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for the > > Galaxy S2") > > Cc: <stable@vger.kernel.org> # v5.8+ > > --- > > This does not apply. You rebased your work on some older > version/tree, > without new layout. Please work on linux-next. This patchset was based on drm-misc-next, because that's where I was planning to apply it; and it was extremely unlikely (but not impossible, apparently) that the i9100.dts would be modified in the meantime. I can rebase on linux-next, the problem then is that I then don't know how/where to apply the patchset. Cheers, -Paul
On 10/07/2023 09:35, Paul Cercueil wrote: > Hi Krzysztof, > > Le lundi 10 juillet 2023 à 08:59 +0200, Krzysztof Kozlowski a écrit : >> On 08/07/2023 10:40, Paul Cercueil wrote: >>> The previous values were completely bogus, and resulted in the >>> computed >>> DPI ratio being much lower than reality, causing applications and >>> UIs to >>> misbehave. >>> >>> The new values were measured by myself with a ruler. >>> >>> Signed-off-by: Paul Cercueil <paul@crapouillou.net> >>> Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for the >>> Galaxy S2") >>> Cc: <stable@vger.kernel.org> # v5.8+ >>> --- >> >> This does not apply. You rebased your work on some older >> version/tree, >> without new layout. Please work on linux-next. > > This patchset was based on drm-misc-next, because that's where I was > planning to apply it; and it was extremely unlikely (but not > impossible, apparently) that the i9100.dts would be modified in the > meantime. > > I can rebase on linux-next, the problem then is that I then don't know > how/where to apply the patchset. DTS cannot go via drm-misc-next, so if that's your intention please always split the patchset into separate ones. *Always*. Best regards, Krzysztof
Le lundi 10 juillet 2023 à 09:45 +0200, Krzysztof Kozlowski a écrit : > On 10/07/2023 09:35, Paul Cercueil wrote: > > Hi Krzysztof, > > > > Le lundi 10 juillet 2023 à 08:59 +0200, Krzysztof Kozlowski a > > écrit : > > > On 08/07/2023 10:40, Paul Cercueil wrote: > > > > The previous values were completely bogus, and resulted in the > > > > computed > > > > DPI ratio being much lower than reality, causing applications > > > > and > > > > UIs to > > > > misbehave. > > > > > > > > The new values were measured by myself with a ruler. > > > > > > > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > > > > Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for > > > > the > > > > Galaxy S2") > > > > Cc: <stable@vger.kernel.org> # v5.8+ > > > > --- > > > > > > This does not apply. You rebased your work on some older > > > version/tree, > > > without new layout. Please work on linux-next. > > > > This patchset was based on drm-misc-next, because that's where I > > was > > planning to apply it; and it was extremely unlikely (but not > > impossible, apparently) that the i9100.dts would be modified in the > > meantime. > > > > I can rebase on linux-next, the problem then is that I then don't > > know > > how/where to apply the patchset. > > DTS cannot go via drm-misc-next, so if that's your intention please > always split the patchset into separate ones. *Always*. Noted. Then I'll apply the patches [1/3] and [2/3] to drm-misc-next since I have my ACKs, and re-send patch [3/3] as standalone and rebased on linux-next. Cheers, -Paul
diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts index 37cd4dde53e4..a9ec1f6c1dea 100644 --- a/arch/arm/boot/dts/exynos4210-i9100.dts +++ b/arch/arm/boot/dts/exynos4210-i9100.dts @@ -207,8 +207,8 @@ lcd@0 { power-on-delay = <10>; reset-delay = <10>; - panel-width-mm = <90>; - panel-height-mm = <154>; + panel-width-mm = <56>; + panel-height-mm = <93>; display-timings { timing {