diff mbox series

[v3] dmaengine: xilinx: dma: remove arch dependency

Message ID 20230531090141.23546-1-zong.li@sifive.com
State New
Headers
Series [v3] dmaengine: xilinx: dma: remove arch dependency |

Commit Message

Zong Li May 31, 2023, 9:01 a.m. UTC 
  As following patches, xilinx dma is also now architecture agnostic,
and it can be compiled for several architectures. We have verified the
CDMA on RISC-V platform, let's remove the ARCH dependency list instead
of adding new ARCH.

To avoid breaking the s390 build, add a dependency on HAS_IOMEM.

'e8b6c54f6d57 ("net: xilinx: temac: Relax Kconfig dependencies")'
'd7eaf962a90b ("net: axienet: In kconfig remove arch dependency for axi_emac")'

Signed-off-by: Zong Li <zong.li@sifive.com>
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
Suggested-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Reported-by: kernel test robot <lkp@intel.com>
---

 Changes in v3:
 - Add a dependency on HAS_IOMEM to avoid breaking the s390 build

 Changes in v2:
 - Remove ARCH dependency list instead of adding new ARCH

 drivers/dma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zong Li June 26, 2023, 2:54 a.m. UTC | #1 
On Wed, May 31, 2023 at 5:01 PM Zong Li <zong.li@sifive.com> wrote:
>
> As following patches, xilinx dma is also now architecture agnostic,
> and it can be compiled for several architectures. We have verified the
> CDMA on RISC-V platform, let's remove the ARCH dependency list instead
> of adding new ARCH.
>
> To avoid breaking the s390 build, add a dependency on HAS_IOMEM.
>
> 'e8b6c54f6d57 ("net: xilinx: temac: Relax Kconfig dependencies")'
> 'd7eaf962a90b ("net: axienet: In kconfig remove arch dependency for axi_emac")'
>
> Signed-off-by: Zong Li <zong.li@sifive.com>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
> Suggested-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> Reported-by: kernel test robot <lkp@intel.com>
> ---
>
>  Changes in v3:
>  - Add a dependency on HAS_IOMEM to avoid breaking the s390 build
>
>  Changes in v2:
>  - Remove ARCH dependency list instead of adding new ARCH
>
>  drivers/dma/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index f5f422f9b850..fd5a94e67163 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -696,7 +696,7 @@ config XGENE_DMA
>
>  config XILINX_DMA
>         tristate "Xilinx AXI DMAS Engine"
> -       depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> +       depends on HAS_IOMEM
>         select DMA_ENGINE
>         help
>           Enable support for Xilinx AXI VDMA Soft IP.
> --
> 2.17.1
>

Hi Vinod,
Linux 6.5-rc1 is opening, could I know if this patch is good for you?
Would it be considered in this merge window?
Thanks.
Zong Li July 10, 2023, 2:31 a.m. UTC | #2 
On Mon, Jun 26, 2023 at 10:54 AM Zong Li <zong.li@sifive.com> wrote:
>
> On Wed, May 31, 2023 at 5:01 PM Zong Li <zong.li@sifive.com> wrote:
> >
> > As following patches, xilinx dma is also now architecture agnostic,
> > and it can be compiled for several architectures. We have verified the
> > CDMA on RISC-V platform, let's remove the ARCH dependency list instead
> > of adding new ARCH.
> >
> > To avoid breaking the s390 build, add a dependency on HAS_IOMEM.
> >
> > 'e8b6c54f6d57 ("net: xilinx: temac: Relax Kconfig dependencies")'
> > 'd7eaf962a90b ("net: axienet: In kconfig remove arch dependency for axi_emac")'
> >
> > Signed-off-by: Zong Li <zong.li@sifive.com>
> > Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
> > Suggested-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > ---
> >
> >  Changes in v3:
> >  - Add a dependency on HAS_IOMEM to avoid breaking the s390 build
> >
> >  Changes in v2:
> >  - Remove ARCH dependency list instead of adding new ARCH
> >
> >  drivers/dma/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> > index f5f422f9b850..fd5a94e67163 100644
> > --- a/drivers/dma/Kconfig
> > +++ b/drivers/dma/Kconfig
> > @@ -696,7 +696,7 @@ config XGENE_DMA
> >
> >  config XILINX_DMA
> >         tristate "Xilinx AXI DMAS Engine"
> > -       depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> > +       depends on HAS_IOMEM
> >         select DMA_ENGINE
> >         help
> >           Enable support for Xilinx AXI VDMA Soft IP.
> > --
> > 2.17.1
> >
>
> Hi Vinod,
> Linux 6.5-rc1 is opening, could I know if this patch is good for you?
> Would it be considered in this merge window?
> Thanks.

Hi Vinod,
It seems that we are transitioning to Linux v6.5-rc2. I'm uncertain
whether you consider this a new feature or a fix. Is there a
possibility of incorporating it during this cycle? Thank you.
Vinod Koul July 11, 2023, 4:44 p.m. UTC | #3 
On Wed, 31 May 2023 09:01:41 +0000, Zong Li wrote:
> As following patches, xilinx dma is also now architecture agnostic,
> and it can be compiled for several architectures. We have verified the
> CDMA on RISC-V platform, let's remove the ARCH dependency list instead
> of adding new ARCH.
> 
> To avoid breaking the s390 build, add a dependency on HAS_IOMEM.
> 
> [...]

Applied, thanks!

[1/1] dmaengine: xilinx: dma: remove arch dependency
      commit: 9945a80fe40886f2d0655c0c3cdee95aaecafb87

Best regards,
diff mbox series

Patch

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index f5f422f9b850..fd5a94e67163 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -696,7 +696,7 @@  config XGENE_DMA
 
 config XILINX_DMA
 	tristate "Xilinx AXI DMAS Engine"
-	depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
+	depends on HAS_IOMEM
 	select DMA_ENGINE
 	help
 	  Enable support for Xilinx AXI VDMA Soft IP.