diff mbox series

[v4] arm64: dts: agilex/stratix10: Updated QSPI Flash layout for UBIFS

Message ID 20230703083626.1347969-1-kah.jing.lee@intel.com
State New
Headers
Series [v4] arm64: dts: agilex/stratix10: Updated QSPI Flash layout for UBIFS |

Commit Message

Lee, Kah Jing July 3, 2023, 8:36 a.m. UTC 
  From: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@intel.com>

Non-UBIFS related boot and fpga data should be stored in qspi_boot (mtd0)
while keeping the rootfs with UBIFS in the root partition "mtd1".
Thus, update the QSPI flash layout to support UBIFS in the mtd root
partition.

Signed-off-by: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@intel.com>
Signed-off-by: Kah Jing Lee <kah.jing.lee@intel.com>
---
V4->V3: Drop cover letter & remove unnecessary marker line
V3->V2: Update commit messages
V2->V1: Update subject prefix

 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 8 ++++----
 arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts     | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)


base-commit: dad9774deaf1cf8e8f7483310dfb2690310193d2

Comments

Conor Dooley July 3, 2023, 9:08 a.m. UTC | #1 
On 03/07/2023 10:00, Markus Elfring wrote:

> …
>> ---
>> V4->V3: Drop cover letter & remove unnecessary marker line
>> V3->V2: Update commit messages
> …
> 
> * Do you find the arrow notation helpful for the version identification?
> 
> * How do you think about to avoid duplicate data in the version history?
> 
> * Would an other listing style become nicer for the “patch changelog”?

This is a complete waste of contributor time. Please stop.
Lee, Kah Jing July 3, 2023, 10:19 a.m. UTC | #2 
> >> * Would an other listing style become nicer for the “patch changelog”?
> >
> > This is a complete waste of contributor time.
> 
> I would like to point further possibilities out once more.
> 
> The arrow notation is also demonstrated in the Linux development
> documentation.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docu
> mentation/process/submitting-patches.rst?h=v6.4#n698
> 
> Various patches show that more succinct version identifiers are also accepted.
> If a bit of duplicate data can be avoided in the version history, the
> maintenance of corresponding version descriptions can be improved
> accordingly.
Hi Markus, 
Do you suggest to use following? 
Changelog:
V2: Changes in v2 xxx
V1: Changes in v1 xxx

A bit lost on the suggestion here. 
> 
> Regards,
> Markus
Krzysztof Kozlowski July 3, 2023, 11:34 a.m. UTC | #3 
On 03/07/2023 11:08, Conor.Dooley@microchip.com wrote:
> On 03/07/2023 10:00, Markus Elfring wrote:
> 
>> …
>>> ---
>>> V4->V3: Drop cover letter & remove unnecessary marker line
>>> V3->V2: Update commit messages
>> …
>>
>> * Do you find the arrow notation helpful for the version identification?
>>
>> * How do you think about to avoid duplicate data in the version history?
>>
>> * Would an other listing style become nicer for the “patch changelog”?
> 
> This is a complete waste of contributor time. Please stop.

Markus is banned from the LKML. Just ignore the comments.

Best regards,
Krzysztof
Dinh Nguyen July 10, 2023, 2:21 a.m. UTC | #4 
On 7/3/23 03:36, kah.jing.lee@intel.com wrote:
> From: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@intel.com>
> 
> Non-UBIFS related boot and fpga data should be stored in qspi_boot (mtd0)
> while keeping the rootfs with UBIFS in the root partition "mtd1".
> Thus, update the QSPI flash layout to support UBIFS in the mtd root
> partition.
> 
> Signed-off-by: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@intel.com>
> Signed-off-by: Kah Jing Lee <kah.jing.lee@intel.com>
> ---
> V4->V3: Drop cover letter & remove unnecessary marker line
> V3->V2: Update commit messages
> V2->V1: Update subject prefix
> 
>   arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 8 ++++----
>   arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts     | 8 ++++----
>   2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> index 38ae674f2f02..12b960b9183c 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> @@ -202,12 +202,12 @@ partitions {
>   
>   			qspi_boot: partition@0 {
>   				label = "Boot and fpga data";
> -				reg = <0x0 0x03FE0000>;
> +				reg = <0x0 0x04200000>;
>   			};
>   
> -			qspi_rootfs: partition@3FE0000 {
> -				label = "Root Filesystem - JFFS2";
> -				reg = <0x03FE0000 0x0C020000>;
> +			root: partition@4200000 {
> +				label = "Root Filesystem - UBIFS";
> +				reg = <0x04200000 0x0BE00000>;
>   			};
>   		};
>   	};
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> index 07c3f8876613..608017e6e36a 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> @@ -128,12 +128,12 @@ partitions {
>   
>   			qspi_boot: partition@0 {
>   				label = "Boot and fpga data";
> -				reg = <0x0 0x03FE0000>;
> +				reg = <0x0 0x04200000>;
>   			};
>   
> -			qspi_rootfs: partition@3FE0000 {
> -				label = "Root Filesystem - JFFS2";
> -				reg = <0x03FE0000 0x0C020000>;
> +			root: partition@4200000 {
> +				label = "Root Filesystem - UBIFS";
> +				reg = <0x04200000 0x0BE00000>;
>   			};
>   		};
>   	};
> 
> base-commit: dad9774deaf1cf8e8f7483310dfb2690310193d2

Applied!

Thanks,
Dinh
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
index 38ae674f2f02..12b960b9183c 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
@@ -202,12 +202,12 @@  partitions {
 
 			qspi_boot: partition@0 {
 				label = "Boot and fpga data";
-				reg = <0x0 0x03FE0000>;
+				reg = <0x0 0x04200000>;
 			};
 
-			qspi_rootfs: partition@3FE0000 {
-				label = "Root Filesystem - JFFS2";
-				reg = <0x03FE0000 0x0C020000>;
+			root: partition@4200000 {
+				label = "Root Filesystem - UBIFS";
+				reg = <0x04200000 0x0BE00000>;
 			};
 		};
 	};
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
index 07c3f8876613..608017e6e36a 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
@@ -128,12 +128,12 @@  partitions {
 
 			qspi_boot: partition@0 {
 				label = "Boot and fpga data";
-				reg = <0x0 0x03FE0000>;
+				reg = <0x0 0x04200000>;
 			};
 
-			qspi_rootfs: partition@3FE0000 {
-				label = "Root Filesystem - JFFS2";
-				reg = <0x03FE0000 0x0C020000>;
+			root: partition@4200000 {
+				label = "Root Filesystem - UBIFS";
+				reg = <0x04200000 0x0BE00000>;
 			};
 		};
 	};