diff mbox series

iio: adc: qcom-spmi-adc5: Add ADC5_GPIO2_100K_PU

Message ID 20230627-topic-adc-v1-1-c61581abffa3@linaro.org
State New
Headers
Series iio: adc: qcom-spmi-adc5: Add ADC5_GPIO2_100K_PU |

Commit Message

Konrad Dybcio June 26, 2023, 11:21 p.m. UTC 
  Even though it existed in bindings for the longest time,
ADC5_GPIO2_100K_PU was never assigned in the driver. Do so.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/iio/adc/qcom-spmi-adc5.c | 2 ++
 1 file changed, 2 insertions(+)


---
base-commit: 60e7c4a25da68cd826719b685babbd23e73b85b0
change-id: 20230627-topic-adc-1e7a7c6aae15

Best regards,

Comments

Dmitry Baryshkov June 27, 2023, 12:08 a.m. UTC | #1 
On 27/06/2023 02:21, Konrad Dybcio wrote:
> Even though it existed in bindings for the longest time,
> ADC5_GPIO2_100K_PU was never assigned in the driver. Do so.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>   drivers/iio/adc/qcom-spmi-adc5.c | 2 ++
>   1 file changed, 2 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Jonathan Cameron July 8, 2023, 2:29 p.m. UTC | #2 
On Tue, 27 Jun 2023 03:08:20 +0300
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote:

> On 27/06/2023 02:21, Konrad Dybcio wrote:
> > Even though it existed in bindings for the longest time,
> > ADC5_GPIO2_100K_PU was never assigned in the driver. Do so.
> > 
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> > ---
> >   drivers/iio/adc/qcom-spmi-adc5.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >   
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
I was a little unsure on this one. So far I've applied it as a 'feature'
so it's in the normal iio togreg branch, but perhaps it should be a fix?

For now applied to the togreg branch of iio.git but given I'll be rebasing
that on rc1, for now it's only visible as testing.  0-day can play with that
in the meantime and see if it can find any issues

Jonathan
Konrad Dybcio July 8, 2023, 2:45 p.m. UTC | #3 
On 8.07.2023 16:29, Jonathan Cameron wrote:
> On Tue, 27 Jun 2023 03:08:20 +0300
> Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote:
> 
>> On 27/06/2023 02:21, Konrad Dybcio wrote:
>>> Even though it existed in bindings for the longest time,
>>> ADC5_GPIO2_100K_PU was never assigned in the driver. Do so.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>>>   drivers/iio/adc/qcom-spmi-adc5.c | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>   
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>
> I was a little unsure on this one. So far I've applied it as a 'feature'
> so it's in the normal iio togreg branch, but perhaps it should be a fix?
I suppose it's a feature as it's never been used before

Konrad
> 
> For now applied to the togreg branch of iio.git but given I'll be rebasing
> that on rc1, for now it's only visible as testing.  0-day can play with that
> in the meantime and see if it can find any issues
> 
> Jonathan
> 
>
diff mbox series

Patch

diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c
index 0a4fd3a46113..b6b612d733ff 100644
--- a/drivers/iio/adc/qcom-spmi-adc5.c
+++ b/drivers/iio/adc/qcom-spmi-adc5.c
@@ -555,6 +555,8 @@  static const struct adc5_channels adc5_chans_pmic[ADC5_MAX_CHANNEL] = {
 					SCALE_HW_CALIB_PM5_SMB_TEMP)
 	[ADC5_GPIO1_100K_PU]	= ADC5_CHAN_TEMP("gpio1_100k_pu", 0,
 					SCALE_HW_CALIB_THERM_100K_PULLUP)
+	[ADC5_GPIO2_100K_PU]	= ADC5_CHAN_TEMP("gpio2_100k_pu", 0,
+					SCALE_HW_CALIB_THERM_100K_PULLUP)
 	[ADC5_GPIO3_100K_PU]	= ADC5_CHAN_TEMP("gpio3_100k_pu", 0,
 					SCALE_HW_CALIB_THERM_100K_PULLUP)
 	[ADC5_GPIO4_100K_PU]	= ADC5_CHAN_TEMP("gpio4_100k_pu", 0,