Message ID | 20230629110359.1111832-5-chengming.zhou@linux.dev |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp9561391vqr; Thu, 29 Jun 2023 04:20:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5MR2NYSkb8mT/FWsf7qKkfZBhPhM69W2cH4FJDhjLWpFL+NrS96sPVsKNNB0LjjLGDJHTd X-Received: by 2002:a05:6a00:24cf:b0:676:2a5c:7bc5 with SMTP id d15-20020a056a0024cf00b006762a5c7bc5mr13976342pfv.1.1688037647565; Thu, 29 Jun 2023 04:20:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688037647; cv=none; d=google.com; s=arc-20160816; b=CjO/ukQd41qh91l1OdT1kM7cGTlW1RrKPmWvwtIZk54JM8jzmxDMpnxi0SNA4nGrL9 EHAFfqOCxlMZRu8J06mkzYFsVwsiW5cSngGx6j7CKxCppSwSKDzI3aXntTbvO70znTAt vf9C9TGE0c5+Ivk9bWCa6Tu93hkPb7S0pmfR3X9fek9qpMdEa7UmuKeonvhErgrR3w5M b+cCISZnZsBNcUkG70AoHc7HUT2lfFde2XXB6jpKataKikZ+bv+1suSKjGMES4AoEPOS RlYJwJTZRrpBcw9JBhYojjQHfgOg5yTt6TO6TDULu60G0aghX8nqIlq5bnfbDBlre03Z 9NWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/O8YJWAa7A//A8YJ1hLAuWA8H/d3IRDfJMQYLuFl59Q=; fh=jVO2EC1fXvr6Bl8+7yHtFIrYqo7iQ9dvd55sFdmq7po=; b=QfouMbCiHOGVhrcdmxVBtJI74Ztcmx2mWnF0PLDi+igwpby4FAiX8GGWWAVt7BXJ1s Ezqsg6599WbFykFqgTrNf1GwxicL9mKozYWqvSEFf3duROZWARqm6TXN3r6F6Pv2qvt8 9UR5vFqHkLhhVBRGnFehtxOjIkEBwGXdmNxIa2O7QhbxlNPPOknJURnopn57c+9idw6f pQ/DdAU24UGpIP89DJv19aRfBNGDGWDre3dIGJ6R7IAUF2ykoBjr2S0D877HDVpV6745 ur/SBpCacWqLNL91nTfdT7bucryUESTiQ8Xvd3A5IRVDMBpEdfZNkHfteYQKObq2j8p7 C09A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=mbIzMFKm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t189-20020a6381c6000000b0054fe9faf30bsi128303pgd.562.2023.06.29.04.20.29; Thu, 29 Jun 2023 04:20:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=mbIzMFKm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231855AbjF2LH7 (ORCPT <rfc822;ivan.orlov0322@gmail.com> + 99 others); Thu, 29 Jun 2023 07:07:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232180AbjF2LHZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 29 Jun 2023 07:07:25 -0400 Received: from out-12.mta1.migadu.com (out-12.mta1.migadu.com [IPv6:2001:41d0:203:375::c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F408294E for <linux-kernel@vger.kernel.org>; Thu, 29 Jun 2023 04:07:24 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1688036842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/O8YJWAa7A//A8YJ1hLAuWA8H/d3IRDfJMQYLuFl59Q=; b=mbIzMFKmGOLPlHTie0bZkFzRR4kKsmNBsTYTIAcXDY9PhKLh+AWN83tEAps+QrlCmHpQJ5 6vPVir4H9Ri7Ue7A0rX45a+10TN8gVkVcHKOdW31Bm1xjWYh2rKJU5FdRDZn+3xBXxdoKu lTL8df0btTRLK09OBxfpmKmt+c9Wkm4= From: chengming.zhou@linux.dev To: axboe@kernel.dk, ming.lei@redhat.com, hch@lst.de, tj@kernel.org Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Chengming Zhou <zhouchengming@bytedance.com> Subject: [PATCH v2 4/4] blk-mq: delete unused completion_data in struct request Date: Thu, 29 Jun 2023 19:03:59 +0800 Message-Id: <20230629110359.1111832-5-chengming.zhou@linux.dev> In-Reply-To: <20230629110359.1111832-1-chengming.zhou@linux.dev> References: <20230629110359.1111832-1-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770035764243537135?= X-GMAIL-MSGID: =?utf-8?q?1770035764243537135?= |
Series |
blk-mq: optimize the size of struct request
|
|
Commit Message
Chengming Zhou
June 29, 2023, 11:03 a.m. UTC
From: Chengming Zhou <zhouchengming@bytedance.com> After global search, I found "completion_data" in struct request is not used anywhere, so just clean it up by the way. Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com> --- include/linux/blk-mq.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Comments
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Although I'd order it first or even send it separately as it doesn't need
any of the other changes.
On 2023/7/6 21:08, Christoph Hellwig wrote: > Looks good: > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > Although I'd order it first or even send it separately as it doesn't need > any of the other changes. Ok, will order it first in the next version. I thought it's too minor to send a separate patch, so put it in this series. Thanks.
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h index 96644d6f8d18..ab790eba5fcf 100644 --- a/include/linux/blk-mq.h +++ b/include/linux/blk-mq.h @@ -158,13 +158,11 @@ struct request { /* * The rb_node is only used inside the io scheduler, requests - * are pruned when moved to the dispatch queue. So let the - * completion_data share space with the rb_node. + * are pruned when moved to the dispatch queue. */ union { struct rb_node rb_node; /* sort/lookup */ struct bio_vec special_vec; - void *completion_data; }; /*